All of lore.kernel.org
 help / color / mirror / Atom feed
From: Etienne Carriere <etienne.carriere@linaro.org>
To: u-boot@lists.denx.de
Subject: [PATCH v5 3/4] drivers: tee: sandbox: add rpc test ta emulation
Date: Fri, 22 Jan 2021 12:54:53 +0100	[thread overview]
Message-ID: <CAN5uoS8jbqAv6rsusKYYLP+oAMJry5=2ppQD6XDB2r4KhqeoZg@mail.gmail.com> (raw)
In-Reply-To: <CAL6CDMHDAcFC0195Rijo1TDt4LZwSk4cA7DAfCYjmQAKO9hHXQ@mail.gmail.com>

Hi Igor

> HI Etienne,
>
> On Thu, Jan 21, 2021 at 9:39 AM Etienne Carriere
> <etienne.carriere@linaro.org> wrote:
> >
> > Hi Igor,
> >
> > On Wed, 20 Jan 2021 at 18:56, Igor Opaniuk <igor.opaniuk@gmail.com> wrote:
> > >
> > > From: Igor Opaniuk <igor.opaniuk@foundries.io>
> > >
> > > This adds support for RPC test trusted application emulation, which
> > > permits to test reverse RPC calls to TEE supplicant. Currently it covers
> > > requests to the I2C bus from TEE.
> > >
> > > Signed-off-by: Igor Opaniuk <igor.opaniuk@foundries.io>
> > > Reviewed-by: Simon Glass <sjg@chromium.org>
> > > ---
> > >
> > > (no changes since v1)
> > >
> > >  drivers/tee/Makefile            |   2 +
> > >  drivers/tee/optee/Kconfig       |   9 ++
> > >  drivers/tee/sandbox.c           | 143 +++++++++++++++++++++++++++++++-
> > >  include/tee/optee_ta_rpc_test.h |  28 +++++++
> > >  4 files changed, 178 insertions(+), 4 deletions(-)
> > >  create mode 100644 include/tee/optee_ta_rpc_test.h
> > >
> > > diff --git a/drivers/tee/Makefile b/drivers/tee/Makefile
> > > index 5c8ffdbce8..ff844195ae 100644
> > > --- a/drivers/tee/Makefile
> > > +++ b/drivers/tee/Makefile
> > > @@ -2,5 +2,7 @@
> > >
> > >  obj-y += tee-uclass.o
> > >  obj-$(CONFIG_SANDBOX) += sandbox.o
> > > +obj-$(CONFIG_OPTEE_TA_RPC_TEST) += optee/supplicant.o
> > > +obj-$(CONFIG_OPTEE_TA_RPC_TEST) += optee/i2c.o
> >
> > I think this line should move to drivers/tee/optee/Makefile for consistency.
> Well, what we do here is testing TEE supplicant from TEE sandbox driver.
> So this is why I pull that bits and pieces from OP-TEE driver, however
> OP-TEE driver itself
> isn't compiled (CONFIG_OPTEE=n when CONFIG_SANDBOX=y).
> I don't either like this idea, but currently that's the only way to add some
> RPC test coverage that was requested in v1.
>
> CONFIG_OPTEE_TA_RPC_TEST is currently supposed to be used only
> in sandbox setups (for testing RPC call paths with DM tests).

Ok, i catch it. These paths make sense.

br,
etienne

>
>
> >  obj-$(CONFIG_OPTEE) += optee/
> >  obj-y += broadcom/
> > diff --git a/drivers/tee/optee/Kconfig b/drivers/tee/optee/Kconfig
> > index d489834df9..65622f30b1 100644
> > --- a/drivers/tee/optee/Kconfig
> > +++ b/drivers/tee/optee/Kconfig
> > @@ -22,6 +22,15 @@ config OPTEE_TA_AVB
> >           The TA can support the "avb" subcommands "read_rb", "write"rb"
> >           and "is_unlocked".
> >
> > +config OPTEE_TA_RPC_TEST
> > +       bool "Support RPC TEST TA"
> > +       depends on SANDBOX_TEE
> > +       default y
> > +       help
> > +         Enables support for RPC test trusted application emulation, which
> > +         permits to test reverse RPC calls to TEE supplicant. Should
> > +         be used only in sandbox env.
> > +
> >  endmenu
> >
> >  endif
> > (snip)

  reply	other threads:[~2021-01-22 11:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-01-20 17:55 [PATCH v5 0/4] OP-TEE I2C trampoline and associated tests Igor Opaniuk
2021-01-20 17:55 ` [PATCH v5 1/4] drivers: tee: i2c trampoline driver Igor Opaniuk
2021-01-20 17:55 ` [PATCH v5 2/4] test: py: add pygit2 and pyelftools to requirements.txt Igor Opaniuk
2021-01-20 17:55 ` [PATCH v5 3/4] drivers: tee: sandbox: add rpc test ta emulation Igor Opaniuk
2021-01-21  7:39   ` Etienne Carriere
2021-01-21 10:41     ` Igor Opaniuk
2021-01-22 11:54       ` Etienne Carriere [this message]
2021-01-20 17:55 ` [PATCH v5 4/4] test: dm: tee: extend with RPC test Igor Opaniuk
2021-01-21  8:00   ` Etienne Carriere
2021-01-21 10:44     ` Igor Opaniuk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN5uoS8jbqAv6rsusKYYLP+oAMJry5=2ppQD6XDB2r4KhqeoZg@mail.gmail.com' \
    --to=etienne.carriere@linaro.org \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.