From: Etienne Carriere <etienne.carriere@linaro.org> To: Sudeep Holla <sudeep.holla@arm.com> Cc: Cristian Marussi <cristian.marussi@arm.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jens Wiklander <jens.wiklander@linaro.org>, Sumit Garg <sumit.garg@linaro.org> Subject: Re: [PATCH 2/2] firmware: arm_scmi: optee: use optee system invocation Date: Fri, 3 Feb 2023 19:43:10 +0100 [thread overview] Message-ID: <CAN5uoS9=Hu+q+9Poei3OAiF2hOD3JtN5Ny4ejUrW2j18TZKSug@mail.gmail.com> (raw) In-Reply-To: <20230203170448.v5iduw2rhpxc47f3@bogus> Hello Sudeep, On Fri, 3 Feb 2023 at 18:04, Sudeep Holla <sudeep.holla@arm.com> wrote: > > On Fri, Feb 03, 2023 at 02:36:26PM +0000, Cristian Marussi wrote: > > On Mon, Jan 30, 2023 at 10:41:57AM +0100, Etienne Carriere wrote: > > > Changes SCMI optee transport to enable sys_service capability of > > > its tee context to leverage provisioned system resources in OP-TEE > > > preventing possible deadlock. > > > > > > Such deadlock could happen when many Linux clients invoke OP-TEE are > > > are all suspended waiting for an OP-TEE RPC request access an SCMI > > > resource through the SCMI OP-TEE PTA service. > > > > > > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> > > > --- > > > drivers/firmware/arm_scmi/optee.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c > > > index 2a7aeab40e54..91840345e946 100644 > > > --- a/drivers/firmware/arm_scmi/optee.c > > > +++ b/drivers/firmware/arm_scmi/optee.c > > > @@ -559,6 +559,9 @@ static int scmi_optee_service_probe(struct device *dev) > > > if (IS_ERR(tee_ctx)) > > > return -ENODEV; > > > > > > + /* SCMI agent can used TEE system service resources */ > > > + tee_ctx->sys_service = true; > > > + > > > agent = devm_kzalloc(dev, sizeof(*agent), GFP_KERNEL); > > > if (!agent) { > > > ret = -ENOMEM; > > > > LGTM. > > > > I suppose you'll sync-up with Sudeep for how to queue this whole series. > > > > I thought I had responded to this but not. Anyways since TEE changes are > significant than SCMI, you can route it via TEE tree. In that case, > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > > Let me know if that was not your plan. That's fine. Thanks. I'll ask Jens to apply it next to the optee commit. Regards, Etienne > > -- > Regards, > Sudeep
WARNING: multiple messages have this Message-ID (diff)
From: Etienne Carriere <etienne.carriere@linaro.org> To: Sudeep Holla <sudeep.holla@arm.com> Cc: Cristian Marussi <cristian.marussi@arm.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Jens Wiklander <jens.wiklander@linaro.org>, Sumit Garg <sumit.garg@linaro.org> Subject: Re: [PATCH 2/2] firmware: arm_scmi: optee: use optee system invocation Date: Fri, 3 Feb 2023 19:43:10 +0100 [thread overview] Message-ID: <CAN5uoS9=Hu+q+9Poei3OAiF2hOD3JtN5Ny4ejUrW2j18TZKSug@mail.gmail.com> (raw) In-Reply-To: <20230203170448.v5iduw2rhpxc47f3@bogus> Hello Sudeep, On Fri, 3 Feb 2023 at 18:04, Sudeep Holla <sudeep.holla@arm.com> wrote: > > On Fri, Feb 03, 2023 at 02:36:26PM +0000, Cristian Marussi wrote: > > On Mon, Jan 30, 2023 at 10:41:57AM +0100, Etienne Carriere wrote: > > > Changes SCMI optee transport to enable sys_service capability of > > > its tee context to leverage provisioned system resources in OP-TEE > > > preventing possible deadlock. > > > > > > Such deadlock could happen when many Linux clients invoke OP-TEE are > > > are all suspended waiting for an OP-TEE RPC request access an SCMI > > > resource through the SCMI OP-TEE PTA service. > > > > > > Signed-off-by: Etienne Carriere <etienne.carriere@linaro.org> > > > --- > > > drivers/firmware/arm_scmi/optee.c | 3 +++ > > > 1 file changed, 3 insertions(+) > > > > > > diff --git a/drivers/firmware/arm_scmi/optee.c b/drivers/firmware/arm_scmi/optee.c > > > index 2a7aeab40e54..91840345e946 100644 > > > --- a/drivers/firmware/arm_scmi/optee.c > > > +++ b/drivers/firmware/arm_scmi/optee.c > > > @@ -559,6 +559,9 @@ static int scmi_optee_service_probe(struct device *dev) > > > if (IS_ERR(tee_ctx)) > > > return -ENODEV; > > > > > > + /* SCMI agent can used TEE system service resources */ > > > + tee_ctx->sys_service = true; > > > + > > > agent = devm_kzalloc(dev, sizeof(*agent), GFP_KERNEL); > > > if (!agent) { > > > ret = -ENOMEM; > > > > LGTM. > > > > I suppose you'll sync-up with Sudeep for how to queue this whole series. > > > > I thought I had responded to this but not. Anyways since TEE changes are > significant than SCMI, you can route it via TEE tree. In that case, > > Acked-by: Sudeep Holla <sudeep.holla@arm.com> > > Let me know if that was not your plan. That's fine. Thanks. I'll ask Jens to apply it next to the optee commit. Regards, Etienne > > -- > Regards, > Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-02-03 18:43 UTC|newest] Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top 2023-01-30 9:41 [PATCH 1/2] tee: system invocation Etienne Carriere 2023-01-30 9:41 ` Etienne Carriere 2023-01-30 9:41 ` [PATCH 2/2] firmware: arm_scmi: optee: use optee " Etienne Carriere 2023-01-30 9:41 ` Etienne Carriere 2023-02-03 14:36 ` Cristian Marussi 2023-02-03 14:36 ` Cristian Marussi 2023-02-03 17:04 ` Sudeep Holla 2023-02-03 17:04 ` Sudeep Holla 2023-02-03 18:43 ` Etienne Carriere [this message] 2023-02-03 18:43 ` Etienne Carriere 2023-02-07 9:59 ` Sumit Garg 2023-02-07 9:59 ` Sumit Garg 2023-02-07 10:39 ` Jens Wiklander 2023-02-07 10:39 ` Jens Wiklander 2023-02-07 11:11 ` Sumit Garg 2023-02-07 11:11 ` Sumit Garg 2023-02-03 11:27 ` [PATCH 1/2] tee: " Jens Wiklander 2023-02-03 11:27 ` Jens Wiklander 2023-02-07 7:26 ` Sumit Garg 2023-02-07 7:26 ` Sumit Garg 2023-02-07 9:08 ` Jens Wiklander 2023-02-07 9:08 ` Jens Wiklander 2023-02-07 9:52 ` Sumit Garg 2023-02-07 9:52 ` Sumit Garg 2023-02-07 10:36 ` Jens Wiklander 2023-02-07 10:36 ` Jens Wiklander 2023-02-08 17:09 ` Etienne Carriere 2023-02-08 17:09 ` Etienne Carriere 2023-02-09 7:14 ` Jens Wiklander 2023-02-09 7:14 ` Jens Wiklander 2023-02-09 8:11 ` Etienne Carriere 2023-02-09 8:11 ` Etienne Carriere 2023-02-09 9:11 ` Etienne Carriere 2023-02-09 9:11 ` Etienne Carriere 2023-02-09 9:19 ` Jens Wiklander 2023-02-09 9:19 ` Jens Wiklander 2023-02-09 12:56 ` Etienne Carriere 2023-02-09 12:56 ` Etienne Carriere
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='CAN5uoS9=Hu+q+9Poei3OAiF2hOD3JtN5Ny4ejUrW2j18TZKSug@mail.gmail.com' \ --to=etienne.carriere@linaro.org \ --cc=cristian.marussi@arm.com \ --cc=jens.wiklander@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=sudeep.holla@arm.com \ --cc=sumit.garg@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.