All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Gesiak <modocache@gmail.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/2] t3200-branch: test setting branch as own upstream
Date: Fri, 28 Feb 2014 15:17:28 +0900	[thread overview]
Message-ID: <CAN7MxmWP9N==0DnoE-0=Xr7NWkNMSGBC+yiz1a3wS5EbHigvKg@mail.gmail.com> (raw)
In-Reply-To: <20140228053703.GA32556@sigill.intra.peff.net>

> For an operation like "git branch foo origin" where setting up the
> tracking is a side effect, a warning makes sense. But the sole purpose
> of the command above is to set the upstream, and we didn't do it; should
> this warning actually be upgraded to an error?

I agree. I originally wrote the test using test_expect_failure--imagine my
surprise when the exit status was 0, despite the fact that the upstream wasn't
set!

> This should use test_i18ncmp, as the string you are matching is
> internationalized.

Patch is on the way, just waiting for the tests to complete. Thanks for pointing
that out! Also, sorry if it's in the Makefile somewhere, but is there
an easy way
to run just a single test file in the t directory?

- Brian Gesiak

  reply	other threads:[~2014-02-28  6:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-28  3:04 [PATCH 1/2] t3200-branch: test setting branch as own upstream Brian Gesiak
2014-02-28  3:04 ` [PATCH 2/2] branch: use skip_prefix Brian Gesiak
2014-02-28  5:46   ` Jeff King
2014-03-03 19:54     ` Junio C Hamano
2014-02-28  5:37 ` [PATCH 1/2] t3200-branch: test setting branch as own upstream Jeff King
2014-02-28  6:17   ` Brian Gesiak [this message]
2014-02-28  6:27     ` Jeff King
2014-02-28 22:15       ` brian m. carlson
2014-02-28  6:55   ` Johannes Sixt
2014-02-28  7:14     ` Jeff King
2014-02-28  7:26       ` Jeff King
2014-02-28  7:28         ` Brian Gesiak
2014-02-28  8:37           ` Jeff King
2014-02-28 10:44             ` Brian Gesiak
2014-02-28 10:59               ` Jeff King
2014-02-28 11:16                 ` Brian Gesiak
2014-02-28 13:03                   ` Jeff King
2014-02-28 14:57                     ` Matthieu Moy
2014-03-01 12:19                       ` [PATCH v2] branch: die when " Brian Gesiak
2014-03-01 12:23                         ` [PATCH 3/3] " Brian Gesiak
2014-03-01 12:26                           ` Brian Gesiak
2014-02-28  7:40       ` [PATCH 1/2] t3200-branch: test " Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN7MxmWP9N==0DnoE-0=Xr7NWkNMSGBC+yiz1a3wS5EbHigvKg@mail.gmail.com' \
    --to=modocache@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.