From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758587Ab3HOALy (ORCPT ); Wed, 14 Aug 2013 20:11:54 -0400 Received: from mail-vb0-f48.google.com ([209.85.212.48]:53849 "EHLO mail-vb0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757772Ab3HOALw (ORCPT ); Wed, 14 Aug 2013 20:11:52 -0400 MIME-Version: 1.0 In-Reply-To: <20130814155742.d3cd651e40e552696667e4f2@linux-foundation.org> References: <20130805152206.76462cc4a42e51b16a0532f1@linux-foundation.org> <20130814155742.d3cd651e40e552696667e4f2@linux-foundation.org> Date: Wed, 14 Aug 2013 17:11:51 -0700 Message-ID: Subject: Re: [PATCH] block: add command line partition parser From: Brian Norris To: Andrew Morton Cc: Caizhiyong , Karel Zak , linux-mtd@lists.infradead.org, "linux-kernel@vger.kernel.org" , "Wanglin (Albert)" , Artem Bityutskiy , Shmulik Ladkani , Huang Shijie Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 14, 2013 at 3:57 PM, Andrew Morton wrote: > On Tue, 13 Aug 2013 06:02:17 +0000 Caizhiyong wrote: > >> move the command line parser to a separate module, and change it into >> library-style code. >> >> reference: https://lkml.org/lkml/2013/8/6/550 The most recent patch is an addendum to this linked patch then? > Well OK. But to prove the library's usefulness and to generally clean > up the kernel, someone needs to sign up to the task of converting > drivers/mtd/cmdlinepart.c to use this code. > > I've been hopefully cc'ing various MTD people but am not being > overwhelmed with waves of enthusiasm ;) "I've been" implies that you have done so prior to this email. And "people" implies more than one person. I see that you CC'd David Woodhouse over a week ago, but he's fairly silent these days on MTD things. It's Artem or me who handle most of the day-to-day of MTD. And this is the first time I've seen this! (BTW, please include linux-mtd@lists.infradead.org for anything involving MTD.) This seems reasonable, and I'd be willing to work with this proposal. Caizhiyong, can you submit a clear single patch (or series of patches), CC'd to linux-mtd at least? Then we can see about supporting it in MTD. It doesn't look too difficult, but I need to check that it faithfully mimics the capability we currently rely on. There have been previous discussions on changing it, but this was rejected in favor of allowing more flexibility. Here's part of one such conversation: http://lists.infradead.org/pipermail/linux-mtd/2012-August/043599.html http://lists.infradead.org/pipermail/linux-mtd/2012-September/043825.html http://lists.infradead.org/pipermail/linux-mtd/2012-December/045322.html So I would recommend: (1) consider carefully the implications of your command-line format now, rather than later (2) if you want MTD to use it, it needs to support the features we use now Some particular cases to consider: overlapping partitions (how do block devices handle overlapping partitions?), out-of-order specification, zero sized partitions, mixed syntax (some specified with an offset, some not), multiple '-' partitions. Anyway, if you resend, we can review. Thanks, Brian From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-vb0-x229.google.com ([2607:f8b0:400c:c02::229]) by merlin.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1V9lAl-0002Sk-Sa for linux-mtd@lists.infradead.org; Thu, 15 Aug 2013 00:12:16 +0000 Received: by mail-vb0-f41.google.com with SMTP id g17so105072vbg.28 for ; Wed, 14 Aug 2013 17:11:52 -0700 (PDT) MIME-Version: 1.0 In-Reply-To: <20130814155742.d3cd651e40e552696667e4f2@linux-foundation.org> References: <20130805152206.76462cc4a42e51b16a0532f1@linux-foundation.org> <20130814155742.d3cd651e40e552696667e4f2@linux-foundation.org> Date: Wed, 14 Aug 2013 17:11:51 -0700 Message-ID: Subject: Re: [PATCH] block: add command line partition parser From: Brian Norris To: Andrew Morton Content-Type: text/plain; charset=ISO-8859-1 Cc: "Wanglin \(Albert\)" , Artem Bityutskiy , "linux-kernel@vger.kernel.org" , Huang Shijie , Karel Zak , linux-mtd@lists.infradead.org, Shmulik Ladkani , Caizhiyong List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Wed, Aug 14, 2013 at 3:57 PM, Andrew Morton wrote: > On Tue, 13 Aug 2013 06:02:17 +0000 Caizhiyong wrote: > >> move the command line parser to a separate module, and change it into >> library-style code. >> >> reference: https://lkml.org/lkml/2013/8/6/550 The most recent patch is an addendum to this linked patch then? > Well OK. But to prove the library's usefulness and to generally clean > up the kernel, someone needs to sign up to the task of converting > drivers/mtd/cmdlinepart.c to use this code. > > I've been hopefully cc'ing various MTD people but am not being > overwhelmed with waves of enthusiasm ;) "I've been" implies that you have done so prior to this email. And "people" implies more than one person. I see that you CC'd David Woodhouse over a week ago, but he's fairly silent these days on MTD things. It's Artem or me who handle most of the day-to-day of MTD. And this is the first time I've seen this! (BTW, please include linux-mtd@lists.infradead.org for anything involving MTD.) This seems reasonable, and I'd be willing to work with this proposal. Caizhiyong, can you submit a clear single patch (or series of patches), CC'd to linux-mtd at least? Then we can see about supporting it in MTD. It doesn't look too difficult, but I need to check that it faithfully mimics the capability we currently rely on. There have been previous discussions on changing it, but this was rejected in favor of allowing more flexibility. Here's part of one such conversation: http://lists.infradead.org/pipermail/linux-mtd/2012-August/043599.html http://lists.infradead.org/pipermail/linux-mtd/2012-September/043825.html http://lists.infradead.org/pipermail/linux-mtd/2012-December/045322.html So I would recommend: (1) consider carefully the implications of your command-line format now, rather than later (2) if you want MTD to use it, it needs to support the features we use now Some particular cases to consider: overlapping partitions (how do block devices handle overlapping partitions?), out-of-order specification, zero sized partitions, mixed syntax (some specified with an offset, some not), multiple '-' partitions. Anyway, if you resend, we can review. Thanks, Brian