All of lore.kernel.org
 help / color / mirror / Atom feed
From: Brian Norris <computersforpeace@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Kamal Dasu" <kdasu.kdev@gmail.com>,
	linux-mtd@lists.infradead.org,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V3] dt-bindings: mtd: brcm,brcmnand: convert to the json-schema
Date: Thu, 22 Apr 2021 19:34:53 -0700	[thread overview]
Message-ID: <CAN8TOE-hMscEyqpZ+mpeZW85izuprxR-HosDgrD0P9o52ATQdQ@mail.gmail.com> (raw)
In-Reply-To: <20210420212008.13174-1-zajec5@gmail.com>

On Tue, Apr 20, 2021 at 2:20 PM Rafał Miłecki <zajec5@gmail.com> wrote:
>
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This helps validating DTS files.

I gotta learn how to read this stuff better someday... but I'll give it a shot:

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> @@ -0,0 +1,242 @@
...
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: brcm,nand-iproc
> +    then:
> +      properties:
> +        reg-names:
> +          minItems: 2
> +          maxItems: 3
> +          items:
> +            - const: nand
> +            - const: iproc-idm
> +            - const: iproc-ext

Reading the original binding as well as the code, I believe all three
are required. Wouldn't that be minItems = maxItems = 3?

Other than that, this looks good to me:

Reviewed-by: Brian Norris <computersforpeace@gmail.com>

Thanks!

WARNING: multiple messages have this Message-ID (diff)
From: Brian Norris <computersforpeace@gmail.com>
To: "Rafał Miłecki" <zajec5@gmail.com>
Cc: "Miquel Raynal" <miquel.raynal@bootlin.com>,
	"Richard Weinberger" <richard@nod.at>,
	"Vignesh Raghavendra" <vigneshr@ti.com>,
	"Rob Herring" <robh+dt@kernel.org>,
	"Kamal Dasu" <kdasu.kdev@gmail.com>,
	linux-mtd@lists.infradead.org,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
	<devicetree@vger.kernel.org>,
	bcm-kernel-feedback-list <bcm-kernel-feedback-list@broadcom.com>,
	"Rafał Miłecki" <rafal@milecki.pl>
Subject: Re: [PATCH V3] dt-bindings: mtd: brcm, brcmnand: convert to the json-schema
Date: Thu, 22 Apr 2021 19:34:53 -0700	[thread overview]
Message-ID: <CAN8TOE-hMscEyqpZ+mpeZW85izuprxR-HosDgrD0P9o52ATQdQ@mail.gmail.com> (raw)
In-Reply-To: <20210420212008.13174-1-zajec5@gmail.com>

On Tue, Apr 20, 2021 at 2:20 PM Rafał Miłecki <zajec5@gmail.com> wrote:
>
> From: Rafał Miłecki <rafal@milecki.pl>
>
> This helps validating DTS files.

I gotta learn how to read this stuff better someday... but I'll give it a shot:

> --- /dev/null
> +++ b/Documentation/devicetree/bindings/mtd/brcm,brcmnand.yaml
> @@ -0,0 +1,242 @@
...
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: brcm,nand-iproc
> +    then:
> +      properties:
> +        reg-names:
> +          minItems: 2
> +          maxItems: 3
> +          items:
> +            - const: nand
> +            - const: iproc-idm
> +            - const: iproc-ext

Reading the original binding as well as the code, I believe all three
are required. Wouldn't that be minItems = maxItems = 3?

Other than that, this looks good to me:

Reviewed-by: Brian Norris <computersforpeace@gmail.com>

Thanks!

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

  parent reply	other threads:[~2021-04-23  2:35 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 12:33 [PATCH] dt-bindings: mtd: brcm,brcmnand: convert to the json-schema Rafał Miłecki
2021-04-16 12:33 ` Rafał Miłecki
2021-04-16 19:54 ` [PATCH V2] " Rafał Miłecki
2021-04-16 19:54   ` [PATCH V2] dt-bindings: mtd: brcm, brcmnand: " Rafał Miłecki
2021-04-20 18:50   ` [PATCH V2] dt-bindings: mtd: brcm,brcmnand: " Rob Herring
2021-04-20 18:50     ` Rob Herring
2021-04-20 21:20   ` [PATCH V3] " Rafał Miłecki
2021-04-20 21:20     ` [PATCH V3] dt-bindings: mtd: brcm, brcmnand: " Rafał Miłecki
2021-04-21 17:05     ` [PATCH V3] dt-bindings: mtd: brcm,brcmnand: " Rob Herring
2021-04-21 17:05       ` Rob Herring
2021-04-23  2:34     ` Brian Norris [this message]
2021-04-23  2:34       ` [PATCH V3] dt-bindings: mtd: brcm, brcmnand: " Brian Norris
2021-04-23  5:05     ` [PATCH V4] " Rafał Miłecki
2021-04-23  5:05       ` Rafał Miłecki
2021-05-10 10:02       ` Miquel Raynal
2021-05-10 10:02         ` Miquel Raynal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAN8TOE-hMscEyqpZ+mpeZW85izuprxR-HosDgrD0P9o52ATQdQ@mail.gmail.com \
    --to=computersforpeace@gmail.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=kdasu.kdev@gmail.com \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=rafal@milecki.pl \
    --cc=richard@nod.at \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    --cc=zajec5@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.