Re: [PATCH 00/48] Rewrite kernel messages with standard printk helpers

[Raymond Yau <superquad.vortex2@gmail.com>]

> > > Hi,
> > > > >
> > > > > this is another long series of patches for trivial cleanups.
> > > > > This time, they replace the printk and snd_print*() calls in ALSA
> PCI
> > > > > and USB drivers with dev_err() and co.  This will give nicer and
> more
> > > > > consistent outputs.
> > > > >
> > > > > The only drawback by these replacements is that alsa-info.sh won't
> be
> > > > > able to catch the dmesg lines because it doesn't contain any longer
> > > > > the word "ALSA", but only show the module name like "snd_intel8x0".
> > > > >
> > > > > I'm going to fix alsa-info.sh on git soon later, but if you guys
> think
> > > > > "oh no it's disaster!", let me know.  We need to reconsider a
> better
> > > > > way to put the known markers (like explicitly putting "ALSA" at the
> > > > > beginning.)
> > > > >
> > > > >
> > > > seem missing au88x0
> > >
> > > Yes, because some driver codes are horrible to work on.
> > > Patches are welcome.
>

do sound-unstable.git test/snd-device need alsa-driver-build-unstable.git ?


> > >
> > > > can the driver build as modules in kernel 3.11 (ubuntu 13.10) ?
> > >
> > > The dev_err() and co exist since ages ago, so it shouldn't be a
> > > problem.  These patches, however, need the previous change of
> > > snd_card_new() to make the device pointer available in time.
> > >
> > > No idea about Ubuntu.
> > >
> > >
> > it seem usb-audio failed to build as module since last year
> >
> >
> https://git.kernel.org/cgit/linux/kernel/git/tiwai/sound.git/commit/?id=80ab8eae70e51d578ebbeb228e0f7a562471b8b7
>
> Ah, so you meant alsa-driver tree.  It's unmaintained so far due to
> the lack of time.  I really consider dropping it.
>
>

emu10k1_main.c is patched but snd-emu10k1.ko is not built and there is no
warning message about ZONE_DMA is not available



git clone git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git
git clone
git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/alsa-driver-build.git
cd alsa-driver-build
git checkout build
cd alsa
utils/setup-alsa-kernel -c ../../sound
./gitcompile --with-sequencer=yes --with-oss=no --enable-dynamic-minors

gcc utils/mod-deps.c -o utils/mod-deps
utils/mod-deps.c: In function ‘output_card_list’:
utils/mod-deps.c:1081:4: warning: format not a string literal and no format
arguments [-Wformat-security]
    printf(card_name);
    ^
utils/mod-deps --basedir /home/raymond/alsa-driver-build/alsa/alsa-kernel
--hiddendir /home/raymond/alsa-driver-build/alsa --versiondep
/home/raymond/alsa-driver-build/alsa/kconfig-vers --makeconf >
toplevel.config.in
can't handle 'default SND_SEQUENCER && SND_RAWMIDI', translating as depends
on
can't handle 'default SND_SEQUENCER && SND_OPL3_LIB', translating as
depends on
can't handle 'default SND_SEQUENCER && SND_OPL4_LIB', translating as
depends on
can't handle 'default SND_SEQUENCER && SND_SBAWE', translating as depends on
can't handle 'default SND_SEQUENCER && SND_EMU10K1', translating as depends
on




checking for kernel version... 3.11.0-17-generic
checking for GCC version... Kernel compiler:  Used compiler: gcc
(Ubuntu/Linaro 4.8.1-10ubuntu9) 4.8.1


checking for built-in ALSA... no
checking for existing ALSA module... yes
checking for Red Hat kernel... auto
checking for Red Hat kernel... no
checking for SUSE kernel... auto
checking for SUSE kernel... no
checking for updating alsa-kernel version.h... yes
checking for CONFIG_EXPERIMENTAL... yes
checking for directory to store kernel modules...
/lib/modules/3.11.0-17-generic/kernel/sound
checking for verbose procfs... on
checking for verbose printk... on
checking for debug level... none
checking for ISA support in kernel... no
checking for processor type... x86_64
checking for ISA DMA API... yes
checking for 32bit compat support... yes
checking for kernel linux/config.h... no
Creating <linux/config.h>...
checking for deprecated linux/config.h... checking to modify of kernel
linux/kmod.h... no
checking for kernel linux/kconfig.h... yes
checking for kernel linux/utsrelease.h... no
Creating a dummy <linux/utsrelease.h>...
checking for kernel linux/compiler.h... yes
checking for kernel linux/pm.h... yes
checking for kernel linux/pm_runtime.h... yes
checking for kernel linux/spinlock.h... yes
checking for kernel linux/irq.h... yes
checking for kernel linux/threads.h... yes
checking for kernel linux/rwsem.h... yes
checking for kernel linux/gameport.h... yes
checking for kernel linux/export.h... yes
checking for kernel media/v4l2-dev.h... yes
checking for kernel media/v4l2-device.h... yes
checking for kernel linux/devfs_fs_kernel.h... no
Creating a dummy <linux/devfs_fs_kernel.h>...
checking for kernel linux/highmem.h... yes
checking for kernel linux/ratelimit.h... yes
checking for kernel linux/kconfig.h... yes
checking for kernel linux/workqueue.h... yes
checking for kernel linux/dma-mapping.h... yes
checking for kernel asm/hw_irq.h... yes
checking for kernel linux/device.h... yes
checking for kernel linux/platform_device.h... yes
checking for kernel linux/isa.h... yes
checking for kernel linux/jiffies.h... yes
checking for kernel linux/compat.h... yes
checking for kernel linux/log2.h... yes
checking for kernel linux/adb.h... yes
checking for kernel linux/cuda.h... yes
checking for kernel linux/pmu.h... yes
checking for kernel linux/io.h... yes
checking for kernel linux/moduleparam.h... yes
checking for kernel linux/syscalls.h... yes
checking for kernel linux/firmware.h... yes
checking for kernel linux/err.h... yes
checking for kernel linux/bitmap.h... yes
checking for kernel linux/mutex.h... yes
checking for kernel linux/pm_qos.h... yes
checking for kernel linux/pm_qos_params.h... no
Creating <linux/pm_qos_params.h>...
checking for kernel linux/kthread.h... yes
checking for kernel asm/irq_regs.h... yes
checking for kernel linux/seq_file.h... yes
checking for kernel linux/debugfs.h... yes
checking for kernel linux/gpio.h... yes
checking for kernel linux/bug.h... yes
checking for kernel linux/math64.h... yes
checking for kernel linux/regulator/consumer.h... yes
checking for kernel linux/dmi.h... yes
checking for kernel linux/bitrev.h... yes
checking for kernel linux/hrtimer.h... yes
checking for kernel linux/vgaarb.h... yes
checking for kernel linux/vga_switcheroo.h... yes
checking for kernel linux/gcd.h... yes
checking for kernel linux/gfp.h... yes
checking for kernel pcmcia/cs_types.h... no
Creating <pcmcia/cs_types.h>...
checking for kernel pcmcia/cs.h... no
Creating <pcmcia/cs.h>...
checking for kernel linux/lzo.h... yes
checking for kernel linux/async.h... yes
checking for kernel linux/bitrev.h... yes
checking for kernel linux/smp_lock.h... no
Creating a dummy <linux/smp_lock.h>...
checking for kernel linux/i8253.h... yes
checking for kernel linux/atomic.h... yes
checking for kernel linux/thinkpad_acpi.h... yes
Copying trace/events headers
checking for kernel linux/tracepoint.h... yes
checking for kernel trace/define_trace.h... yes
Creating a workaround <linux/tracepoint.h>...
checking for kernel module symbol versions... yes
checking for has ioport support... yes
checking for PCI support in kernel... yes
checking for I2C driver in kernel... yes
checking for I2C_POWERMAC in kernel... unknown
checking for firmware loader... yes
checking for input subsystem in kernel... yes
checking for pc-speaker platform in kernel... yes
checking for SMP... yes
checking for Video device support in kernel... yes
checking for ISA PnP driver in kernel... yes
checking for PnP driver in kernel... yes
checking for Kernel ISA-PnP support... no
checking for Kernel ISA-PnP module support... no
checking for strlcpy... yes
checking for snprintf... yes
checking for vsnprintf... yes
checking for scnprintf... yes
checking for sscanf... yes
checking for vmalloc_to_page... yes
checking for vzalloc... yes
checking for div_u64... yes
checking for dev_name... yes
checking for dev_set_name... yes
checking for put_pid... yes
checking for pid_vnr... yes
checking for old kmod... no
checking for PDE... no
checking for pci_set_consistent_dma_mask... yes
checking for pci_dev_present... yes
checking for msleep... yes
checking for msleep_interrupt... yes
checking for msecs_to_jiffies... yes
checking for tty->count is the atomic type... yes
checking for video_drvdata... yes
checking for V4L1 layer... no
checking for V4L2 layer... yes
checking for kernel media/v4l2-ctrls.h... yes
checking for io_remap_pfn_range... yes
checking for kcalloc... yes
checking for kstrdup... yes
checking for kstrndup... yes
checking for kzalloc... yes
checking for create_workqueue with flags... no
checking for pci_ioremap_bar... yes
checking for register_sound_special_device... yes
checking for driver extra-version...
checking for driver version... 1.0.25
checking for dynamic minor numbers... yes
checking for maximum number of soundcards... max_cards
checking for sequencer support... yes
checking for OSS/Free emulation... no
checking for RTC support... no
checking for HPET support... yes
checking for Procfs support... yes
checking for USB support... yes
checking for kernel linux/usb/audio-v2.h... yes
checking for kernel linux/usb/audio.h... yes
checking for valid v1 in linux/usb/audio.h... yes
checking for invalid v2 in linux/usb/audio.h... no
checking for valid linux/usb/audio-v2.h... no
Creating <linux/usb/audio-v2.h>...
checking for kernel linux/usb/ch9.h... yes
checking usb_alloc_coherent... yes
checking for class_simple... no
checking for old driver suspend/resume callbacks... no
checking for removal of page-reservation for nopage/mmap... no
checking for vm_iomap_memory... yes
checking for nested class_device... no
checking for new IRQ handler... yes
checking for gfp_t... yes
checking for GFP_DMA32... yes
checking for page_to_pfn... yes
checking for PnP suspend/resume... yes
checking for device_create_drvdata... no
checking for pm_qos_request... yes
checking for static pm_qos_request... no
checking for new pm_qos_request... no
checking for new unlocked/compat_ioctl... yes
checking for builtin _Bool support... yes
checking for x86-compatible PC... no
checking for High-Res timers... yes
checking for kernel PCMCIA
checking for PCMCIA support... yes
checking for PC9800 support in kernel... no
checking for parallel port support... yes
checking for power management... yes
checking for CONFIG_HAS_DMA... yes
checking for FireWire support... yes
checking for set_pages_array_wc... yes
checking for fdput... yes
checking for cards to compile driver for... all
checking for additonal options to compile driver for... all


make[2]: Entering directory
`/home/raymond/alsa-driver-build/alsa/pci/emu10k1'
copying file alsa-kernel/pci/emu10k1/emu10k1_main.c
Ignoring potentially dangerous file name
../../alsa-kernel/pci/emu10k1/emu10k1_main.c
patching file emu10k1_main.c
Hunk #2 succeeded at 1807 (offset 33 lines).
copying file alsa-kernel/pci/emu10k1/emu10k1x.c
Ignoring potentially dangerous file name
../../alsa-kernel/pci/emu10k1/emu10k1x.c
patching file emu10k1x.c
Hunk #2 succeeded at 962 (offset 21 lines).
Hunk #3 succeeded at 1641 (offset 20 lines).
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
http://mailman.alsa-project.org/mailman/listinfo/alsa-devel