All of lore.kernel.org
 help / color / mirror / Atom feed
From: shekhar sharma <shekhar250198@gmail.com>
To: Phil Sutter <phil@nwl.cc>, netfilter-devel@vger.kernel.org
Subject: Re: [PATCH nft v2]tests: json_echo: convert to py3
Date: Tue, 28 May 2019 21:43:51 +0530	[thread overview]
Message-ID: <CAN9XX2ronY=gBVbjZrL2_ytycDiYCTm7qRCqYeb-zbxgELzy0Q@mail.gmail.com> (raw)
In-Reply-To: <20190528160617.GB21440@orbyte.nwl.cc>

On Tue, May 28, 2019, 9:36 PM Phil Sutter <phil@nwl.cc> wrote:
>
> Hi,
>
> On Tue, May 28, 2019 at 06:06:53AM +0530, Shekhar Sharma wrote:
> > This patch converts the run-test.py file to run on both python3 and python2.
> > The version history of the patch is:
> > v1: modified print and other statments.
> > v2: updated the shebang and order of import statements.
>
> I personally prefer to keep the respin-changelog out of the commit
> message, again in a section between commit message and diffstat. My
> approach is to rather make sure the commit message itself is up to date
> and contains everything relevant worth keeping from the changelog. But
> the topic is rather controversial (David Miller e.g. prefers the
> changelog as part of the commit message), so you've just read a purely
> informational monologue. :)
>
> > Signed-off-by: Shekhar Sharma <shekhar250198@gmail.com>
>
> Acked-by: Phil Sutter <phil@nwl.cc>
>
> Thanks, Phil


Informational monologues like these are very useful to people like me. :-).
I very highly value suggestions like these.

With regards,
Shekhar

  reply	other threads:[~2019-05-28 16:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-28  0:36 [PATCH nft v2]tests: json_echo: convert to py3 Shekhar Sharma
2019-05-28 16:06 ` Phil Sutter
2019-05-28 16:13   ` shekhar sharma [this message]
2019-05-29  7:47 ` Pablo Neira Ayuso
     [not found] ` <20190529074851.sjmnulacdufhhlmx@salvia>
2019-05-29  7:49   ` Pablo Neira Ayuso
2019-05-29  9:45     ` shekhar sharma

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAN9XX2ronY=gBVbjZrL2_ytycDiYCTm7qRCqYeb-zbxgELzy0Q@mail.gmail.com' \
    --to=shekhar250198@gmail.com \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=phil@nwl.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.