All of lore.kernel.org
 help / color / mirror / Atom feed
From: Arkady <arkady.miasnikov@gmail.com>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH v6 2/8] debugfs: prevent access to removed files' private data
Date: Sun, 19 Mar 2017 18:30:33 +0200	[thread overview]
Message-ID: <CANA-60ot0U-kCerb8cF_Bd85xC7QVvmqStPdfTUtQDBrYE_SWw@mail.gmail.com> (raw)

Nicolai,

Regarding the debugfs_create_file() which ignores .mmap field in the
struct file_operations. The patch is a part of the kernel 4.8 in the
Ubuntu 16.10 and breaks quite a few online code examples of mmap
drivers.

Is is acceptable to replace the debugfs_create_file() by a macro and
fail the compilation if the .mmap field is not initialized.
Alternatively debugfs_create_file() can return an error if .mmap is
not NULL.

Thank you, Arkady.

             reply	other threads:[~2017-03-19 17:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-19 16:30 Arkady [this message]
  -- strict thread matches above, loose matches on Subject: below --
2016-03-22 13:11 [PATCH v6 0/8] fix debugfs file removal races Nicolai Stange
2016-03-22 13:11 ` [PATCH v6 2/8] debugfs: prevent access to removed files' private data Nicolai Stange
2016-05-18 14:48   ` Sasha Levin
2016-05-18 15:01     ` Nicolai Stange
2016-05-18 15:18       ` Sasha Levin
2016-05-18 16:05         ` Greg Kroah-Hartman
2016-05-20 16:57           ` Sasha Levin
2016-05-21 17:57             ` Nicolai Stange
2016-05-22 13:28               ` Nicolai Stange
2016-05-18 16:32         ` Nicolai Stange
2016-05-20 16:55           ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANA-60ot0U-kCerb8cF_Bd85xC7QVvmqStPdfTUtQDBrYE_SWw@mail.gmail.com \
    --to=arkady.miasnikov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.