From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AB8D4C433F5 for ; Sat, 21 May 2022 09:52:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1349907AbiEUJwf (ORCPT ); Sat, 21 May 2022 05:52:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236810AbiEUJwc (ORCPT ); Sat, 21 May 2022 05:52:32 -0400 Received: from mail-io1-xd34.google.com (mail-io1-xd34.google.com [IPv6:2607:f8b0:4864:20::d34]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4B0AADFF67; Sat, 21 May 2022 02:52:30 -0700 (PDT) Received: by mail-io1-xd34.google.com with SMTP id d198so5876820iof.12; Sat, 21 May 2022 02:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HgU6CVcBQStjcDR5gk2dFy7rEHS5OgkX1HJgnqEvLw4=; b=OiM5dSKoVRtHFckOGNUBmUfGQYcX+ecD9ipw8M8AS5csnbpWH32uLwtiwQ5hVwyHvx IXAXwm0FLv8yQMy78Z9KQP1t9L8hg9KCEcFQ03HQqWFTtYvy/NQWY9Eopwga0Lneqpje MTZTZKTpQW1eUtDAZ/V04SNZKFIUZ/wyPuD+vklv/a72S+41O+iD9i1rgiHoQHhWaSXt XzLgATlHRwU1liDoo+vw5sC8C9YIa/rMHzfOYIS2Q69Pgfo665nC0hbioBh7Xq4ltYsd G3enkBJb1ElKXAi9fLqDNjcb/WPpJRvhnf3GGKWCVDz0x2GRhQXs25q4TnvHb8DLK9SY QGPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HgU6CVcBQStjcDR5gk2dFy7rEHS5OgkX1HJgnqEvLw4=; b=beLGFEJLOMSwk5MejloaXs2WzITbxUZjE4+w3N/d/XieNIcxXUHLQr1n8umCo7DvC3 eElkDaKDPvwyJUMNvqv+WS/FiIHUuO654SqZY05alA45HJaf+oqWw6WgZkj8Z5SNm8X2 jlZ4PhDiXw8v2Cg0uifyNwQQog7AFuRCZjPSynCVPQIhZT44s2hncZuE3i7UOa7fi46O +JQljLA8/W8oYhhe0d84S9pm/ma9xnARrZSYiez0SeCogPjWI1SFZuS8a6OsnCVt1M07 xLLXccZ8iRB7acNK1FL//lInhpXhn3na5suJiZU0YUGmMz+LQSYvwo1CsfzncOSudVss 66mg== X-Gm-Message-State: AOAM531QE6sPZrfZn642JIaL0HCB1381c41F3DyL9EULDhmyVjEIqdEc FoFSmf4ZNq5kGCKtp6wUlh41fiUCowhQrmIYEQI= X-Google-Smtp-Source: ABdhPJw2I3LiVPq9ZApoyJMwbFaJnOwaKOIo4UqmVWX6E5YU3HM68MY2KtVhBgJPSi2J0ZE+/mU127hS/nAp5g+gsCo= X-Received: by 2002:a05:6638:130a:b0:32b:b608:1676 with SMTP id r10-20020a056638130a00b0032bb6081676mr7729318jad.108.1653126749775; Sat, 21 May 2022 02:52:29 -0700 (PDT) MIME-Version: 1.0 References: <20220515064126.1424-1-linux.amoon@gmail.com> <20220515064126.1424-7-linux.amoon@gmail.com> <79b727f8-0631-5a96-fbc6-6e5d637bab7d@linaro.org> <018b97c2-efab-699d-653d-c220a98f5ec3@linaro.org> In-Reply-To: <018b97c2-efab-699d-653d-c220a98f5ec3@linaro.org> From: Anand Moon Date: Sat, 21 May 2022 15:22:13 +0530 Message-ID: Subject: Re: [PATCHv2 6/6] thermal: exynos: Add runtime power management for tmu To: Krzysztof Kozlowski Cc: Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Alim Akhtar , Linux PM list , linux-samsung-soc@vger.kernel.org, linux-arm-kernel , Linux Kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Krzysztof, On Wed, 18 May 2022 at 12:49, Krzysztof Kozlowski wrote: > > On 17/05/2022 20:45, Anand Moon wrote: > > Hi Krzysztof, > > > > On Sun, 15 May 2022 at 15:18, Krzysztof Kozlowski > > wrote: > >> > >> On 15/05/2022 08:41, Anand Moon wrote: > >>> Add runtime power management for exynos thermal driver. > >> > >> First of all - why? Second, I do not see it being added. Where are the > >> runtime callbacks? > >> > > > > To control runtime control PMU, did I miss something? > > Controlling runtime PM by itself is not a goal. What does it change if > it is enabled? > It means we could have efficient power management for this driver. as per my understanding, it controls runtime sleep and improves power efficiency > > I looked into imx thermal driver # drivers/thermal/imx_thermal.c > > to enable run-time power management for exynos driver. > > So you have runtime PM enabled and then what happens? Where is the power > saving? Since you did not implement the callbacks, all this should be > explained in commit msg. > Ok, As per the original code, it just registers the SIMPLE_DEV_PM_OPS with .pm = &exynos_tmu_pm So I have made sure that suspend resume feature works correctly with these changes on SBC Odroid U3 and XU4. I will try to look into setting RUNTIME_PM_OPS or use UNIVERSAL_DEV_PM_OPS instead of SIMPLE_DEV_PM_OPS any thought on this? > > Best regards, > Krzysztof Thanks and Regards -Anand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 891F9C433F5 for ; Sat, 21 May 2022 09:53:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=51U/8lr55/7L58wzErmqOI0bYnGAnOp/gVNTKObDGs8=; b=uQdzOz0WYw1tLN pTKfpT2GgLP3SQKpEiZDcNDRHkPKiu+PxjGzc6ih4RfjQ6uwWu/4I07DLKeEqH84A6J7zhj/HdurZ b5JcVGlL6+6QjkY64SmwNF2amy7lLV9tl9RqbA2Z0DhjZPz7rfx8mkCyfcJoTukSkRoolZXT5NX6U 1r50YfpEpv0elD4i2pznLvny2amoxYiQr3lBKj5IEG7x371SZFmVcshfooLwSQf1gGVSbqWq5SDK9 MXik0sYfBtCI0Z2ovThLw6jy2iHXTawyubCgjB6uf3SXf3tUcaIk0OrmP6keMS6/Iyo1Vd2h8HcHx 1xewgFhDw9A1qOYpWfIg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsLmj-00G6dT-Eo; Sat, 21 May 2022 09:52:33 +0000 Received: from mail-io1-xd30.google.com ([2607:f8b0:4864:20::d30]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsLmg-00G6cU-Qv for linux-arm-kernel@lists.infradead.org; Sat, 21 May 2022 09:52:32 +0000 Received: by mail-io1-xd30.google.com with SMTP id p74so7289730iod.8 for ; Sat, 21 May 2022 02:52:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=HgU6CVcBQStjcDR5gk2dFy7rEHS5OgkX1HJgnqEvLw4=; b=OiM5dSKoVRtHFckOGNUBmUfGQYcX+ecD9ipw8M8AS5csnbpWH32uLwtiwQ5hVwyHvx IXAXwm0FLv8yQMy78Z9KQP1t9L8hg9KCEcFQ03HQqWFTtYvy/NQWY9Eopwga0Lneqpje MTZTZKTpQW1eUtDAZ/V04SNZKFIUZ/wyPuD+vklv/a72S+41O+iD9i1rgiHoQHhWaSXt XzLgATlHRwU1liDoo+vw5sC8C9YIa/rMHzfOYIS2Q69Pgfo665nC0hbioBh7Xq4ltYsd G3enkBJb1ElKXAi9fLqDNjcb/WPpJRvhnf3GGKWCVDz0x2GRhQXs25q4TnvHb8DLK9SY QGPQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=HgU6CVcBQStjcDR5gk2dFy7rEHS5OgkX1HJgnqEvLw4=; b=4ONSF3yPv4enMs283nd7zxupFcCWlukIjC43/Xk2tgx0gAuNAaHFun6ryowGhcyO+/ IB03Cac3f+Y5CAEktAaH7QwfmlgBzBHZT0o1J+6j+XhQreoIip11N1jC+qBh0sx6LrH3 5ciAA3IIi8zQXFss/ezl9q62714f090SGhI9FgdBHMyjjNuZc7Tw3gTgh+GMBcX25mie LRK5LUKy8ArAJDFIUcZxpYnlAGMCDkRNhKcCeKuSPuWeKo6FQmVxiRxWw6o/vtrIDVXj K+GIU7uoTG4wlCUtLH+xa2j39SX1JbzpMNVE+FsYfwQAvuxbuwtEpviLZorXB8IgDIkh 5Iyw== X-Gm-Message-State: AOAM530gwGZNf5gkJaxlyZwNvsnNN2I4jnP0PumHwkuQTSe0vYfAMidf MMmTM0Z7OS7nShohlIBFlQcR/h0DzrASpaRviME= X-Google-Smtp-Source: ABdhPJw2I3LiVPq9ZApoyJMwbFaJnOwaKOIo4UqmVWX6E5YU3HM68MY2KtVhBgJPSi2J0ZE+/mU127hS/nAp5g+gsCo= X-Received: by 2002:a05:6638:130a:b0:32b:b608:1676 with SMTP id r10-20020a056638130a00b0032bb6081676mr7729318jad.108.1653126749775; Sat, 21 May 2022 02:52:29 -0700 (PDT) MIME-Version: 1.0 References: <20220515064126.1424-1-linux.amoon@gmail.com> <20220515064126.1424-7-linux.amoon@gmail.com> <79b727f8-0631-5a96-fbc6-6e5d637bab7d@linaro.org> <018b97c2-efab-699d-653d-c220a98f5ec3@linaro.org> In-Reply-To: <018b97c2-efab-699d-653d-c220a98f5ec3@linaro.org> From: Anand Moon Date: Sat, 21 May 2022 15:22:13 +0530 Message-ID: Subject: Re: [PATCHv2 6/6] thermal: exynos: Add runtime power management for tmu To: Krzysztof Kozlowski Cc: Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Alim Akhtar , Linux PM list , linux-samsung-soc@vger.kernel.org, linux-arm-kernel , Linux Kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220521_025230_936232_BD57BD27 X-CRM114-Status: GOOD ( 20.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Krzysztof, On Wed, 18 May 2022 at 12:49, Krzysztof Kozlowski wrote: > > On 17/05/2022 20:45, Anand Moon wrote: > > Hi Krzysztof, > > > > On Sun, 15 May 2022 at 15:18, Krzysztof Kozlowski > > wrote: > >> > >> On 15/05/2022 08:41, Anand Moon wrote: > >>> Add runtime power management for exynos thermal driver. > >> > >> First of all - why? Second, I do not see it being added. Where are the > >> runtime callbacks? > >> > > > > To control runtime control PMU, did I miss something? > > Controlling runtime PM by itself is not a goal. What does it change if > it is enabled? > It means we could have efficient power management for this driver. as per my understanding, it controls runtime sleep and improves power efficiency > > I looked into imx thermal driver # drivers/thermal/imx_thermal.c > > to enable run-time power management for exynos driver. > > So you have runtime PM enabled and then what happens? Where is the power > saving? Since you did not implement the callbacks, all this should be > explained in commit msg. > Ok, As per the original code, it just registers the SIMPLE_DEV_PM_OPS with .pm = &exynos_tmu_pm So I have made sure that suspend resume feature works correctly with these changes on SBC Odroid U3 and XU4. I will try to look into setting RUNTIME_PM_OPS or use UNIVERSAL_DEV_PM_OPS instead of SIMPLE_DEV_PM_OPS any thought on this? > > Best regards, > Krzysztof Thanks and Regards -Anand _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel