From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6433BC47404 for ; Mon, 7 Oct 2019 15:29:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 38F00205C9 for ; Mon, 7 Oct 2019 15:29:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rq91mJU4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728474AbfJGP3B (ORCPT ); Mon, 7 Oct 2019 11:29:01 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:33657 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726334AbfJGP3A (ORCPT ); Mon, 7 Oct 2019 11:29:00 -0400 Received: by mail-io1-f68.google.com with SMTP id z19so29597828ior.0; Mon, 07 Oct 2019 08:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wtVsLO1ntFCrS5daswTpm686yy3QS5pSIH9g4p/6SHY=; b=Rq91mJU4qTssd1QORjJKdkSCMC5RTaFQhaQZilPoU8yf2BUuUM+yTlZnTRoi+85Fri evPqABRZll0UgF32Srs86O6CyUHAb6Y4hgM+r2xZMDa9x1ClU/dfLgn/JjwfI+GnTJYt 9iIAlIcMRWHCoi/b6W1HBDgQEPLleBYKQNNBZYfF2AaD9gKAv7u7kE+NUbQxlehRltWh /HhI+/V/rk0/jcP6/YcVqlVkTrnJ+NVRkzGPUCXxk6uYohYaPCw/QKpAdMpxk2K95PGH ULYlMqwJWHMBZLNfWNWB8HRuYt3akVcDn6GgQ1145Fz43jqbF5bFZIWmdtjcBS+EkH5f j+yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wtVsLO1ntFCrS5daswTpm686yy3QS5pSIH9g4p/6SHY=; b=Ef70Hncbaa5KT9MTJTqoriQPM5idksBjaR/JG/hYVlyD1cbMP0wX14D9CzKukrEssX LpjmKLCz9hr8RlCaHtZcy5wSggOGWIYmTpYDc8Re7OT9WvsqY6bnTQR5SyGzXT3CJE+i Z62Y0zm6dadyXcVO0ejucNtCPCZgKgerVZUCWjXtlo/L10WqYC9o5tQvHS8RfUtuiq9M J4593kJE9vVfzN4AjgF6HrYSgTOpgMS86YmWw2uhkMdnlSj3o+HN1fS3OREvL2mp5x9e 4QNeoKt330onA8+eXL1I19ntpAhI0ren5zgG/CCTvfJtl4f+vx8BjgEAZLE5iByo14Mz M8SA== X-Gm-Message-State: APjAAAXOMcpci28Y4JQhSgvoTv45wRhZHMuPKDPyRlf2/o4Nzw5xNBKh uNtwq3xsNhMVhxn51OITj63VsG5wIrh7tW6t4dc= X-Google-Smtp-Source: APXvYqx45IwIf/HAU8nElk9tCCd1rWFbJeMPlSSBQCc0bur5Oz+a9TlsSmo4fwChJbmJLYKpfCOoDn08G87lnL/TrVc= X-Received: by 2002:a02:69cd:: with SMTP id e196mr28656654jac.84.1570462139862; Mon, 07 Oct 2019 08:28:59 -0700 (PDT) MIME-Version: 1.0 References: <20191007131649.1768-1-linux.amoon@gmail.com> <20191007131649.1768-2-linux.amoon@gmail.com> In-Reply-To: From: Anand Moon Date: Mon, 7 Oct 2019 20:58:47 +0530 Message-ID: Subject: Re: [RFCv1 1/5] arm64: dts: meson: Add missing 5V_EN gpio signal for VCC5V regulator To: Neil Armstrong Cc: Rob Herring , Mark Rutland , Kevin Hilman , Martin Blumenstingl , Jerome Brunet , Catalin Marinas , Will Deacon , devicetree , linux-arm-kernel , linux-amlogic@lists.infradead.org, Linux Kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Neil, On Mon, 7 Oct 2019 at 19:49, Neil Armstrong wrote: > > Hi Anand, > > On 07/10/2019 15:16, Anand Moon wrote: > > As per schematics add missing 5V_EN gpio signal to enable > > VCC5V regulator node. > > > > Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2) > > Cc: Martin Blumenstingl > > Cc: Jerome Brunet > > Cc: Neil Armstrong > > Signed-off-by: Anand Moon > > --- > > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > index 42f15405750c..a9a661258886 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > @@ -94,6 +94,9 @@ > > regulator-max-microvolt = <5000000>; > > regulator-always-on; > > vin-supply = <&main_12v>; > > + /* U12 NB679GD 5V_EN */ > > + gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>; > > + enable-active-high; > > This GPIO is handled by the BL301 SCP firmware, I'm personally against > adding this to the DT since it's out of control of Linux or any OS. > > Neil > Thanks for your input. > > }; > > > > vcc_1v8: regulator-vcc_1v8 { > > > Best Regards -Anand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01D62C47404 for ; Mon, 7 Oct 2019 15:29:05 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id CC0BD21721 for ; Mon, 7 Oct 2019 15:29:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="f3qhjzdK"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rq91mJU4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org CC0BD21721 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=c30nhpSVS0zGywjGNFvqOiwvGml8FChbOaZwDzDQjbk=; b=f3qhjzdKieM92x FCVdJD26gxfO/XVePs17Ki+GlJnV6+nqxtfu3bupySxt2G4eHWUJkxQAF78fjN5I8sNxkT0h5WS4Y c6cGx7VO6dHwC545mmaMJf1uxvAj0SqtDqWCnFphZny+JK5U1tuBPvsATanUVo0Vi4zl/OCLsUeOf DRLah41qnhAMzviEe0bDkFqnxL+gxcY9bLG/sOQRR09QyzHmhohPKER8NRQnBdaiMo+oKOUFOsy7N GM8dtr1+rPD8Aln5JLxYs6fiiBRBIALUOzAy1CAo7TylACVC4M/h6ip0jD8ehVM86Hy0yE+dGkAbN 7nu12KDsmroMVtZLQE7w==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHUwa-0006U2-2W; Mon, 07 Oct 2019 15:29:04 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHUwX-0006TL-7k; Mon, 07 Oct 2019 15:29:02 +0000 Received: by mail-io1-xd43.google.com with SMTP id n197so29415771iod.9; Mon, 07 Oct 2019 08:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wtVsLO1ntFCrS5daswTpm686yy3QS5pSIH9g4p/6SHY=; b=Rq91mJU4qTssd1QORjJKdkSCMC5RTaFQhaQZilPoU8yf2BUuUM+yTlZnTRoi+85Fri evPqABRZll0UgF32Srs86O6CyUHAb6Y4hgM+r2xZMDa9x1ClU/dfLgn/JjwfI+GnTJYt 9iIAlIcMRWHCoi/b6W1HBDgQEPLleBYKQNNBZYfF2AaD9gKAv7u7kE+NUbQxlehRltWh /HhI+/V/rk0/jcP6/YcVqlVkTrnJ+NVRkzGPUCXxk6uYohYaPCw/QKpAdMpxk2K95PGH ULYlMqwJWHMBZLNfWNWB8HRuYt3akVcDn6GgQ1145Fz43jqbF5bFZIWmdtjcBS+EkH5f j+yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wtVsLO1ntFCrS5daswTpm686yy3QS5pSIH9g4p/6SHY=; b=QKOp4PTlHdXjiN6T8s5GgOJJelnEWEmeEMwRRcyAFHUduWc6iiwXG6nkujh+rb5d2g /FfkjE6bn6uuef9XqoxnAOHzDuGJubU1/D3+0RqyXEz8coVz0dCVOgP7RO5s3J9GDw2B d9hE3c52q2MAkr1nlXyQiSrFmVclH8TQixwU99mpqOD0T7I7XV1nJkL6dbO3UrazOdNX hidXXO6eQMl7M4M9vulHZdG4RmDCGQsmRHliDw98KUm+GyySZhcTShMvz8FX1qhVgFtX bZ8MUL8i5Y59yN2yhIZYCBlKasS75L5NMZgVPTop1oTatP46Xa6u9cei2KTHZqouULjr al7g== X-Gm-Message-State: APjAAAUoUnCD6uRbMC7+c4UcSQwFsDOZWJdGcV47Cy6utPgTLSW4a5bR oxYJi+iFu2uavdHBlTbFhgF25oDebV45mTPoWfg= X-Google-Smtp-Source: APXvYqx45IwIf/HAU8nElk9tCCd1rWFbJeMPlSSBQCc0bur5Oz+a9TlsSmo4fwChJbmJLYKpfCOoDn08G87lnL/TrVc= X-Received: by 2002:a02:69cd:: with SMTP id e196mr28656654jac.84.1570462139862; Mon, 07 Oct 2019 08:28:59 -0700 (PDT) MIME-Version: 1.0 References: <20191007131649.1768-1-linux.amoon@gmail.com> <20191007131649.1768-2-linux.amoon@gmail.com> In-Reply-To: From: Anand Moon Date: Mon, 7 Oct 2019 20:58:47 +0530 Message-ID: Subject: Re: [RFCv1 1/5] arm64: dts: meson: Add missing 5V_EN gpio signal for VCC5V regulator To: Neil Armstrong X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_082901_280444_780CE36C X-CRM114-Status: GOOD ( 15.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Martin Blumenstingl , Kevin Hilman , Linux Kernel , Rob Herring , Catalin Marinas , linux-amlogic@lists.infradead.org, Will Deacon , linux-arm-kernel , Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Neil, On Mon, 7 Oct 2019 at 19:49, Neil Armstrong wrote: > > Hi Anand, > > On 07/10/2019 15:16, Anand Moon wrote: > > As per schematics add missing 5V_EN gpio signal to enable > > VCC5V regulator node. > > > > Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2) > > Cc: Martin Blumenstingl > > Cc: Jerome Brunet > > Cc: Neil Armstrong > > Signed-off-by: Anand Moon > > --- > > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > index 42f15405750c..a9a661258886 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > @@ -94,6 +94,9 @@ > > regulator-max-microvolt = <5000000>; > > regulator-always-on; > > vin-supply = <&main_12v>; > > + /* U12 NB679GD 5V_EN */ > > + gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>; > > + enable-active-high; > > This GPIO is handled by the BL301 SCP firmware, I'm personally against > adding this to the DT since it's out of control of Linux or any OS. > > Neil > Thanks for your input. > > }; > > > > vcc_1v8: regulator-vcc_1v8 { > > > Best Regards -Anand _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D70A5ECE58C for ; Mon, 7 Oct 2019 15:29:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A8D8C205C9 for ; Mon, 7 Oct 2019 15:29:18 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="d5pydNRG"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Rq91mJU4" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org A8D8C205C9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=DszvxDIlLBM4ZY1AD6uTUdbRGt2oBFNSkURQgl8QKs0=; b=d5pydNRGnTZOhD BuL1ks147EPphoJP2nPlUCTA33YmaQmyMOCd7J3EP/PeQCcBgvBI3c/RgHL+DBNQB5d9wLLlMl1iq ob/bUrZgs2+hg23kt5ZsZAiW0JFzdRbyNQtoNkNNxAkwpUF2IrLSgS84TFWegd3D/kjvWGDs0hT4U gH3D8VYdwAGIpCgLcRcujL7lbi9rKsyhQYUjYFAMEiEmlP5DkHrzUtNjcx1Dy4mpXU9glenAcLSh0 xTwV/FulA5mydioWA7YfbUoscTkGv3LgLvQx+0u3FKOtzKlaX16/z/P3r9iVnNvOaUISfy4B71ohz rGOD6bWZukmFujgvlbnA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHUwh-0006kz-Ks; Mon, 07 Oct 2019 15:29:11 +0000 Received: from mail-io1-xd43.google.com ([2607:f8b0:4864:20::d43]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHUwX-0006TL-7k; Mon, 07 Oct 2019 15:29:02 +0000 Received: by mail-io1-xd43.google.com with SMTP id n197so29415771iod.9; Mon, 07 Oct 2019 08:29:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=wtVsLO1ntFCrS5daswTpm686yy3QS5pSIH9g4p/6SHY=; b=Rq91mJU4qTssd1QORjJKdkSCMC5RTaFQhaQZilPoU8yf2BUuUM+yTlZnTRoi+85Fri evPqABRZll0UgF32Srs86O6CyUHAb6Y4hgM+r2xZMDa9x1ClU/dfLgn/JjwfI+GnTJYt 9iIAlIcMRWHCoi/b6W1HBDgQEPLleBYKQNNBZYfF2AaD9gKAv7u7kE+NUbQxlehRltWh /HhI+/V/rk0/jcP6/YcVqlVkTrnJ+NVRkzGPUCXxk6uYohYaPCw/QKpAdMpxk2K95PGH ULYlMqwJWHMBZLNfWNWB8HRuYt3akVcDn6GgQ1145Fz43jqbF5bFZIWmdtjcBS+EkH5f j+yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=wtVsLO1ntFCrS5daswTpm686yy3QS5pSIH9g4p/6SHY=; b=QKOp4PTlHdXjiN6T8s5GgOJJelnEWEmeEMwRRcyAFHUduWc6iiwXG6nkujh+rb5d2g /FfkjE6bn6uuef9XqoxnAOHzDuGJubU1/D3+0RqyXEz8coVz0dCVOgP7RO5s3J9GDw2B d9hE3c52q2MAkr1nlXyQiSrFmVclH8TQixwU99mpqOD0T7I7XV1nJkL6dbO3UrazOdNX hidXXO6eQMl7M4M9vulHZdG4RmDCGQsmRHliDw98KUm+GyySZhcTShMvz8FX1qhVgFtX bZ8MUL8i5Y59yN2yhIZYCBlKasS75L5NMZgVPTop1oTatP46Xa6u9cei2KTHZqouULjr al7g== X-Gm-Message-State: APjAAAUoUnCD6uRbMC7+c4UcSQwFsDOZWJdGcV47Cy6utPgTLSW4a5bR oxYJi+iFu2uavdHBlTbFhgF25oDebV45mTPoWfg= X-Google-Smtp-Source: APXvYqx45IwIf/HAU8nElk9tCCd1rWFbJeMPlSSBQCc0bur5Oz+a9TlsSmo4fwChJbmJLYKpfCOoDn08G87lnL/TrVc= X-Received: by 2002:a02:69cd:: with SMTP id e196mr28656654jac.84.1570462139862; Mon, 07 Oct 2019 08:28:59 -0700 (PDT) MIME-Version: 1.0 References: <20191007131649.1768-1-linux.amoon@gmail.com> <20191007131649.1768-2-linux.amoon@gmail.com> In-Reply-To: From: Anand Moon Date: Mon, 7 Oct 2019 20:58:47 +0530 Message-ID: Subject: Re: [RFCv1 1/5] arm64: dts: meson: Add missing 5V_EN gpio signal for VCC5V regulator To: Neil Armstrong X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_082901_280444_780CE36C X-CRM114-Status: GOOD ( 15.53 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Martin Blumenstingl , Kevin Hilman , Linux Kernel , Rob Herring , Catalin Marinas , linux-amlogic@lists.infradead.org, Will Deacon , linux-arm-kernel , Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Neil, On Mon, 7 Oct 2019 at 19:49, Neil Armstrong wrote: > > Hi Anand, > > On 07/10/2019 15:16, Anand Moon wrote: > > As per schematics add missing 5V_EN gpio signal to enable > > VCC5V regulator node. > > > > Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2) > > Cc: Martin Blumenstingl > > Cc: Jerome Brunet > > Cc: Neil Armstrong > > Signed-off-by: Anand Moon > > --- > > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > index 42f15405750c..a9a661258886 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > @@ -94,6 +94,9 @@ > > regulator-max-microvolt = <5000000>; > > regulator-always-on; > > vin-supply = <&main_12v>; > > + /* U12 NB679GD 5V_EN */ > > + gpio = <&gpio GPIOH_8 GPIO_OPEN_DRAIN>; > > + enable-active-high; > > This GPIO is handled by the BL301 SCP firmware, I'm personally against > adding this to the DT since it's out of control of Linux or any OS. > > Neil > Thanks for your input. > > }; > > > > vcc_1v8: regulator-vcc_1v8 { > > > Best Regards -Anand _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic