From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7FDBC47404 for ; Mon, 7 Oct 2019 15:54:08 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 9DF6120679 for ; Mon, 7 Oct 2019 15:54:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GIm5xSbR" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728598AbfJGPyH (ORCPT ); Mon, 7 Oct 2019 11:54:07 -0400 Received: from mail-io1-f67.google.com ([209.85.166.67]:39272 "EHLO mail-io1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727958AbfJGPyG (ORCPT ); Mon, 7 Oct 2019 11:54:06 -0400 Received: by mail-io1-f67.google.com with SMTP id a1so29693444ioc.6; Mon, 07 Oct 2019 08:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oOKcZv1B2M+ysN8LJmTMwi1RT7cbsvdwnRry27TboAA=; b=GIm5xSbRI50sJepzUbwycg7NDvMt3BT+3RYQ1Ak3PHk03MA/wlw9SqTNGY2DfIZkI3 vzloLLiQdo1Im+2BoTX2drQ9SytWBxd+eHhHN+oxkN83GrWLEW2lR8fnp2/7fI3yPVJk ZxOm4F1VeDXgpPbLMuAjDt3XlVRxikDPzHve8KYJuOw5hyLbMGGgxDCmn4YkVI3ivd7q +qC9HjO+buQM/o2qZs44GNytFS6dr+QBe4nE9YfUXJ9tYuB3aUliVkTo2PYIw168NusB jYzgE62kDvg5lylYW9+xxyGY9aRNG6dfE/sjjE4tsJNb9Fkc+4mHngnT1fhm2fIWSs2U RT8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oOKcZv1B2M+ysN8LJmTMwi1RT7cbsvdwnRry27TboAA=; b=TT0iZBLI16XwtTexmqZsUD5xmgKK/gzd0xMCjNNoM/VB5dn7LIR8A102KgkWh3HJmf iYXdlqA3pr1R5OFeFHb4/6YH9gnN1uy7yWAzamyPLdGxlpTdYj2Rtly7Uwbh76BQW4dt JPylGWhsS0F5bVYi2fJTjKPhrfmNGBW9UoBanU3rqcyOWUifJ1jO2dPIK0NDfCo0QmS2 WLrL2eahRMCWWkWVmlNLjhMMwFi2mrT6MOf6xk/sYUuoQvh8/u1wdAy25IcY20iDFZcJ xHzaHZX5U7ahJlbLEiZsAT8sZgHfo834Blgwbj60BKOksT/qeRCqZTdnfze/24bcqfdK Jh0Q== X-Gm-Message-State: APjAAAWe6WD8WI9jHmDQffAgaK7+MzyQxegubfwqQETzGc6ULP/5udX4 WjvDFKneRUinhIk+Q25EVexhTL9qbTmgi60cU/A= X-Google-Smtp-Source: APXvYqw9T09ClSC4idvRRaaJZz/xKErgE5SB3WxVYBhzuMFYdqY2HrLZiaXgYCS9faKiSyduxgwe6sfmi9HXu2ybLSY= X-Received: by 2002:a02:c983:: with SMTP id b3mr27831643jap.120.1570463645906; Mon, 07 Oct 2019 08:54:05 -0700 (PDT) MIME-Version: 1.0 References: <20191007131649.1768-1-linux.amoon@gmail.com> <20191007131649.1768-4-linux.amoon@gmail.com> In-Reply-To: From: Anand Moon Date: Mon, 7 Oct 2019 21:23:53 +0530 Message-ID: Subject: Re: [RFCv1 3/5] arm64: dts: meson: Add missing regulator linked to VDDAO_3V3 regulator to FLASH_VDD To: Neil Armstrong Cc: Rob Herring , Mark Rutland , Kevin Hilman , Martin Blumenstingl , Jerome Brunet , Catalin Marinas , Will Deacon , devicetree , linux-arm-kernel , linux-amlogic@lists.infradead.org, Linux Kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Neil, On Mon, 7 Oct 2019 at 19:51, Neil Armstrong wrote: > > On 07/10/2019 15:16, Anand Moon wrote: > > As per schematics add missing VDDAO_3V3 power supply to FLASH_VDD > > regulator. Also add TFLASH_VDD_EN signal name to gpio pin. > > > > Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2) > > Cc: Martin Blumenstingl > > Cc: Jerome Brunet > > Cc: Neil Armstrong > > Signed-off-by: Anand Moon > > --- > > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > index 66262a6ab3fe..6bd23a1e7e1d 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > @@ -51,9 +51,12 @@ > > regulator-min-microvolt = <3300000>; > > regulator-max-microvolt = <3300000>; > > > > + /* TFLASH_VDD_EN */ > > gpio = <&gpio_ao GPIOAO_8 GPIO_ACTIVE_HIGH>; > > enable-active-high; > > regulator-always-on; > > + /* U18 FC8731-09VF05NRR */ > > + vin-supply = <&vddao_3v3>; > > }; > > > > tf_io: gpio-regulator-tf_io { > > > > Reviewed-by: Neil Armstrong Thanks, Best Regards -Anand From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anand Moon Subject: Re: [RFCv1 3/5] arm64: dts: meson: Add missing regulator linked to VDDAO_3V3 regulator to FLASH_VDD Date: Mon, 7 Oct 2019 21:23:53 +0530 Message-ID: References: <20191007131649.1768-1-linux.amoon@gmail.com> <20191007131649.1768-4-linux.amoon@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Neil Armstrong Cc: Mark Rutland , devicetree , Martin Blumenstingl , Kevin Hilman , Linux Kernel , Rob Herring , Catalin Marinas , linux-amlogic@lists.infradead.org, Will Deacon , linux-arm-kernel , Jerome Brunet List-Id: devicetree@vger.kernel.org Hi Neil, On Mon, 7 Oct 2019 at 19:51, Neil Armstrong wrote: > > On 07/10/2019 15:16, Anand Moon wrote: > > As per schematics add missing VDDAO_3V3 power supply to FLASH_VDD > > regulator. Also add TFLASH_VDD_EN signal name to gpio pin. > > > > Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2) > > Cc: Martin Blumenstingl > > Cc: Jerome Brunet > > Cc: Neil Armstrong > > Signed-off-by: Anand Moon > > --- > > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > index 66262a6ab3fe..6bd23a1e7e1d 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > @@ -51,9 +51,12 @@ > > regulator-min-microvolt = <3300000>; > > regulator-max-microvolt = <3300000>; > > > > + /* TFLASH_VDD_EN */ > > gpio = <&gpio_ao GPIOAO_8 GPIO_ACTIVE_HIGH>; > > enable-active-high; > > regulator-always-on; > > + /* U18 FC8731-09VF05NRR */ > > + vin-supply = <&vddao_3v3>; > > }; > > > > tf_io: gpio-regulator-tf_io { > > > > Reviewed-by: Neil Armstrong Thanks, Best Regards -Anand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B95DECE58E for ; Mon, 7 Oct 2019 15:54:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 002B92070B for ; Mon, 7 Oct 2019 15:54:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="egGMSjk3"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GIm5xSbR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 002B92070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=yWyrI3Gj1hIz4M5n3GJF4CoPj6gH9KOghvad7jFqkYA=; b=egGMSjk3fMWZNj QdqElpl1jQINiMJbfunTr/Tg85uHWsM3bJw3v/QfD0HvHs939unRvSF+OGweFd6tv6EeL10rIhGhA ytYD5LFJoQKo9GRaRMc7uFDpNuaNLgDPs0JuWfUYJsI+YaA6JwN0B1Blvzn3rhcdSST9Mx1TlozVC MrHmrvfjllzYGCJPQUE1BxcRfp6KyGajSm93mUCxxdWfeGgwK+I8byACiXaBHTpfgucAvrBNgsLE6 HFJxJmXkZRMDSBgAF7MXCw9IxBZUXVZz/5/D0DgmDMNv0SA0Q2jipR8GKTcnbuM7r2EOuLmeZMbZ4 P4pRct+WD4kJ2k9HUMdA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHVKq-00081h-JZ; Mon, 07 Oct 2019 15:54:08 +0000 Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHVKo-00081A-FP; Mon, 07 Oct 2019 15:54:07 +0000 Received: by mail-io1-xd44.google.com with SMTP id q1so29760550ion.1; Mon, 07 Oct 2019 08:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oOKcZv1B2M+ysN8LJmTMwi1RT7cbsvdwnRry27TboAA=; b=GIm5xSbRI50sJepzUbwycg7NDvMt3BT+3RYQ1Ak3PHk03MA/wlw9SqTNGY2DfIZkI3 vzloLLiQdo1Im+2BoTX2drQ9SytWBxd+eHhHN+oxkN83GrWLEW2lR8fnp2/7fI3yPVJk ZxOm4F1VeDXgpPbLMuAjDt3XlVRxikDPzHve8KYJuOw5hyLbMGGgxDCmn4YkVI3ivd7q +qC9HjO+buQM/o2qZs44GNytFS6dr+QBe4nE9YfUXJ9tYuB3aUliVkTo2PYIw168NusB jYzgE62kDvg5lylYW9+xxyGY9aRNG6dfE/sjjE4tsJNb9Fkc+4mHngnT1fhm2fIWSs2U RT8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oOKcZv1B2M+ysN8LJmTMwi1RT7cbsvdwnRry27TboAA=; b=TjPmXVGuCV3Pz3VNEwdWCwyG3j1rE3uI0ekSqfcSCpNWnwvXHlE0mmbCx2DKCYmtBB 8SQJnSII2n/o0EMDX2aoUkzkk1Q2i80Q8fz85Nupr7rqRFgabydWP9/dIq+mgrKTd08B LOSMjZ4Az4HavbPA3ZtegbiEe4tp2738zvJFatLOXfsZ35B6doPqDuOT+wvZceH2hna3 OZPAyzL71Xg16xOO2/A576l4nW9UHhxji7na1ntCZdbrFBO5YjJWtjKUv9vT+/pDMveW bBByR3Nrz3Q3oSY8EyqsEJ3Fa043yAooEM60jAL0DA3rJ3JfxdmwBrAT0XZHuDbEpoLw HySA== X-Gm-Message-State: APjAAAUNrX4kxq4XIouN/1SiHtx94sLMMX5qPVBuT7N2Eliy6RLn0iXz Gi3HaNxAL2yDAVzDNzEv/I3O6eWFION/zjynWBc= X-Google-Smtp-Source: APXvYqw9T09ClSC4idvRRaaJZz/xKErgE5SB3WxVYBhzuMFYdqY2HrLZiaXgYCS9faKiSyduxgwe6sfmi9HXu2ybLSY= X-Received: by 2002:a02:c983:: with SMTP id b3mr27831643jap.120.1570463645906; Mon, 07 Oct 2019 08:54:05 -0700 (PDT) MIME-Version: 1.0 References: <20191007131649.1768-1-linux.amoon@gmail.com> <20191007131649.1768-4-linux.amoon@gmail.com> In-Reply-To: From: Anand Moon Date: Mon, 7 Oct 2019 21:23:53 +0530 Message-ID: Subject: Re: [RFCv1 3/5] arm64: dts: meson: Add missing regulator linked to VDDAO_3V3 regulator to FLASH_VDD To: Neil Armstrong X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_085406_519004_67607AD7 X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Martin Blumenstingl , Kevin Hilman , Linux Kernel , Rob Herring , Catalin Marinas , linux-amlogic@lists.infradead.org, Will Deacon , linux-arm-kernel , Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Neil, On Mon, 7 Oct 2019 at 19:51, Neil Armstrong wrote: > > On 07/10/2019 15:16, Anand Moon wrote: > > As per schematics add missing VDDAO_3V3 power supply to FLASH_VDD > > regulator. Also add TFLASH_VDD_EN signal name to gpio pin. > > > > Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2) > > Cc: Martin Blumenstingl > > Cc: Jerome Brunet > > Cc: Neil Armstrong > > Signed-off-by: Anand Moon > > --- > > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > index 66262a6ab3fe..6bd23a1e7e1d 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > @@ -51,9 +51,12 @@ > > regulator-min-microvolt = <3300000>; > > regulator-max-microvolt = <3300000>; > > > > + /* TFLASH_VDD_EN */ > > gpio = <&gpio_ao GPIOAO_8 GPIO_ACTIVE_HIGH>; > > enable-active-high; > > regulator-always-on; > > + /* U18 FC8731-09VF05NRR */ > > + vin-supply = <&vddao_3v3>; > > }; > > > > tf_io: gpio-regulator-tf_io { > > > > Reviewed-by: Neil Armstrong Thanks, Best Regards -Anand _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A205ECE58C for ; Mon, 7 Oct 2019 15:54:18 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F047720679 for ; Mon, 7 Oct 2019 15:54:17 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="GXv5NWJ2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="GIm5xSbR" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F047720679 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FSldB8hXrJqfEA1pX0Wng0t/MNbD9WGgkl9TomE0Wf8=; b=GXv5NWJ2owgnyS WZKnfzd3lsITmDLMxajryBxzx4TYh/6Rfwr1vfWYhtTzdAO3hcWKTvAn9E+gHkVMLLYvQmeykDO0L DnKf2O1ITk6u9l0onBCbEDJa9Zg3Glh18oyihDFTscFE3IRH5lXPKj88I2gdmvleR1hzcEmW+eAcT iEbFmP68gogTGWf+PpuFMTvdT9EvOgTdASYEa2bl5tir/i76SO9c4ABapH8LLaj3w35oW00QGqo+g /Xso3CecOKz9mNynoBkeP0TcQZPqy6bpYvujCWAgIPAUmzyCnr4+e1scOSv9oGW0gfcNJsjWBUiPM 96HmwXLyItu7tFsxcdMQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHVKv-000894-Rs; Mon, 07 Oct 2019 15:54:13 +0000 Received: from mail-io1-xd44.google.com ([2607:f8b0:4864:20::d44]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iHVKo-00081A-FP; Mon, 07 Oct 2019 15:54:07 +0000 Received: by mail-io1-xd44.google.com with SMTP id q1so29760550ion.1; Mon, 07 Oct 2019 08:54:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=oOKcZv1B2M+ysN8LJmTMwi1RT7cbsvdwnRry27TboAA=; b=GIm5xSbRI50sJepzUbwycg7NDvMt3BT+3RYQ1Ak3PHk03MA/wlw9SqTNGY2DfIZkI3 vzloLLiQdo1Im+2BoTX2drQ9SytWBxd+eHhHN+oxkN83GrWLEW2lR8fnp2/7fI3yPVJk ZxOm4F1VeDXgpPbLMuAjDt3XlVRxikDPzHve8KYJuOw5hyLbMGGgxDCmn4YkVI3ivd7q +qC9HjO+buQM/o2qZs44GNytFS6dr+QBe4nE9YfUXJ9tYuB3aUliVkTo2PYIw168NusB jYzgE62kDvg5lylYW9+xxyGY9aRNG6dfE/sjjE4tsJNb9Fkc+4mHngnT1fhm2fIWSs2U RT8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=oOKcZv1B2M+ysN8LJmTMwi1RT7cbsvdwnRry27TboAA=; b=TjPmXVGuCV3Pz3VNEwdWCwyG3j1rE3uI0ekSqfcSCpNWnwvXHlE0mmbCx2DKCYmtBB 8SQJnSII2n/o0EMDX2aoUkzkk1Q2i80Q8fz85Nupr7rqRFgabydWP9/dIq+mgrKTd08B LOSMjZ4Az4HavbPA3ZtegbiEe4tp2738zvJFatLOXfsZ35B6doPqDuOT+wvZceH2hna3 OZPAyzL71Xg16xOO2/A576l4nW9UHhxji7na1ntCZdbrFBO5YjJWtjKUv9vT+/pDMveW bBByR3Nrz3Q3oSY8EyqsEJ3Fa043yAooEM60jAL0DA3rJ3JfxdmwBrAT0XZHuDbEpoLw HySA== X-Gm-Message-State: APjAAAUNrX4kxq4XIouN/1SiHtx94sLMMX5qPVBuT7N2Eliy6RLn0iXz Gi3HaNxAL2yDAVzDNzEv/I3O6eWFION/zjynWBc= X-Google-Smtp-Source: APXvYqw9T09ClSC4idvRRaaJZz/xKErgE5SB3WxVYBhzuMFYdqY2HrLZiaXgYCS9faKiSyduxgwe6sfmi9HXu2ybLSY= X-Received: by 2002:a02:c983:: with SMTP id b3mr27831643jap.120.1570463645906; Mon, 07 Oct 2019 08:54:05 -0700 (PDT) MIME-Version: 1.0 References: <20191007131649.1768-1-linux.amoon@gmail.com> <20191007131649.1768-4-linux.amoon@gmail.com> In-Reply-To: From: Anand Moon Date: Mon, 7 Oct 2019 21:23:53 +0530 Message-ID: Subject: Re: [RFCv1 3/5] arm64: dts: meson: Add missing regulator linked to VDDAO_3V3 regulator to FLASH_VDD To: Neil Armstrong X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191007_085406_519004_67607AD7 X-CRM114-Status: GOOD ( 13.19 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Martin Blumenstingl , Kevin Hilman , Linux Kernel , Rob Herring , Catalin Marinas , linux-amlogic@lists.infradead.org, Will Deacon , linux-arm-kernel , Jerome Brunet Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org Hi Neil, On Mon, 7 Oct 2019 at 19:51, Neil Armstrong wrote: > > On 07/10/2019 15:16, Anand Moon wrote: > > As per schematics add missing VDDAO_3V3 power supply to FLASH_VDD > > regulator. Also add TFLASH_VDD_EN signal name to gpio pin. > > > > Fixes: c35f6dc5c377 (arm64: dts: meson: Add minimal support for Odroid-N2) > > Cc: Martin Blumenstingl > > Cc: Jerome Brunet > > Cc: Neil Armstrong > > Signed-off-by: Anand Moon > > --- > > arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > index 66262a6ab3fe..6bd23a1e7e1d 100644 > > --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts > > @@ -51,9 +51,12 @@ > > regulator-min-microvolt = <3300000>; > > regulator-max-microvolt = <3300000>; > > > > + /* TFLASH_VDD_EN */ > > gpio = <&gpio_ao GPIOAO_8 GPIO_ACTIVE_HIGH>; > > enable-active-high; > > regulator-always-on; > > + /* U18 FC8731-09VF05NRR */ > > + vin-supply = <&vddao_3v3>; > > }; > > > > tf_io: gpio-regulator-tf_io { > > > > Reviewed-by: Neil Armstrong Thanks, Best Regards -Anand _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic