v5 Exynos5422 odroidxu3 pwm-fan control using thermal sensors

v5 Exynos5422 odroidxu3 pwm-fan control using thermal sensors

[Anand Moon]

Rebase on  https://github.com/krzk/linux.git v4.2-next/dt-samsung

Changes from previous version.
Updated the the "cpu-crit-0" trip point in arch/arm/boot/dts/exynos5-cpu-thermal.dtsi

Changes From 
				cpu_crit0: cpu-crit-0 {
					temperature = <100000>; /* millicelsius */
					hysteresis = <0>; /* millicelsius */
					type = "critical";
				};
Changes To 
				cpu_crit0: cpu-crit-0 {
					temperature = <120000>; /* millicelsius */
					hysteresis = <0>; /* millicelsius */
					type = "critical";
				};

Changes were made to match exynos5420-trip-points.dtsi

-Anand Moon

v5 Exynos5422 odroidxu3 pwm-fan control using thermal sensors

[Anand Moon]

Rebase on  https://github.com/krzk/linux.git v4.2-next/dt-samsung

Changes from previous version.
Updated the the "cpu-crit-0" trip point in arch/arm/boot/dts/exynos5-cpu-thermal.dtsi

Changes From 
				cpu_crit0: cpu-crit-0 {
					temperature = <100000>; /* millicelsius */
					hysteresis = <0>; /* millicelsius */
					type = "critical";
				};
Changes To 
				cpu_crit0: cpu-crit-0 {
					temperature = <120000>; /* millicelsius */
					hysteresis = <0>; /* millicelsius */
					type = "critical";
				};

Changes were made to match exynos5420-trip-points.dtsi

-Anand Moon

[PATCHv5 1/5] ARM: dts: exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board

[Anand Moon]

Add pwm-fan node to the Odroid-XU3 board.

Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index f0ce60b..9446e28 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -310,6 +310,15 @@
 			linux,default-trigger = "mmc1";
 		};
 	};
+
+	fan0: pwm-fan {
+		compatible = "pwm-fan";
+		pwms = <&pwm 0 20972 0>;
+		cooling-min-state = <0>;
+		cooling-max-state = <3>;
+		#cooling-cells = <2>;
+		cooling-levels = <0 130 170 230>;
+	};
 };
 
 &hdmi {
@@ -415,3 +424,10 @@
 		shunt-resistor = <10000>;
 	};
 };
+
+&pwm {
+	pinctrl-0 = <&pwm0_out>;
+	pinctrl-names = "default";
+	samsung,pwm-outputs = <0>;
+	status = "okay";
+};
-- 
1.9.1

[PATCHv5 1/5] ARM: dts: exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board

[Anand Moon]

Add pwm-fan node to the Odroid-XU3 board.

Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 16 ++++++++++++++++
 1 file changed, 16 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index f0ce60b..9446e28 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -310,6 +310,15 @@
 			linux,default-trigger = "mmc1";
 		};
 	};
+
+	fan0: pwm-fan {
+		compatible = "pwm-fan";
+		pwms = <&pwm 0 20972 0>;
+		cooling-min-state = <0>;
+		cooling-max-state = <3>;
+		#cooling-cells = <2>;
+		cooling-levels = <0 130 170 230>;
+	};
 };
 
 &hdmi {
@@ -415,3 +424,10 @@
 		shunt-resistor = <10000>;
 	};
 };
+
+&pwm {
+	pinctrl-0 = <&pwm0_out>;
+	pinctrl-names = "default";
+	samsung,pwm-outputs = <0>;
+	status = "okay";
+};
-- 
1.9.1

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

This changes enables TMU IP block on the Exynos5422 Odroid-XU3
device.

Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index 9446e28..cd78816 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -319,6 +319,31 @@
 		#cooling-cells = <2>;
 		cooling-levels = <0 130 170 230>;
 	};
+
+	tmu@10060000 {
+		vtmu-supply = <&ldo10_reg>;
+		status = "okay";
+	};
+
+	tmu@10064000 {
+		vtmu-supply = <&ldo10_reg>;
+		status = "okay";
+	};
+
+	tmu@10068000 {
+		vtmu-supply = <&ldo10_reg>;
+		status = "okay";
+	};
+
+	tmu@1006c000 {
+		vtmu-supply = <&ldo10_reg>;
+		status = "okay";
+	};
+
+	tmu@100a0000 {
+		vtmu-supply = <&ldo10_reg>;
+		status = "okay";
+	};
 };
 
 &hdmi {
-- 
1.9.1

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

This changes enables TMU IP block on the Exynos5422 Odroid-XU3
device.

Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index 9446e28..cd78816 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -319,6 +319,31 @@
 		#cooling-cells = <2>;
 		cooling-levels = <0 130 170 230>;
 	};
+
+	tmu at 10060000 {
+		vtmu-supply = <&ldo10_reg>;
+		status = "okay";
+	};
+
+	tmu at 10064000 {
+		vtmu-supply = <&ldo10_reg>;
+		status = "okay";
+	};
+
+	tmu at 10068000 {
+		vtmu-supply = <&ldo10_reg>;
+		status = "okay";
+	};
+
+	tmu at 1006c000 {
+		vtmu-supply = <&ldo10_reg>;
+		status = "okay";
+	};
+
+	tmu at 100a0000 {
+		vtmu-supply = <&ldo10_reg>;
+		status = "okay";
+	};
 };
 
 &hdmi {
-- 
1.9.1

[PATCHv5 3/5] ARM: dts: define default thermal-zones for exynos5422

[Anand Moon]

Trip points corresponding to the one defined in the exynos_tmu_data.c
for Exynos5 have been included.
This thermal-zones attribute is afterwards reused for Exynos5422.

Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm/boot/dts/exynos5-cpu-thermal.dtsi | 59 ++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos5-cpu-thermal.dtsi

diff --git a/arch/arm/boot/dts/exynos5-cpu-thermal.dtsi b/arch/arm/boot/dts/exynos5-cpu-thermal.dtsi
new file mode 100644
index 0000000..508375d
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5-cpu-thermal.dtsi
@@ -0,0 +1,59 @@
+/*
+ * Device tree sources for Exynos5 thermal zone
+ *
+ * Copyright (c) 2015 Lukasz Majewski <l.majewski@samsung.com>
+ *			Anand Moon <linux.amoon@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ */
+
+#include <dt-bindings/thermal/thermal.h>
+
+/ {
+	thermal-zones {
+		cpu0_thermal: cpu0-thermal {
+			thermal-sensors = <&tmu_cpu0 0>;
+			polling-delay-passive = <0>;
+			polling-delay = <0>;
+			trips {
+				cpu_alert0: cpu-alert-0 {
+					temperature = <50000>; /* millicelsius */
+					hysteresis = <5000>; /* millicelsius */
+					type = "active";
+				};
+				cpu_alert1: cpu-alert-1 {
+					temperature = <60000>; /* millicelsius */
+					hysteresis = <5000>; /* millicelsius */
+					type = "active";
+				};
+				cpu_alert2: cpu-alert-2 {
+					temperature = <70000>; /* millicelsius */
+					hysteresis = <5000>; /* millicelsius */
+					type = "active";
+				};
+				cpu_crit0: cpu-crit-0 {
+					temperature = <120000>; /* millicelsius */
+					hysteresis = <0>; /* millicelsius */
+					type = "critical";
+				};
+			};
+			cooling-maps {
+				map0 {
+				     trip = <&cpu_alert0>;
+				     cooling-device = <&fan0 0 1>;
+				};
+				map1 {
+				     trip = <&cpu_alert1>;
+				     cooling-device = <&fan0 1 2>;
+				};
+				map2 {
+				     trip = <&cpu_alert2>;
+				     cooling-device = <&fan0 2 3>;
+				};
+			};
+		};
+	};
+};
-- 
1.9.1

[PATCHv5 3/5] ARM: dts: define default thermal-zones for exynos5422

[Anand Moon]

Trip points corresponding to the one defined in the exynos_tmu_data.c
for Exynos5 have been included.
This thermal-zones attribute is afterwards reused for Exynos5422.

Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm/boot/dts/exynos5-cpu-thermal.dtsi | 59 ++++++++++++++++++++++++++++++
 1 file changed, 59 insertions(+)
 create mode 100644 arch/arm/boot/dts/exynos5-cpu-thermal.dtsi

diff --git a/arch/arm/boot/dts/exynos5-cpu-thermal.dtsi b/arch/arm/boot/dts/exynos5-cpu-thermal.dtsi
new file mode 100644
index 0000000..508375d
--- /dev/null
+++ b/arch/arm/boot/dts/exynos5-cpu-thermal.dtsi
@@ -0,0 +1,59 @@
+/*
+ * Device tree sources for Exynos5 thermal zone
+ *
+ * Copyright (c) 2015 Lukasz Majewski <l.majewski@samsung.com>
+ *			Anand Moon <linux.amoon@gmail.com>
+ *
+ * This program is free software; you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 2 as
+ * published by the Free Software Foundation.
+ *
+ */
+
+#include <dt-bindings/thermal/thermal.h>
+
+/ {
+	thermal-zones {
+		cpu0_thermal: cpu0-thermal {
+			thermal-sensors = <&tmu_cpu0 0>;
+			polling-delay-passive = <0>;
+			polling-delay = <0>;
+			trips {
+				cpu_alert0: cpu-alert-0 {
+					temperature = <50000>; /* millicelsius */
+					hysteresis = <5000>; /* millicelsius */
+					type = "active";
+				};
+				cpu_alert1: cpu-alert-1 {
+					temperature = <60000>; /* millicelsius */
+					hysteresis = <5000>; /* millicelsius */
+					type = "active";
+				};
+				cpu_alert2: cpu-alert-2 {
+					temperature = <70000>; /* millicelsius */
+					hysteresis = <5000>; /* millicelsius */
+					type = "active";
+				};
+				cpu_crit0: cpu-crit-0 {
+					temperature = <120000>; /* millicelsius */
+					hysteresis = <0>; /* millicelsius */
+					type = "critical";
+				};
+			};
+			cooling-maps {
+				map0 {
+				     trip = <&cpu_alert0>;
+				     cooling-device = <&fan0 0 1>;
+				};
+				map1 {
+				     trip = <&cpu_alert1>;
+				     cooling-device = <&fan0 1 2>;
+				};
+				map2 {
+				     trip = <&cpu_alert2>;
+				     cooling-device = <&fan0 2 3>;
+				};
+			};
+		};
+	};
+};
-- 
1.9.1

[PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0

[Anand Moon]

update the cooling level for cpu0 to avoid following message.

root@odroidxu3:~# dmesg | grep ther
[    0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0:
                         could not get #cooling-cells for /cpus/cpu@0

Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm/boot/dts/exynos5420.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 4531753..c75ed16 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -61,6 +61,10 @@
 			reg = <0x0>;
 			clock-frequency = <1800000000>;
 			cci-control-port = <&cci_control1>;
+
+			cooling-min-level = <10>;
+			cooling-max-level = <7>;
+			#cooling-cells = <2>; /* min followed by max */
 		};
 
 		cpu1: cpu@1 {
-- 
1.9.1

[PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0

[Anand Moon]

update the cooling level for cpu0 to avoid following message.

root at odroidxu3:~# dmesg | grep ther
[    0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0:
                         could not get #cooling-cells for /cpus/cpu at 0

Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm/boot/dts/exynos5420.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
index 4531753..c75ed16 100644
--- a/arch/arm/boot/dts/exynos5420.dtsi
+++ b/arch/arm/boot/dts/exynos5420.dtsi
@@ -61,6 +61,10 @@
 			reg = <0x0>;
 			clock-frequency = <1800000000>;
 			cci-control-port = <&cci_control1>;
+
+			cooling-min-level = <10>;
+			cooling-max-level = <7>;
+			#cooling-cells = <2>; /* min followed by max */
 		};
 
 		cpu1: cpu at 1 {
-- 
1.9.1

[PATCHv5 5/5] ARM: dts: Enable thermal_zone for exynos5422-odroidxu3

[Anand Moon]

Include exynos5-cpu-thermal.dtsi to enable thermal_zone support.

Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index cd78816..9256fb5 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -13,6 +13,7 @@
 /dts-v1/;
 #include <dt-bindings/gpio/gpio.h>
 #include "exynos5800.dtsi"
+#include "exynos5-cpu-thermal.dtsi"
 
 / {
 	model = "Hardkernel Odroid XU3";
-- 
1.9.1

[PATCHv5 5/5] ARM: dts: Enable thermal_zone for exynos5422-odroidxu3

[Anand Moon]

Include exynos5-cpu-thermal.dtsi to enable thermal_zone support.

Tested-by: Markus Reichl <m.reichl@fivetechno.de>
Acked-by: Lukasz Majewski <l.majewski@samsung.com>
Signed-off-by: Anand Moon <linux.amoon@gmail.com>
---
 arch/arm/boot/dts/exynos5422-odroidxu3.dts | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
index cd78816..9256fb5 100644
--- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
+++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
@@ -13,6 +13,7 @@
 /dts-v1/;
 #include <dt-bindings/gpio/gpio.h>
 #include "exynos5800.dtsi"
+#include "exynos5-cpu-thermal.dtsi"
 
 / {
 	model = "Hardkernel Odroid XU3";
-- 
1.9.1

Re: [PATCHv5 1/5] ARM: dts: exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board

[Krzysztof Kozlowski]

2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> Add pwm-fan node to the Odroid-XU3 board.
>
> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>

Please fix the title of commit (missing colon, duplicated name of board) to:
"ARM: dts: exynos5422-odroidxu3: Add pwm-fan node"

Rest looks good:
Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

[PATCHv5 1/5] ARM: dts: exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board

[Krzysztof Kozlowski]

2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> Add pwm-fan node to the Odroid-XU3 board.
>
> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>

Please fix the title of commit (missing colon, duplicated name of board) to:
"ARM: dts: exynos5422-odroidxu3: Add pwm-fan node"

Rest looks good:
Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Krzysztof Kozlowski]

2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
> device.
>
> Tested-by: Markus Reichl <m.reichl-SRyzfwRm/0rPTwkrwQOX7A@public.gmane.org>
> Acked-by: Lukasz Majewski <l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Signed-off-by: Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index 9446e28..cd78816 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -319,6 +319,31 @@
>                 #cooling-cells = <2>;
>                 cooling-levels = <0 130 170 230>;
>         };
> +
> +       tmu@10060000 {

Here and for other overrides please use label notation, like:

&tmu_cpu0 {
              ...
};

> +               vtmu-supply = <&ldo10_reg>;

I am curious, how did you find that LDO10 supplies TMU unit?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Krzysztof Kozlowski]

2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
> device.
>
> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>  1 file changed, 25 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> index 9446e28..cd78816 100644
> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
> @@ -319,6 +319,31 @@
>                 #cooling-cells = <2>;
>                 cooling-levels = <0 130 170 230>;
>         };
> +
> +       tmu at 10060000 {

Here and for other overrides please use label notation, like:

&tmu_cpu0 {
              ...
};

> +               vtmu-supply = <&ldo10_reg>;

I am curious, how did you find that LDO10 supplies TMU unit?

Best regards,
Krzysztof

Re: [PATCHv5 3/5] ARM: dts: define default thermal-zones for exynos5422

[Krzysztof Kozlowski]

2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> Trip points corresponding to the one defined in the exynos_tmu_data.c
> for Exynos5 have been included.
> This thermal-zones attribute is afterwards reused for Exynos5422.
>
> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>

Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

[PATCHv5 3/5] ARM: dts: define default thermal-zones for exynos5422

[Krzysztof Kozlowski]

2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> Trip points corresponding to the one defined in the exynos_tmu_data.c
> for Exynos5 have been included.
> This thermal-zones attribute is afterwards reused for Exynos5422.
>
> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>

Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>

Best regards,
Krzysztof

Re: [PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0

[Krzysztof Kozlowski]

2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> update the cooling level for cpu0 to avoid following message.

Capitalize sentence.
In commit subject add missing colon after "exynos5420".

>
> root@odroidxu3:~# dmesg | grep ther

This command not needed, we all know how to use dmesg and grep.

> [    0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0:
>                          could not get #cooling-cells for /cpus/cpu@0
>
> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
>  arch/arm/boot/dts/exynos5420.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 4531753..c75ed16 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -61,6 +61,10 @@
>                         reg = <0x0>;
>                         clock-frequency = <1800000000>;
>                         cci-control-port = <&cci_control1>;
> +
> +                       cooling-min-level = <10>;
> +                       cooling-max-level = <7>;
> +                       #cooling-cells = <2>; /* min followed by max */

I might be missing something but I do not understand which cooling
levels are referenced here. In my exynos5420.dtsi file there are no
frequencies for cpu0 node. Could you help me understand this?

Best regards,
Krzysztof

[PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0

[Krzysztof Kozlowski]

2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> update the cooling level for cpu0 to avoid following message.

Capitalize sentence.
In commit subject add missing colon after "exynos5420".

>
> root at odroidxu3:~# dmesg | grep ther

This command not needed, we all know how to use dmesg and grep.

> [    0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0:
>                          could not get #cooling-cells for /cpus/cpu at 0
>
> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
>  arch/arm/boot/dts/exynos5420.dtsi | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
> index 4531753..c75ed16 100644
> --- a/arch/arm/boot/dts/exynos5420.dtsi
> +++ b/arch/arm/boot/dts/exynos5420.dtsi
> @@ -61,6 +61,10 @@
>                         reg = <0x0>;
>                         clock-frequency = <1800000000>;
>                         cci-control-port = <&cci_control1>;
> +
> +                       cooling-min-level = <10>;
> +                       cooling-max-level = <7>;
> +                       #cooling-cells = <2>; /* min followed by max */

I might be missing something but I do not understand which cooling
levels are referenced here. In my exynos5420.dtsi file there are no
frequencies for cpu0 node. Could you help me understand this?

Best regards,
Krzysztof

Re: [PATCHv5 5/5] ARM: dts: Enable thermal_zone for exynos5422-odroidxu3

[Krzysztof Kozlowski]

2015-05-13 15:37 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> Include exynos5-cpu-thermal.dtsi to enable thermal_zone support.

I am a little confused because you named this file as
exynos5-cpu-thermal, meaning it is common for all Exynos5 boards. But:
1. It references some specific phandles like &fan0 (cooling-device =
<&fan0 2 3>).
2. You include it only here.

So the question: is "exynos5-cpu-thermal.dtsi" a generic thermal DTSI?
What is your intention?

Lukasz, you acked the patchset, is it fine?

Best regards,
Krzysztof

[PATCHv5 5/5] ARM: dts: Enable thermal_zone for exynos5422-odroidxu3

[Krzysztof Kozlowski]

2015-05-13 15:37 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> Include exynos5-cpu-thermal.dtsi to enable thermal_zone support.

I am a little confused because you named this file as
exynos5-cpu-thermal, meaning it is common for all Exynos5 boards. But:
1. It references some specific phandles like &fan0 (cooling-device =
<&fan0 2 3>).
2. You include it only here.

So the question: is "exynos5-cpu-thermal.dtsi" a generic thermal DTSI?
What is your intention?

Lukasz, you acked the patchset, is it fine?

Best regards,
Krzysztof

Re: [PATCHv5 1/5] ARM: dts: exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board

[Anand Moon]

Hi Krzysztof,

Will make the changes.

Thanks for the review.

-Anand Moon

On 13 May 2015 at 12:41, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>> Add pwm-fan node to the Odroid-XU3 board.
>>
>> Tested-by: Markus Reichl <m.reichl-SRyzfwRm/0rPTwkrwQOX7A@public.gmane.org>
>> Acked-by: Lukasz Majewski <l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>> Signed-off-by: Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Please fix the title of commit (missing colon, duplicated name of board) to:
> "ARM: dts: exynos5422-odroidxu3: Add pwm-fan node"
>
> Rest looks good:
> Acked-by: Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>
> Best regards,
> Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHv5 1/5] ARM: dts: exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board

[Anand Moon]

Hi Krzysztof,

Will make the changes.

Thanks for the review.

-Anand Moon

On 13 May 2015 at 12:41, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> Add pwm-fan node to the Odroid-XU3 board.
>>
>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>
> Please fix the title of commit (missing colon, duplicated name of board) to:
> "ARM: dts: exynos5422-odroidxu3: Add pwm-fan node"
>
> Rest looks good:
> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
>
> Best regards,
> Krzysztof

Re: [PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0

[Anand Moon]

Hi Krzysztof,

You are correct.

#cooling-cells property are required by the thermal-zone.

http://lxr.free-electrons.com/source/drivers/thermal/of-thermal.c#L607

So I picked this values from earlier series of CPU frequency by Thomas.

Hope this explains the changes. I will update the commit log.

-Anand Moon

On 13 May 2015 at 13:01, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> update the cooling level for cpu0 to avoid following message.
>
> Capitalize sentence.
> In commit subject add missing colon after "exynos5420".
>
>>
>> root@odroidxu3:~# dmesg | grep ther
>
> This command not needed, we all know how to use dmesg and grep.
>
>> [    0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0:
>>                          could not get #cooling-cells for /cpus/cpu@0
>>
>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>> ---
>>  arch/arm/boot/dts/exynos5420.dtsi | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>> index 4531753..c75ed16 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -61,6 +61,10 @@
>>                         reg = <0x0>;
>>                         clock-frequency = <1800000000>;
>>                         cci-control-port = <&cci_control1>;
>> +
>> +                       cooling-min-level = <10>;
>> +                       cooling-max-level = <7>;
>> +                       #cooling-cells = <2>; /* min followed by max */
>
> I might be missing something but I do not understand which cooling
> levels are referenced here. In my exynos5420.dtsi file there are no
> frequencies for cpu0 node. Could you help me understand this?
>
> Best regards,
> Krzysztof

[PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0

[Anand Moon]

Hi Krzysztof,

You are correct.

#cooling-cells property are required by the thermal-zone.

http://lxr.free-electrons.com/source/drivers/thermal/of-thermal.c#L607

So I picked this values from earlier series of CPU frequency by Thomas.

Hope this explains the changes. I will update the commit log.

-Anand Moon

On 13 May 2015 at 13:01, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> update the cooling level for cpu0 to avoid following message.
>
> Capitalize sentence.
> In commit subject add missing colon after "exynos5420".
>
>>
>> root at odroidxu3:~# dmesg | grep ther
>
> This command not needed, we all know how to use dmesg and grep.
>
>> [    0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0:
>>                          could not get #cooling-cells for /cpus/cpu at 0
>>
>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>> ---
>>  arch/arm/boot/dts/exynos5420.dtsi | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>> index 4531753..c75ed16 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -61,6 +61,10 @@
>>                         reg = <0x0>;
>>                         clock-frequency = <1800000000>;
>>                         cci-control-port = <&cci_control1>;
>> +
>> +                       cooling-min-level = <10>;
>> +                       cooling-max-level = <7>;
>> +                       #cooling-cells = <2>; /* min followed by max */
>
> I might be missing something but I do not understand which cooling
> levels are referenced here. In my exynos5420.dtsi file there are no
> frequencies for cpu0 node. Could you help me understand this?
>
> Best regards,
> Krzysztof

Re: [PATCHv5 3/5] ARM: dts: define default thermal-zones for exynos5422

[Krzysztof Kozlowski]

2015-05-13 16:23 GMT+09:00 Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>:
> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>> Trip points corresponding to the one defined in the exynos_tmu_data.c
>> for Exynos5 have been included.
>> This thermal-zones attribute is afterwards reused for Exynos5422.
>>
>> Tested-by: Markus Reichl <m.reichl-SRyzfwRm/0rPTwkrwQOX7A@public.gmane.org>
>> Acked-by: Lukasz Majewski <l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>

I cannot find email with Lukasz's acked-by. Could you point me to it?

Lukasz, is the file OK?

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHv5 3/5] ARM: dts: define default thermal-zones for exynos5422

[Krzysztof Kozlowski]

2015-05-13 16:23 GMT+09:00 Krzysztof Kozlowski <k.kozlowski@samsung.com>:
> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> Trip points corresponding to the one defined in the exynos_tmu_data.c
>> for Exynos5 have been included.
>> This thermal-zones attribute is afterwards reused for Exynos5422.
>>
>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>

I cannot find email with Lukasz's acked-by. Could you point me to it?

Lukasz, is the file OK?

Best regards,
Krzysztof

Re: [PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0

[Krzysztof Kozlowski]

2015-05-13 16:58 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> Hi Krzysztof,
>
> You are correct.
>
> #cooling-cells property are required by the thermal-zone.
>
> http://lxr.free-electrons.com/source/drivers/thermal/of-thermal.c#L607
>
> So I picked this values from earlier series of CPU frequency by Thomas.
>
> Hope this explains the changes. I will update the commit log.

I still don't get it. I do not ask about cooling-cells but levels.

>>> +
>>> +                       cooling-min-level = <10>;
>>> +                       cooling-max-level = <7>;
>>> +                       #cooling-cells = <2>; /* min followed by max */

Which cooling levels are referenced here? Where are they defined?

Please, don't top-post.

Krzysztof

[PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0

[Krzysztof Kozlowski]

2015-05-13 16:58 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> Hi Krzysztof,
>
> You are correct.
>
> #cooling-cells property are required by the thermal-zone.
>
> http://lxr.free-electrons.com/source/drivers/thermal/of-thermal.c#L607
>
> So I picked this values from earlier series of CPU frequency by Thomas.
>
> Hope this explains the changes. I will update the commit log.

I still don't get it. I do not ask about cooling-cells but levels.

>>> +
>>> +                       cooling-min-level = <10>;
>>> +                       cooling-max-level = <7>;
>>> +                       #cooling-cells = <2>; /* min followed by max */

Which cooling levels are referenced here? Where are they defined?

Please, don't top-post.

Krzysztof

Re: [PATCHv5 1/5] ARM: dts: exynos5422-odroidxu3 Add pwm-fan node tothe Odroid-XU3 board

[Kukjin Kim]

On 05/13/15 16:11, Krzysztof Kozlowski wrote:
> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> Add pwm-fan node to the Odroid-XU3 board.
>>
>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> 
> Please fix the title of commit (missing colon, duplicated name of board) to:
> "ARM: dts: exynos5422-odroidxu3: Add pwm-fan node"
> 
Well, I'd preferred to use the following format:
"ARM: dts: add pwm-fan node for exynos5422-odroidxu3"

But I can change it when I apply it ;-)

> Rest looks good:
> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
Thanks,
Kukjin

[PATCHv5 1/5] ARM: dts: exynos5422-odroidxu3 Add pwm-fan node tothe Odroid-XU3 board

[Kukjin Kim]

On 05/13/15 16:11, Krzysztof Kozlowski wrote:
> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> Add pwm-fan node to the Odroid-XU3 board.
>>
>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> 
> Please fix the title of commit (missing colon, duplicated name of board) to:
> "ARM: dts: exynos5422-odroidxu3: Add pwm-fan node"
> 
Well, I'd preferred to use the following format:
"ARM: dts: add pwm-fan node for exynos5422-odroidxu3"

But I can change it when I apply it ;-)

> Rest looks good:
> Acked-by: Krzysztof Kozlowski <k.kozlowski@samsung.com>
> 
Thanks,
Kukjin

Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>> device.
>>
>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>> ---
>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>  1 file changed, 25 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> index 9446e28..cd78816 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> @@ -319,6 +319,31 @@
>>                 #cooling-cells = <2>;
>>                 cooling-levels = <0 130 170 230>;
>>         };
>> +
>> +       tmu@10060000 {
>
> Here and for other overrides please use label notation, like:
>
> &tmu_cpu0 {
>               ...
> };
>
>> +               vtmu-supply = <&ldo10_reg>;
>
> I am curious, how did you find that LDO10 supplies TMU unit?
>
> Best regards,
> Krzysztof

Hi Krzysztof,

I have re-base my work on earlier Lukasz Majewski patches.

https://patchwork.kernel.org/patch/5693201/

-Anand Moon

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>> device.
>>
>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>> ---
>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>  1 file changed, 25 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> index 9446e28..cd78816 100644
>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> @@ -319,6 +319,31 @@
>>                 #cooling-cells = <2>;
>>                 cooling-levels = <0 130 170 230>;
>>         };
>> +
>> +       tmu at 10060000 {
>
> Here and for other overrides please use label notation, like:
>
> &tmu_cpu0 {
>               ...
> };
>
>> +               vtmu-supply = <&ldo10_reg>;
>
> I am curious, how did you find that LDO10 supplies TMU unit?
>
> Best regards,
> Krzysztof

Hi Krzysztof,

I have re-base my work on earlier Lukasz Majewski patches.

https://patchwork.kernel.org/patch/5693201/

-Anand Moon

Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Krzysztof Kozlowski]

2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>> device.
>>>
>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>> ---
>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>>  1 file changed, 25 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>> index 9446e28..cd78816 100644
>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>> @@ -319,6 +319,31 @@
>>>                 #cooling-cells = <2>;
>>>                 cooling-levels = <0 130 170 230>;
>>>         };
>>> +
>>> +       tmu@10060000 {
>>
>> Here and for other overrides please use label notation, like:
>>
>> &tmu_cpu0 {
>>               ...
>> };
>>
>>> +               vtmu-supply = <&ldo10_reg>;
>>
>> I am curious, how did you find that LDO10 supplies TMU unit?
>>
>> Best regards,
>> Krzysztof
>
> Hi Krzysztof,
>
> I have re-base my work on earlier Lukasz Majewski patches.
>
> https://patchwork.kernel.org/patch/5693201/

NAK.
I am sorry, but this is not sufficient explanation. Actually such
explanation could mean that you did just blindly copied everything
instead of developing it.

You cannot use some regulator here just because some Exynos4 boards
use it. You have to be sure that this regulator supplies this part of
SoC or device.

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Krzysztof Kozlowski]

2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>> device.
>>>
>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>> ---
>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>>  1 file changed, 25 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>> index 9446e28..cd78816 100644
>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>> @@ -319,6 +319,31 @@
>>>                 #cooling-cells = <2>;
>>>                 cooling-levels = <0 130 170 230>;
>>>         };
>>> +
>>> +       tmu at 10060000 {
>>
>> Here and for other overrides please use label notation, like:
>>
>> &tmu_cpu0 {
>>               ...
>> };
>>
>>> +               vtmu-supply = <&ldo10_reg>;
>>
>> I am curious, how did you find that LDO10 supplies TMU unit?
>>
>> Best regards,
>> Krzysztof
>
> Hi Krzysztof,
>
> I have re-base my work on earlier Lukasz Majewski patches.
>
> https://patchwork.kernel.org/patch/5693201/

NAK.
I am sorry, but this is not sufficient explanation. Actually such
explanation could mean that you did just blindly copied everything
instead of developing it.

You cannot use some regulator here just because some Exynos4 boards
use it. You have to be sure that this regulator supplies this part of
SoC or device.

Re: [PATCHv5 5/5] ARM: dts: Enable thermal_zone for exynos5422-odroidxu3

[Anand Moon]

On 13 May 2015 at 13:10, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 15:37 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> Include exynos5-cpu-thermal.dtsi to enable thermal_zone support.
>
> I am a little confused because you named this file as
> exynos5-cpu-thermal, meaning it is common for all Exynos5 boards. But:
> 1. It references some specific phandles like &fan0 (cooling-device =
> <&fan0 2 3>).
> 2. You include it only here.
>
> So the question: is "exynos5-cpu-thermal.dtsi" a generic thermal DTSI?
> What is your intention?
>
> Lukasz, you acked the patchset, is it fine?
>
> Best regards,
> Krzysztof

Hi Krysxtof,

This file almost similar to below patch

https://patchwork.kernel.org/patch/5693321/

I had to create this new file as I was not able to register
#thermal-sensors to tmu_cpu0.

+       thermal-zones {
+               cpu0_thermal: cpu0-thermal {
+                       thermal-sensors = <&tmu_cpu0 0>;
+                       polling-delay-passive = <0>;
+                       polling-delay = <0>;

Earlier the DTS sensor's were not getting registers to the tmu_cpu0 sensors.

I am not aware If this file will be common to Exynos5 series.
I could not include any common dts file as I would through me
compilation error hence .dtsi  extension,

-Anand Moon

[PATCHv5 5/5] ARM: dts: Enable thermal_zone for exynos5422-odroidxu3

[Anand Moon]

On 13 May 2015 at 13:10, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 15:37 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> Include exynos5-cpu-thermal.dtsi to enable thermal_zone support.
>
> I am a little confused because you named this file as
> exynos5-cpu-thermal, meaning it is common for all Exynos5 boards. But:
> 1. It references some specific phandles like &fan0 (cooling-device =
> <&fan0 2 3>).
> 2. You include it only here.
>
> So the question: is "exynos5-cpu-thermal.dtsi" a generic thermal DTSI?
> What is your intention?
>
> Lukasz, you acked the patchset, is it fine?
>
> Best regards,
> Krzysztof

Hi Krysxtof,

This file almost similar to below patch

https://patchwork.kernel.org/patch/5693321/

I had to create this new file as I was not able to register
#thermal-sensors to tmu_cpu0.

+       thermal-zones {
+               cpu0_thermal: cpu0-thermal {
+                       thermal-sensors = <&tmu_cpu0 0>;
+                       polling-delay-passive = <0>;
+                       polling-delay = <0>;

Earlier the DTS sensor's were not getting registers to the tmu_cpu0 sensors.

I am not aware If this file will be common to Exynos5 series.
I could not include any common dts file as I would through me
compilation error hence .dtsi  extension,

-Anand Moon

Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>> On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>> device.
>>>>
>>>> Tested-by: Markus Reichl <m.reichl-SRyzfwRm/0rPTwkrwQOX7A@public.gmane.org>
>>>> Acked-by: Lukasz Majewski <l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>>>> Signed-off-by: Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>>> ---
>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>>>  1 file changed, 25 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>> index 9446e28..cd78816 100644
>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>> @@ -319,6 +319,31 @@
>>>>                 #cooling-cells = <2>;
>>>>                 cooling-levels = <0 130 170 230>;
>>>>         };
>>>> +
>>>> +       tmu@10060000 {
>>>
>>> Here and for other overrides please use label notation, like:
>>>
>>> &tmu_cpu0 {
>>>               ...
>>> };
>>>
>>>> +               vtmu-supply = <&ldo10_reg>;
>>>
>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>
>>> Best regards,
>>> Krzysztof
>>
>> Hi Krzysztof,
>>
>> I have re-base my work on earlier Lukasz Majewski patches.
>>
>> https://patchwork.kernel.org/patch/5693201/
>
> NAK.
> I am sorry, but this is not sufficient explanation. Actually such
> explanation could mean that you did just blindly copied everything
> instead of developing it.
>
> You cannot use some regulator here just because some Exynos4 boards
> use it. You have to be sure that this regulator supplies this part of
> SoC or device.

Hi Krzysztof,

Ok as if now I don't clearly know how I works. But I will study the
regulators and update it.

Lukasz Majewski could you help me out on how it suppose to be,

-Anand Moon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>> device.
>>>>
>>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>>> ---
>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>>>  1 file changed, 25 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>> index 9446e28..cd78816 100644
>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>> @@ -319,6 +319,31 @@
>>>>                 #cooling-cells = <2>;
>>>>                 cooling-levels = <0 130 170 230>;
>>>>         };
>>>> +
>>>> +       tmu at 10060000 {
>>>
>>> Here and for other overrides please use label notation, like:
>>>
>>> &tmu_cpu0 {
>>>               ...
>>> };
>>>
>>>> +               vtmu-supply = <&ldo10_reg>;
>>>
>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>
>>> Best regards,
>>> Krzysztof
>>
>> Hi Krzysztof,
>>
>> I have re-base my work on earlier Lukasz Majewski patches.
>>
>> https://patchwork.kernel.org/patch/5693201/
>
> NAK.
> I am sorry, but this is not sufficient explanation. Actually such
> explanation could mean that you did just blindly copied everything
> instead of developing it.
>
> You cannot use some regulator here just because some Exynos4 boards
> use it. You have to be sure that this regulator supplies this part of
> SoC or device.

Hi Krzysztof,

Ok as if now I don't clearly know how I works. But I will study the
regulators and update it.

Lukasz Majewski could you help me out on how it suppose to be,

-Anand Moon

Re: [PATCHv5 5/5] ARM: dts: Enable thermal_zone for exynos5422-odroidxu3

[Krzysztof Kozlowski]

2015-05-13 17:39 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> On 13 May 2015 at 13:10, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>> 2015-05-13 15:37 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>> Include exynos5-cpu-thermal.dtsi to enable thermal_zone support.
>>
>> I am a little confused because you named this file as
>> exynos5-cpu-thermal, meaning it is common for all Exynos5 boards. But:
>> 1. It references some specific phandles like &fan0 (cooling-device =
>> <&fan0 2 3>).
>> 2. You include it only here.
>>
>> So the question: is "exynos5-cpu-thermal.dtsi" a generic thermal DTSI?
>> What is your intention?
>>
>> Lukasz, you acked the patchset, is it fine?
>>
>> Best regards,
>> Krzysztof
>
> Hi Krysxtof,
>
> This file almost similar to below patch
>
> https://patchwork.kernel.org/patch/5693321/

It is similar but it has major difference: it references external (to
the file) phandle: fan0.

> I had to create this new file as I was not able to register
> #thermal-sensors to tmu_cpu0.
>
> +       thermal-zones {
> +               cpu0_thermal: cpu0-thermal {
> +                       thermal-sensors = <&tmu_cpu0 0>;
> +                       polling-delay-passive = <0>;
> +                       polling-delay = <0>;
>
> Earlier the DTS sensor's were not getting registers to the tmu_cpu0 sensors.
>
> I am not aware If this file will be common to Exynos5 series.
> I could not include any common dts file as I would through me
> compilation error hence .dtsi  extension,

So this looks exynos5420-odroidxu3 specific.

Łukasz, does this design looks good to you? You acked this but:
1. I cannot find your ack for patch 3/5.
2. I have doubts. :)

Best regards,
Krzysztof

[PATCHv5 5/5] ARM: dts: Enable thermal_zone for exynos5422-odroidxu3

[Krzysztof Kozlowski]

2015-05-13 17:39 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> On 13 May 2015 at 13:10, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>> 2015-05-13 15:37 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>> Include exynos5-cpu-thermal.dtsi to enable thermal_zone support.
>>
>> I am a little confused because you named this file as
>> exynos5-cpu-thermal, meaning it is common for all Exynos5 boards. But:
>> 1. It references some specific phandles like &fan0 (cooling-device =
>> <&fan0 2 3>).
>> 2. You include it only here.
>>
>> So the question: is "exynos5-cpu-thermal.dtsi" a generic thermal DTSI?
>> What is your intention?
>>
>> Lukasz, you acked the patchset, is it fine?
>>
>> Best regards,
>> Krzysztof
>
> Hi Krysxtof,
>
> This file almost similar to below patch
>
> https://patchwork.kernel.org/patch/5693321/

It is similar but it has major difference: it references external (to
the file) phandle: fan0.

> I had to create this new file as I was not able to register
> #thermal-sensors to tmu_cpu0.
>
> +       thermal-zones {
> +               cpu0_thermal: cpu0-thermal {
> +                       thermal-sensors = <&tmu_cpu0 0>;
> +                       polling-delay-passive = <0>;
> +                       polling-delay = <0>;
>
> Earlier the DTS sensor's were not getting registers to the tmu_cpu0 sensors.
>
> I am not aware If this file will be common to Exynos5 series.
> I could not include any common dts file as I would through me
> compilation error hence .dtsi  extension,

So this looks exynos5420-odroidxu3 specific.

?ukasz, does this design looks good to you? You acked this but:
1. I cannot find your ack for patch 3/5.
2. I have doubts. :)

Best regards,
Krzysztof

Re: [PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0

[Anand Moon]

On 13 May 2015 at 13:01, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> update the cooling level for cpu0 to avoid following message.
>
> Capitalize sentence.
> In commit subject add missing colon after "exynos5420".
>
>>
>> root@odroidxu3:~# dmesg | grep ther
>
> This command not needed, we all know how to use dmesg and grep.
>
>> [    0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0:
>>                          could not get #cooling-cells for /cpus/cpu@0
>>
>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>> ---
>>  arch/arm/boot/dts/exynos5420.dtsi | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>> index 4531753..c75ed16 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -61,6 +61,10 @@
>>                         reg = <0x0>;
>>                         clock-frequency = <1800000000>;
>>                         cci-control-port = <&cci_control1>;
>> +
>> +                       cooling-min-level = <10>;
>> +                       cooling-max-level = <7>;
>> +                       #cooling-cells = <2>; /* min followed by max */
>
> I might be missing something but I do not understand which cooling
> levels are referenced here. In my exynos5420.dtsi file there are no
> frequencies for cpu0 node. Could you help me understand this?
>
> Best regards,
> Krzysztof

Hi Krzysztof,

http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt
http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/thermal/thermal.txt#L201

These two documents provide the description on cooling-min-level and
cooling-max-level.

I will correctly update the value in the next updated patch.

-Anand Moon

[PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0

[Anand Moon]

On 13 May 2015 at 13:01, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> update the cooling level for cpu0 to avoid following message.
>
> Capitalize sentence.
> In commit subject add missing colon after "exynos5420".
>
>>
>> root at odroidxu3:~# dmesg | grep ther
>
> This command not needed, we all know how to use dmesg and grep.
>
>> [    0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0:
>>                          could not get #cooling-cells for /cpus/cpu at 0
>>
>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>> ---
>>  arch/arm/boot/dts/exynos5420.dtsi | 4 ++++
>>  1 file changed, 4 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>> index 4531753..c75ed16 100644
>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>> @@ -61,6 +61,10 @@
>>                         reg = <0x0>;
>>                         clock-frequency = <1800000000>;
>>                         cci-control-port = <&cci_control1>;
>> +
>> +                       cooling-min-level = <10>;
>> +                       cooling-max-level = <7>;
>> +                       #cooling-cells = <2>; /* min followed by max */
>
> I might be missing something but I do not understand which cooling
> levels are referenced here. In my exynos5420.dtsi file there are no
> frequencies for cpu0 node. Could you help me understand this?
>
> Best regards,
> Krzysztof

Hi Krzysztof,

http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt
http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/thermal/thermal.txt#L201

These two documents provide the description on cooling-min-level and
cooling-max-level.

I will correctly update the value in the next updated patch.

-Anand Moon

Re: [PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0

[Krzysztof Kozlowski]

2015-05-13 19:07 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
> On 13 May 2015 at 13:01, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>>> update the cooling level for cpu0 to avoid following message.
>>
>> Capitalize sentence.
>> In commit subject add missing colon after "exynos5420".
>>
>>>
>>> root@odroidxu3:~# dmesg | grep ther
>>
>> This command not needed, we all know how to use dmesg and grep.
>>
>>> [    0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0:
>>>                          could not get #cooling-cells for /cpus/cpu@0
>>>
>>> Tested-by: Markus Reichl <m.reichl-SRyzfwRm/0rPTwkrwQOX7A@public.gmane.org>
>>> Acked-by: Lukasz Majewski <l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>>> Signed-off-by: Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>> ---
>>>  arch/arm/boot/dts/exynos5420.dtsi | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>>> index 4531753..c75ed16 100644
>>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>>> @@ -61,6 +61,10 @@
>>>                         reg = <0x0>;
>>>                         clock-frequency = <1800000000>;
>>>                         cci-control-port = <&cci_control1>;
>>> +
>>> +                       cooling-min-level = <10>;
>>> +                       cooling-max-level = <7>;
>>> +                       #cooling-cells = <2>; /* min followed by max */
>>
>> I might be missing something but I do not understand which cooling
>> levels are referenced here. In my exynos5420.dtsi file there are no
>> frequencies for cpu0 node. Could you help me understand this?
>>
>> Best regards,
>> Krzysztof
>
> Hi Krzysztof,
>
> http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt
> http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/thermal/thermal.txt#L201
>
> These two documents provide the description on cooling-min-level and
> cooling-max-level.
>
> I will correctly update the value in the next updated patch.

I know these files and AFAIU your does not follow the documentation.
So this is why I am asking: you are referencing cooling level 7 and
10, please show where are these cooling levels defined.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0

[Krzysztof Kozlowski]

2015-05-13 19:07 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> On 13 May 2015 at 13:01, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>> update the cooling level for cpu0 to avoid following message.
>>
>> Capitalize sentence.
>> In commit subject add missing colon after "exynos5420".
>>
>>>
>>> root at odroidxu3:~# dmesg | grep ther
>>
>> This command not needed, we all know how to use dmesg and grep.
>>
>>> [    0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0:
>>>                          could not get #cooling-cells for /cpus/cpu at 0
>>>
>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>> ---
>>>  arch/arm/boot/dts/exynos5420.dtsi | 4 ++++
>>>  1 file changed, 4 insertions(+)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>>> index 4531753..c75ed16 100644
>>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>>> @@ -61,6 +61,10 @@
>>>                         reg = <0x0>;
>>>                         clock-frequency = <1800000000>;
>>>                         cci-control-port = <&cci_control1>;
>>> +
>>> +                       cooling-min-level = <10>;
>>> +                       cooling-max-level = <7>;
>>> +                       #cooling-cells = <2>; /* min followed by max */
>>
>> I might be missing something but I do not understand which cooling
>> levels are referenced here. In my exynos5420.dtsi file there are no
>> frequencies for cpu0 node. Could you help me understand this?
>>
>> Best regards,
>> Krzysztof
>
> Hi Krzysztof,
>
> http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt
> http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/thermal/thermal.txt#L201
>
> These two documents provide the description on cooling-min-level and
> cooling-max-level.
>
> I will correctly update the value in the next updated patch.

I know these files and AFAIU your does not follow the documentation.
So this is why I am asking: you are referencing cooling level 7 and
10, please show where are these cooling levels defined.

Re: [PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0

[Anand Moon]

Hi Krzysztof,

Yep these values are wrong.

These cooling-max-level and cooling-min-level values come with cpufreq
operating-points
Which is not present in the dts right now.

So I will update for now with this value.
cooling-min-level = <0>;
cooling-max-level = <7>;

-Anand Moon

On 13 May 2015 at 15:42, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 19:07 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> On 13 May 2015 at 13:01, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>> update the cooling level for cpu0 to avoid following message.
>>>
>>> Capitalize sentence.
>>> In commit subject add missing colon after "exynos5420".
>>>
>>>>
>>>> root@odroidxu3:~# dmesg | grep ther
>>>
>>> This command not needed, we all know how to use dmesg and grep.
>>>
>>>> [    0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0:
>>>>                          could not get #cooling-cells for /cpus/cpu@0
>>>>
>>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>>> ---
>>>>  arch/arm/boot/dts/exynos5420.dtsi | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>>>> index 4531753..c75ed16 100644
>>>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>>>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>>>> @@ -61,6 +61,10 @@
>>>>                         reg = <0x0>;
>>>>                         clock-frequency = <1800000000>;
>>>>                         cci-control-port = <&cci_control1>;
>>>> +
>>>> +                       cooling-min-level = <10>;
>>>> +                       cooling-max-level = <7>;
>>>> +                       #cooling-cells = <2>; /* min followed by max */
>>>
>>> I might be missing something but I do not understand which cooling
>>> levels are referenced here. In my exynos5420.dtsi file there are no
>>> frequencies for cpu0 node. Could you help me understand this?
>>>
>>> Best regards,
>>> Krzysztof
>>
>> Hi Krzysztof,
>>
>> http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt
>> http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/thermal/thermal.txt#L201
>>
>> These two documents provide the description on cooling-min-level and
>> cooling-max-level.
>>
>> I will correctly update the value in the next updated patch.
>
> I know these files and AFAIU your does not follow the documentation.
> So this is why I am asking: you are referencing cooling level 7 and
> 10, please show where are these cooling levels defined.

[PATCHv5 4/5] ARM: dts: exynos5420 update the cooling cells for core cpu0

[Anand Moon]

Hi Krzysztof,

Yep these values are wrong.

These cooling-max-level and cooling-min-level values come with cpufreq
operating-points
Which is not present in the dts right now.

So I will update for now with this value.
cooling-min-level = <0>;
cooling-max-level = <7>;

-Anand Moon

On 13 May 2015 at 15:42, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 19:07 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> On 13 May 2015 at 13:01, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>> update the cooling level for cpu0 to avoid following message.
>>>
>>> Capitalize sentence.
>>> In commit subject add missing colon after "exynos5420".
>>>
>>>>
>>>> root at odroidxu3:~# dmesg | grep ther
>>>
>>> This command not needed, we all know how to use dmesg and grep.
>>>
>>>> [    0.241511] /thermal-zones/cpu-thermal/cooling-maps/map0:
>>>>                          could not get #cooling-cells for /cpus/cpu at 0
>>>>
>>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>>> ---
>>>>  arch/arm/boot/dts/exynos5420.dtsi | 4 ++++
>>>>  1 file changed, 4 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi
>>>> index 4531753..c75ed16 100644
>>>> --- a/arch/arm/boot/dts/exynos5420.dtsi
>>>> +++ b/arch/arm/boot/dts/exynos5420.dtsi
>>>> @@ -61,6 +61,10 @@
>>>>                         reg = <0x0>;
>>>>                         clock-frequency = <1800000000>;
>>>>                         cci-control-port = <&cci_control1>;
>>>> +
>>>> +                       cooling-min-level = <10>;
>>>> +                       cooling-max-level = <7>;
>>>> +                       #cooling-cells = <2>; /* min followed by max */
>>>
>>> I might be missing something but I do not understand which cooling
>>> levels are referenced here. In my exynos5420.dtsi file there are no
>>> frequencies for cpu0 node. Could you help me understand this?
>>>
>>> Best regards,
>>> Krzysztof
>>
>> Hi Krzysztof,
>>
>> http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/cpufreq/cpufreq-dt.txt
>> http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/thermal/thermal.txt#L201
>>
>> These two documents provide the description on cooling-min-level and
>> cooling-max-level.
>>
>> I will correctly update the value in the next updated patch.
>
> I know these files and AFAIU your does not follow the documentation.
> So this is why I am asking: you are referencing cooling level 7 and
> 10, please show where are these cooling levels defined.

Re: [PATCHv5 3/5] ARM: dts: define default thermal-zones for exynos5422

[Lukasz Majewski]

Hi Krzysztof,

> 2015-05-13 16:23 GMT+09:00 Krzysztof Kozlowski
> <k.kozlowski@samsung.com>:
> > 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> >> Trip points corresponding to the one defined in the
> >> exynos_tmu_data.c for Exynos5 have been included.
> >> This thermal-zones attribute is afterwards reused for Exynos5422.
> >>
> >> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
> >> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> 
> I cannot find email with Lukasz's acked-by. Could you point me to it?
> 
> Lukasz, is the file OK?

Yes, it is OK.

> 
> Best regards,
> Krzysztof



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

[PATCHv5 3/5] ARM: dts: define default thermal-zones for exynos5422

[Lukasz Majewski]

Hi Krzysztof,

> 2015-05-13 16:23 GMT+09:00 Krzysztof Kozlowski
> <k.kozlowski@samsung.com>:
> > 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> >> Trip points corresponding to the one defined in the
> >> exynos_tmu_data.c for Exynos5 have been included.
> >> This thermal-zones attribute is afterwards reused for Exynos5422.
> >>
> >> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
> >> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
> 
> I cannot find email with Lukasz's acked-by. Could you point me to it?
> 
> Lukasz, is the file OK?

Yes, it is OK.

> 
> Best regards,
> Krzysztof



-- 
Best regards,

Lukasz Majewski

Samsung R&D Institute Poland (SRPOL) | Linux Platform Group

Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>> On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>> device.
>>>>
>>>> Tested-by: Markus Reichl <m.reichl-SRyzfwRm/0rPTwkrwQOX7A@public.gmane.org>
>>>> Acked-by: Lukasz Majewski <l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>>>> Signed-off-by: Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>>> ---
>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>>>  1 file changed, 25 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>> index 9446e28..cd78816 100644
>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>> @@ -319,6 +319,31 @@
>>>>                 #cooling-cells = <2>;
>>>>                 cooling-levels = <0 130 170 230>;
>>>>         };
>>>> +
>>>> +       tmu@10060000 {
>>>
>>> Here and for other overrides please use label notation, like:
>>>
>>> &tmu_cpu0 {
>>>               ...
>>> };
>>>
>>>> +               vtmu-supply = <&ldo10_reg>;
>>>
>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>
>>> Best regards,
>>> Krzysztof
>>
>> Hi Krzysztof,
>>
>> I have re-base my work on earlier Lukasz Majewski patches.
>>
>> https://patchwork.kernel.org/patch/5693201/
>
> NAK.
> I am sorry, but this is not sufficient explanation. Actually such
> explanation could mean that you did just blindly copied everything
> instead of developing it.
>
> You cannot use some regulator here just because some Exynos4 boards
> use it. You have to be sure that this regulator supplies this part of
> SoC or device.

Hi Krzysztof,

After going through the schematics, I came to understanding that their is
missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.

Below is the schematic of the board.

http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF

  ldo18_reg: LDO18 {
                                         regulator-name = "vdd_ldo18";
                                         regulator-min-microvolt = <1800000>;
                                         regulator-max-microvolt = <1800000>;
                                         regulator-always-on;
                               };

Please share your thought on this.

-Anand Moon
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>> device.
>>>>
>>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>>> ---
>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>>>  1 file changed, 25 insertions(+)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>> index 9446e28..cd78816 100644
>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>> @@ -319,6 +319,31 @@
>>>>                 #cooling-cells = <2>;
>>>>                 cooling-levels = <0 130 170 230>;
>>>>         };
>>>> +
>>>> +       tmu at 10060000 {
>>>
>>> Here and for other overrides please use label notation, like:
>>>
>>> &tmu_cpu0 {
>>>               ...
>>> };
>>>
>>>> +               vtmu-supply = <&ldo10_reg>;
>>>
>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>
>>> Best regards,
>>> Krzysztof
>>
>> Hi Krzysztof,
>>
>> I have re-base my work on earlier Lukasz Majewski patches.
>>
>> https://patchwork.kernel.org/patch/5693201/
>
> NAK.
> I am sorry, but this is not sufficient explanation. Actually such
> explanation could mean that you did just blindly copied everything
> instead of developing it.
>
> You cannot use some regulator here just because some Exynos4 boards
> use it. You have to be sure that this regulator supplies this part of
> SoC or device.

Hi Krzysztof,

After going through the schematics, I came to understanding that their is
missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.

Below is the schematic of the board.

http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF

  ldo18_reg: LDO18 {
                                         regulator-name = "vdd_ldo18";
                                         regulator-min-microvolt = <1800000>;
                                         regulator-max-microvolt = <1800000>;
                                         regulator-always-on;
                               };

Please share your thought on this.

-Anand Moon

Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Krzysztof Kozlowski]

2015-05-15 1:16 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>> On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>>> device.
>>>>>
>>>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>>>> ---
>>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>>>>  1 file changed, 25 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>> index 9446e28..cd78816 100644
>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>> @@ -319,6 +319,31 @@
>>>>>                 #cooling-cells = <2>;
>>>>>                 cooling-levels = <0 130 170 230>;
>>>>>         };
>>>>> +
>>>>> +       tmu@10060000 {
>>>>
>>>> Here and for other overrides please use label notation, like:
>>>>
>>>> &tmu_cpu0 {
>>>>               ...
>>>> };
>>>>
>>>>> +               vtmu-supply = <&ldo10_reg>;
>>>>
>>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>
>>> Hi Krzysztof,
>>>
>>> I have re-base my work on earlier Lukasz Majewski patches.
>>>
>>> https://patchwork.kernel.org/patch/5693201/
>>
>> NAK.
>> I am sorry, but this is not sufficient explanation. Actually such
>> explanation could mean that you did just blindly copied everything
>> instead of developing it.
>>
>> You cannot use some regulator here just because some Exynos4 boards
>> use it. You have to be sure that this regulator supplies this part of
>> SoC or device.
>
> Hi Krzysztof,
>
> After going through the schematics, I came to understanding that their is
> missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.
>
> Below is the schematic of the board.
>
> http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF
>
>   ldo18_reg: LDO18 {
>                                          regulator-name = "vdd_ldo18";
>                                          regulator-min-microvolt = <1800000>;
>                                          regulator-max-microvolt = <1800000>;
>                                          regulator-always-on;
>                                };

The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU.

I think the schematics are missing some of details but it can be deducted that:
1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5
pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]).
2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of
S2MPS11 PMIC.
3. I confirmed with the Exynos5422 datasheet that these
VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES).

So the LDO7 it is... but before using it there is a caveat. The LDO7
is also connected to VDD of MIPI, HDMI and few more. So when you use
this regulator in TMU it may be turned off by TMU driver (e.g. during
unbind). In such case these other blocks also should be tested and
checked whether they take this regulator and enable it.

Best regards,
Krzysztof

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Krzysztof Kozlowski]

2015-05-15 1:16 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>> On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>>> device.
>>>>>
>>>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>>>> ---
>>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>>>>  1 file changed, 25 insertions(+)
>>>>>
>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>> index 9446e28..cd78816 100644
>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>> @@ -319,6 +319,31 @@
>>>>>                 #cooling-cells = <2>;
>>>>>                 cooling-levels = <0 130 170 230>;
>>>>>         };
>>>>> +
>>>>> +       tmu at 10060000 {
>>>>
>>>> Here and for other overrides please use label notation, like:
>>>>
>>>> &tmu_cpu0 {
>>>>               ...
>>>> };
>>>>
>>>>> +               vtmu-supply = <&ldo10_reg>;
>>>>
>>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>>
>>>> Best regards,
>>>> Krzysztof
>>>
>>> Hi Krzysztof,
>>>
>>> I have re-base my work on earlier Lukasz Majewski patches.
>>>
>>> https://patchwork.kernel.org/patch/5693201/
>>
>> NAK.
>> I am sorry, but this is not sufficient explanation. Actually such
>> explanation could mean that you did just blindly copied everything
>> instead of developing it.
>>
>> You cannot use some regulator here just because some Exynos4 boards
>> use it. You have to be sure that this regulator supplies this part of
>> SoC or device.
>
> Hi Krzysztof,
>
> After going through the schematics, I came to understanding that their is
> missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.
>
> Below is the schematic of the board.
>
> http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF
>
>   ldo18_reg: LDO18 {
>                                          regulator-name = "vdd_ldo18";
>                                          regulator-min-microvolt = <1800000>;
>                                          regulator-max-microvolt = <1800000>;
>                                          regulator-always-on;
>                                };

The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU.

I think the schematics are missing some of details but it can be deducted that:
1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5
pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]).
2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of
S2MPS11 PMIC.
3. I confirmed with the Exynos5422 datasheet that these
VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES).

So the LDO7 it is... but before using it there is a caveat. The LDO7
is also connected to VDD of MIPI, HDMI and few more. So when you use
this regulator in TMU it may be turned off by TMU driver (e.g. during
unbind). In such case these other blocks also should be tested and
checked whether they take this regulator and enable it.

Best regards,
Krzysztof

Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

Hi Krzysztof,

I will verify this and test it.

-Anand Moon

On 15 May 2015 at 05:42, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> 2015-05-15 1:16 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>> On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>>> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>>>> On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>>>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>>>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>>>> device.
>>>>>>
>>>>>> Tested-by: Markus Reichl <m.reichl-SRyzfwRm/0rPTwkrwQOX7A@public.gmane.org>
>>>>>> Acked-by: Lukasz Majewski <l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>>>>>> Signed-off-by: Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>>>>> ---
>>>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>>>>>  1 file changed, 25 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>> index 9446e28..cd78816 100644
>>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>> @@ -319,6 +319,31 @@
>>>>>>                 #cooling-cells = <2>;
>>>>>>                 cooling-levels = <0 130 170 230>;
>>>>>>         };
>>>>>> +
>>>>>> +       tmu@10060000 {
>>>>>
>>>>> Here and for other overrides please use label notation, like:
>>>>>
>>>>> &tmu_cpu0 {
>>>>>               ...
>>>>> };
>>>>>
>>>>>> +               vtmu-supply = <&ldo10_reg>;
>>>>>
>>>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>
>>>> Hi Krzysztof,
>>>>
>>>> I have re-base my work on earlier Lukasz Majewski patches.
>>>>
>>>> https://patchwork.kernel.org/patch/5693201/
>>>
>>> NAK.
>>> I am sorry, but this is not sufficient explanation. Actually such
>>> explanation could mean that you did just blindly copied everything
>>> instead of developing it.
>>>
>>> You cannot use some regulator here just because some Exynos4 boards
>>> use it. You have to be sure that this regulator supplies this part of
>>> SoC or device.
>>
>> Hi Krzysztof,
>>
>> After going through the schematics, I came to understanding that their is
>> missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.
>>
>> Below is the schematic of the board.
>>
>> http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF
>>
>>   ldo18_reg: LDO18 {
>>                                          regulator-name = "vdd_ldo18";
>>                                          regulator-min-microvolt = <1800000>;
>>                                          regulator-max-microvolt = <1800000>;
>>                                          regulator-always-on;
>>                                };
>
> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU.
>
> I think the schematics are missing some of details but it can be deducted that:
> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5
> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]).
> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of
> S2MPS11 PMIC.
> 3. I confirmed with the Exynos5422 datasheet that these
> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES).
>
> So the LDO7 it is... but before using it there is a caveat. The LDO7
> is also connected to VDD of MIPI, HDMI and few more. So when you use
> this regulator in TMU it may be turned off by TMU driver (e.g. during
> unbind). In such case these other blocks also should be tested and
> checked whether they take this regulator and enable it.
>
> Best regards,
> Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

Hi Krzysztof,

I will verify this and test it.

-Anand Moon

On 15 May 2015 at 05:42, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-15 1:16 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>>> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>> On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>>>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>>>> device.
>>>>>>
>>>>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>>>>> ---
>>>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>>>>>  1 file changed, 25 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>> index 9446e28..cd78816 100644
>>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>> @@ -319,6 +319,31 @@
>>>>>>                 #cooling-cells = <2>;
>>>>>>                 cooling-levels = <0 130 170 230>;
>>>>>>         };
>>>>>> +
>>>>>> +       tmu at 10060000 {
>>>>>
>>>>> Here and for other overrides please use label notation, like:
>>>>>
>>>>> &tmu_cpu0 {
>>>>>               ...
>>>>> };
>>>>>
>>>>>> +               vtmu-supply = <&ldo10_reg>;
>>>>>
>>>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>
>>>> Hi Krzysztof,
>>>>
>>>> I have re-base my work on earlier Lukasz Majewski patches.
>>>>
>>>> https://patchwork.kernel.org/patch/5693201/
>>>
>>> NAK.
>>> I am sorry, but this is not sufficient explanation. Actually such
>>> explanation could mean that you did just blindly copied everything
>>> instead of developing it.
>>>
>>> You cannot use some regulator here just because some Exynos4 boards
>>> use it. You have to be sure that this regulator supplies this part of
>>> SoC or device.
>>
>> Hi Krzysztof,
>>
>> After going through the schematics, I came to understanding that their is
>> missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.
>>
>> Below is the schematic of the board.
>>
>> http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF
>>
>>   ldo18_reg: LDO18 {
>>                                          regulator-name = "vdd_ldo18";
>>                                          regulator-min-microvolt = <1800000>;
>>                                          regulator-max-microvolt = <1800000>;
>>                                          regulator-always-on;
>>                                };
>
> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU.
>
> I think the schematics are missing some of details but it can be deducted that:
> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5
> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]).
> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of
> S2MPS11 PMIC.
> 3. I confirmed with the Exynos5422 datasheet that these
> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES).
>
> So the LDO7 it is... but before using it there is a caveat. The LDO7
> is also connected to VDD of MIPI, HDMI and few more. So when you use
> this regulator in TMU it may be turned off by TMU driver (e.g. during
> unbind). In such case these other blocks also should be tested and
> checked whether they take this regulator and enable it.
>
> Best regards,
> Krzysztof

Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

On 15 May 2015 at 05:42, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
> 2015-05-15 1:16 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>> On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>>> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>>>> On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>>>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>>>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>>>> device.
>>>>>>
>>>>>> Tested-by: Markus Reichl <m.reichl-SRyzfwRm/0rPTwkrwQOX7A@public.gmane.org>
>>>>>> Acked-by: Lukasz Majewski <l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>>>>>> Signed-off-by: Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>>>>> ---
>>>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>>>>>  1 file changed, 25 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>> index 9446e28..cd78816 100644
>>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>> @@ -319,6 +319,31 @@
>>>>>>                 #cooling-cells = <2>;
>>>>>>                 cooling-levels = <0 130 170 230>;
>>>>>>         };
>>>>>> +
>>>>>> +       tmu@10060000 {
>>>>>
>>>>> Here and for other overrides please use label notation, like:
>>>>>
>>>>> &tmu_cpu0 {
>>>>>               ...
>>>>> };
>>>>>
>>>>>> +               vtmu-supply = <&ldo10_reg>;
>>>>>
>>>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>
>>>> Hi Krzysztof,
>>>>
>>>> I have re-base my work on earlier Lukasz Majewski patches.
>>>>
>>>> https://patchwork.kernel.org/patch/5693201/
>>>
>>> NAK.
>>> I am sorry, but this is not sufficient explanation. Actually such
>>> explanation could mean that you did just blindly copied everything
>>> instead of developing it.
>>>
>>> You cannot use some regulator here just because some Exynos4 boards
>>> use it. You have to be sure that this regulator supplies this part of
>>> SoC or device.
>>
>> Hi Krzysztof,
>>
>> After going through the schematics, I came to understanding that their is
>> missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.
>>
>> Below is the schematic of the board.
>>
>> http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF
>>
>>   ldo18_reg: LDO18 {
>>                                          regulator-name = "vdd_ldo18";
>>                                          regulator-min-microvolt = <1800000>;
>>                                          regulator-max-microvolt = <1800000>;
>>                                          regulator-always-on;
>>                                };
>
> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU.
>
> I think the schematics are missing some of details but it can be deducted that:
> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5
> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]).
> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of
> S2MPS11 PMIC.
> 3. I confirmed with the Exynos5422 datasheet that these
> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES).
>
> So the LDO7 it is... but before using it there is a caveat. The LDO7
> is also connected to VDD of MIPI, HDMI and few more. So when you use
> this regulator in TMU it may be turned off by TMU driver (e.g. during
> unbind). In such case these other blocks also should be tested and
> checked whether they take this regulator and enable it.

hi Krzysztof,

I tried to use the LDO7 regulator for TMU but it failed to register.

[    3.231329] ina2xx 0-0045: power monitor ina231 (Rshunt = 10000 uOhm)
[    3.237691] thermal thermal_zone0: failed to read out thermal zone (-22)
[    3.243033] exynos-tmu 10060000.tmu: Looking up vtmu-supply from device tree
[    3.243936] thermal thermal_zone1: failed to read out thermal zone (-22)
[    3.249791] exynos-tmu 10064000.tmu: Looking up vtmu-supply from device tree
[    3.250677] thermal thermal_zone2: failed to read out thermal zone (-22)
[    3.256410] exynos-tmu 10068000.tmu: Looking up vtmu-supply from device tree
[    3.257345] thermal thermal_zone3: failed to read out thermal zone (-22)
[    3.263050] exynos-tmu 1006c000.tmu: Looking up vtmu-supply from device tree
[    3.263984] thermal thermal_zone4: failed to read out thermal zone (-22)
[    3.269769] exynos-tmu 100a0000.tmu: Looking up vtmu-supply from device tree
[    3.270363] usb 5-1: New USB device found, idVendor=0424, idProduct=9514
[    3.276389] usb 5-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0

-Anand Moon

>
> Best regards,
> Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

On 15 May 2015 at 05:42, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-15 1:16 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>>> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>> On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>>>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>>>> device.
>>>>>>
>>>>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>>>>> ---
>>>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>>>>>  1 file changed, 25 insertions(+)
>>>>>>
>>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>> index 9446e28..cd78816 100644
>>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>> @@ -319,6 +319,31 @@
>>>>>>                 #cooling-cells = <2>;
>>>>>>                 cooling-levels = <0 130 170 230>;
>>>>>>         };
>>>>>> +
>>>>>> +       tmu at 10060000 {
>>>>>
>>>>> Here and for other overrides please use label notation, like:
>>>>>
>>>>> &tmu_cpu0 {
>>>>>               ...
>>>>> };
>>>>>
>>>>>> +               vtmu-supply = <&ldo10_reg>;
>>>>>
>>>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>>>
>>>>> Best regards,
>>>>> Krzysztof
>>>>
>>>> Hi Krzysztof,
>>>>
>>>> I have re-base my work on earlier Lukasz Majewski patches.
>>>>
>>>> https://patchwork.kernel.org/patch/5693201/
>>>
>>> NAK.
>>> I am sorry, but this is not sufficient explanation. Actually such
>>> explanation could mean that you did just blindly copied everything
>>> instead of developing it.
>>>
>>> You cannot use some regulator here just because some Exynos4 boards
>>> use it. You have to be sure that this regulator supplies this part of
>>> SoC or device.
>>
>> Hi Krzysztof,
>>
>> After going through the schematics, I came to understanding that their is
>> missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.
>>
>> Below is the schematic of the board.
>>
>> http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF
>>
>>   ldo18_reg: LDO18 {
>>                                          regulator-name = "vdd_ldo18";
>>                                          regulator-min-microvolt = <1800000>;
>>                                          regulator-max-microvolt = <1800000>;
>>                                          regulator-always-on;
>>                                };
>
> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU.
>
> I think the schematics are missing some of details but it can be deducted that:
> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5
> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]).
> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of
> S2MPS11 PMIC.
> 3. I confirmed with the Exynos5422 datasheet that these
> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES).
>
> So the LDO7 it is... but before using it there is a caveat. The LDO7
> is also connected to VDD of MIPI, HDMI and few more. So when you use
> this regulator in TMU it may be turned off by TMU driver (e.g. during
> unbind). In such case these other blocks also should be tested and
> checked whether they take this regulator and enable it.

hi Krzysztof,

I tried to use the LDO7 regulator for TMU but it failed to register.

[    3.231329] ina2xx 0-0045: power monitor ina231 (Rshunt = 10000 uOhm)
[    3.237691] thermal thermal_zone0: failed to read out thermal zone (-22)
[    3.243033] exynos-tmu 10060000.tmu: Looking up vtmu-supply from device tree
[    3.243936] thermal thermal_zone1: failed to read out thermal zone (-22)
[    3.249791] exynos-tmu 10064000.tmu: Looking up vtmu-supply from device tree
[    3.250677] thermal thermal_zone2: failed to read out thermal zone (-22)
[    3.256410] exynos-tmu 10068000.tmu: Looking up vtmu-supply from device tree
[    3.257345] thermal thermal_zone3: failed to read out thermal zone (-22)
[    3.263050] exynos-tmu 1006c000.tmu: Looking up vtmu-supply from device tree
[    3.263984] thermal thermal_zone4: failed to read out thermal zone (-22)
[    3.269769] exynos-tmu 100a0000.tmu: Looking up vtmu-supply from device tree
[    3.270363] usb 5-1: New USB device found, idVendor=0424, idProduct=9514
[    3.276389] usb 5-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0

-Anand Moon

>
> Best regards,
> Krzysztof

Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Krzysztof Kozlowski]

2015-05-19 16:28 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
> On 15 May 2015 at 05:42, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>> 2015-05-15 1:16 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>>> On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>>>> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>>>>> On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org> wrote:
>>>>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>:
>>>>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>>>>> device.
>>>>>>>
>>>>>>> Tested-by: Markus Reichl <m.reichl-SRyzfwRm/0rPTwkrwQOX7A@public.gmane.org>
>>>>>>> Acked-by: Lukasz Majewski <l.majewski-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>>>>>>> Signed-off-by: Anand Moon <linux.amoon-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>>>>>>> ---
>>>>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>>>>>>  1 file changed, 25 insertions(+)
>>>>>>>
>>>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>> index 9446e28..cd78816 100644
>>>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>> @@ -319,6 +319,31 @@
>>>>>>>                 #cooling-cells = <2>;
>>>>>>>                 cooling-levels = <0 130 170 230>;
>>>>>>>         };
>>>>>>> +
>>>>>>> +       tmu@10060000 {
>>>>>>
>>>>>> Here and for other overrides please use label notation, like:
>>>>>>
>>>>>> &tmu_cpu0 {
>>>>>>               ...
>>>>>> };
>>>>>>
>>>>>>> +               vtmu-supply = <&ldo10_reg>;
>>>>>>
>>>>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>>>>
>>>>>> Best regards,
>>>>>> Krzysztof
>>>>>
>>>>> Hi Krzysztof,
>>>>>
>>>>> I have re-base my work on earlier Lukasz Majewski patches.
>>>>>
>>>>> https://patchwork.kernel.org/patch/5693201/
>>>>
>>>> NAK.
>>>> I am sorry, but this is not sufficient explanation. Actually such
>>>> explanation could mean that you did just blindly copied everything
>>>> instead of developing it.
>>>>
>>>> You cannot use some regulator here just because some Exynos4 boards
>>>> use it. You have to be sure that this regulator supplies this part of
>>>> SoC or device.
>>>
>>> Hi Krzysztof,
>>>
>>> After going through the schematics, I came to understanding that their is
>>> missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.
>>>
>>> Below is the schematic of the board.
>>>
>>> http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF
>>>
>>>   ldo18_reg: LDO18 {
>>>                                          regulator-name = "vdd_ldo18";
>>>                                          regulator-min-microvolt = <1800000>;
>>>                                          regulator-max-microvolt = <1800000>;
>>>                                          regulator-always-on;
>>>                                };
>>
>> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU.
>>
>> I think the schematics are missing some of details but it can be deducted that:
>> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5
>> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]).
>> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of
>> S2MPS11 PMIC.
>> 3. I confirmed with the Exynos5422 datasheet that these
>> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES).
>>
>> So the LDO7 it is... but before using it there is a caveat. The LDO7
>> is also connected to VDD of MIPI, HDMI and few more. So when you use
>> this regulator in TMU it may be turned off by TMU driver (e.g. during
>> unbind). In such case these other blocks also should be tested and
>> checked whether they take this regulator and enable it.
>
> hi Krzysztof,
>
> I tried to use the LDO7 regulator for TMU but it failed to register.
>
> [    3.231329] ina2xx 0-0045: power monitor ina231 (Rshunt = 10000 uOhm)
> [    3.237691] thermal thermal_zone0: failed to read out thermal zone (-22)
> [    3.243033] exynos-tmu 10060000.tmu: Looking up vtmu-supply from device tree
> [    3.243936] thermal thermal_zone1: failed to read out thermal zone (-22)
> [    3.249791] exynos-tmu 10064000.tmu: Looking up vtmu-supply from device tree
> [    3.250677] thermal thermal_zone2: failed to read out thermal zone (-22)
> [    3.256410] exynos-tmu 10068000.tmu: Looking up vtmu-supply from device tree
> [    3.257345] thermal thermal_zone3: failed to read out thermal zone (-22)
> [    3.263050] exynos-tmu 1006c000.tmu: Looking up vtmu-supply from device tree
> [    3.263984] thermal thermal_zone4: failed to read out thermal zone (-22)
> [    3.269769] exynos-tmu 100a0000.tmu: Looking up vtmu-supply from device tree
> [    3.270363] usb 5-1: New USB device found, idVendor=0424, idProduct=9514
> [    3.276389] usb 5-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0

Indeed.

Best regards,
Krzysztof
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Krzysztof Kozlowski]

2015-05-19 16:28 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> On 15 May 2015 at 05:42, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>> 2015-05-15 1:16 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>> On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>>>> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>> On 13 May 2015 at 12:51, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
>>>>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>>>>> device.
>>>>>>>
>>>>>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>>>>>> ---
>>>>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++
>>>>>>>  1 file changed, 25 insertions(+)
>>>>>>>
>>>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>> index 9446e28..cd78816 100644
>>>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>> @@ -319,6 +319,31 @@
>>>>>>>                 #cooling-cells = <2>;
>>>>>>>                 cooling-levels = <0 130 170 230>;
>>>>>>>         };
>>>>>>> +
>>>>>>> +       tmu at 10060000 {
>>>>>>
>>>>>> Here and for other overrides please use label notation, like:
>>>>>>
>>>>>> &tmu_cpu0 {
>>>>>>               ...
>>>>>> };
>>>>>>
>>>>>>> +               vtmu-supply = <&ldo10_reg>;
>>>>>>
>>>>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>>>>
>>>>>> Best regards,
>>>>>> Krzysztof
>>>>>
>>>>> Hi Krzysztof,
>>>>>
>>>>> I have re-base my work on earlier Lukasz Majewski patches.
>>>>>
>>>>> https://patchwork.kernel.org/patch/5693201/
>>>>
>>>> NAK.
>>>> I am sorry, but this is not sufficient explanation. Actually such
>>>> explanation could mean that you did just blindly copied everything
>>>> instead of developing it.
>>>>
>>>> You cannot use some regulator here just because some Exynos4 boards
>>>> use it. You have to be sure that this regulator supplies this part of
>>>> SoC or device.
>>>
>>> Hi Krzysztof,
>>>
>>> After going through the schematics, I came to understanding that their is
>>> missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.
>>>
>>> Below is the schematic of the board.
>>>
>>> http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF
>>>
>>>   ldo18_reg: LDO18 {
>>>                                          regulator-name = "vdd_ldo18";
>>>                                          regulator-min-microvolt = <1800000>;
>>>                                          regulator-max-microvolt = <1800000>;
>>>                                          regulator-always-on;
>>>                                };
>>
>> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for TMU.
>>
>> I think the schematics are missing some of details but it can be deducted that:
>> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5
>> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]).
>> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to the LDO7 of
>> S2MPS11 PMIC.
>> 3. I confirmed with the Exynos5422 datasheet that these
>> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES).
>>
>> So the LDO7 it is... but before using it there is a caveat. The LDO7
>> is also connected to VDD of MIPI, HDMI and few more. So when you use
>> this regulator in TMU it may be turned off by TMU driver (e.g. during
>> unbind). In such case these other blocks also should be tested and
>> checked whether they take this regulator and enable it.
>
> hi Krzysztof,
>
> I tried to use the LDO7 regulator for TMU but it failed to register.
>
> [    3.231329] ina2xx 0-0045: power monitor ina231 (Rshunt = 10000 uOhm)
> [    3.237691] thermal thermal_zone0: failed to read out thermal zone (-22)
> [    3.243033] exynos-tmu 10060000.tmu: Looking up vtmu-supply from device tree
> [    3.243936] thermal thermal_zone1: failed to read out thermal zone (-22)
> [    3.249791] exynos-tmu 10064000.tmu: Looking up vtmu-supply from device tree
> [    3.250677] thermal thermal_zone2: failed to read out thermal zone (-22)
> [    3.256410] exynos-tmu 10068000.tmu: Looking up vtmu-supply from device tree
> [    3.257345] thermal thermal_zone3: failed to read out thermal zone (-22)
> [    3.263050] exynos-tmu 1006c000.tmu: Looking up vtmu-supply from device tree
> [    3.263984] thermal thermal_zone4: failed to read out thermal zone (-22)
> [    3.269769] exynos-tmu 100a0000.tmu: Looking up vtmu-supply from device tree
> [    3.270363] usb 5-1: New USB device found, idVendor=0424, idProduct=9514
> [    3.276389] usb 5-1: New USB device strings: Mfr=0, Product=0, SerialNumber=0

Indeed.

Best regards,
Krzysztof

Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

On 20 May 2015 at 08:57, Dongjin Kim <tobetter@gmail.com> wrote:
> Hello Kryzsztof,
>
> Are you able to check if TMU is under VDDI power domain from Exynos5422
> datasheet?
> If it is, XU3 use BUCK3 for TMU and more internal blocks.
>
> Thank you,
> Dongjin.
>
> On Tue, May 19, 2015 at 4:42 PM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>>
>> 2015-05-19 16:28 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> > On 15 May 2015 at 05:42, Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> > wrote:
>> >> 2015-05-15 1:16 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> >>> On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> >>> wrote:
>> >>>> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> >>>>> On 13 May 2015 at 12:51, Krzysztof Kozlowski
>> >>>>> <k.kozlowski@samsung.com> wrote:
>> >>>>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> >>>>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>> >>>>>>> device.
>> >>>>>>>
>> >>>>>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>> >>>>>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>> >>>>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>> >>>>>>> ---
>> >>>>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25
>> >>>>>>> +++++++++++++++++++++++++
>> >>>>>>>  1 file changed, 25 insertions(+)
>> >>>>>>>
>> >>>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> >>>>>>> b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> >>>>>>> index 9446e28..cd78816 100644
>> >>>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> >>>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> >>>>>>> @@ -319,6 +319,31 @@
>> >>>>>>>                 #cooling-cells = <2>;
>> >>>>>>>                 cooling-levels = <0 130 170 230>;
>> >>>>>>>         };
>> >>>>>>> +
>> >>>>>>> +       tmu@10060000 {
>> >>>>>>
>> >>>>>> Here and for other overrides please use label notation, like:
>> >>>>>>
>> >>>>>> &tmu_cpu0 {
>> >>>>>>               ...
>> >>>>>> };
>> >>>>>>
>> >>>>>>> +               vtmu-supply = <&ldo10_reg>;
>> >>>>>>
>> >>>>>> I am curious, how did you find that LDO10 supplies TMU unit?
>> >>>>>>
>> >>>>>> Best regards,
>> >>>>>> Krzysztof
>> >>>>>
>> >>>>> Hi Krzysztof,
>> >>>>>
>> >>>>> I have re-base my work on earlier Lukasz Majewski patches.
>> >>>>>
>> >>>>> https://patchwork.kernel.org/patch/5693201/
>> >>>>
>> >>>> NAK.
>> >>>> I am sorry, but this is not sufficient explanation. Actually such
>> >>>> explanation could mean that you did just blindly copied everything
>> >>>> instead of developing it.
>> >>>>
>> >>>> You cannot use some regulator here just because some Exynos4 boards
>> >>>> use it. You have to be sure that this regulator supplies this part of
>> >>>> SoC or device.
>> >>>
>> >>> Hi Krzysztof,
>> >>>
>> >>> After going through the schematics, I came to understanding that their
>> >>> is
>> >>> missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.
>> >>>
>> >>> Below is the schematic of the board.
>> >>>
>> >>> http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF
>> >>>
>> >>>   ldo18_reg: LDO18 {
>> >>>                                          regulator-name = "vdd_ldo18";
>> >>>                                          regulator-min-microvolt =
>> >>> <1800000>;
>> >>>                                          regulator-max-microvolt =
>> >>> <1800000>;
>> >>>                                          regulator-always-on;
>> >>>                                };
>> >>
>> >> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for
>> >> TMU.
>> >>
>> >> I think the schematics are missing some of details but it can be
>> >> deducted that:
>> >> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5
>> >> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]).
>> >> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to theL DO7 of
>> >> S2MPS11 PMIC.
>> >> 3. I confirmed with the Exynos5422 datasheet that these
>> >> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES).
>> >>
>> >> So the LDO7 it is... but before using it there is a caveat. The LDO7
>> >> is also connected to VDD of MIPI, HDMI and few more. So when you use
>> >> this regulator in TMU it may be turned off by TMU driver (e.g. during
>> >> unbind). In such case these other blocks also should be tested and
>> >> checked whether they take this regulator and enable it.
>> >
>> > hi Krzysztof,
>> >
>> > I tried to use the LDO7 regulator for TMU but it failed to register.
>> >
>> > [    3.231329] ina2xx 0-0045: power monitor ina231 (Rshunt = 10000 uOhm)
>> > [    3.237691] thermal thermal_zone0: failed to read out thermal zone
>> > (-22)
>> > [    3.243033] exynos-tmu 10060000.tmu: Looking up vtmu-supply from
>> > device tree
>> > [    3.243936] thermal thermal_zone1: failed to read out thermal zone
>> > (-22)
>> > [    3.249791] exynos-tmu 10064000.tmu: Looking up vtmu-supply from
>> > device tree
>> > [    3.250677] thermal thermal_zone2: failed to read out thermal zone
>> > (-22)
>> > [    3.256410] exynos-tmu 10068000.tmu: Looking up vtmu-supply from
>> > device tree
>> > [    3.257345] thermal thermal_zone3: failed to read out thermal zone
>> > (-22)
>> > [    3.263050] exynos-tmu 1006c000.tmu: Looking up vtmu-supply from
>> > device tree
>> > [    3.263984] thermal thermal_zone4: failed to read out thermal zone
>> > (-22)
>> > [    3.269769] exynos-tmu 100a0000.tmu: Looking up vtmu-supply from
>> > device tree
>> > [    3.270363] usb 5-1: New USB device found, idVendor=0424,
>> > idProduct=9514
>> > [    3.276389] usb 5-1: New USB device strings: Mfr=0, Product=0,
>> > SerialNumber=0
>>
>> Indeed.
>>

Hi Krzysztof/Dongjin

BUCK3 is option for TMU as suggested by Dongjin

Earlier I have some missing CONFIG option's hence It was not working.
Now its registering with TMU.

Bellow is the output device tree.

root@odroidxu3: cd /sys/firmware/devicetree/base/
root@odroidxu3:/sys/firmware/devicetree/base# cat tmu@10060000/status
okay
root@odroidxu3:/sys/firmware/devicetree/base#
root@odroidxu3:/sys/firmware/devicetree/base# cat tmu@10064000/status
okay
root@odroidxu3:/sys/firmware/devicetree/base# cat tmu@10068000/status
okay
root@odroidxu3:/sys/firmware/devicetree/base# cat tmu@1006c000/status
okay
root@odroidxu3:/sys/firmware/devicetree/base# cat tmu@100a0000/status
okay
root@odroidxu3:/sys/firmware/devicetree/base#

-Anand Moon

>> Best regards,
>> Krzysztof
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel@lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

On 20 May 2015 at 08:57, Dongjin Kim <tobetter@gmail.com> wrote:
> Hello Kryzsztof,
>
> Are you able to check if TMU is under VDDI power domain from Exynos5422
> datasheet?
> If it is, XU3 use BUCK3 for TMU and more internal blocks.
>
> Thank you,
> Dongjin.
>
> On Tue, May 19, 2015 at 4:42 PM, Krzysztof Kozlowski
> <k.kozlowski@samsung.com> wrote:
>>
>> 2015-05-19 16:28 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> > On 15 May 2015 at 05:42, Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> > wrote:
>> >> 2015-05-15 1:16 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> >>> On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski@samsung.com>
>> >>> wrote:
>> >>>> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> >>>>> On 13 May 2015 at 12:51, Krzysztof Kozlowski
>> >>>>> <k.kozlowski@samsung.com> wrote:
>> >>>>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> >>>>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>> >>>>>>> device.
>> >>>>>>>
>> >>>>>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>> >>>>>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>> >>>>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>> >>>>>>> ---
>> >>>>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25
>> >>>>>>> +++++++++++++++++++++++++
>> >>>>>>>  1 file changed, 25 insertions(+)
>> >>>>>>>
>> >>>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> >>>>>>> b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> >>>>>>> index 9446e28..cd78816 100644
>> >>>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> >>>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>> >>>>>>> @@ -319,6 +319,31 @@
>> >>>>>>>                 #cooling-cells = <2>;
>> >>>>>>>                 cooling-levels = <0 130 170 230>;
>> >>>>>>>         };
>> >>>>>>> +
>> >>>>>>> +       tmu at 10060000 {
>> >>>>>>
>> >>>>>> Here and for other overrides please use label notation, like:
>> >>>>>>
>> >>>>>> &tmu_cpu0 {
>> >>>>>>               ...
>> >>>>>> };
>> >>>>>>
>> >>>>>>> +               vtmu-supply = <&ldo10_reg>;
>> >>>>>>
>> >>>>>> I am curious, how did you find that LDO10 supplies TMU unit?
>> >>>>>>
>> >>>>>> Best regards,
>> >>>>>> Krzysztof
>> >>>>>
>> >>>>> Hi Krzysztof,
>> >>>>>
>> >>>>> I have re-base my work on earlier Lukasz Majewski patches.
>> >>>>>
>> >>>>> https://patchwork.kernel.org/patch/5693201/
>> >>>>
>> >>>> NAK.
>> >>>> I am sorry, but this is not sufficient explanation. Actually such
>> >>>> explanation could mean that you did just blindly copied everything
>> >>>> instead of developing it.
>> >>>>
>> >>>> You cannot use some regulator here just because some Exynos4 boards
>> >>>> use it. You have to be sure that this regulator supplies this part of
>> >>>> SoC or device.
>> >>>
>> >>> Hi Krzysztof,
>> >>>
>> >>> After going through the schematics, I came to understanding that their
>> >>> is
>> >>> missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.
>> >>>
>> >>> Below is the schematic of the board.
>> >>>
>> >>> http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF
>> >>>
>> >>>   ldo18_reg: LDO18 {
>> >>>                                          regulator-name = "vdd_ldo18";
>> >>>                                          regulator-min-microvolt =
>> >>> <1800000>;
>> >>>                                          regulator-max-microvolt =
>> >>> <1800000>;
>> >>>                                          regulator-always-on;
>> >>>                                };
>> >>
>> >> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for
>> >> TMU.
>> >>
>> >> I think the schematics are missing some of details but it can be
>> >> deducted that:
>> >> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5
>> >> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]).
>> >> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to theL DO7 of
>> >> S2MPS11 PMIC.
>> >> 3. I confirmed with the Exynos5422 datasheet that these
>> >> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES).
>> >>
>> >> So the LDO7 it is... but before using it there is a caveat. The LDO7
>> >> is also connected to VDD of MIPI, HDMI and few more. So when you use
>> >> this regulator in TMU it may be turned off by TMU driver (e.g. during
>> >> unbind). In such case these other blocks also should be tested and
>> >> checked whether they take this regulator and enable it.
>> >
>> > hi Krzysztof,
>> >
>> > I tried to use the LDO7 regulator for TMU but it failed to register.
>> >
>> > [    3.231329] ina2xx 0-0045: power monitor ina231 (Rshunt = 10000 uOhm)
>> > [    3.237691] thermal thermal_zone0: failed to read out thermal zone
>> > (-22)
>> > [    3.243033] exynos-tmu 10060000.tmu: Looking up vtmu-supply from
>> > device tree
>> > [    3.243936] thermal thermal_zone1: failed to read out thermal zone
>> > (-22)
>> > [    3.249791] exynos-tmu 10064000.tmu: Looking up vtmu-supply from
>> > device tree
>> > [    3.250677] thermal thermal_zone2: failed to read out thermal zone
>> > (-22)
>> > [    3.256410] exynos-tmu 10068000.tmu: Looking up vtmu-supply from
>> > device tree
>> > [    3.257345] thermal thermal_zone3: failed to read out thermal zone
>> > (-22)
>> > [    3.263050] exynos-tmu 1006c000.tmu: Looking up vtmu-supply from
>> > device tree
>> > [    3.263984] thermal thermal_zone4: failed to read out thermal zone
>> > (-22)
>> > [    3.269769] exynos-tmu 100a0000.tmu: Looking up vtmu-supply from
>> > device tree
>> > [    3.270363] usb 5-1: New USB device found, idVendor=0424,
>> > idProduct=9514
>> > [    3.276389] usb 5-1: New USB device strings: Mfr=0, Product=0,
>> > SerialNumber=0
>>
>> Indeed.
>>

Hi Krzysztof/Dongjin

BUCK3 is option for TMU as suggested by Dongjin

Earlier I have some missing CONFIG option's hence It was not working.
Now its registering with TMU.

Bellow is the output device tree.

root at odroidxu3: cd /sys/firmware/devicetree/base/
root at odroidxu3:/sys/firmware/devicetree/base# cat tmu at 10060000/status
okay
root at odroidxu3:/sys/firmware/devicetree/base#
root at odroidxu3:/sys/firmware/devicetree/base# cat tmu at 10064000/status
okay
root at odroidxu3:/sys/firmware/devicetree/base# cat tmu at 10068000/status
okay
root at odroidxu3:/sys/firmware/devicetree/base# cat tmu at 1006c000/status
okay
root at odroidxu3:/sys/firmware/devicetree/base# cat tmu at 100a0000/status
okay
root at odroidxu3:/sys/firmware/devicetree/base#

-Anand Moon

>> Best regards,
>> Krzysztof
>>
>> _______________________________________________
>> linux-arm-kernel mailing list
>> linux-arm-kernel at lists.infradead.org
>> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
>
>

Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Krzysztof Kozlowski]

On 20.05.2015 23:59, Anand Moon wrote:
> On 20 May 2015 at 08:57, Dongjin Kim <tobetter@gmail.com> wrote:
>> Hello Kryzsztof,
>>
>> Are you able to check if TMU is under VDDI power domain from Exynos5422
>> datasheet?
>> If it is, XU3 use BUCK3 for TMU and more internal blocks.
>>
>> Thank you,
>> Dongjin.
>>
>> On Tue, May 19, 2015 at 4:42 PM, Krzysztof Kozlowski
>> <k.kozlowski@samsung.com> wrote:
>>>
>>> 2015-05-19 16:28 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>> On 15 May 2015 at 05:42, Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>>> wrote:
>>>>> 2015-05-15 1:16 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>>> On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>>>>> wrote:
>>>>>>> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>>>>> On 13 May 2015 at 12:51, Krzysztof Kozlowski
>>>>>>>> <k.kozlowski@samsung.com> wrote:
>>>>>>>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>>>>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>>>>>>>> device.
>>>>>>>>>>
>>>>>>>>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>>>>>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>>>>>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>>>>>>>>> ---
>>>>>>>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25
>>>>>>>>>> +++++++++++++++++++++++++
>>>>>>>>>>  1 file changed, 25 insertions(+)
>>>>>>>>>>
>>>>>>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>> b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>> index 9446e28..cd78816 100644
>>>>>>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>> @@ -319,6 +319,31 @@
>>>>>>>>>>                 #cooling-cells = <2>;
>>>>>>>>>>                 cooling-levels = <0 130 170 230>;
>>>>>>>>>>         };
>>>>>>>>>> +
>>>>>>>>>> +       tmu@10060000 {
>>>>>>>>>
>>>>>>>>> Here and for other overrides please use label notation, like:
>>>>>>>>>
>>>>>>>>> &tmu_cpu0 {
>>>>>>>>>               ...
>>>>>>>>> };
>>>>>>>>>
>>>>>>>>>> +               vtmu-supply = <&ldo10_reg>;
>>>>>>>>>
>>>>>>>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>>>>>>>
>>>>>>>>> Best regards,
>>>>>>>>> Krzysztof
>>>>>>>>
>>>>>>>> Hi Krzysztof,
>>>>>>>>
>>>>>>>> I have re-base my work on earlier Lukasz Majewski patches.
>>>>>>>>
>>>>>>>> https://patchwork.kernel.org/patch/5693201/
>>>>>>>
>>>>>>> NAK.
>>>>>>> I am sorry, but this is not sufficient explanation. Actually such
>>>>>>> explanation could mean that you did just blindly copied everything
>>>>>>> instead of developing it.
>>>>>>>
>>>>>>> You cannot use some regulator here just because some Exynos4 boards
>>>>>>> use it. You have to be sure that this regulator supplies this part of
>>>>>>> SoC or device.
>>>>>>
>>>>>> Hi Krzysztof,
>>>>>>
>>>>>> After going through the schematics, I came to understanding that their
>>>>>> is
>>>>>> missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.
>>>>>>
>>>>>> Below is the schematic of the board.
>>>>>>
>>>>>> http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF
>>>>>>
>>>>>>   ldo18_reg: LDO18 {
>>>>>>                                          regulator-name = "vdd_ldo18";
>>>>>>                                          regulator-min-microvolt =
>>>>>> <1800000>;
>>>>>>                                          regulator-max-microvolt =
>>>>>> <1800000>;
>>>>>>                                          regulator-always-on;
>>>>>>                                };
>>>>>
>>>>> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for
>>>>> TMU.
>>>>>
>>>>> I think the schematics are missing some of details but it can be
>>>>> deducted that:
>>>>> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5
>>>>> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]).
>>>>> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to theL DO7 of
>>>>> S2MPS11 PMIC.
>>>>> 3. I confirmed with the Exynos5422 datasheet that these
>>>>> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES).
>>>>>
>>>>> So the LDO7 it is... but before using it there is a caveat. The LDO7
>>>>> is also connected to VDD of MIPI, HDMI and few more. So when you use
>>>>> this regulator in TMU it may be turned off by TMU driver (e.g. during
>>>>> unbind). In such case these other blocks also should be tested and
>>>>> checked whether they take this regulator and enable it.
>>>>
>>>> hi Krzysztof,
>>>>
>>>> I tried to use the LDO7 regulator for TMU but it failed to register.
>>>>
>>>> [    3.231329] ina2xx 0-0045: power monitor ina231 (Rshunt = 10000 uOhm)
>>>> [    3.237691] thermal thermal_zone0: failed to read out thermal zone
>>>> (-22)
>>>> [    3.243033] exynos-tmu 10060000.tmu: Looking up vtmu-supply from
>>>> device tree
>>>> [    3.243936] thermal thermal_zone1: failed to read out thermal zone
>>>> (-22)
>>>> [    3.249791] exynos-tmu 10064000.tmu: Looking up vtmu-supply from
>>>> device tree
>>>> [    3.250677] thermal thermal_zone2: failed to read out thermal zone
>>>> (-22)
>>>> [    3.256410] exynos-tmu 10068000.tmu: Looking up vtmu-supply from
>>>> device tree
>>>> [    3.257345] thermal thermal_zone3: failed to read out thermal zone
>>>> (-22)
>>>> [    3.263050] exynos-tmu 1006c000.tmu: Looking up vtmu-supply from
>>>> device tree
>>>> [    3.263984] thermal thermal_zone4: failed to read out thermal zone
>>>> (-22)
>>>> [    3.269769] exynos-tmu 100a0000.tmu: Looking up vtmu-supply from
>>>> device tree
>>>> [    3.270363] usb 5-1: New USB device found, idVendor=0424,
>>>> idProduct=9514
>>>> [    3.276389] usb 5-1: New USB device strings: Mfr=0, Product=0,
>>>> SerialNumber=0
>>>
>>> Indeed.
>>>
> 
> Hi Krzysztof/Dongjin
> 
> BUCK3 is option for TMU as suggested by Dongjin

What do you mean by that? VDD_INT is one of important regulators. It
supplies many parts of chip and should not be disabled during exynos-tmu
driver removal.

Of course it wouldn't because it is "always-on"... so what is the
benefit of using it in exynos-tmu?

What about regulator supplying TMU sensors? Shouldn't it be enabled? Is
it the same?

Before posting a new solution please be sure that you have sufficient
answer for each of these questions. Anwser that "someone told me so"
unfortunately is not sufficient :).



> Earlier I have some missing CONFIG option's hence It was not working.
> Now its registering with TMU.
> 
> Bellow is the output device tree.
> 
> root@odroidxu3: cd /sys/firmware/devicetree/base/
> root@odroidxu3:/sys/firmware/devicetree/base# cat tmu@10060000/status
> okay
> root@odroidxu3:/sys/firmware/devicetree/base#
> root@odroidxu3:/sys/firmware/devicetree/base# cat tmu@10064000/status
> okay
> root@odroidxu3:/sys/firmware/devicetree/base# cat tmu@10068000/status
> okay
> root@odroidxu3:/sys/firmware/devicetree/base# cat tmu@1006c000/status
> okay
> root@odroidxu3:/sys/firmware/devicetree/base# cat tmu@100a0000/status
> okay
> root@odroidxu3:/sys/firmware/devicetree/base#

If you looked at the driver then you would know, that above status does
not mean anything for this discussion about regulator. You could use
EMMC regulator (which you proposed) and the results would be the same.

Best regards,
Krzysztof

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Krzysztof Kozlowski]

On 20.05.2015 23:59, Anand Moon wrote:
> On 20 May 2015 at 08:57, Dongjin Kim <tobetter@gmail.com> wrote:
>> Hello Kryzsztof,
>>
>> Are you able to check if TMU is under VDDI power domain from Exynos5422
>> datasheet?
>> If it is, XU3 use BUCK3 for TMU and more internal blocks.
>>
>> Thank you,
>> Dongjin.
>>
>> On Tue, May 19, 2015 at 4:42 PM, Krzysztof Kozlowski
>> <k.kozlowski@samsung.com> wrote:
>>>
>>> 2015-05-19 16:28 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>> On 15 May 2015 at 05:42, Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>>> wrote:
>>>>> 2015-05-15 1:16 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>>> On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>>>>> wrote:
>>>>>>> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>>>>> On 13 May 2015 at 12:51, Krzysztof Kozlowski
>>>>>>>> <k.kozlowski@samsung.com> wrote:
>>>>>>>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>>>>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>>>>>>>> device.
>>>>>>>>>>
>>>>>>>>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>>>>>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>>>>>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>>>>>>>>> ---
>>>>>>>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25
>>>>>>>>>> +++++++++++++++++++++++++
>>>>>>>>>>  1 file changed, 25 insertions(+)
>>>>>>>>>>
>>>>>>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>> b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>> index 9446e28..cd78816 100644
>>>>>>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>> @@ -319,6 +319,31 @@
>>>>>>>>>>                 #cooling-cells = <2>;
>>>>>>>>>>                 cooling-levels = <0 130 170 230>;
>>>>>>>>>>         };
>>>>>>>>>> +
>>>>>>>>>> +       tmu at 10060000 {
>>>>>>>>>
>>>>>>>>> Here and for other overrides please use label notation, like:
>>>>>>>>>
>>>>>>>>> &tmu_cpu0 {
>>>>>>>>>               ...
>>>>>>>>> };
>>>>>>>>>
>>>>>>>>>> +               vtmu-supply = <&ldo10_reg>;
>>>>>>>>>
>>>>>>>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>>>>>>>
>>>>>>>>> Best regards,
>>>>>>>>> Krzysztof
>>>>>>>>
>>>>>>>> Hi Krzysztof,
>>>>>>>>
>>>>>>>> I have re-base my work on earlier Lukasz Majewski patches.
>>>>>>>>
>>>>>>>> https://patchwork.kernel.org/patch/5693201/
>>>>>>>
>>>>>>> NAK.
>>>>>>> I am sorry, but this is not sufficient explanation. Actually such
>>>>>>> explanation could mean that you did just blindly copied everything
>>>>>>> instead of developing it.
>>>>>>>
>>>>>>> You cannot use some regulator here just because some Exynos4 boards
>>>>>>> use it. You have to be sure that this regulator supplies this part of
>>>>>>> SoC or device.
>>>>>>
>>>>>> Hi Krzysztof,
>>>>>>
>>>>>> After going through the schematics, I came to understanding that their
>>>>>> is
>>>>>> missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.
>>>>>>
>>>>>> Below is the schematic of the board.
>>>>>>
>>>>>> http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF
>>>>>>
>>>>>>   ldo18_reg: LDO18 {
>>>>>>                                          regulator-name = "vdd_ldo18";
>>>>>>                                          regulator-min-microvolt =
>>>>>> <1800000>;
>>>>>>                                          regulator-max-microvolt =
>>>>>> <1800000>;
>>>>>>                                          regulator-always-on;
>>>>>>                                };
>>>>>
>>>>> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for
>>>>> TMU.
>>>>>
>>>>> I think the schematics are missing some of details but it can be
>>>>> deducted that:
>>>>> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5
>>>>> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]).
>>>>> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to theL DO7 of
>>>>> S2MPS11 PMIC.
>>>>> 3. I confirmed with the Exynos5422 datasheet that these
>>>>> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES).
>>>>>
>>>>> So the LDO7 it is... but before using it there is a caveat. The LDO7
>>>>> is also connected to VDD of MIPI, HDMI and few more. So when you use
>>>>> this regulator in TMU it may be turned off by TMU driver (e.g. during
>>>>> unbind). In such case these other blocks also should be tested and
>>>>> checked whether they take this regulator and enable it.
>>>>
>>>> hi Krzysztof,
>>>>
>>>> I tried to use the LDO7 regulator for TMU but it failed to register.
>>>>
>>>> [    3.231329] ina2xx 0-0045: power monitor ina231 (Rshunt = 10000 uOhm)
>>>> [    3.237691] thermal thermal_zone0: failed to read out thermal zone
>>>> (-22)
>>>> [    3.243033] exynos-tmu 10060000.tmu: Looking up vtmu-supply from
>>>> device tree
>>>> [    3.243936] thermal thermal_zone1: failed to read out thermal zone
>>>> (-22)
>>>> [    3.249791] exynos-tmu 10064000.tmu: Looking up vtmu-supply from
>>>> device tree
>>>> [    3.250677] thermal thermal_zone2: failed to read out thermal zone
>>>> (-22)
>>>> [    3.256410] exynos-tmu 10068000.tmu: Looking up vtmu-supply from
>>>> device tree
>>>> [    3.257345] thermal thermal_zone3: failed to read out thermal zone
>>>> (-22)
>>>> [    3.263050] exynos-tmu 1006c000.tmu: Looking up vtmu-supply from
>>>> device tree
>>>> [    3.263984] thermal thermal_zone4: failed to read out thermal zone
>>>> (-22)
>>>> [    3.269769] exynos-tmu 100a0000.tmu: Looking up vtmu-supply from
>>>> device tree
>>>> [    3.270363] usb 5-1: New USB device found, idVendor=0424,
>>>> idProduct=9514
>>>> [    3.276389] usb 5-1: New USB device strings: Mfr=0, Product=0,
>>>> SerialNumber=0
>>>
>>> Indeed.
>>>
> 
> Hi Krzysztof/Dongjin
> 
> BUCK3 is option for TMU as suggested by Dongjin

What do you mean by that? VDD_INT is one of important regulators. It
supplies many parts of chip and should not be disabled during exynos-tmu
driver removal.

Of course it wouldn't because it is "always-on"... so what is the
benefit of using it in exynos-tmu?

What about regulator supplying TMU sensors? Shouldn't it be enabled? Is
it the same?

Before posting a new solution please be sure that you have sufficient
answer for each of these questions. Anwser that "someone told me so"
unfortunately is not sufficient :).



> Earlier I have some missing CONFIG option's hence It was not working.
> Now its registering with TMU.
> 
> Bellow is the output device tree.
> 
> root at odroidxu3: cd /sys/firmware/devicetree/base/
> root at odroidxu3:/sys/firmware/devicetree/base# cat tmu at 10060000/status
> okay
> root at odroidxu3:/sys/firmware/devicetree/base#
> root at odroidxu3:/sys/firmware/devicetree/base# cat tmu at 10064000/status
> okay
> root at odroidxu3:/sys/firmware/devicetree/base# cat tmu at 10068000/status
> okay
> root at odroidxu3:/sys/firmware/devicetree/base# cat tmu at 1006c000/status
> okay
> root at odroidxu3:/sys/firmware/devicetree/base# cat tmu at 100a0000/status
> okay
> root at odroidxu3:/sys/firmware/devicetree/base#

If you looked at the driver then you would know, that above status does
not mean anything for this discussion about regulator. You could use
EMMC regulator (which you proposed) and the results would be the same.

Best regards,
Krzysztof

Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

On 21 May 2015 at 05:33, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> On 20.05.2015 23:59, Anand Moon wrote:
>> On 20 May 2015 at 08:57, Dongjin Kim <tobetter@gmail.com> wrote:
>>> Hello Kryzsztof,
>>>
>>> Are you able to check if TMU is under VDDI power domain from Exynos5422
>>> datasheet?
>>> If it is, XU3 use BUCK3 for TMU and more internal blocks.
>>>
>>> Thank you,
>>> Dongjin.
>>>
>>> On Tue, May 19, 2015 at 4:42 PM, Krzysztof Kozlowski
>>> <k.kozlowski@samsung.com> wrote:
>>>>
>>>> 2015-05-19 16:28 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>> On 15 May 2015 at 05:42, Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>>>> wrote:
>>>>>> 2015-05-15 1:16 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>>>> On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>>>>>> wrote:
>>>>>>>> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>>>>>> On 13 May 2015 at 12:51, Krzysztof Kozlowski
>>>>>>>>> <k.kozlowski@samsung.com> wrote:
>>>>>>>>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>>>>>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>>>>>>>>> device.
>>>>>>>>>>>
>>>>>>>>>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>>>>>>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>>>>>>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>>>>>>>>>> ---
>>>>>>>>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25
>>>>>>>>>>> +++++++++++++++++++++++++
>>>>>>>>>>>  1 file changed, 25 insertions(+)
>>>>>>>>>>>
>>>>>>>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>>> b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>>> index 9446e28..cd78816 100644
>>>>>>>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>>> @@ -319,6 +319,31 @@
>>>>>>>>>>>                 #cooling-cells = <2>;
>>>>>>>>>>>                 cooling-levels = <0 130 170 230>;
>>>>>>>>>>>         };
>>>>>>>>>>> +
>>>>>>>>>>> +       tmu@10060000 {
>>>>>>>>>>
>>>>>>>>>> Here and for other overrides please use label notation, like:
>>>>>>>>>>
>>>>>>>>>> &tmu_cpu0 {
>>>>>>>>>>               ...
>>>>>>>>>> };
>>>>>>>>>>
>>>>>>>>>>> +               vtmu-supply = <&ldo10_reg>;
>>>>>>>>>>
>>>>>>>>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>>>>>>>>
>>>>>>>>>> Best regards,
>>>>>>>>>> Krzysztof
>>>>>>>>>
>>>>>>>>> Hi Krzysztof,
>>>>>>>>>
>>>>>>>>> I have re-base my work on earlier Lukasz Majewski patches.
>>>>>>>>>
>>>>>>>>> https://patchwork.kernel.org/patch/5693201/
>>>>>>>>
>>>>>>>> NAK.
>>>>>>>> I am sorry, but this is not sufficient explanation. Actually such
>>>>>>>> explanation could mean that you did just blindly copied everything
>>>>>>>> instead of developing it.
>>>>>>>>
>>>>>>>> You cannot use some regulator here just because some Exynos4 boards
>>>>>>>> use it. You have to be sure that this regulator supplies this part of
>>>>>>>> SoC or device.
>>>>>>>
>>>>>>> Hi Krzysztof,
>>>>>>>
>>>>>>> After going through the schematics, I came to understanding that their
>>>>>>> is
>>>>>>> missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.
>>>>>>>
>>>>>>> Below is the schematic of the board.
>>>>>>>
>>>>>>> http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF
>>>>>>>
>>>>>>>   ldo18_reg: LDO18 {
>>>>>>>                                          regulator-name = "vdd_ldo18";
>>>>>>>                                          regulator-min-microvolt =
>>>>>>> <1800000>;
>>>>>>>                                          regulator-max-microvolt =
>>>>>>> <1800000>;
>>>>>>>                                          regulator-always-on;
>>>>>>>                                };
>>>>>>
>>>>>> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for
>>>>>> TMU.
>>>>>>
>>>>>> I think the schematics are missing some of details but it can be
>>>>>> deducted that:
>>>>>> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5
>>>>>> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]).
>>>>>> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to theL DO7 of
>>>>>> S2MPS11 PMIC.
>>>>>> 3. I confirmed with the Exynos5422 datasheet that these
>>>>>> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES).
>>>>>>
>>>>>> So the LDO7 it is... but before using it there is a caveat. The LDO7
>>>>>> is also connected to VDD of MIPI, HDMI and few more. So when you use
>>>>>> this regulator in TMU it may be turned off by TMU driver (e.g. during
>>>>>> unbind). In such case these other blocks also should be tested and
>>>>>> checked whether they take this regulator and enable it.
>>>>>
>>>>> hi Krzysztof,
>>>>>
>>>>> I tried to use the LDO7 regulator for TMU but it failed to register.
>>>>>
>>>>> [    3.231329] ina2xx 0-0045: power monitor ina231 (Rshunt = 10000 uOhm)
>>>>> [    3.237691] thermal thermal_zone0: failed to read out thermal zone
>>>>> (-22)
>>>>> [    3.243033] exynos-tmu 10060000.tmu: Looking up vtmu-supply from
>>>>> device tree
>>>>> [    3.243936] thermal thermal_zone1: failed to read out thermal zone
>>>>> (-22)
>>>>> [    3.249791] exynos-tmu 10064000.tmu: Looking up vtmu-supply from
>>>>> device tree
>>>>> [    3.250677] thermal thermal_zone2: failed to read out thermal zone
>>>>> (-22)
>>>>> [    3.256410] exynos-tmu 10068000.tmu: Looking up vtmu-supply from
>>>>> device tree
>>>>> [    3.257345] thermal thermal_zone3: failed to read out thermal zone
>>>>> (-22)
>>>>> [    3.263050] exynos-tmu 1006c000.tmu: Looking up vtmu-supply from
>>>>> device tree
>>>>> [    3.263984] thermal thermal_zone4: failed to read out thermal zone
>>>>> (-22)
>>>>> [    3.269769] exynos-tmu 100a0000.tmu: Looking up vtmu-supply from
>>>>> device tree
>>>>> [    3.270363] usb 5-1: New USB device found, idVendor=0424,
>>>>> idProduct=9514
>>>>> [    3.276389] usb 5-1: New USB device strings: Mfr=0, Product=0,
>>>>> SerialNumber=0
>>>>
>>>> Indeed.
>>>>
>>
>> Hi Krzysztof/Dongjin
>>
>> BUCK3 is option for TMU as suggested by Dongjin
>
> What do you mean by that? VDD_INT is one of important regulators. It
> supplies many parts of chip and should not be disabled during exynos-tmu
> driver removal.
>
> Of course it wouldn't because it is "always-on"... so what is the
> benefit of using it in exynos-tmu?
>
> What about regulator supplying TMU sensors? Shouldn't it be enabled? Is
> it the same?
>
> Before posting a new solution please be sure that you have sufficient
> answer for each of these questions. Anwser that "someone told me so"
> unfortunately is not sufficient :).
>
>
>
>> Earlier I have some missing CONFIG option's hence It was not working.
>> Now its registering with TMU.
>>
>> Bellow is the output device tree.
>>
>> root@odroidxu3: cd /sys/firmware/devicetree/base/
>> root@odroidxu3:/sys/firmware/devicetree/base# cat tmu@10060000/status
>> okay
>> root@odroidxu3:/sys/firmware/devicetree/base#
>> root@odroidxu3:/sys/firmware/devicetree/base# cat tmu@10064000/status
>> okay
>> root@odroidxu3:/sys/firmware/devicetree/base# cat tmu@10068000/status
>> okay
>> root@odroidxu3:/sys/firmware/devicetree/base# cat tmu@1006c000/status
>> okay
>> root@odroidxu3:/sys/firmware/devicetree/base# cat tmu@100a0000/status
>> okay
>> root@odroidxu3:/sys/firmware/devicetree/base#
>
> If you looked at the driver then you would know, that above status does
> not mean anything for this discussion about regulator. You could use
> EMMC regulator (which you proposed) and the results would be the same.
>
> Best regards,
> Krzysztof
>

Hi Krzysztof,

I did some debugging on the this using powerdebug utility.
Using  LDO7 to control TMU seams to me correct option compared to BUCK3.

Setting LDO7 to control TMU I observed  following output on powerdebug.
I observed that the power drawn by the board on Odroid show is much
less compare to BUCK3 on the same setup.
I can see the HDMI output on Odroid-V2 display screen.
I have done some stress testing on this configuration and It worked correctly.

Powerdebug output using LDO7
---------------------------------------------------------------------------------------------------------------
PowerDebug 0.7.3     Clocks  Regulators  Sensors  Gpio
Name        Status      State       Type        Users       Microvolts
 Min u-volts Max u-volts
phy                                             0           0
 0           0
phy                                             0           0
 0           0
vdd_ldo1                enabled     voltage     0           1000000
 1000000     1000000
LDO1                                            0           0
 0           0
LDO2                    enabled     voltage     0           1800000
 0           0
vdd_ldo3                enabled     voltage     0           1800000
 1800000     1800000
LDO3                                            0           0
 0           0
LDO4                    enabled     voltage     0           1800000
 0           0
vdd_ldo5                enabled     voltage     0           1800000
 1800000     1800000
LDO5                                            0           0
 0           0
vdd_ldo6                enabled     voltage     0           1000000
 1000000     1000000
hdmi        okay                                0           0
 0           0
hdmi        okay                                0           0
 0           0
LDO6                                            0           0
 0           0
vdd_ldo7                enabled     voltage     0           1800000
 1800000     1800000
hdmi        okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
LDO7                                            0           0
 0           0
vdd_ldo8                enabled     voltage     0           1800000
 1800000     1800000
LDO8                                            0           0
 0           0
vdd_ldo9                enabled     voltage     0           3000000
 3000000     3000000
LDO9                                            0           0
 0           0

Powerdebug output using BUCK3.
--------------------------------------------------------------------------------------------------------------------------
PowerDebug 0.7.3     Clocks  Regulators  Sensors  Gpio
Name        Status      State       Type        Users       Microvolts
 Min u-volts Max u-volts
LDO21                   disabled    voltage     0           1800000
 0           0
LDO22                   disabled    voltage     0           1200000
 0           0
LDO23                   enabled     voltage     0           1100000
 0           0
tsp_io                  enabled     voltage     0           2800000
 2800000     2800000
LDO24                                           0           0
 0           0
LDO25                   disabled    voltage     0           1800000
 0           0
vdd_ldo26               enabled     voltage     0           3000000
 3000000     3000000
LDO26                                           0           0
 0           0
LDO27                   enabled     voltage     0           1000000
 0           0
LDO28                   disabled    voltage     0           3300000
 0           0
LDO29                   disabled    voltage     0           1800000
 0           0
LDO30                   disabled    voltage     0           1800000
 0           0
LDO31                   disabled    voltage     0           1800000
 0           0
LDO32                   disabled    voltage     0           1800000
 0           0
LDO33                   disabled    voltage     0           1800000
 0           0
LDO34                   disabled    voltage     0           3000000
 0           0
LDO35                   disabled    voltage     0           1600000
 0           0
LDO36                   disabled    voltage     0           1800000
 0           0
LDO37                   disabled    voltage     0           1800000
 0           0
LDO38                   disabled    voltage     0           2800000
 0           0
vdd_mif                 enabled     voltage     0           1100000
 800000      1300000
BUCK1                                           0           0
 0           0
vdd_arm                 enabled     voltage     0           1000000
 800000      1500000
BUCK2                                           0           0
 0           0
vdd_int                 enabled     voltage     0           1000000
 800000      1400000
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
BUCK3                                           0           0
 0           0
vdd_g3d                 enabled     voltage     0           1000000
 800000      1400000
BUCK4                                           0           0
 0           0
vdd_mem                 enabled     voltage     0           1200000
 800000      1400000
BUCK5                                           0           0
 0           0
vdd_kfc                 enabled     voltage     0           1025000
 800000      1500000

So I would like to go with LDO7.

Please share your thoughts.

-Anand Moon

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

On 21 May 2015 at 05:33, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> On 20.05.2015 23:59, Anand Moon wrote:
>> On 20 May 2015 at 08:57, Dongjin Kim <tobetter@gmail.com> wrote:
>>> Hello Kryzsztof,
>>>
>>> Are you able to check if TMU is under VDDI power domain from Exynos5422
>>> datasheet?
>>> If it is, XU3 use BUCK3 for TMU and more internal blocks.
>>>
>>> Thank you,
>>> Dongjin.
>>>
>>> On Tue, May 19, 2015 at 4:42 PM, Krzysztof Kozlowski
>>> <k.kozlowski@samsung.com> wrote:
>>>>
>>>> 2015-05-19 16:28 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>> On 15 May 2015 at 05:42, Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>>>> wrote:
>>>>>> 2015-05-15 1:16 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>>>> On 13 May 2015 at 14:02, Krzysztof Kozlowski <k.kozlowski@samsung.com>
>>>>>>> wrote:
>>>>>>>> 2015-05-13 17:21 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>>>>>> On 13 May 2015 at 12:51, Krzysztof Kozlowski
>>>>>>>>> <k.kozlowski@samsung.com> wrote:
>>>>>>>>>> 2015-05-13 15:36 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>>>>>>>>>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3
>>>>>>>>>>> device.
>>>>>>>>>>>
>>>>>>>>>>> Tested-by: Markus Reichl <m.reichl@fivetechno.de>
>>>>>>>>>>> Acked-by: Lukasz Majewski <l.majewski@samsung.com>
>>>>>>>>>>> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
>>>>>>>>>>> ---
>>>>>>>>>>>  arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25
>>>>>>>>>>> +++++++++++++++++++++++++
>>>>>>>>>>>  1 file changed, 25 insertions(+)
>>>>>>>>>>>
>>>>>>>>>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>>> b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>>> index 9446e28..cd78816 100644
>>>>>>>>>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts
>>>>>>>>>>> @@ -319,6 +319,31 @@
>>>>>>>>>>>                 #cooling-cells = <2>;
>>>>>>>>>>>                 cooling-levels = <0 130 170 230>;
>>>>>>>>>>>         };
>>>>>>>>>>> +
>>>>>>>>>>> +       tmu at 10060000 {
>>>>>>>>>>
>>>>>>>>>> Here and for other overrides please use label notation, like:
>>>>>>>>>>
>>>>>>>>>> &tmu_cpu0 {
>>>>>>>>>>               ...
>>>>>>>>>> };
>>>>>>>>>>
>>>>>>>>>>> +               vtmu-supply = <&ldo10_reg>;
>>>>>>>>>>
>>>>>>>>>> I am curious, how did you find that LDO10 supplies TMU unit?
>>>>>>>>>>
>>>>>>>>>> Best regards,
>>>>>>>>>> Krzysztof
>>>>>>>>>
>>>>>>>>> Hi Krzysztof,
>>>>>>>>>
>>>>>>>>> I have re-base my work on earlier Lukasz Majewski patches.
>>>>>>>>>
>>>>>>>>> https://patchwork.kernel.org/patch/5693201/
>>>>>>>>
>>>>>>>> NAK.
>>>>>>>> I am sorry, but this is not sufficient explanation. Actually such
>>>>>>>> explanation could mean that you did just blindly copied everything
>>>>>>>> instead of developing it.
>>>>>>>>
>>>>>>>> You cannot use some regulator here just because some Exynos4 boards
>>>>>>>> use it. You have to be sure that this regulator supplies this part of
>>>>>>>> SoC or device.
>>>>>>>
>>>>>>> Hi Krzysztof,
>>>>>>>
>>>>>>> After going through the schematics, I came to understanding that their
>>>>>>> is
>>>>>>> missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts.
>>>>>>>
>>>>>>> Below is the schematic of the board.
>>>>>>>
>>>>>>> http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF
>>>>>>>
>>>>>>>   ldo18_reg: LDO18 {
>>>>>>>                                          regulator-name = "vdd_ldo18";
>>>>>>>                                          regulator-min-microvolt =
>>>>>>> <1800000>;
>>>>>>>                                          regulator-max-microvolt =
>>>>>>> <1800000>;
>>>>>>>                                          regulator-always-on;
>>>>>>>                                };
>>>>>>
>>>>>> The output of LDO18 goes to VDD_EMMC_1V8. This is not regulator for
>>>>>> TMU.
>>>>>>
>>>>>> I think the schematics are missing some of details but it can be
>>>>>> deducted that:
>>>>>> 1. TEMP SE is supplied by VDD18_TS power domain. It consists of 5
>>>>>> pairs of pins (XTSTEST_OUT[0-4], XTSEXT_RES[0-4]).
>>>>>> 2. The VDD18_TS01, VDD18_TS23 and VDD18_TS4 are wired to theL DO7 of
>>>>>> S2MPS11 PMIC.
>>>>>> 3. I confirmed with the Exynos5422 datasheet that these
>>>>>> VDD18_TS{01,23,4} supply the XTSTEST pins (OUT and RES).
>>>>>>
>>>>>> So the LDO7 it is... but before using it there is a caveat. The LDO7
>>>>>> is also connected to VDD of MIPI, HDMI and few more. So when you use
>>>>>> this regulator in TMU it may be turned off by TMU driver (e.g. during
>>>>>> unbind). In such case these other blocks also should be tested and
>>>>>> checked whether they take this regulator and enable it.
>>>>>
>>>>> hi Krzysztof,
>>>>>
>>>>> I tried to use the LDO7 regulator for TMU but it failed to register.
>>>>>
>>>>> [    3.231329] ina2xx 0-0045: power monitor ina231 (Rshunt = 10000 uOhm)
>>>>> [    3.237691] thermal thermal_zone0: failed to read out thermal zone
>>>>> (-22)
>>>>> [    3.243033] exynos-tmu 10060000.tmu: Looking up vtmu-supply from
>>>>> device tree
>>>>> [    3.243936] thermal thermal_zone1: failed to read out thermal zone
>>>>> (-22)
>>>>> [    3.249791] exynos-tmu 10064000.tmu: Looking up vtmu-supply from
>>>>> device tree
>>>>> [    3.250677] thermal thermal_zone2: failed to read out thermal zone
>>>>> (-22)
>>>>> [    3.256410] exynos-tmu 10068000.tmu: Looking up vtmu-supply from
>>>>> device tree
>>>>> [    3.257345] thermal thermal_zone3: failed to read out thermal zone
>>>>> (-22)
>>>>> [    3.263050] exynos-tmu 1006c000.tmu: Looking up vtmu-supply from
>>>>> device tree
>>>>> [    3.263984] thermal thermal_zone4: failed to read out thermal zone
>>>>> (-22)
>>>>> [    3.269769] exynos-tmu 100a0000.tmu: Looking up vtmu-supply from
>>>>> device tree
>>>>> [    3.270363] usb 5-1: New USB device found, idVendor=0424,
>>>>> idProduct=9514
>>>>> [    3.276389] usb 5-1: New USB device strings: Mfr=0, Product=0,
>>>>> SerialNumber=0
>>>>
>>>> Indeed.
>>>>
>>
>> Hi Krzysztof/Dongjin
>>
>> BUCK3 is option for TMU as suggested by Dongjin
>
> What do you mean by that? VDD_INT is one of important regulators. It
> supplies many parts of chip and should not be disabled during exynos-tmu
> driver removal.
>
> Of course it wouldn't because it is "always-on"... so what is the
> benefit of using it in exynos-tmu?
>
> What about regulator supplying TMU sensors? Shouldn't it be enabled? Is
> it the same?
>
> Before posting a new solution please be sure that you have sufficient
> answer for each of these questions. Anwser that "someone told me so"
> unfortunately is not sufficient :).
>
>
>
>> Earlier I have some missing CONFIG option's hence It was not working.
>> Now its registering with TMU.
>>
>> Bellow is the output device tree.
>>
>> root at odroidxu3: cd /sys/firmware/devicetree/base/
>> root at odroidxu3:/sys/firmware/devicetree/base# cat tmu at 10060000/status
>> okay
>> root at odroidxu3:/sys/firmware/devicetree/base#
>> root at odroidxu3:/sys/firmware/devicetree/base# cat tmu at 10064000/status
>> okay
>> root at odroidxu3:/sys/firmware/devicetree/base# cat tmu at 10068000/status
>> okay
>> root at odroidxu3:/sys/firmware/devicetree/base# cat tmu at 1006c000/status
>> okay
>> root at odroidxu3:/sys/firmware/devicetree/base# cat tmu at 100a0000/status
>> okay
>> root at odroidxu3:/sys/firmware/devicetree/base#
>
> If you looked at the driver then you would know, that above status does
> not mean anything for this discussion about regulator. You could use
> EMMC regulator (which you proposed) and the results would be the same.
>
> Best regards,
> Krzysztof
>

Hi Krzysztof,

I did some debugging on the this using powerdebug utility.
Using  LDO7 to control TMU seams to me correct option compared to BUCK3.

Setting LDO7 to control TMU I observed  following output on powerdebug.
I observed that the power drawn by the board on Odroid show is much
less compare to BUCK3 on the same setup.
I can see the HDMI output on Odroid-V2 display screen.
I have done some stress testing on this configuration and It worked correctly.

Powerdebug output using LDO7
---------------------------------------------------------------------------------------------------------------
PowerDebug 0.7.3     Clocks  Regulators  Sensors  Gpio
Name        Status      State       Type        Users       Microvolts
 Min u-volts Max u-volts
phy                                             0           0
 0           0
phy                                             0           0
 0           0
vdd_ldo1                enabled     voltage     0           1000000
 1000000     1000000
LDO1                                            0           0
 0           0
LDO2                    enabled     voltage     0           1800000
 0           0
vdd_ldo3                enabled     voltage     0           1800000
 1800000     1800000
LDO3                                            0           0
 0           0
LDO4                    enabled     voltage     0           1800000
 0           0
vdd_ldo5                enabled     voltage     0           1800000
 1800000     1800000
LDO5                                            0           0
 0           0
vdd_ldo6                enabled     voltage     0           1000000
 1000000     1000000
hdmi        okay                                0           0
 0           0
hdmi        okay                                0           0
 0           0
LDO6                                            0           0
 0           0
vdd_ldo7                enabled     voltage     0           1800000
 1800000     1800000
hdmi        okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
LDO7                                            0           0
 0           0
vdd_ldo8                enabled     voltage     0           1800000
 1800000     1800000
LDO8                                            0           0
 0           0
vdd_ldo9                enabled     voltage     0           3000000
 3000000     3000000
LDO9                                            0           0
 0           0

Powerdebug output using BUCK3.
--------------------------------------------------------------------------------------------------------------------------
PowerDebug 0.7.3     Clocks  Regulators  Sensors  Gpio
Name        Status      State       Type        Users       Microvolts
 Min u-volts Max u-volts
LDO21                   disabled    voltage     0           1800000
 0           0
LDO22                   disabled    voltage     0           1200000
 0           0
LDO23                   enabled     voltage     0           1100000
 0           0
tsp_io                  enabled     voltage     0           2800000
 2800000     2800000
LDO24                                           0           0
 0           0
LDO25                   disabled    voltage     0           1800000
 0           0
vdd_ldo26               enabled     voltage     0           3000000
 3000000     3000000
LDO26                                           0           0
 0           0
LDO27                   enabled     voltage     0           1000000
 0           0
LDO28                   disabled    voltage     0           3300000
 0           0
LDO29                   disabled    voltage     0           1800000
 0           0
LDO30                   disabled    voltage     0           1800000
 0           0
LDO31                   disabled    voltage     0           1800000
 0           0
LDO32                   disabled    voltage     0           1800000
 0           0
LDO33                   disabled    voltage     0           1800000
 0           0
LDO34                   disabled    voltage     0           3000000
 0           0
LDO35                   disabled    voltage     0           1600000
 0           0
LDO36                   disabled    voltage     0           1800000
 0           0
LDO37                   disabled    voltage     0           1800000
 0           0
LDO38                   disabled    voltage     0           2800000
 0           0
vdd_mif                 enabled     voltage     0           1100000
 800000      1300000
BUCK1                                           0           0
 0           0
vdd_arm                 enabled     voltage     0           1000000
 800000      1500000
BUCK2                                           0           0
 0           0
vdd_int                 enabled     voltage     0           1000000
 800000      1400000
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
tmu         okay                                0           0
 0           0
BUCK3                                           0           0
 0           0
vdd_g3d                 enabled     voltage     0           1000000
 800000      1400000
BUCK4                                           0           0
 0           0
vdd_mem                 enabled     voltage     0           1200000
 800000      1400000
BUCK5                                           0           0
 0           0
vdd_kfc                 enabled     voltage     0           1025000
 800000      1500000

So I would like to go with LDO7.

Please share your thoughts.

-Anand Moon

Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Krzysztof Kozlowski]

2015-05-24 2:35 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> Hi Krzysztof,
>
> I did some debugging on the this using powerdebug utility.
> Using  LDO7 to control TMU seams to me correct option compared to BUCK3.
>
> Setting LDO7 to control TMU I observed  following output on powerdebug.
> I observed that the power drawn by the board on Odroid show is much
> less compare to BUCK3 on the same setup.
> I can see the HDMI output on Odroid-V2 display screen.
> I have done some stress testing on this configuration and It worked correctly.
>
> Powerdebug output using LDO7
> ---------------------------------------------------------------------------------------------------------------
> PowerDebug 0.7.3     Clocks  Regulators  Sensors  Gpio
> Name        Status      State       Type        Users       Microvolts
>  Min u-volts Max u-volts
> phy                                             0           0
>  0           0
> phy                                             0           0
>  0           0
> vdd_ldo1                enabled     voltage     0           1000000
>  1000000     1000000
> LDO1                                            0           0
>  0           0
> LDO2                    enabled     voltage     0           1800000
>  0           0
> vdd_ldo3                enabled     voltage     0           1800000
>  1800000     1800000
> LDO3                                            0           0
>  0           0
> LDO4                    enabled     voltage     0           1800000
>  0           0
> vdd_ldo5                enabled     voltage     0           1800000
>  1800000     1800000
> LDO5                                            0           0
>  0           0
> vdd_ldo6                enabled     voltage     0           1000000
>  1000000     1000000
> hdmi        okay                                0           0
>  0           0
> hdmi        okay                                0           0
>  0           0
> LDO6                                            0           0
>  0           0
> vdd_ldo7                enabled     voltage     0           1800000
>  1800000     1800000
> hdmi        okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> LDO7                                            0           0
>  0           0
> vdd_ldo8                enabled     voltage     0           1800000
>  1800000     1800000
> LDO8                                            0           0
>  0           0
> vdd_ldo9                enabled     voltage     0           3000000
>  3000000     3000000
> LDO9                                            0           0
>  0           0
>
> Powerdebug output using BUCK3.
> --------------------------------------------------------------------------------------------------------------------------
> PowerDebug 0.7.3     Clocks  Regulators  Sensors  Gpio
> Name        Status      State       Type        Users       Microvolts
>  Min u-volts Max u-volts
> LDO21                   disabled    voltage     0           1800000
>  0           0
> LDO22                   disabled    voltage     0           1200000
>  0           0
> LDO23                   enabled     voltage     0           1100000
>  0           0
> tsp_io                  enabled     voltage     0           2800000
>  2800000     2800000
> LDO24                                           0           0
>  0           0
> LDO25                   disabled    voltage     0           1800000
>  0           0
> vdd_ldo26               enabled     voltage     0           3000000
>  3000000     3000000
> LDO26                                           0           0
>  0           0
> LDO27                   enabled     voltage     0           1000000
>  0           0
> LDO28                   disabled    voltage     0           3300000
>  0           0
> LDO29                   disabled    voltage     0           1800000
>  0           0
> LDO30                   disabled    voltage     0           1800000
>  0           0
> LDO31                   disabled    voltage     0           1800000
>  0           0
> LDO32                   disabled    voltage     0           1800000
>  0           0
> LDO33                   disabled    voltage     0           1800000
>  0           0
> LDO34                   disabled    voltage     0           3000000
>  0           0
> LDO35                   disabled    voltage     0           1600000
>  0           0
> LDO36                   disabled    voltage     0           1800000
>  0           0
> LDO37                   disabled    voltage     0           1800000
>  0           0
> LDO38                   disabled    voltage     0           2800000
>  0           0
> vdd_mif                 enabled     voltage     0           1100000
>  800000      1300000
> BUCK1                                           0           0
>  0           0
> vdd_arm                 enabled     voltage     0           1000000
>  800000      1500000
> BUCK2                                           0           0
>  0           0
> vdd_int                 enabled     voltage     0           1000000
>  800000      1400000
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> BUCK3                                           0           0
>  0           0
> vdd_g3d                 enabled     voltage     0           1000000
>  800000      1400000
> BUCK4                                           0           0
>  0           0
> vdd_mem                 enabled     voltage     0           1200000
>  800000      1400000
> BUCK5                                           0           0
>  0           0
> vdd_kfc                 enabled     voltage     0           1025000
>  800000      1500000
>
> So I would like to go with LDO7.
>
> Please share your thoughts.

I don't understand how grepping through /sys/class/regulator helps in
making this decision. I just don't get it. Can you please explain it
to me?

Best regards,
Krzysztof

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Krzysztof Kozlowski]

2015-05-24 2:35 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> Hi Krzysztof,
>
> I did some debugging on the this using powerdebug utility.
> Using  LDO7 to control TMU seams to me correct option compared to BUCK3.
>
> Setting LDO7 to control TMU I observed  following output on powerdebug.
> I observed that the power drawn by the board on Odroid show is much
> less compare to BUCK3 on the same setup.
> I can see the HDMI output on Odroid-V2 display screen.
> I have done some stress testing on this configuration and It worked correctly.
>
> Powerdebug output using LDO7
> ---------------------------------------------------------------------------------------------------------------
> PowerDebug 0.7.3     Clocks  Regulators  Sensors  Gpio
> Name        Status      State       Type        Users       Microvolts
>  Min u-volts Max u-volts
> phy                                             0           0
>  0           0
> phy                                             0           0
>  0           0
> vdd_ldo1                enabled     voltage     0           1000000
>  1000000     1000000
> LDO1                                            0           0
>  0           0
> LDO2                    enabled     voltage     0           1800000
>  0           0
> vdd_ldo3                enabled     voltage     0           1800000
>  1800000     1800000
> LDO3                                            0           0
>  0           0
> LDO4                    enabled     voltage     0           1800000
>  0           0
> vdd_ldo5                enabled     voltage     0           1800000
>  1800000     1800000
> LDO5                                            0           0
>  0           0
> vdd_ldo6                enabled     voltage     0           1000000
>  1000000     1000000
> hdmi        okay                                0           0
>  0           0
> hdmi        okay                                0           0
>  0           0
> LDO6                                            0           0
>  0           0
> vdd_ldo7                enabled     voltage     0           1800000
>  1800000     1800000
> hdmi        okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> LDO7                                            0           0
>  0           0
> vdd_ldo8                enabled     voltage     0           1800000
>  1800000     1800000
> LDO8                                            0           0
>  0           0
> vdd_ldo9                enabled     voltage     0           3000000
>  3000000     3000000
> LDO9                                            0           0
>  0           0
>
> Powerdebug output using BUCK3.
> --------------------------------------------------------------------------------------------------------------------------
> PowerDebug 0.7.3     Clocks  Regulators  Sensors  Gpio
> Name        Status      State       Type        Users       Microvolts
>  Min u-volts Max u-volts
> LDO21                   disabled    voltage     0           1800000
>  0           0
> LDO22                   disabled    voltage     0           1200000
>  0           0
> LDO23                   enabled     voltage     0           1100000
>  0           0
> tsp_io                  enabled     voltage     0           2800000
>  2800000     2800000
> LDO24                                           0           0
>  0           0
> LDO25                   disabled    voltage     0           1800000
>  0           0
> vdd_ldo26               enabled     voltage     0           3000000
>  3000000     3000000
> LDO26                                           0           0
>  0           0
> LDO27                   enabled     voltage     0           1000000
>  0           0
> LDO28                   disabled    voltage     0           3300000
>  0           0
> LDO29                   disabled    voltage     0           1800000
>  0           0
> LDO30                   disabled    voltage     0           1800000
>  0           0
> LDO31                   disabled    voltage     0           1800000
>  0           0
> LDO32                   disabled    voltage     0           1800000
>  0           0
> LDO33                   disabled    voltage     0           1800000
>  0           0
> LDO34                   disabled    voltage     0           3000000
>  0           0
> LDO35                   disabled    voltage     0           1600000
>  0           0
> LDO36                   disabled    voltage     0           1800000
>  0           0
> LDO37                   disabled    voltage     0           1800000
>  0           0
> LDO38                   disabled    voltage     0           2800000
>  0           0
> vdd_mif                 enabled     voltage     0           1100000
>  800000      1300000
> BUCK1                                           0           0
>  0           0
> vdd_arm                 enabled     voltage     0           1000000
>  800000      1500000
> BUCK2                                           0           0
>  0           0
> vdd_int                 enabled     voltage     0           1000000
>  800000      1400000
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> tmu         okay                                0           0
>  0           0
> BUCK3                                           0           0
>  0           0
> vdd_g3d                 enabled     voltage     0           1000000
>  800000      1400000
> BUCK4                                           0           0
>  0           0
> vdd_mem                 enabled     voltage     0           1200000
>  800000      1400000
> BUCK5                                           0           0
>  0           0
> vdd_kfc                 enabled     voltage     0           1025000
>  800000      1500000
>
> So I would like to go with LDO7.
>
> Please share your thoughts.

I don't understand how grepping through /sys/class/regulator helps in
making this decision. I just don't get it. Can you please explain it
to me?

Best regards,
Krzysztof

Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

On 24 May 2015 at 10:03, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-24 2:35 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> Hi Krzysztof,
>>
>> I did some debugging on the this using powerdebug utility.
>> Using  LDO7 to control TMU seams to me correct option compared to BUCK3.
>>
>> Setting LDO7 to control TMU I observed  following output on powerdebug.
>> I observed that the power drawn by the board on Odroid show is much
>> less compare to BUCK3 on the same setup.
>> I can see the HDMI output on Odroid-V2 display screen.
>> I have done some stress testing on this configuration and It worked correctly.
>>
>> Powerdebug output using LDO7
>> ---------------------------------------------------------------------------------------------------------------
>> PowerDebug 0.7.3     Clocks  Regulators  Sensors  Gpio
>> Name        Status      State       Type        Users       Microvolts
>>  Min u-volts Max u-volts
>> phy                                             0           0
>>  0           0
>> phy                                             0           0
>>  0           0
>> vdd_ldo1                enabled     voltage     0           1000000
>>  1000000     1000000
>> LDO1                                            0           0
>>  0           0
>> LDO2                    enabled     voltage     0           1800000
>>  0           0
>> vdd_ldo3                enabled     voltage     0           1800000
>>  1800000     1800000
>> LDO3                                            0           0
>>  0           0
>> LDO4                    enabled     voltage     0           1800000
>>  0           0
>> vdd_ldo5                enabled     voltage     0           1800000
>>  1800000     1800000
>> LDO5                                            0           0
>>  0           0
>> vdd_ldo6                enabled     voltage     0           1000000
>>  1000000     1000000
>> hdmi        okay                                0           0
>>  0           0
>> hdmi        okay                                0           0
>>  0           0
>> LDO6                                            0           0
>>  0           0
>> vdd_ldo7                enabled     voltage     0           1800000
>>  1800000     1800000
>> hdmi        okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> LDO7                                            0           0
>>  0           0
>> vdd_ldo8                enabled     voltage     0           1800000
>>  1800000     1800000
>> LDO8                                            0           0
>>  0           0
>> vdd_ldo9                enabled     voltage     0           3000000
>>  3000000     3000000
>> LDO9                                            0           0
>>  0           0
>>
>> Powerdebug output using BUCK3.
>> --------------------------------------------------------------------------------------------------------------------------
>> PowerDebug 0.7.3     Clocks  Regulators  Sensors  Gpio
>> Name        Status      State       Type        Users       Microvolts
>>  Min u-volts Max u-volts
>> LDO21                   disabled    voltage     0           1800000
>>  0           0
>> LDO22                   disabled    voltage     0           1200000
>>  0           0
>> LDO23                   enabled     voltage     0           1100000
>>  0           0
>> tsp_io                  enabled     voltage     0           2800000
>>  2800000     2800000
>> LDO24                                           0           0
>>  0           0
>> LDO25                   disabled    voltage     0           1800000
>>  0           0
>> vdd_ldo26               enabled     voltage     0           3000000
>>  3000000     3000000
>> LDO26                                           0           0
>>  0           0
>> LDO27                   enabled     voltage     0           1000000
>>  0           0
>> LDO28                   disabled    voltage     0           3300000
>>  0           0
>> LDO29                   disabled    voltage     0           1800000
>>  0           0
>> LDO30                   disabled    voltage     0           1800000
>>  0           0
>> LDO31                   disabled    voltage     0           1800000
>>  0           0
>> LDO32                   disabled    voltage     0           1800000
>>  0           0
>> LDO33                   disabled    voltage     0           1800000
>>  0           0
>> LDO34                   disabled    voltage     0           3000000
>>  0           0
>> LDO35                   disabled    voltage     0           1600000
>>  0           0
>> LDO36                   disabled    voltage     0           1800000
>>  0           0
>> LDO37                   disabled    voltage     0           1800000
>>  0           0
>> LDO38                   disabled    voltage     0           2800000
>>  0           0
>> vdd_mif                 enabled     voltage     0           1100000
>>  800000      1300000
>> BUCK1                                           0           0
>>  0           0
>> vdd_arm                 enabled     voltage     0           1000000
>>  800000      1500000
>> BUCK2                                           0           0
>>  0           0
>> vdd_int                 enabled     voltage     0           1000000
>>  800000      1400000
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> BUCK3                                           0           0
>>  0           0
>> vdd_g3d                 enabled     voltage     0           1000000
>>  800000      1400000
>> BUCK4                                           0           0
>>  0           0
>> vdd_mem                 enabled     voltage     0           1200000
>>  800000      1400000
>> BUCK5                                           0           0
>>  0           0
>> vdd_kfc                 enabled     voltage     0           1025000
>>  800000      1500000
>>
>> So I would like to go with LDO7.
>>
>> Please share your thoughts.
>
> I don't understand how grepping through /sys/class/regulator helps in
> making this decision. I just don't get it. Can you please explain it
> to me?
>
> Best regards,
> Krzysztof

Hi Krzysztof,

I am just trying to understand the how the DTS changes get mapped internally.
If their seem to be a problem with the changes, then I could figure it
out but doing some testing.

-Anand Moon

[PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base

[Anand Moon]

On 24 May 2015 at 10:03, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-24 2:35 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> Hi Krzysztof,
>>
>> I did some debugging on the this using powerdebug utility.
>> Using  LDO7 to control TMU seams to me correct option compared to BUCK3.
>>
>> Setting LDO7 to control TMU I observed  following output on powerdebug.
>> I observed that the power drawn by the board on Odroid show is much
>> less compare to BUCK3 on the same setup.
>> I can see the HDMI output on Odroid-V2 display screen.
>> I have done some stress testing on this configuration and It worked correctly.
>>
>> Powerdebug output using LDO7
>> ---------------------------------------------------------------------------------------------------------------
>> PowerDebug 0.7.3     Clocks  Regulators  Sensors  Gpio
>> Name        Status      State       Type        Users       Microvolts
>>  Min u-volts Max u-volts
>> phy                                             0           0
>>  0           0
>> phy                                             0           0
>>  0           0
>> vdd_ldo1                enabled     voltage     0           1000000
>>  1000000     1000000
>> LDO1                                            0           0
>>  0           0
>> LDO2                    enabled     voltage     0           1800000
>>  0           0
>> vdd_ldo3                enabled     voltage     0           1800000
>>  1800000     1800000
>> LDO3                                            0           0
>>  0           0
>> LDO4                    enabled     voltage     0           1800000
>>  0           0
>> vdd_ldo5                enabled     voltage     0           1800000
>>  1800000     1800000
>> LDO5                                            0           0
>>  0           0
>> vdd_ldo6                enabled     voltage     0           1000000
>>  1000000     1000000
>> hdmi        okay                                0           0
>>  0           0
>> hdmi        okay                                0           0
>>  0           0
>> LDO6                                            0           0
>>  0           0
>> vdd_ldo7                enabled     voltage     0           1800000
>>  1800000     1800000
>> hdmi        okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> LDO7                                            0           0
>>  0           0
>> vdd_ldo8                enabled     voltage     0           1800000
>>  1800000     1800000
>> LDO8                                            0           0
>>  0           0
>> vdd_ldo9                enabled     voltage     0           3000000
>>  3000000     3000000
>> LDO9                                            0           0
>>  0           0
>>
>> Powerdebug output using BUCK3.
>> --------------------------------------------------------------------------------------------------------------------------
>> PowerDebug 0.7.3     Clocks  Regulators  Sensors  Gpio
>> Name        Status      State       Type        Users       Microvolts
>>  Min u-volts Max u-volts
>> LDO21                   disabled    voltage     0           1800000
>>  0           0
>> LDO22                   disabled    voltage     0           1200000
>>  0           0
>> LDO23                   enabled     voltage     0           1100000
>>  0           0
>> tsp_io                  enabled     voltage     0           2800000
>>  2800000     2800000
>> LDO24                                           0           0
>>  0           0
>> LDO25                   disabled    voltage     0           1800000
>>  0           0
>> vdd_ldo26               enabled     voltage     0           3000000
>>  3000000     3000000
>> LDO26                                           0           0
>>  0           0
>> LDO27                   enabled     voltage     0           1000000
>>  0           0
>> LDO28                   disabled    voltage     0           3300000
>>  0           0
>> LDO29                   disabled    voltage     0           1800000
>>  0           0
>> LDO30                   disabled    voltage     0           1800000
>>  0           0
>> LDO31                   disabled    voltage     0           1800000
>>  0           0
>> LDO32                   disabled    voltage     0           1800000
>>  0           0
>> LDO33                   disabled    voltage     0           1800000
>>  0           0
>> LDO34                   disabled    voltage     0           3000000
>>  0           0
>> LDO35                   disabled    voltage     0           1600000
>>  0           0
>> LDO36                   disabled    voltage     0           1800000
>>  0           0
>> LDO37                   disabled    voltage     0           1800000
>>  0           0
>> LDO38                   disabled    voltage     0           2800000
>>  0           0
>> vdd_mif                 enabled     voltage     0           1100000
>>  800000      1300000
>> BUCK1                                           0           0
>>  0           0
>> vdd_arm                 enabled     voltage     0           1000000
>>  800000      1500000
>> BUCK2                                           0           0
>>  0           0
>> vdd_int                 enabled     voltage     0           1000000
>>  800000      1400000
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> tmu         okay                                0           0
>>  0           0
>> BUCK3                                           0           0
>>  0           0
>> vdd_g3d                 enabled     voltage     0           1000000
>>  800000      1400000
>> BUCK4                                           0           0
>>  0           0
>> vdd_mem                 enabled     voltage     0           1200000
>>  800000      1400000
>> BUCK5                                           0           0
>>  0           0
>> vdd_kfc                 enabled     voltage     0           1025000
>>  800000      1500000
>>
>> So I would like to go with LDO7.
>>
>> Please share your thoughts.
>
> I don't understand how grepping through /sys/class/regulator helps in
> making this decision. I just don't get it. Can you please explain it
> to me?
>
> Best regards,
> Krzysztof

Hi Krzysztof,

I am just trying to understand the how the DTS changes get mapped internally.
If their seem to be a problem with the changes, then I could figure it
out but doing some testing.

-Anand Moon

Re: [PATCHv5 1/5] ARM: dts: exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board

[Krzysztof Kozlowski]

2015-05-13 16:46 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> Hi Krzysztof,
>
> Will make the changes.
>
> Thanks for the review.

Hi Anand,

Do you plan to continue working on this patchset?

Best regards,
Krzysztof

[PATCHv5 1/5] ARM: dts: exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board

[Krzysztof Kozlowski]

2015-05-13 16:46 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
> Hi Krzysztof,
>
> Will make the changes.
>
> Thanks for the review.

Hi Anand,

Do you plan to continue working on this patchset?

Best regards,
Krzysztof

Re: [PATCHv5 1/5] ARM: dts: exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board

[Anand Moon]

hi Krzysztof,

I will send an update version soon.

-Anand Moon

On 14 June 2015 at 11:01, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 16:46 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> Hi Krzysztof,
>>
>> Will make the changes.
>>
>> Thanks for the review.
>
> Hi Anand,
>
> Do you plan to continue working on this patchset?
>
> Best regards,
> Krzysztof

[PATCHv5 1/5] ARM: dts: exynos5422-odroidxu3 Add pwm-fan node to the Odroid-XU3 board

[Anand Moon]

hi Krzysztof,

I will send an update version soon.

-Anand Moon

On 14 June 2015 at 11:01, Krzysztof Kozlowski <k.kozlowski@samsung.com> wrote:
> 2015-05-13 16:46 GMT+09:00 Anand Moon <linux.amoon@gmail.com>:
>> Hi Krzysztof,
>>
>> Will make the changes.
>>
>> Thanks for the review.
>
> Hi Anand,
>
> Do you plan to continue working on this patchset?
>
> Best regards,
> Krzysztof