From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anand Moon Date: Tue, 31 Jul 2018 23:40:10 +0530 Subject: [U-Boot] [PATCH v1 9/9] ARM: Odroid XU3: Modify Odroid XU3 config to boot by default from SD card In-Reply-To: <20180727115623.7708763d@jawa> References: <20180725222552.3450-1-lukma@denx.de> <20180725222552.3450-10-lukma@denx.de> <20180726175323.316d9a30@jawa> <20180727102410.37621bb8@jawa> <20180727115623.7708763d@jawa> Message-ID: List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Hi Lukasz, On 27 July 2018 at 15:26, Lukasz Majewski wrote: > On Fri, 27 Jul 2018 14:42:32 +0530 > Anand Moon wrote: > >> Hi Lukasz, >> >> On 27 July 2018 at 13:54, Lukasz Majewski wrote: >> > On Fri, 27 Jul 2018 08:34:15 +0530 >> > Anand Moon wrote: >> > >> >> Hi Lukasz, >> >> >> >> On 26 July 2018 at 21:23, Lukasz Majewski wrote: >> >> > Hi Anand, >> >> > >> >> >> Hi Lukasz, >> >> >> >> >> >> On 26 July 2018 at 03:55, Lukasz Majewski >> >> >> wrote: >> >> >> > This commit allows by default booting Odroid XU3 from the SD >> >> >> > card (when e.g. eMMC module is not present). >> >> >> > >> >> >> > Signed-off-by: Lukasz Majewski >> >> >> > >> >> >> > --- >> >> >> > >> >> >> > include/configs/odroid_xu3.h | 7 +++++-- >> >> >> > 1 file changed, 5 insertions(+), 2 deletions(-) >> >> >> > >> >> >> > diff --git a/include/configs/odroid_xu3.h >> >> >> > b/include/configs/odroid_xu3.h index >> >> >> > f495f6219ba9..818a06515cb2 100644 --- >> >> >> > a/include/configs/odroid_xu3.h +++ >> >> >> > b/include/configs/odroid_xu3.h @@ -94,6 +94,9 @@ >> >> >> > #undef CONFIG_SYS_BOARD >> >> >> > #define CONFIG_SYS_BOARD "odroid" >> >> >> > >> >> >> > +#undef CONFIG_SYS_MMC_ENV_DEV >> >> >> > +#define CONFIG_SYS_MMC_ENV_DEV 2 >> >> >> > + >> >> >> > /* Define new extra env settings, including DFU settings */ >> >> >> > #undef CONFIG_EXTRA_ENV_SETTINGS >> >> >> > #define CONFIG_EXTRA_ENV_SETTINGS \ >> >> >> > @@ -105,8 +108,8 @@ >> >> >> > "console=" CONFIG_DEFAULT_CONSOLE "\0"\ >> >> >> > "fdtfile=exynos5422-odroidxu3.dtb\0" \ >> >> >> > "boardname=odroidxu3\0" \ >> >> >> > - "mmcbootdev=0\0" \ >> >> >> > - "mmcrootdev=0\0" \ >> >> >> > + "mmcbootdev=2\0" \ >> >> >> > + "mmcrootdev=1\0" \ >> >> >> > "mmcbootpart=1\0" \ >> >> >> > "mmcrootpart=2\0" \ >> >> >> > "dfu_alt_system="CONFIG_DFU_ALT_SYSTEM \ >> >> >> > -- >> >> >> > 2.11.0 >> >> >> > >> >> >> >> >> >> This changes probably breaks the booting from eMMC on >> >> >> Odroid-XU4 >> >> > >> >> > I suppose, that XU4 is also equipped with SD card slot as XU3. >> >> > >> >> > Nonetheless, as I don't have eMMC card for mine XU3, the only >> >> > way to boot my device is SD card. >> >> > >> >> > If you believe that this may be a problem, then I can drop this >> >> > patch. >> >> > >> >> > Have you checked patches from 1-8? >> >> > Does it work for you? If yes, please send tested-by tag. >> >> > >> >> >> >> Yes you probably need to drop this patch, >> >> I had some tough time recovering my eMMC back to flash new u-boot. >> >> >> >> I have tested my eMMC with default boot.scr its boot good. >> >> Need to modify the boot.scr to boot into SD card. >> > >> > SD card has different layout than eMMC. >> > >> > Despite above - you just shall need to apply patch 9/9 to get the >> > board running from SD card. >> > >> >> Actually SD card are easy to modify and tune with just adding >> setenv mmcrootdev "1" to autoboot.cmd from sdcard. >> >> but with eMMC module it's bit difficult to make this work, > > Ach.... Ok, I see > > The problem is when you have both attached - the eMMC and SD card. > > In that case I always thought that one shall boot from eMMC and the SD > card shall be used as an extra storage space. > > Also, please keep in mind that IIRC the ROM first tries to boot from > eMMC, so you need BL1, u-boot placed there if it is present. > Can we create a different board initialization file to fine tune the odroid xu3 platform. for example Odroid U3 has # board/samsung/odroid/odroid.c where we can initialize for Odroid XU3 platform boards with following features. board_clock_init board_gpio_init exynos_power_init board_usb_init board_leds Best Regards -Anand