From mboxrd@z Thu Jan 1 00:00:00 1970 From: Anand Moon Subject: Re: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base Date: Thu, 14 May 2015 21:46:17 +0530 Message-ID: References: <1431499020-3912-1-git-send-email-linux.amoon@gmail.com> <1431499020-3912-3-git-send-email-linux.amoon@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Return-path: In-Reply-To: Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Krzysztof Kozlowski Cc: Lukasz Majewski , Guenter Roeck , Markus Reichl , Eduardo Valentin , Sjoerd Simons , Russell King , Kukjin Kim , devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, "linux-samsung-soc-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: devicetree@vger.kernel.org On 13 May 2015 at 14:02, Krzysztof Kozlowski wrote: > 2015-05-13 17:21 GMT+09:00 Anand Moon : >> On 13 May 2015 at 12:51, Krzysztof Kozlowski wrote: >>> 2015-05-13 15:36 GMT+09:00 Anand Moon : >>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3 >>>> device. >>>> >>>> Tested-by: Markus Reichl >>>> Acked-by: Lukasz Majewski >>>> Signed-off-by: Anand Moon >>>> --- >>>> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++ >>>> 1 file changed, 25 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts >>>> index 9446e28..cd78816 100644 >>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts >>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts >>>> @@ -319,6 +319,31 @@ >>>> #cooling-cells = <2>; >>>> cooling-levels = <0 130 170 230>; >>>> }; >>>> + >>>> + tmu@10060000 { >>> >>> Here and for other overrides please use label notation, like: >>> >>> &tmu_cpu0 { >>> ... >>> }; >>> >>>> + vtmu-supply = <&ldo10_reg>; >>> >>> I am curious, how did you find that LDO10 supplies TMU unit? >>> >>> Best regards, >>> Krzysztof >> >> Hi Krzysztof, >> >> I have re-base my work on earlier Lukasz Majewski patches. >> >> https://patchwork.kernel.org/patch/5693201/ > > NAK. > I am sorry, but this is not sufficient explanation. Actually such > explanation could mean that you did just blindly copied everything > instead of developing it. > > You cannot use some regulator here just because some Exynos4 boards > use it. You have to be sure that this regulator supplies this part of > SoC or device. Hi Krzysztof, After going through the schematics, I came to understanding that their is missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts. Below is the schematic of the board. http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF ldo18_reg: LDO18 { regulator-name = "vdd_ldo18"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; }; Please share your thought on this. -Anand Moon -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 From: linux.amoon@gmail.com (Anand Moon) Date: Thu, 14 May 2015 21:46:17 +0530 Subject: [PATCHv5 2/5] ARM: dts: Odroid-XU3 Enable TMU at Exynos5422 base In-Reply-To: References: <1431499020-3912-1-git-send-email-linux.amoon@gmail.com> <1431499020-3912-3-git-send-email-linux.amoon@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 13 May 2015 at 14:02, Krzysztof Kozlowski wrote: > 2015-05-13 17:21 GMT+09:00 Anand Moon : >> On 13 May 2015 at 12:51, Krzysztof Kozlowski wrote: >>> 2015-05-13 15:36 GMT+09:00 Anand Moon : >>>> This changes enables TMU IP block on the Exynos5422 Odroid-XU3 >>>> device. >>>> >>>> Tested-by: Markus Reichl >>>> Acked-by: Lukasz Majewski >>>> Signed-off-by: Anand Moon >>>> --- >>>> arch/arm/boot/dts/exynos5422-odroidxu3.dts | 25 +++++++++++++++++++++++++ >>>> 1 file changed, 25 insertions(+) >>>> >>>> diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts >>>> index 9446e28..cd78816 100644 >>>> --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts >>>> +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts >>>> @@ -319,6 +319,31 @@ >>>> #cooling-cells = <2>; >>>> cooling-levels = <0 130 170 230>; >>>> }; >>>> + >>>> + tmu at 10060000 { >>> >>> Here and for other overrides please use label notation, like: >>> >>> &tmu_cpu0 { >>> ... >>> }; >>> >>>> + vtmu-supply = <&ldo10_reg>; >>> >>> I am curious, how did you find that LDO10 supplies TMU unit? >>> >>> Best regards, >>> Krzysztof >> >> Hi Krzysztof, >> >> I have re-base my work on earlier Lukasz Majewski patches. >> >> https://patchwork.kernel.org/patch/5693201/ > > NAK. > I am sorry, but this is not sufficient explanation. Actually such > explanation could mean that you did just blindly copied everything > instead of developing it. > > You cannot use some regulator here just because some Exynos4 boards > use it. You have to be sure that this regulator supplies this part of > SoC or device. Hi Krzysztof, After going through the schematics, I came to understanding that their is missing regulator related to TEMP SE in the exynos5422-odroidxu3.dts. Below is the schematic of the board. http://dn.odroid.com/5422/ODROID-XU3/Schematics/XU3_MAIN_REV0.2.PDF ldo18_reg: LDO18 { regulator-name = "vdd_ldo18"; regulator-min-microvolt = <1800000>; regulator-max-microvolt = <1800000>; regulator-always-on; }; Please share your thought on this. -Anand Moon