From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E2584C2D0C2 for ; Sat, 7 Dec 2019 05:08:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B746A206DB for ; Sat, 7 Dec 2019 05:08:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e/7O6x16" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726553AbfLGFIC (ORCPT ); Sat, 7 Dec 2019 00:08:02 -0500 Received: from mail-io1-f47.google.com ([209.85.166.47]:40143 "EHLO mail-io1-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725280AbfLGFIC (ORCPT ); Sat, 7 Dec 2019 00:08:02 -0500 Received: by mail-io1-f47.google.com with SMTP id x1so9507293iop.7; Fri, 06 Dec 2019 21:08:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WZjCU4j3sL53untxnLZNdDSh0qNqfLN8e+bQHEuZ5dE=; b=e/7O6x16LI/cuCQ9VTwPI5Qk6hyKut98AIxqbVAVLXFnPUZszlL1F8MV0zeOlzDw98 HNsphd3/kuZeVUnk/l+0GmPBjf3+I51JSETHKJ5xNFY202XDoSOAIsX0gWRf/m7vu3Xq kMmZ2dECX7IZhWY9XsT+MbFZCfSxV9drsJHQUEd+wbcl5J3b7Lo/a8seWTM7Yq3dzOsP U9oQc4brO84vwhqY+ZCjjwQ1qi2dc8fnhzkTFfZeHrPLoO7umCQtmN5/Kbz8MZ5tlSON rnwU7Z5V8M3R6LRjkh3sGIAllgXm1L8stfF4hlxW/dyYp8s2KF5q91MoguFmdFMmmYeH 6ohg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WZjCU4j3sL53untxnLZNdDSh0qNqfLN8e+bQHEuZ5dE=; b=nYolNh/94vzHhutV3XTnJM1eDurxog4C4QxXMYNmHQjsSjo6AxWWSLZCwbLbHENbkg /QWYx2R2x7aCaSi+OLRZP9Azz3LzUDPgomsiJsAnCJHXHMFkXB8D0Y8+SuZUHTvw20Zs MZR4cfahhNFJuSWALOXMlvvdFq9fxgNUf3316MilEcqsbe1xjVqkaQzIfWEJy7fA01ar AU0PfRZTyq3Wz1Yd1Mss/Og98E8S9JWcAhIr9ACvud/WLdsIqy0aby51jGG3ny3DDu5e 9CCsmYb2f2TtGMba9cUP5q7No3wH8c9lSJqxsU6iycyuwfurMF5zqUA6zZSTQAtWlzET LxZg== X-Gm-Message-State: APjAAAUnsjQ8qiPyQCmpVpG8vzlxk8t2vihPH1lOkTL5yYvOhqitgEBf beIPcTAQ+//8tMo8qYyjaoyevP+E5Mq+MGJ9twM= X-Google-Smtp-Source: APXvYqyhs07MAWwbyQaZm+/Kp7saX8qenn+0uk1OjJl5k3oO2GPkxDDzBSxlGDoe37fLgle+eEbXq0/21fu5UFYXzcs= X-Received: by 2002:a5e:9314:: with SMTP id k20mr8633311iom.6.1575695281133; Fri, 06 Dec 2019 21:08:01 -0800 (PST) MIME-Version: 1.0 References: <20191206184536.2507-1-linux.amoon@gmail.com> <1765889.rfqrfT1PbY@phil> In-Reply-To: <1765889.rfqrfT1PbY@phil> From: Anand Moon Date: Sat, 7 Dec 2019 10:37:49 +0530 Message-ID: Subject: Re: [RFCv1 0/8] RK3399 clean shutdown issue To: Heiko Stuebner Cc: Rob Herring , Mark Rutland , Jagan Teki , Manivannan Sadhasivam , Robin Murphy , Daniel Schultz , devicetree , linux-arm-kernel , linux-rockchip@lists.infradead.org, Linux Kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Heiko, On Sat, 7 Dec 2019 at 04:02, Heiko Stuebner wrote: > > Hi Anand, > > Am Freitag, 6. Dezember 2019, 19:45:28 CET schrieb Anand Moon: > > Most of the RK3399 SBC boards do not perform clean > > shutdown and clean reboot. > > > > These patches try to help resolve the issue with proper > > shutdown by turning off the PMIC. > > > > For reference > > RK805 PMCI data sheet: > > [0] http://rockchip.fr/RK805%20datasheet%20V1.3.pdf > > RK808 PMIC data sheet: > > [1] http://rockchip.fr/RK808%20datasheet%20V1.4.pdf > > RK817 PMIC data sheet: > > [2] http://rockchip.fr/RK817%20datasheet%20V1.01.pdf > > RK818 PMIC data sheet: > > [3] http://rockchip.fr/RK818%20datasheet%20V1.0.pdf > > > > Reboot issue: > > My guess is that we need to some proper sequence of > > setting to PMCI to perform clean. > > > > If you have any input please share them. > > The rk8xx pmics may not on all devices be responsible for powering down > the device. That is what the system-power-controller dt-property is for. > > So that property is there for a reason - to indicate that the pmic is > responsible for power-off-handling. > > Heiko > Ok, my intent was to have common framework for shutdown, restart, suspend, resume routines. -Anand From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.5 required=3.0 tests=DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E5B5C43603 for ; Sat, 7 Dec 2019 05:08:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F20A206DB for ; Sat, 7 Dec 2019 05:08:08 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="qJ2NFx/u"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="e/7O6x16" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0F20A206DB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=W75EPlTEZqFhjy4yUoPFfAGmUpkdjrRb9nPIv0E8vxc=; b=qJ2NFx/ueh9f1X 4whUC4h16ZvmhXhHRQzLdmUPVDbo0Tc9pEGZ4lhuKTTsMr2mUKNAW+n2Ibo6O9Zsd6tk5L6FA5dPX XfLj3SBh0wGwN0+ry/giS4sFSPuHCn9fclzE3vVCS/QkzwszykLjIl+Wf68yg1Qg97aZMfjAQzz8Y AQLhogcnfgWlugIeBCVe58qKaCaCul3U37R6QNEoaNcRY34QoymgFaFeUiskFng8///Ack9S8zMO0 hqw7732PYJYqPabeTpjA+oDPzKnw5DTk+BtZmcosjYNnQG5G7JKDZZiffXaU9bGYTi6MopzBJMf9u BJVE8oEc0FdDPXbwX1mw==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1idSK6-0007dY-TZ; Sat, 07 Dec 2019 05:08:06 +0000 Received: from mail-io1-xd30.google.com ([2607:f8b0:4864:20::d30]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1idSK4-0007cj-8U; Sat, 07 Dec 2019 05:08:05 +0000 Received: by mail-io1-xd30.google.com with SMTP id c16so9512681ioh.6; Fri, 06 Dec 2019 21:08:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WZjCU4j3sL53untxnLZNdDSh0qNqfLN8e+bQHEuZ5dE=; b=e/7O6x16LI/cuCQ9VTwPI5Qk6hyKut98AIxqbVAVLXFnPUZszlL1F8MV0zeOlzDw98 HNsphd3/kuZeVUnk/l+0GmPBjf3+I51JSETHKJ5xNFY202XDoSOAIsX0gWRf/m7vu3Xq kMmZ2dECX7IZhWY9XsT+MbFZCfSxV9drsJHQUEd+wbcl5J3b7Lo/a8seWTM7Yq3dzOsP U9oQc4brO84vwhqY+ZCjjwQ1qi2dc8fnhzkTFfZeHrPLoO7umCQtmN5/Kbz8MZ5tlSON rnwU7Z5V8M3R6LRjkh3sGIAllgXm1L8stfF4hlxW/dyYp8s2KF5q91MoguFmdFMmmYeH 6ohg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WZjCU4j3sL53untxnLZNdDSh0qNqfLN8e+bQHEuZ5dE=; b=LMFai1iPAetOd8WDOK0S1ost2wD9PRtLFYh9tIkU1Cp4edVhb9Z3tdjHaWOyBaiG2s X16F42w6QlAB15fvX6jUteonBTiPybikjrTPnhHqp3WEOp0AVL05u33WuVxUNxhLMnBb z7yMPmo3hmm+ABWz9EeWYeopEcSaaSkVidN7kqSZizRbB1mtiyKRZn0EgCiHWUM2AOxS NV+svqi9BDiWAFMNYVPy+aJ42N3P84/ubM5OEK0oSPAt3uzdaqFZTOs65ds7mxBWfHSt Ttt+fl1srtCYkbAQCxQcVyxP8YkYiFwim4+97H0bSW1S58cFKX/3JQROrl81FTSFr41j sMIw== X-Gm-Message-State: APjAAAVLfwj4gdYeFs189iDnAI0DG3kA9GaPQZJcacrFPtUcGHLx2DUY c2xzsYDJUvi4cJr58ST4lAZR3VbhK5JMWLmOuZg= X-Google-Smtp-Source: APXvYqyhs07MAWwbyQaZm+/Kp7saX8qenn+0uk1OjJl5k3oO2GPkxDDzBSxlGDoe37fLgle+eEbXq0/21fu5UFYXzcs= X-Received: by 2002:a5e:9314:: with SMTP id k20mr8633311iom.6.1575695281133; Fri, 06 Dec 2019 21:08:01 -0800 (PST) MIME-Version: 1.0 References: <20191206184536.2507-1-linux.amoon@gmail.com> <1765889.rfqrfT1PbY@phil> In-Reply-To: <1765889.rfqrfT1PbY@phil> From: Anand Moon Date: Sat, 7 Dec 2019 10:37:49 +0530 Message-ID: Subject: Re: [RFCv1 0/8] RK3399 clean shutdown issue To: Heiko Stuebner X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191206_210804_325344_C53EB7A6 X-CRM114-Status: GOOD ( 13.03 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree , Daniel Schultz , Linux Kernel , linux-rockchip@lists.infradead.org, Rob Herring , Jagan Teki , Manivannan Sadhasivam , Robin Murphy , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Heiko, On Sat, 7 Dec 2019 at 04:02, Heiko Stuebner wrote: > > Hi Anand, > > Am Freitag, 6. Dezember 2019, 19:45:28 CET schrieb Anand Moon: > > Most of the RK3399 SBC boards do not perform clean > > shutdown and clean reboot. > > > > These patches try to help resolve the issue with proper > > shutdown by turning off the PMIC. > > > > For reference > > RK805 PMCI data sheet: > > [0] http://rockchip.fr/RK805%20datasheet%20V1.3.pdf > > RK808 PMIC data sheet: > > [1] http://rockchip.fr/RK808%20datasheet%20V1.4.pdf > > RK817 PMIC data sheet: > > [2] http://rockchip.fr/RK817%20datasheet%20V1.01.pdf > > RK818 PMIC data sheet: > > [3] http://rockchip.fr/RK818%20datasheet%20V1.0.pdf > > > > Reboot issue: > > My guess is that we need to some proper sequence of > > setting to PMCI to perform clean. > > > > If you have any input please share them. > > The rk8xx pmics may not on all devices be responsible for powering down > the device. That is what the system-power-controller dt-property is for. > > So that property is there for a reason - to indicate that the pmic is > responsible for power-off-handling. > > Heiko > Ok, my intent was to have common framework for shutdown, restart, suspend, resume routines. -Anand _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel