All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anand Moon <linux.amoon@gmail.com>
To: u-boot@lists.denx.de
Subject: [PATCH 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error
Date: Tue, 27 Apr 2021 11:10:48 +0530	[thread overview]
Message-ID: <CANAwSgTzO=U39NQQoBLMKVt-Mr+XGL2hBZf_8U6ZvNEADYGm5A@mail.gmail.com> (raw)
In-Reply-To: <YIceT3aCa7ZRuvK3@mone.fritz.box>

Hi Patrick,

On Tue, 27 Apr 2021 at 01:40, Patrick Wildt <patrick@blueri.se> wrote:
>
> Am Mon, Apr 26, 2021 at 01:26:30PM +0000 schrieb Anand Moon:
> > Use the Error values that may be returned by PCI functions
> > Added the error macro from linux/include/linux/pci.h
> >
> > drivers/pci/pcie_dw_rockchip.c: In function 'rk_pcie_read':
> > drivers/pci/pcie_dw_rockchip.c:70:10: error: 'PCIBIOS_UNSUPPORTED'
> >                       undeclared (first use in this function)
> >    70 |   return PCIBIOS_UNSUPPORTED;
> >       |          ^~~~~~~~~~~~~~~~~~~
> > drivers/pci/pcie_dw_rockchip.c: In function 'rk_pcie_write':
> > drivers/pci/pcie_dw_rockchip.c:90:10: error: 'PCIBIOS_UNSUPPORTED'
> >                       undeclared (first use in this function)
> >    90 |   return PCIBIOS_UNSUPPORTED;
> >       |          ^~~~~~~~~~~~~~~~~~~
> >
> > Cc: Neil Armstrong <narmstrong@baylibre.com>
> > Cc: Kever Yang <kever.yang@rock-chips.com>
> > Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> > ---
> >  drivers/pci/pcie_dw_common.h   | 9 +++++++++
> >  drivers/pci/pcie_dw_rockchip.c | 4 ++--
> >  2 files changed, 11 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/pci/pcie_dw_common.h b/drivers/pci/pcie_dw_common.h
> > index 6b701645af..ba5feb5b51 100644
> > --- a/drivers/pci/pcie_dw_common.h
> > +++ b/drivers/pci/pcie_dw_common.h
> > @@ -90,6 +90,15 @@
> >  #define PCIE_MISC_CONTROL_1_OFF              0x8bc
> >  #define PCIE_DBI_RO_WR_EN            BIT(0)
> >
> > +/* Error values that may be returned by PCI functions */
> > +#define PCIBIOS_SUCCESSFUL              0x00
> > +#define PCIBIOS_FUNC_NOT_SUPPORTED      0x81
> > +#define PCIBIOS_BAD_VENDOR_ID           0x83
> > +#define PCIBIOS_DEVICE_NOT_FOUND        0x86
> > +#define PCIBIOS_BAD_REGISTER_NUMBER     0x87
> > +#define PCIBIOS_SET_FAILED              0x88
> > +#define PCIBIOS_BUFFER_TOO_SMALL        0x89
> > +
> >  /* Parameters for the waiting for iATU enabled routine */
> >  #define LINK_WAIT_MAX_IATU_RETRIES   5
> >  #define LINK_WAIT_IATU                       10000
> > diff --git a/drivers/pci/pcie_dw_rockchip.c b/drivers/pci/pcie_dw_rockchip.c
> > index bc22af4230..9702b40019 100644
> > --- a/drivers/pci/pcie_dw_rockchip.c
> > +++ b/drivers/pci/pcie_dw_rockchip.c
> > @@ -67,7 +67,7 @@ static int rk_pcie_read(void __iomem *addr, int size, u32 *val)
> >  {
> >       if ((uintptr_t)addr & (size - 1)) {
> >               *val = 0;
> > -             return PCIBIOS_UNSUPPORTED;
> > +             return PCIBIOS_BAD_REGISTER_NUMBER;
>
> Since this function seems to return normal error code, why not use
> -EINVAL?  Or even better -EOPNOTSUP?  The callers only check for != 0
> anyway.
>

Thanks for your review comments.
-EOPNOTSUPP It seems to be the correct return code over here.


-Anand

  reply	other threads:[~2021-04-27  5:40 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-26 13:26 Anand Moon
2021-04-26 13:26 ` [PATCH 2/3] pci: pcie_dw_rockchip: Drop the unused variable warning Anand Moon
2021-05-21 13:21   ` Kever Yang
2021-04-26 13:26 ` [PATCH 3/3] pci: pcie_dw_rockchip: Use udelay instead of msleep Anand Moon
2021-04-26 20:08   ` Patrick Wildt
2021-04-27  5:41     ` Anand Moon
2021-04-27 19:27       ` Patrick Wildt
2021-05-06 18:40         ` Anand Moon
2021-05-21 13:20   ` Kever Yang
2021-04-26 20:10 ` [PATCH 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error Patrick Wildt
2021-04-27  5:40   ` Anand Moon [this message]
2021-05-21 13:21 ` Kever Yang
2021-05-21 16:58   ` Anand Moon

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANAwSgTzO=U39NQQoBLMKVt-Mr+XGL2hBZf_8U6ZvNEADYGm5A@mail.gmail.com' \
    --to=linux.amoon@gmail.com \
    --cc=u-boot@lists.denx.de \
    --subject='Re: [PATCH 1/3] pci: pcie_dw_rockchip: Fixed the below compilation error' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.