From: Emil Renner Berthing <kernel@esmil.dk>
To: Randy Dunlap <rdunlap@infradead.org>, Arnd Bergmann <arnd@kernel.org>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Linux Next Mailing List <linux-next@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Philipp Zabel <p.zabel@pengutronix.de>
Subject: Re: linux-next: Tree for Dec 17 (drivers/reset/reset-starfive-jh7100.c)
Date: Fri, 17 Dec 2021 22:53:26 +0100 [thread overview]
Message-ID: <CANBLGcynOdjJDS45YwMPZQ+MuYHf4w-rQ5GixokLyvuZ4ZM4vQ@mail.gmail.com> (raw)
In-Reply-To: <eff1f8d6-ec12-42c7-d869-8fbd9e3a560d@infradead.org>
Hi Randy,
On Fri, 17 Dec 2021 at 22:48, Randy Dunlap <rdunlap@infradead.org> wrote:
> On 12/17/21 05:33, Stephen Rothwell wrote:
> > Hi all,
> >
> > Changes since 20211216:
> >
>
> on i386:
>
> ../drivers/reset/reset-starfive-jh7100.c: In function ‘jh7100_reset_update’:
> ../drivers/reset/reset-starfive-jh7100.c:81:10: error: implicit declaration of function ‘readq’; did you mean ‘readl’? [-Werror=implicit-function-declaration]
> value = readq(reg_assert);
> ^~~~~
> ../drivers/reset/reset-starfive-jh7100.c:86:2: error: implicit declaration of function ‘writeq’; did you mean ‘writel’? [-Werror=implicit-function-declaration]
> writeq(value, reg_assert);
> ^~~~~~
Yes, It needs to include <linux/io-64-nonatomic-lo-hi.h> for compile
testing to work on 32bit architectures without readq.
Arnd: Do I just send a patch or do I redo the pull-request?
/Emil
prev parent reply other threads:[~2021-12-17 21:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-17 13:33 linux-next: Tree for Dec 17 Stephen Rothwell
2021-12-17 21:25 ` linux-next: Tree for Dec 17 (drivers/reset/reset-starfive-jh7100.c) Randy Dunlap
2021-12-17 21:53 ` Emil Renner Berthing [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANBLGcynOdjJDS45YwMPZQ+MuYHf4w-rQ5GixokLyvuZ4ZM4vQ@mail.gmail.com \
--to=kernel@esmil.dk \
--cc=arnd@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rdunlap@infradead.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.