From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id AFF72C77B72 for ; Wed, 12 Apr 2023 14:15:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231548AbjDLOPC (ORCPT ); Wed, 12 Apr 2023 10:15:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45062 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231522AbjDLOPA (ORCPT ); Wed, 12 Apr 2023 10:15:00 -0400 Received: from mail-vs1-xe33.google.com (mail-vs1-xe33.google.com [IPv6:2607:f8b0:4864:20::e33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 349B419C; Wed, 12 Apr 2023 07:14:59 -0700 (PDT) Received: by mail-vs1-xe33.google.com with SMTP id e20so10506680vsj.10; Wed, 12 Apr 2023 07:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681308898; x=1683900898; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tz0zRW94Z/hmkdTJSfqG3WhRFcEFleZV0tRiJIInS+o=; b=P7XSviNYBBN4/cBFWoeR8Bo2jx+nVtrKpzKhddaicAm0flKyF+IzsIrxZzM3vtGWtO 0KdRlgaZm9KNWQRy28Uu47HtjY6gZ8iNET7syOuICPuOozzSSGw2IKRYIZNDwHVkixxR JUfFLdN8lZBYEE+URai9CavDuTmZK/TLlF2JVLBxNt87gllBTW/FehgBv8jo1yK32vUZ IqSdcv+yf2QVoRwMrB6FtM7/Zk2SMupZlsAt+t6Ojenr3HO1ezkZ+trZmJDedEfr5NPM c4iTyz7pTk6bZYITPqvAHLXBnEK4KfYwGbqGKOCZncsa1X6dNYY0eVqmATBsCJp4ar3l dChw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681308898; x=1683900898; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tz0zRW94Z/hmkdTJSfqG3WhRFcEFleZV0tRiJIInS+o=; b=ID9cVQKz9WNhq5ww1tZBMrMjcIdwaOLSjmBLyP9uphtvocc8+My0beu8o0eYF6vDBR OZ38QV/35FDrXhOwmD0MrMzEiawqCxWDRts2c19qc67mXsRPOgzCubEpA0BzIePOlsCl 9FUIcIvPQ9FrEnSxqOuLRq40YHUc7yxy93X1LefOCVAZSetMBtCDCWY16gkeU4hNo01t 5F8hsi8oc4QyeT4S9d5peSZsgdmbb9iApV2EsOhRgwDdXBaVuZJU/4zJXm2pbJExVudz XGalx1ClWHnjKAz4zy5I9oHF6tul3ulbb1jL6AxTO+j4pA9Sdl7lwg9U8iMzO+PUR68E SnBA== X-Gm-Message-State: AAQBX9e1N0Gk/HwiB+hIe3QctD7IVZ4VOSQQNH/f2tD7/fKgQ4LWBxhd 9zOy4oLYdsskKfptLQO2LweGUviSjR6OTy9YlEU= X-Google-Smtp-Source: AKy350avWMjBT0JOfHwbQHUPSOKOOj9paUb8BFRtQEd7/VdSYxRrFONuSauNTrFOpHN5ZBgIyAv1a8jmw5b/tp4wE9A= X-Received: by 2002:a67:c311:0:b0:42c:9733:de2f with SMTP id r17-20020a67c311000000b0042c9733de2fmr1002823vsj.6.1681308898270; Wed, 12 Apr 2023 07:14:58 -0700 (PDT) MIME-Version: 1.0 References: <20230411165919.23955-1-jim2101024@gmail.com> <20230411165919.23955-2-jim2101024@gmail.com> <5a28e520-63e4-dbcf-5b3e-e5097f02dea2@linaro.org> <78c18cdb-5757-8d30-e2a6-414f09505cc6@gmail.com> <66b7d0b9-9569-ddaf-89ca-5a0133074a17@linaro.org> In-Reply-To: <66b7d0b9-9569-ddaf-89ca-5a0133074a17@linaro.org> From: Jim Quinlan Date: Wed, 12 Apr 2023 10:14:46 -0400 Message-ID: Subject: Re: [PATCH v2 1/3] dt-bindings: PCI: brcmstb: Add two optional props To: Krzysztof Kozlowski Cc: Florian Fainelli , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 12, 2023 at 7:56=E2=80=AFAM Krzysztof Kozlowski wrote: > > On 12/04/2023 13:49, Florian Fainelli wrote: > > > > > > On 4/12/2023 1:09 AM, Krzysztof Kozlowski wrote: > >> On 11/04/2023 18:59, Jim Quinlan wrote: > >>> Regarding "brcm,enable-l1ss": > >>> > >>> The Broadcom STB/CM PCIe HW -- a core that is also used by RPi SOC= s -- > >>> requires the driver probe() to deliberately place the HW one of th= ree > >>> CLKREQ# modes: > >>> > >>> (a) CLKREQ# driven by the RC unconditionally > >>> (b) CLKREQ# driven by the EP for ASPM L0s, L1 > >>> (c) Bidirectional CLKREQ#, as used for L1 Substates (L1SS). > >>> > >>> The HW+driver can tell the difference between downstream devices t= hat > >>> need (a) and (b), but does not know when to configure (c). Furthe= r, the > >>> HW may cause a CPU abort on boot if guesses wrong regarding the ne= ed for > >>> (c). So we introduce the boolean "brcm,enable-l1ss" property to i= ndicate > >>> that (c) is desired. Setting this property only makes sense when = the > >>> downstream device is L1SS-capable and the OS is configured to acti= vate > >>> this mode (e.g. policy=3D=3Dsuperpowersave). > >>> > >>> This property is already present in the Raspian version of Linux, = but the > >>> upstream driver implementaion that will follow adds more details a= nd > >> > >> typo, implementation > >> > >>> discerns between (a) and (b). > >>> > >>> Regarding "brcm,completion-timeout-us" > >>> > >>> Our HW will cause a CPU abort if the L1SS exit time is longer than= the > >>> PCIe transaction completion abort timeout. We've been asked to ma= ke this > >>> configurable, so we are introducing "brcm,completion-timeout-us". > >>> > >>> Signed-off-by: Jim Quinlan > >> > >> What happened here? Where is the changelog? > > > > It is in the cover letter: > > > > https://lore.kernel.org/all/20230411165919.23955-1-jim2101024@gmail.com= / > > > > but it does not look like the cover letter was copied to you or Rob. > > As you said, I did not get it. Yes, sorry about that; I use a wrapper over the "cocci_cc" script and I need to modify one or both scripts to send the cover to the superset of recipients in the constituent commits. Regards, Jim Quinan Broadcom STB > > Best regards, > Krzysztof > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8862EC7619A for ; Wed, 12 Apr 2023 14:15:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QsOHdskw2RNqdWWbLbyPSmjulqpu7iGreKrfoviDyYE=; b=vsLlWt+EY6pz+g /jGmAhzgdLdZz26yhMkVGygdsR8vR1gnwohfsoQSXVyLZNi7dfrVmIRVE2+fbS+s+BembR6tmnaq/ xC5P3fCQ6VSXx0jWR3iKWZgjiz4axOWMMt8neT6bFqzLrRz0SxJMi0aHHVcVbg6cM8T6EoZgTcLuR uuUU45KgCw56e8UN4vXASBlb9DQ7HMRUW9DzTdeGyFicN7bOJ+U74Ge1zJLyfCh5XxALGo9q+I31C E/ma2IK9BIK1jKt7eOarlLAvi+FV4BiLsL7QjPHihKgyqvTFuKnRMxVTkxzQQhNMsCRBaC0kGb2M5 ArMVjdtO+2yJudYjNqYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1pmbFW-003S6m-0H; Wed, 12 Apr 2023 14:15:02 +0000 Received: from mail-vs1-xe31.google.com ([2607:f8b0:4864:20::e31]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pmbFT-003S5V-28; Wed, 12 Apr 2023 14:15:01 +0000 Received: by mail-vs1-xe31.google.com with SMTP id y17so10448277vsd.9; Wed, 12 Apr 2023 07:14:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1681308898; x=1683900898; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=tz0zRW94Z/hmkdTJSfqG3WhRFcEFleZV0tRiJIInS+o=; b=P7XSviNYBBN4/cBFWoeR8Bo2jx+nVtrKpzKhddaicAm0flKyF+IzsIrxZzM3vtGWtO 0KdRlgaZm9KNWQRy28Uu47HtjY6gZ8iNET7syOuICPuOozzSSGw2IKRYIZNDwHVkixxR JUfFLdN8lZBYEE+URai9CavDuTmZK/TLlF2JVLBxNt87gllBTW/FehgBv8jo1yK32vUZ IqSdcv+yf2QVoRwMrB6FtM7/Zk2SMupZlsAt+t6Ojenr3HO1ezkZ+trZmJDedEfr5NPM c4iTyz7pTk6bZYITPqvAHLXBnEK4KfYwGbqGKOCZncsa1X6dNYY0eVqmATBsCJp4ar3l dChw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1681308898; x=1683900898; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=tz0zRW94Z/hmkdTJSfqG3WhRFcEFleZV0tRiJIInS+o=; b=adHO4Fu54zUczj4qiuezJyKS+qg4ZX6NddCmC7mwZQ6xYhG+WT5S1yNMv5eKuDVdKM /sFlSlC2AgF6T6L2dW6pGhNW1/5fAXw7Tubv44XvDq5yOjsIv/0tVk6oyGPLGmBBQESs Gzn1zjkjm1I8AVhA6q5o2KxGqv4tmfxQqjwT5tpMoXLOk2jgorBOAq2ludmq14ObQCVp 6habaMNtdAjewIE4IoKAvEtUftQ1xD4z9wNoo37o6rbbn3Z3vIJx44DmBSIxxBwGWvkr NiBUH64tCRUdcLcoChetd+9M3JVhi6MmJYxGZDwlgBR7+hwaI5iZu3rbFC51M/Kj+kC/ X2mQ== X-Gm-Message-State: AAQBX9e4lzEkMQSx7iqSGB7lxKFYIM0UPfvM33nISNoyahqAoDd/bZDG Tkznca2BpxDEE/jQMaQeNGlMg6vrVVDjXxryTeY= X-Google-Smtp-Source: AKy350avWMjBT0JOfHwbQHUPSOKOOj9paUb8BFRtQEd7/VdSYxRrFONuSauNTrFOpHN5ZBgIyAv1a8jmw5b/tp4wE9A= X-Received: by 2002:a67:c311:0:b0:42c:9733:de2f with SMTP id r17-20020a67c311000000b0042c9733de2fmr1002823vsj.6.1681308898270; Wed, 12 Apr 2023 07:14:58 -0700 (PDT) MIME-Version: 1.0 References: <20230411165919.23955-1-jim2101024@gmail.com> <20230411165919.23955-2-jim2101024@gmail.com> <5a28e520-63e4-dbcf-5b3e-e5097f02dea2@linaro.org> <78c18cdb-5757-8d30-e2a6-414f09505cc6@gmail.com> <66b7d0b9-9569-ddaf-89ca-5a0133074a17@linaro.org> In-Reply-To: <66b7d0b9-9569-ddaf-89ca-5a0133074a17@linaro.org> From: Jim Quinlan Date: Wed, 12 Apr 2023 10:14:46 -0400 Message-ID: Subject: Re: [PATCH v2 1/3] dt-bindings: PCI: brcmstb: Add two optional props To: Krzysztof Kozlowski Cc: Florian Fainelli , linux-pci@vger.kernel.org, Nicolas Saenz Julienne , Bjorn Helgaas , Lorenzo Pieralisi , Cyril Brulebois , Phil Elwell , bcm-kernel-feedback-list@broadcom.com, james.quinlan@broadcom.com, Lorenzo Pieralisi , =?UTF-8?Q?Krzysztof_Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , "moderated list:BROADCOM BCM7XXX ARM ARCHITECTURE" , "moderated list:BROADCOM BCM2711/BCM2835 ARM ARCHITECTURE" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230412_071459_704183_C4BF2F7B X-CRM114-Status: GOOD ( 20.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gV2VkLCBBcHIgMTIsIDIwMjMgYXQgNzo1NuKAr0FNIEtyenlzenRvZiBLb3psb3dza2kKPGty enlzenRvZi5rb3psb3dza2lAbGluYXJvLm9yZz4gd3JvdGU6Cj4KPiBPbiAxMi8wNC8yMDIzIDEz OjQ5LCBGbG9yaWFuIEZhaW5lbGxpIHdyb3RlOgo+ID4KPiA+Cj4gPiBPbiA0LzEyLzIwMjMgMTow OSBBTSwgS3J6eXN6dG9mIEtvemxvd3NraSB3cm90ZToKPiA+PiBPbiAxMS8wNC8yMDIzIDE4OjU5 LCBKaW0gUXVpbmxhbiB3cm90ZToKPiA+Pj4gUmVnYXJkaW5nICJicmNtLGVuYWJsZS1sMXNzIjoK PiA+Pj4KPiA+Pj4gICAgVGhlIEJyb2FkY29tIFNUQi9DTSBQQ0llIEhXIC0tIGEgY29yZSB0aGF0 IGlzIGFsc28gdXNlZCBieSBSUGkgU09DcyAtLQo+ID4+PiAgICByZXF1aXJlcyB0aGUgZHJpdmVy IHByb2JlKCkgdG8gZGVsaWJlcmF0ZWx5IHBsYWNlIHRoZSBIVyBvbmUgb2YgdGhyZWUKPiA+Pj4g ICAgQ0xLUkVRIyBtb2RlczoKPiA+Pj4KPiA+Pj4gICAgKGEpIENMS1JFUSMgZHJpdmVuIGJ5IHRo ZSBSQyB1bmNvbmRpdGlvbmFsbHkKPiA+Pj4gICAgKGIpIENMS1JFUSMgZHJpdmVuIGJ5IHRoZSBF UCBmb3IgQVNQTSBMMHMsIEwxCj4gPj4+ICAgIChjKSBCaWRpcmVjdGlvbmFsIENMS1JFUSMsIGFz IHVzZWQgZm9yIEwxIFN1YnN0YXRlcyAoTDFTUykuCj4gPj4+Cj4gPj4+ICAgIFRoZSBIVytkcml2 ZXIgY2FuIHRlbGwgdGhlIGRpZmZlcmVuY2UgYmV0d2VlbiBkb3duc3RyZWFtIGRldmljZXMgdGhh dAo+ID4+PiAgICBuZWVkIChhKSBhbmQgKGIpLCBidXQgZG9lcyBub3Qga25vdyB3aGVuIHRvIGNv bmZpZ3VyZSAoYykuICBGdXJ0aGVyLCB0aGUKPiA+Pj4gICAgSFcgbWF5IGNhdXNlIGEgQ1BVIGFi b3J0IG9uIGJvb3QgaWYgZ3Vlc3NlcyB3cm9uZyByZWdhcmRpbmcgdGhlIG5lZWQgZm9yCj4gPj4+ ICAgIChjKS4gIFNvIHdlIGludHJvZHVjZSB0aGUgYm9vbGVhbiAiYnJjbSxlbmFibGUtbDFzcyIg cHJvcGVydHkgdG8gaW5kaWNhdGUKPiA+Pj4gICAgdGhhdCAoYykgaXMgZGVzaXJlZC4gIFNldHRp bmcgdGhpcyBwcm9wZXJ0eSBvbmx5IG1ha2VzIHNlbnNlIHdoZW4gdGhlCj4gPj4+ICAgIGRvd25z dHJlYW0gZGV2aWNlIGlzIEwxU1MtY2FwYWJsZSBhbmQgdGhlIE9TIGlzIGNvbmZpZ3VyZWQgdG8g YWN0aXZhdGUKPiA+Pj4gICAgdGhpcyBtb2RlIChlLmcuIHBvbGljeT09c3VwZXJwb3dlcnNhdmUp Lgo+ID4+Pgo+ID4+PiAgICBUaGlzIHByb3BlcnR5IGlzIGFscmVhZHkgcHJlc2VudCBpbiB0aGUg UmFzcGlhbiB2ZXJzaW9uIG9mIExpbnV4LCBidXQgdGhlCj4gPj4+ICAgIHVwc3RyZWFtIGRyaXZl ciBpbXBsZW1lbnRhaW9uIHRoYXQgd2lsbCBmb2xsb3cgYWRkcyBtb3JlIGRldGFpbHMgYW5kCj4g Pj4KPiA+PiB0eXBvLCBpbXBsZW1lbnRhdGlvbgo+ID4+Cj4gPj4+ICAgIGRpc2Nlcm5zIGJldHdl ZW4gKGEpIGFuZCAoYikuCj4gPj4+Cj4gPj4+IFJlZ2FyZGluZyAiYnJjbSxjb21wbGV0aW9uLXRp bWVvdXQtdXMiCj4gPj4+Cj4gPj4+ICAgIE91ciBIVyB3aWxsIGNhdXNlIGEgQ1BVIGFib3J0IGlm IHRoZSBMMVNTIGV4aXQgdGltZSBpcyBsb25nZXIgdGhhbiB0aGUKPiA+Pj4gICAgUENJZSB0cmFu c2FjdGlvbiBjb21wbGV0aW9uIGFib3J0IHRpbWVvdXQuICBXZSd2ZSBiZWVuIGFza2VkIHRvIG1h a2UgdGhpcwo+ID4+PiAgICBjb25maWd1cmFibGUsIHNvIHdlIGFyZSBpbnRyb2R1Y2luZyAiYnJj bSxjb21wbGV0aW9uLXRpbWVvdXQtdXMiLgo+ID4+Pgo+ID4+PiBTaWduZWQtb2ZmLWJ5OiBKaW0g UXVpbmxhbiA8amltMjEwMTAyNEBnbWFpbC5jb20+Cj4gPj4KPiA+PiBXaGF0IGhhcHBlbmVkIGhl cmU/IFdoZXJlIGlzIHRoZSBjaGFuZ2Vsb2c/Cj4gPgo+ID4gSXQgaXMgaW4gdGhlIGNvdmVyIGxl dHRlcjoKPiA+Cj4gPiBodHRwczovL2xvcmUua2VybmVsLm9yZy9hbGwvMjAyMzA0MTExNjU5MTku MjM5NTUtMS1qaW0yMTAxMDI0QGdtYWlsLmNvbS8KPiA+Cj4gPiBidXQgaXQgZG9lcyBub3QgbG9v ayBsaWtlIHRoZSBjb3ZlciBsZXR0ZXIgd2FzIGNvcGllZCB0byB5b3Ugb3IgUm9iLgo+Cj4gQXMg eW91IHNhaWQsIEkgZGlkIG5vdCBnZXQgaXQuCgpZZXMsIHNvcnJ5IGFib3V0IHRoYXQ7IEkgdXNl IGEgd3JhcHBlciBvdmVyIHRoZSAiY29jY2lfY2MiIHNjcmlwdCBhbmQKSSBuZWVkIHRvIG1vZGlm eSBvbmUgb3IgYm90aCBzY3JpcHRzIHRvIHNlbmQgdGhlIGNvdmVyIHRvIHRoZQpzdXBlcnNldCBv ZiByZWNpcGllbnRzIGluIHRoZSBjb25zdGl0dWVudCBjb21taXRzLgoKUmVnYXJkcywKSmltIFF1 aW5hbgpCcm9hZGNvbSBTVEIKPgo+IEJlc3QgcmVnYXJkcywKPiBLcnp5c3p0b2YKPgoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5l bCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6 Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=