From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C961CC433DB for ; Wed, 6 Jan 2021 14:35:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 95F2323110 for ; Wed, 6 Jan 2021 14:35:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726370AbhAFOet (ORCPT ); Wed, 6 Jan 2021 09:34:49 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725803AbhAFOet (ORCPT ); Wed, 6 Jan 2021 09:34:49 -0500 Received: from mail-pj1-x1032.google.com (mail-pj1-x1032.google.com [IPv6:2607:f8b0:4864:20::1032]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EDFCDC06134D for ; Wed, 6 Jan 2021 06:34:08 -0800 (PST) Received: by mail-pj1-x1032.google.com with SMTP id hk16so1672048pjb.4 for ; Wed, 06 Jan 2021 06:34:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xG+Aig3uaRFj6+3S+rLCMgLtTBzVQJurKYaoHP2i+Ww=; b=NzFc+bZV1qpPy6j4yIBaInX0XaTSlqt6raRR72ykm+Ui4w4dewN1vyAfI2pS7RFWIK ETJiVrhHsZa/hhSfQm9JsW9mcwsk5mO2WAr0diNkOuk64EOtEaW+N2CtBWNA0bqtVKeo 0kMZDWN9JS4ROKqiZRoTXo5ldadEB+osKmYP7xrlwMLjJCx8SpmodoWmDK0rMqUlYvC5 Pycmd6UcRK5XhOU0LvKnLKqy+fo3jMFLTDwZgydywxZUj0JwpON6e+egZ3C7WqfHyQZH 6khGzZ/7iI4jsWXgJgwAErdGlKDb31H5yaa2UejmST+LUW+zQ3d2bArPgjaH2L8HAP6x qyFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xG+Aig3uaRFj6+3S+rLCMgLtTBzVQJurKYaoHP2i+Ww=; b=BYVi1Rj5cl2TaRCdSG4dBvmta9k/sonUCyGq+PhFpcGup7foMfxdS76dxbLr8Br4gY /SGR1qwAhDxu3IZTWHHgq+0wiBswAHmc1z0DfKWauDolHNiMxe0zkLV8NZihzbH8qy22 wPpL7ObDE0yIhe6GzgvbWLCmUQqNWKk3xca6dg0VkZeDqrUvSzU3v+gXxxomGZtVnZk+ LjvOmEhv4M37RAlxczXNAXYDR6yxUXm7k4NiCPgu950Y3nW8NA5pvGPjeWqoZxMbrlYu ExpOSNgDMh1s5vmDg+SZI039TZwP1i8998wkTVxQGp1wC8QTpHE73dFHXi2Qxse/6PJA zDLA== X-Gm-Message-State: AOAM532ejtk19tCKjkRNX6EV+qDsvPBxEWYkb1PLy0DYgPLoHCJhRJlj bQXiYkHoU3YcgxRjpbo46OwnSKqAwYIj7GEAQfs= X-Google-Smtp-Source: ABdhPJwWMD0LL5531x/3RTqnQtusY8HCavdf9UARcO7sry0xVZeOm4kVtvDtfJK03bpoFDzwto9SGmZ8JRIGbpCl574= X-Received: by 2002:a17:90a:49c5:: with SMTP id l5mr4603955pjm.116.1609943648576; Wed, 06 Jan 2021 06:34:08 -0800 (PST) MIME-Version: 1.0 References: <20210106093053.tnlncqvcba7qnwnk@bogus> In-Reply-To: <20210106093053.tnlncqvcba7qnwnk@bogus> From: Jim Quinlan Date: Wed, 6 Jan 2021 09:33:57 -0500 Message-ID: Subject: Re: [PATCH v4 2/2] firmware: arm_scmi: Augment SMC/HVC to allow optional interrupt To: Sudeep Holla Cc: Jim Quinlan , Florian Fainelli , bcm-kernel-feedback-list , "open list:SYSTEM CONTROL & POWER/MANAGEMENT INTERFACE Mes..." , open list Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 6, 2021 at 4:30 AM Sudeep Holla wrote: > > On Tue, Jan 05, 2021 at 01:32:49PM -0500, Jim Quinlan wrote: > > [...] > > > > > I don't think that is the case; the bottom routine, > > do_wait_for_common(), decrements the x->done after a completion (which > > does an increment). Regardless, I think it is prudent to add the > > reinit patch you've provided below. > > > > Ah right, but I will add that. > > > BTW, one thing I could have done was incorporate the timeout value but > > I thought that since this is the "fast" call we shouldn't be timing > > out at all. > > > > Agreed, we can add it later. However it is not related to fast call, it is > more for protection against failure of delivery of interrupt from the platform > or any firmware responsible IMO. > > > > This electronic communication and the information and any files > > > transmitted with it, or attached to it, are confidential and are intended > > > solely for the use of the individual or entity to whom it is addressed and > > > may contain information that is confidential, legally privileged, > > > protected by privacy laws, or otherwise restricted from disclosure to > > > anyone else. If you are not the intended recipient or the person > > > responsible for delivering the e-mail to the intended recipient, you are > > > hereby notified that any use, copying, distributing, dissemination, > > > forwarding, printing, or copying of this e-mail is strictly prohibited. If > > > you received this e-mail in error, please return the e-mail to the sender, > > > delete it from your computer, and destroy any printed copy of it. > > I am assuming this was unintentional and ignoring. If not disregard my > response. Otherwise you may need to fix your mail server. Hi Sudeep, Yes please ignore the above legalize in my email -- our company is attaching this text to all outgoing emails. We are working on a general solution. Regards, Jim Quinlan Broadcom STB > > -- > Regards, > Sudeep From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.7 required=3.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CC07C433DB for ; Wed, 6 Jan 2021 14:36:50 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DB3122064C for ; Wed, 6 Jan 2021 14:36:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DB3122064C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=newedIMrQZkx3u/Cp0C1EhtEVztUOe9PF8klBpbPkNI=; b=t32DsMHl5xTmmDXlLv+PsmbJB bKuCBefodqloWVfrDBd3LAP9ZcOwBbtAaA7Fyep/x8jETGQTxhj90wlHoiWK1zzjFjBMvOJl5pENQ HCckRcEHEe5raOxocvEy2Hc2QC13WHp6Z55FfhFPxUhY99drKFh/TqZRiXjdvvJwbyu6bEZs8pqVe 8nWvSwdgf9aGCKAn13Q4Z9cHSQ8GxMRxfxDebjWSWJkZiIW4hQmHa+yUU/3Ayjfp5LWVHolkKyexl jKTnTrvTx7TeVGer0GsNkH7HRXWEFcXoFfXg9Olk5sLmJ5cPiefI8ejxz+y4/pzRrTv4aF3In8pBr IdRBlkSzw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx9t7-0006dM-8I; Wed, 06 Jan 2021 14:34:13 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kx9t4-0006cb-Gm for linux-arm-kernel@lists.infradead.org; Wed, 06 Jan 2021 14:34:11 +0000 Received: by mail-pl1-x62b.google.com with SMTP id v3so1609931plz.13 for ; Wed, 06 Jan 2021 06:34:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=xG+Aig3uaRFj6+3S+rLCMgLtTBzVQJurKYaoHP2i+Ww=; b=NzFc+bZV1qpPy6j4yIBaInX0XaTSlqt6raRR72ykm+Ui4w4dewN1vyAfI2pS7RFWIK ETJiVrhHsZa/hhSfQm9JsW9mcwsk5mO2WAr0diNkOuk64EOtEaW+N2CtBWNA0bqtVKeo 0kMZDWN9JS4ROKqiZRoTXo5ldadEB+osKmYP7xrlwMLjJCx8SpmodoWmDK0rMqUlYvC5 Pycmd6UcRK5XhOU0LvKnLKqy+fo3jMFLTDwZgydywxZUj0JwpON6e+egZ3C7WqfHyQZH 6khGzZ/7iI4jsWXgJgwAErdGlKDb31H5yaa2UejmST+LUW+zQ3d2bArPgjaH2L8HAP6x qyFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=xG+Aig3uaRFj6+3S+rLCMgLtTBzVQJurKYaoHP2i+Ww=; b=KnxXEPpQnV178B0yFFbfOJjJ0nOM9cYgCMgTObCE+PND0GAy5Y+y6KObeO5WoRwrlg hf/jtR6xyv+frCAqPAAYdgToTb6Pw4dTKMlRsoOGvpiNj1+1XeM25YhIQeQa2/V16LU8 JBx2qfo2/eMliVfg2SOQhm+YhplozQ1aUmevFbL2/CwBLAAxGpPXEDc9CKp0H/6wbgLw 8YEg4uJM6hFAe8m7cRVOwprtFVH5VALwiyM6AOKLzbdQrNfLp+PWGjmsgOSf2V+0i5El XDKZtZ4CWL3/PlCuxoY1Au+VDWcZcnpzcK18pBNqtEPzzj3ydmiVMBBPuUbMzOcAZwdL c7tQ== X-Gm-Message-State: AOAM533JEc0qklfHLYnR2CFbZ0f1hz7gL5KQPEC8qs86CqLQdlpOFBrZ PFdCZZsfcJ3HaPtqM80TJkoXjpwHMMGM5X0/xTg= X-Google-Smtp-Source: ABdhPJwWMD0LL5531x/3RTqnQtusY8HCavdf9UARcO7sry0xVZeOm4kVtvDtfJK03bpoFDzwto9SGmZ8JRIGbpCl574= X-Received: by 2002:a17:90a:49c5:: with SMTP id l5mr4603955pjm.116.1609943648576; Wed, 06 Jan 2021 06:34:08 -0800 (PST) MIME-Version: 1.0 References: <20210106093053.tnlncqvcba7qnwnk@bogus> In-Reply-To: <20210106093053.tnlncqvcba7qnwnk@bogus> From: Jim Quinlan Date: Wed, 6 Jan 2021 09:33:57 -0500 Message-ID: Subject: Re: [PATCH v4 2/2] firmware: arm_scmi: Augment SMC/HVC to allow optional interrupt To: Sudeep Holla X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210106_093410_664699_A4805189 X-CRM114-Status: GOOD ( 25.06 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Florian Fainelli , bcm-kernel-feedback-list , "open list:SYSTEM CONTROL & POWER/MANAGEMENT INTERFACE Mes..." , Jim Quinlan , open list Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jan 6, 2021 at 4:30 AM Sudeep Holla wrote: > > On Tue, Jan 05, 2021 at 01:32:49PM -0500, Jim Quinlan wrote: > > [...] > > > > > I don't think that is the case; the bottom routine, > > do_wait_for_common(), decrements the x->done after a completion (which > > does an increment). Regardless, I think it is prudent to add the > > reinit patch you've provided below. > > > > Ah right, but I will add that. > > > BTW, one thing I could have done was incorporate the timeout value but > > I thought that since this is the "fast" call we shouldn't be timing > > out at all. > > > > Agreed, we can add it later. However it is not related to fast call, it is > more for protection against failure of delivery of interrupt from the platform > or any firmware responsible IMO. > > > > This electronic communication and the information and any files > > > transmitted with it, or attached to it, are confidential and are intended > > > solely for the use of the individual or entity to whom it is addressed and > > > may contain information that is confidential, legally privileged, > > > protected by privacy laws, or otherwise restricted from disclosure to > > > anyone else. If you are not the intended recipient or the person > > > responsible for delivering the e-mail to the intended recipient, you are > > > hereby notified that any use, copying, distributing, dissemination, > > > forwarding, printing, or copying of this e-mail is strictly prohibited. If > > > you received this e-mail in error, please return the e-mail to the sender, > > > delete it from your computer, and destroy any printed copy of it. > > I am assuming this was unintentional and ignoring. If not disregard my > response. Otherwise you may need to fix your mail server. Hi Sudeep, Yes please ignore the above legalize in my email -- our company is attaching this text to all outgoing emails. We are working on a general solution. Regards, Jim Quinlan Broadcom STB > > -- > Regards, > Sudeep _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel