From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,HTML_MESSAGE,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8D63C4338F for ; Tue, 10 Aug 2021 02:45:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0100C61051 for ; Tue, 10 Aug 2021 02:45:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0100C61051 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bsdimp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:48410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mDHlO-0006mR-TF for qemu-devel@archiver.kernel.org; Mon, 09 Aug 2021 22:45:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38462) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mDHkm-00067u-Oe for qemu-devel@nongnu.org; Mon, 09 Aug 2021 22:44:32 -0400 Received: from mail-qt1-x82f.google.com ([2607:f8b0:4864:20::82f]:41574) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mDHkl-0005GY-9S for qemu-devel@nongnu.org; Mon, 09 Aug 2021 22:44:32 -0400 Received: by mail-qt1-x82f.google.com with SMTP id z24so14336385qtn.8 for ; Mon, 09 Aug 2021 19:44:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7odjHUtzyq0JscxEH5sCcZAFM2BoO9/c4GqUeKQnx2Y=; b=QQ+ClpV92wyRlWTuUm5o4F8PvYyAG82AObtxx4Ju0vQ2OCqKnV5Yi9YeTyLhyas7MO yjPiHpoID/boBhFYzs3f1sQVvLx8USP6QQdoopxEs7qjSs3eiylgos6T9EcXoxWaGT34 yXpUf5SnJsITVLJh5AMSVx36NkDqKl0i0uATgykJRKm9zeX7Q+de3IFRmGW4Qhrztkfq SWahsUQTZ5dIYWGCu2GH/prKwEOsy+5RZjAzWcs7+qGZ7KiAbmbWYOPWsVplWUZCoPGl 3i7pC7FMoprEjHn6b/YzqMH1WL0ZLK40BFO8SNN2gf96z2mIs0aYXLngYUgvHuSl2WCb 80mg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7odjHUtzyq0JscxEH5sCcZAFM2BoO9/c4GqUeKQnx2Y=; b=ENgKrO1gilzIoLT0gEjQHYrCj7PCj1BTiO2X3s/xCDDmRXZcSYqEeEUlxoqC+FMsA6 ZhQENolWiFsKg7G7kKBQjOWC/y/uq1BNp+2JBmTNLt1+k2KJ1Rahx0q6adU3qxS04efC fTTVmL+4/Joc3hT1YC5hEz/EE/iRdU6CMclHy+HbJ1WXlFM/U2dZ5A0rSdeI5e7Fay6x DKUzIP+l8/lynFBzCLX3sORakEGOtN5HcZs2Woj5cFi2ecfLOW9aa9tTFULAg/S0bT3T YHcMiNJRcpPM0t6ZCVvtV1vZSIxDez2DPqOE8trvojH3GtwZpboPZ1IBHw+fWyvfL6Kf 11dw== X-Gm-Message-State: AOAM530bnxAu5WMACAwgDSMo16p5eG8xs6JaQyI2/jnqUIHlt1t0tVHp F5tAc+PxtiiEO9nP8REDMEyA7FS8aKDB50304bHHmQ== X-Google-Smtp-Source: ABdhPJwoqJ0iNCqRtaGPI4tTogBFQteYyppxOF14tVOPRDRnOOHa9rxtUlUIjhWv3MV54jruIGAAAWC2eptnPr1L15c= X-Received: by 2002:ac8:777a:: with SMTP id h26mr13078823qtu.235.1628563470210; Mon, 09 Aug 2021 19:44:30 -0700 (PDT) MIME-Version: 1.0 References: <20210807214242.82385-1-imp@bsdimp.com> <20210807214242.82385-27-imp@bsdimp.com> <59d15760-3c49-e9d4-c6e3-f21a7b84e7ae@linaro.org> In-Reply-To: <59d15760-3c49-e9d4-c6e3-f21a7b84e7ae@linaro.org> From: Warner Losh Date: Mon, 9 Aug 2021 20:44:19 -0600 Message-ID: Subject: Re: [PATCH for 6.2 26/49] bsd-user: Create target specific vmparam.h To: Richard Henderson Content-Type: multipart/alternative; boundary="00000000000022e8e805c92b7bee" Received-SPF: none client-ip=2607:f8b0:4864:20::82f; envelope-from=wlosh@bsdimp.com; helo=mail-qt1-x82f.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kyle Evans , Warner Losh , QEMU Developers , Stacey Son Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000022e8e805c92b7bee Content-Type: text/plain; charset="UTF-8" On Mon, Aug 9, 2021 at 2:39 PM Richard Henderson < richard.henderson@linaro.org> wrote: > On 8/7/21 11:42 AM, Warner Losh wrote: > > +#define TARGET_MAXTSIZ (128UL*1024*1024) /* max text size */ > > +#define TARGET_DFLDSIZ (128UL*1024*1024) /* initial data size limit > */ > > +#define TARGET_MAXDSIZ (512UL*1024*1024) /* max data size */ > > +#define TARGET_DFLSSIZ (8UL*1024*1024) /* initial stack size limit > */ > > +#define TARGET_MAXSSIZ (64UL*1024*1024) /* max stack size */ > > +#define TARGET_SGROWSIZ (128UL*1024) /* amount to grow stack */ > > To-do list: KiB and MiB from units.h. > Easy enough to do now and merge to our main branch > > +++ b/bsd-user/qemu.h > > @@ -44,7 +44,7 @@ extern enum BSDType bsd_type; > > #include "target_arch.h" > > #include "syscall_defs.h" > > #include "target_syscall.h" > > -//#include "target_os_vmparam.h" > > +#include "target_os_vmparam.h" > > //#include "target_os_signal.h" > > //#include "hostdep.h" > > Ah, I see. Well, perhaps just squash the addition of the include to the > patch that > introduces the include? > Good idea. Reviewed-by: Richard Henderson > thanks! Warner --00000000000022e8e805c92b7bee Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Aug 9, 2021 at 2:39 PM Richar= d Henderson <richard.hen= derson@linaro.org> wrote:
On 8/7/21 11:42 AM, Warner Losh wrote:
> +#define TARGET_MAXTSIZ=C2=A0 (128UL*1024*1024)=C2=A0 =C2=A0/* max tex= t size */
> +#define TARGET_DFLDSIZ=C2=A0 (128UL*1024*1024)=C2=A0 =C2=A0/* initial= data size limit */
> +#define TARGET_MAXDSIZ=C2=A0 (512UL*1024*1024)=C2=A0 =C2=A0/* max dat= a size */
> +#define TARGET_DFLSSIZ=C2=A0 (8UL*1024*1024)=C2=A0 =C2=A0 =C2=A0/* in= itial stack size limit */
> +#define TARGET_MAXSSIZ=C2=A0 (64UL*1024*1024)=C2=A0 =C2=A0 /* max sta= ck size */
> +#define TARGET_SGROWSIZ (128UL*1024)=C2=A0 =C2=A0 =C2=A0 =C2=A0 /* am= ount to grow stack */

To-do list: KiB and MiB from units.h.

E= asy enough to do now and merge to our main branch
=C2=A0
> +++ b/bsd-user/qemu.h
> @@ -44,7 +44,7 @@ extern enum BSDType bsd_type;
>=C2=A0 =C2=A0#include "target_arch.h"
>=C2=A0 =C2=A0#include "syscall_defs.h"
>=C2=A0 =C2=A0#include "target_syscall.h"
> -//#include "target_os_vmparam.h"
> +#include "target_os_vmparam.h"
>=C2=A0 =C2=A0//#include "target_os_signal.h"
>=C2=A0 =C2=A0//#include "hostdep.h"

Ah, I see.=C2=A0 Well, perhaps just squash the addition of the include to t= he patch that
introduces the include?

Good idea.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

thanks!

Warner=C2=A0
=
--00000000000022e8e805c92b7bee--