All of lore.kernel.org
 help / color / mirror / Atom feed
From: Warner Losh <imp@bsdimp.com>
To: Eric Blake <eblake@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>,
	qemu-devel@nongnu.org, richard.henderson@linaro.org,
	 pbonzini@redhat.com, kwolf@redhat.com, hreitz@redhat.com,
	kevans@freebsd.org,  berrange@redhat.com, groug@kaod.org,
	qemu_oss@crudebyte.com, mst@redhat.com,  philmd@linaro.org,
	peter.maydell@linaro.org, alistair@alistair23.me,
	 jasowang@redhat.com, jonathan.cameron@huawei.com,
	 kbastian@mail.uni-paderborn.de, quintela@redhat.com,
	dgilbert@redhat.com,  michael.roth@amd.com, kkostiuk@redhat.com,
	tsimpson@quicinc.com,  palmer@dabbelt.com,
	bin.meng@windriver.com, qemu-block@nongnu.org,
	 qemu-arm@nongnu.org, qemu-riscv@nongnu.org
Subject: Re: [PATCH v4 03/19] scripts/clean-includes: Skip symbolic links
Date: Fri, 27 Jan 2023 16:08:12 -0700	[thread overview]
Message-ID: <CANCZdfoj4S06hhbGxHiVqCUQgj08Hyg7HCm5f5sQg0n1k854BA@mail.gmail.com> (raw)
In-Reply-To: <20230127224746.2rqorp2ushelp4wj@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1208 bytes --]

On Fri, Jan 27, 2023 at 3:47 PM Eric Blake <eblake@redhat.com> wrote:

> On Thu, Jan 19, 2023 at 07:59:43AM +0100, Markus Armbruster wrote:
> > When a symbolic link points to a file that needs cleaning, the script
> > replaces the link with a cleaned regular file.  Not wanted; skip them.
> >
> > We have a few symbolic links under subprojects/libvduse/ and
> > subprojects/libvhost-user/.
> >
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
> > ---
> >  scripts/clean-includes | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/scripts/clean-includes b/scripts/clean-includes
> > index 8e8420d785..f0466a6262 100755
> > --- a/scripts/clean-includes
> > +++ b/scripts/clean-includes
> > @@ -113,6 +113,10 @@ EOT
> >
> >  files=
> >  for f in "$@"; do
> > +  if [ -L "$f" ]; then
>
> I don't see -L used with test very often, but POSIX requires it, so it
> is safe for our choice of /bin/sh.
>

FYI: -L is in FreeBSD, NetBSD, OpenBSD, etc. It's been in all these trees
since the mid 90s. It wasn't in 4.4BSD, but all these projects have
imported the code from pdksh's test.

So in addition to POSIX, it's been widely implemented, at least in the BSD
world, for over 20 years.

Warner

[-- Attachment #2: Type: text/html, Size: 1834 bytes --]

  reply	other threads:[~2023-01-27 23:09 UTC|newest]

Thread overview: 64+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-19  6:59 [PATCH v4 00/19] Clean up includes Markus Armbruster
2023-01-19  6:59 ` [PATCH v4 01/19] scripts/clean-includes: Fully skip / ignore files Markus Armbruster
2023-01-27 21:29   ` Eric Blake
2023-01-28 10:28   ` Michael S. Tsirkin
2023-01-30 12:55     ` Markus Armbruster
2023-01-19  6:59 ` [PATCH v4 02/19] scripts/clean-includes: Don't claim duplicate headers found when not Markus Armbruster
2023-01-27 21:38   ` Eric Blake
2023-01-19  6:59 ` [PATCH v4 03/19] scripts/clean-includes: Skip symbolic links Markus Armbruster
2023-01-27 22:47   ` Eric Blake
2023-01-27 23:08     ` Warner Losh [this message]
2023-01-19  6:59 ` [PATCH v4 04/19] bsd-user: Clean up includes Markus Armbruster
2023-01-19 14:42   ` Warner Losh
2023-01-19 16:42     ` Markus Armbruster
2023-01-19 17:05       ` Warner Losh
2023-01-27 12:01         ` Markus Armbruster
2023-01-27 14:54     ` Peter Maydell
2023-01-27 15:01       ` Michael S. Tsirkin
2023-01-28 10:29         ` Michael S. Tsirkin
2023-01-30 13:12           ` Markus Armbruster
2023-01-19  6:59 ` [PATCH v4 05/19] crypto: " Markus Armbruster
2023-01-19 10:34   ` Philippe Mathieu-Daudé
2023-01-19  6:59 ` [PATCH v4 06/19] hw/cxl: " Markus Armbruster
2023-01-19  6:59 ` [PATCH v4 07/19] hw/input: " Markus Armbruster
2023-01-19  6:59 ` [PATCH v4 08/19] hw/tricore: " Markus Armbruster
2023-01-19 10:34   ` Philippe Mathieu-Daudé
2023-01-19  6:59 ` [PATCH v4 09/19] qga: " Markus Armbruster
2023-01-19  8:30   ` Konstantin Kostiuk
2023-01-19  6:59 ` [PATCH v4 10/19] migration: " Markus Armbruster
2023-01-19  9:34   ` Dr. David Alan Gilbert
2023-01-19 10:31     ` Markus Armbruster
2023-01-19 11:45       ` Dr. David Alan Gilbert
2023-01-20  7:19         ` Markus Armbruster
2023-01-30  4:11           ` Juan Quintela
2023-01-19  6:59 ` [PATCH v4 11/19] net: " Markus Armbruster
2023-01-19 10:35   ` Philippe Mathieu-Daudé
2023-01-19  6:59 ` [PATCH v4 12/19] target/hexagon: " Markus Armbruster
2023-01-19 22:15   ` Taylor Simpson
2023-01-20  7:21     ` Markus Armbruster
2023-01-19  6:59 ` [PATCH v4 13/19] riscv: " Markus Armbruster
2023-01-19 10:38   ` Philippe Mathieu-Daudé
2023-01-19 22:44   ` Alistair Francis
2023-01-19  6:59 ` [PATCH v4 14/19] block: " Markus Armbruster
2023-01-27 22:55   ` Eric Blake
2023-01-19  6:59 ` [PATCH v4 15/19] accel: " Markus Armbruster
2023-01-19 10:36   ` Philippe Mathieu-Daudé
2023-01-19  6:59 ` [PATCH v4 16/19] Fix non-first inclusions of qemu/osdep.h Markus Armbruster
2023-01-19 10:40   ` Philippe Mathieu-Daudé
2023-01-19 11:41     ` Markus Armbruster
2023-01-19 11:52       ` Philippe Mathieu-Daudé
2023-01-19 12:40         ` Markus Armbruster
2023-01-27 12:05         ` Markus Armbruster
2023-01-30  4:13   ` Juan Quintela
2023-01-19  6:59 ` [PATCH v4 17/19] Don't include headers already included by qemu/osdep.h Markus Armbruster
2023-01-19 12:06   ` Christian Schoenebeck
2023-01-19  6:59 ` [PATCH v4 18/19] 9p: Drop superfluous include of linux/limits.h Markus Armbruster
2023-01-19  9:50   ` Christian Schoenebeck
2023-01-19 10:37     ` Markus Armbruster
2023-01-19 12:01       ` Christian Schoenebeck
2023-01-19  6:59 ` [PATCH v4 19/19] Drop duplicate #include Markus Armbruster
2023-01-19 10:19   ` Dr. David Alan Gilbert
2023-01-19 14:17   ` Greg Kurz
2023-01-30  4:16   ` Juan Quintela
2023-01-19  9:20 ` [PATCH v4 00/19] Clean up includes Markus Armbruster
2023-01-19 11:49 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANCZdfoj4S06hhbGxHiVqCUQgj08Hyg7HCm5f5sQg0n1k854BA@mail.gmail.com \
    --to=imp@bsdimp.com \
    --cc=alistair@alistair23.me \
    --cc=armbru@redhat.com \
    --cc=berrange@redhat.com \
    --cc=bin.meng@windriver.com \
    --cc=dgilbert@redhat.com \
    --cc=eblake@redhat.com \
    --cc=groug@kaod.org \
    --cc=hreitz@redhat.com \
    --cc=jasowang@redhat.com \
    --cc=jonathan.cameron@huawei.com \
    --cc=kbastian@mail.uni-paderborn.de \
    --cc=kevans@freebsd.org \
    --cc=kkostiuk@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=michael.roth@amd.com \
    --cc=mst@redhat.com \
    --cc=palmer@dabbelt.com \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu_oss@crudebyte.com \
    --cc=quintela@redhat.com \
    --cc=richard.henderson@linaro.org \
    --cc=tsimpson@quicinc.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.