From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 711B8C433F5 for ; Mon, 8 Nov 2021 16:38:12 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D2FCF61181 for ; Mon, 8 Nov 2021 16:38:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D2FCF61181 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bsdimp.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:56594 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mk7et-00042z-2E for qemu-devel@archiver.kernel.org; Mon, 08 Nov 2021 11:38:11 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40276) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mk7ac-00013T-67 for qemu-devel@nongnu.org; Mon, 08 Nov 2021 11:33:46 -0500 Received: from [2607:f8b0:4864:20::f35] (port=37508 helo=mail-qv1-xf35.google.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mk7aZ-0004gx-S6 for qemu-devel@nongnu.org; Mon, 08 Nov 2021 11:33:45 -0500 Received: by mail-qv1-xf35.google.com with SMTP id u16so12257620qvk.4 for ; Mon, 08 Nov 2021 08:33:43 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdimp-com.20210112.gappssmtp.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kv31/+W0QRST2iverr0v5zeNZ7U7wUR33WNUFd9o78Y=; b=Xj5ybLCw2PZT1GeMJTkpnBn29USzCpSrmQ57xmCe6rsb092i3JPe0YGWNoU2viI1lk 6+n/A95wHkhLQrP7GRJOAdyf0zhNrhHELd+2yObmgHsqU4wrRqHm6XqV4yrYAvC/5EOE knOJROex/l9liEbX2QdhO/QyoEVwtCn1kfeoQQ2Wc/fVXVQPnMUtLx++nLvs6m+o2v90 6IwRfgJhBtMXHcWiGbSJp0EbDvh/TyDmjPF3ADmaNyCF9H+W54wBwZBlnLef+hzuHvFm dqW4OZ3T2gR7FLcfyNLs3JrtRBjEAUNci5ExuTEK+56WCbDhTIpBOqwdtSitnPKYnRHB 9ijA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kv31/+W0QRST2iverr0v5zeNZ7U7wUR33WNUFd9o78Y=; b=kRxrX9hdAv9SLEBujWUJXp9CkY11om/cf4jUlFjTYt5IrWO19ZNoxb0qsp1VLfa02H +rVdNdbBO/bmxSqnW65IPjzAEz5mawCzC9TKZt/cxk1MZ6lMse3gQ3ZK7ukIZ2Jf+cR5 fZ6U1Y6bnYgpewNGpYPQyqqQju5XsJu77G0XXfb/Uyo7Bmq3L+3GrM3kJOIeqkzZ1ob6 p/qEmJUCYp8MKnEZW/G/GEC1zPreJMHYBzhm2j/5n+lYSGFf7Eipz0G0l368+964T5C3 IcRiomqVfkf0EwqKNr1zBu/rgEi/yXlpLrwYC4tit9gXLNOe79K9Ksg02UH5owP0dHe7 bgqw== X-Gm-Message-State: AOAM531WC7kpENJ8SMQREQbEFvuTc2GQEhKn+gP4spFr91XoEQipk88W CzmeQ7rJt8RZuAyx481XvaAN7vb9vDjBGbbVtdLAkODHbDU= X-Google-Smtp-Source: ABdhPJx2lViSdGOMUsQl5gPo8qQ+kuxE6Ia7O73qdjII50uJ9kuDJpaEA5HRfzqQYuApb7My4V2K7V2RMxeQVA3Db18= X-Received: by 2002:a67:e050:: with SMTP id n16mr364909vsl.44.1636388757331; Mon, 08 Nov 2021 08:25:57 -0800 (PST) MIME-Version: 1.0 References: <20211106113916.544587-1-f4bug@amsat.org> <39681686-e208-3c75-c0a5-ffda2482311f@amsat.org> In-Reply-To: <39681686-e208-3c75-c0a5-ffda2482311f@amsat.org> From: Warner Losh Date: Mon, 8 Nov 2021 09:25:46 -0700 Message-ID: Subject: Re: [PATCH v2] linux-user: Mark cpu_loop() with noreturn attribute To: =?UTF-8?Q?Philippe_Mathieu=2DDaud=C3=A9?= Content-Type: multipart/alternative; boundary="00000000000098754405d049727f" X-Host-Lookup-Failed: Reverse DNS lookup failed for 2607:f8b0:4864:20::f35 (failed) Received-SPF: none client-ip=2607:f8b0:4864:20::f35; envelope-from=wlosh@bsdimp.com; helo=mail-qv1-xf35.google.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HTML_MESSAGE=0.001, PDS_HP_HELO_NORDNS=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_NONE=0.793, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Bin Meng , Richard Henderson , QEMU Developers , Laurent Vivier Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" --00000000000098754405d049727f Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Mon, Nov 8, 2021 at 12:37 AM Philippe Mathieu-Daud=C3=A9 wrote: > On 11/7/21 01:39, Warner Losh wrote: > > > > > > On Sat, Nov 6, 2021, 5:39 AM Philippe Mathieu-Daud=C3=A9 > > wrote: > > > > cpu_loop() never exits, so mark it with QEMU_NORETURN. > > > > Reviewed-by: Richard Henderson > > > > Reviewed-By: Warner Losh > > > Reviewed-by: Bin Meng >> > > Signed-off-by: Philippe Mathieu-Daud=C3=A9 > > > > --- > > v2: > > - rebased > > - restricted to linux-user > > > > Supersedes: <20210905000429.1097336-1-f4bug@amsat.org > > > > > > > > > Reviewed-by: Warner Losh > > > > > bsd-user likely needs similar treatment, no? > > IIUC this thread, not yet (I didn't want to get into your refactor): > > https://lore.kernel.org/qemu-devel/CAFEAcA-f=3Dn6XHp5Cj7=3DtH8NWO1GLA50i3= 4=3D5GyaHrZELyr0bjw@mail.gmail.com/ I'll add it to my TODO items. I hope to get a small collection of those in this month before the release after I land the arm bits. Warner --00000000000098754405d049727f Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


=
On Mon, Nov 8, 2021 at 12:37 AM Phili= ppe Mathieu-Daud=C3=A9 <f4bug@amsat.o= rg> wrote:
f4bug@amsat.org
> <mailto:f4bug@= amsat.org>> wrote:
>
>=C2=A0 =C2=A0 =C2=A0cpu_loop() never exits, so mark it with QEMU_NORETU= RN.
>
>=C2=A0 =C2=A0 =C2=A0Reviewed-by: Richard Henderson <richard.henderson@linaro.= org
>=C2=A0 =C2=A0 =C2=A0<mailto:richard.henderson@linaro.org>>
>=C2=A0 =C2=A0 =C2=A0Reviewed-By: Warner Losh <imp@bsdimp.com <mailto:imp@bsdimp.com>>
>=C2=A0 =C2=A0 =C2=A0Reviewed-by: Bin Meng <bmeng.cn@gmail.com <mailto:bmeng.cn@gmail.com>>= ;
>=C2=A0 =C2=A0 =C2=A0Signed-off-by: Philippe Mathieu-Daud=C3=A9 <f4bug@amsat.org
>=C2=A0 =C2=A0 =C2=A0<mailto:f4bug@amsat.org>>
>=C2=A0 =C2=A0 =C2=A0---
>=C2=A0 =C2=A0 =C2=A0v2:
>=C2=A0 =C2=A0 =C2=A0- rebased
>=C2=A0 =C2=A0 =C2=A0- restricted to linux-user
>
>=C2=A0 =C2=A0 =C2=A0Supersedes: <20210905000429.1097336-1-f4bug@a= msat.org
>=C2=A0 =C2=A0 =C2=A0<mailto:20210905000429.1097336-1-f4bug@amsat.= org>>
>
>
> Reviewed-by: Warner Losh <imp@bsdimp.com <mailto:imp@bsdimp.com>>
>
> bsd-user likely needs similar treatment, no?

IIUC this thread, not yet (I didn't want to get into your refactor): https://lore.kernel.org/qemu-devel/CAFEAcA-f=3Dn6XHp5Cj7=3DtH8NWO1G= LA50i34=3D5GyaHrZELyr0bjw@mail.gmail.com/

I'll add it to my TODO items. I hope to get a small collection of th= ose in this month before the release after I land the arm bits.
<= br>
Warner
--00000000000098754405d049727f--