On Fri, Sep 24, 2021 at 6:00 AM Richard Henderson <richard.henderson@linaro.org> wrote:

On 9/21/21 9:56 PM, Warner Losh wrote:
> /* no page was there, so we allocate one */
> void *p = mmap(host_start, qemu_host_page_size, prot,
> - flags | MAP_ANON, -1, 0);
> + flags | ((fd != -1) ? MAP_ANON : 0), -1, 0);

I don't understand this change, given that the actual fd passed is always -1.

That's a very good question. I'll have to trace down why that was made because

I'm having trouble with it as well now that I'm trying to defend it.

Warner

r~