From mboxrd@z Thu Jan 1 00:00:00 1970 From: Puthikorn Voravootivat Subject: Re: [PATCH 1/2] drm/dp: Add defines for latency in sink Date: Tue, 26 Sep 2017 13:37:20 -0700 Message-ID: References: <1505917955-6623-1-git-send-email-vathsala.nagaraju@intel.com> <20170921144207.f4j2vfasp5gqksl2@intel.com> <20170926051100.w6uvkaup7c2a62wq@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0385338046==" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Puthikorn Voravootivat Cc: intel-gfx , dri-devel@lists.freedesktop.org, Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org --===============0385338046== Content-Type: multipart/alternative; boundary="94eb2c0762e6807c40055a1da535" --94eb2c0762e6807c40055a1da535 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Sep 26, 2017 at 10:37 AM, Puthikorn Voravootivat < puthik@chromium.org> wrote: > > > On Mon, Sep 25, 2017 at 10:11 PM, Daniel Vetter wrote: > >> On Thu, Sep 21, 2017 at 07:42:07AM -0700, Rodrigo Vivi wrote: >> > On Wed, Sep 20, 2017 at 02:32:34PM +0000, vathsala nagaraju wrote: >> > > Add defines for dpcd register 2009 (synchronization latency >> > > in sink). >> > > >> > > Cc: Rodrigo Vivi >> > > CC: Puthikorn Voravootivat >> > > Signed-off-by: Vathsala Nagaraju >> > >> > I keep forgetting to update my eDP spec 1.4 to this 1.4b... >> >> Maybe the patch should then make this clear, by annotating it with >> /* eDP 1.4b */ That's missing, which isn't all that great really, since = it >> makes specs hunts like yours necessary. >> >> It's actually in eDP 1.4 spec, table 5-6 page 86 > Copy and paste the wrong one. 0x2009 is actually in eDP 1.4 spec, Table 6-7: DPCD =E2=80=93 Sink Device P= SR Status Field page 124 > > >> Please fix up before applying. >> -Daniel >> > >> > >> > Reviewed-by: Rodrigo Vivi >> > >> > >> > >> > > --- >> > > include/drm/drm_dp_helper.h | 3 +++ >> > > 1 file changed, 3 insertions(+) >> > > >> > > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_helper= .h >> > > index 11c39f1..846004e6 100644 >> > > --- a/include/drm/drm_dp_helper.h >> > > +++ b/include/drm/drm_dp_helper.h >> > > @@ -735,6 +735,9 @@ >> > > # define DP_PSR_SINK_INTERNAL_ERROR 7 >> > > # define DP_PSR_SINK_STATE_MASK 0x07 >> > > >> > > +#define DP_SINK_SYNCHRONIZATION_LATENCY 0x2009 >> > > +# define DP_MAX_RESYNC_FRAME_CNT_MASK 0xf >> > > + >> > > #define DP_RECEIVER_ALPM_STATUS 0x200b /* eDP 1.4 *= / >> > > # define DP_ALPM_LOCK_TIMEOUT_ERROR (1 << 0) >> > > >> > > -- >> > > 1.9.1 >> > > >> > _______________________________________________ >> > dri-devel mailing list >> > dri-devel@lists.freedesktop.org >> > https://lists.freedesktop.org/mailman/listinfo/dri-devel >> >> -- >> Daniel Vetter >> Software Engineer, Intel Corporation >> http://blog.ffwll.ch >> > > --94eb2c0762e6807c40055a1da535 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable


On Tue, Sep 26, 2017 at 10:37 AM, Puthikorn Voravootivat <puthik@chromium.org> wrote:<= br>

<= div class=3D"gmail_extra">
On Mon, Sep 25, 2017 at 10:11 PM, Daniel Vetter <= daniel@ffwll.ch&= gt; wrote:
On Thu, Sep 21, 2017 at 07:42:07AM -0700, Rodrigo Vivi wrote:
> On Wed, Sep 20, 2017 at 02:32:34PM +0000, vathsala nagaraju wrote:
> > Add defines for dpcd register 2009 (synchronization latency
> > in sink).
> >
> > Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> > CC: Puthikorn Voravootivat <puthik@chromium.org>
> > Signed-off-by: Vathsala Nagaraju <vathsala.nagaraju@intel.com><= br> >
> I keep forgetting to update my eDP spec 1.4 to this 1.4b...

Maybe the patch should then make this clear, by annotating it with /* eDP 1.4b */ That's missing, which isn't all that great really, s= ince it
makes specs hunts like yours necessary.

It's actually in eDP 1.4 spec, table 5-6 p= age 86
Copy and paste the wrong on= e.
0x2009 is actually in eDP 1.4 spec, Table 6-7: DPCD =E2=80=93 = Sink Device PSR Status Field=C2=A0page 124
=C2=A0
=C2= =A0
Please fix up before applying.
-Daniel
>
>
> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>
>
>
> > ---
> >=C2=A0 include/drm/drm_dp_helper.h | 3 +++
> >=C2=A0 1 file changed, 3 insertions(+)
> >
> > diff --git a/include/drm/drm_dp_helper.h b/include/drm/drm_dp_hel= per.h
> > index 11c39f1..846004e6 100644
> > --- a/include/drm/drm_dp_helper.h
> > +++ b/include/drm/drm_dp_helper.h
> > @@ -735,6 +735,9 @@
> >=C2=A0 # define DP_PSR_SINK_INTERNAL_ERROR=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A07
> >=C2=A0 # define DP_PSR_SINK_STATE_MASK=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A00x07
> >
> > +#define DP_SINK_SYNCHRONIZATION_LATENCY=C2=A0 =C2=A0 =C2=A0= =C2=A0 0x2009
> > +# define DP_MAX_RESYNC_FRAME_CNT_MASK=C2=A0 =C2=A0 =C2=A0 =C2=A0= =C2=A0 0xf
> > +
> >=C2=A0 #define DP_RECEIVER_ALPM_STATUS=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 =C2=A0 =C2=A0 0x200b=C2=A0 /* eDP 1.4 */
> >=C2=A0 # define DP_ALPM_LOCK_TIMEOUT_ERROR=C2=A0 =C2=A0 =C2=A0 =C2= =A0 =C2=A0 =C2=A0 (1 << 0)
> >
> > --
> > 1.9.1
> >
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/ma= ilman/listinfo/dri-devel
<= br> --
Daniel Vetter
Software Engineer, Intel Corporation
htt= p://blog.ffwll.ch


--94eb2c0762e6807c40055a1da535-- --===============0385338046== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============0385338046==--