From mboxrd@z Thu Jan 1 00:00:00 1970 From: Puthikorn Voravootivat Subject: Re: [PATCH RESEND v11 0/3] Enhancement to intel_dp_aux_backlight driver Date: Wed, 14 Jun 2017 17:13:15 -0700 Message-ID: References: <20170605215607.27766-1-puthik@chromium.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1465242865==" Return-path: In-Reply-To: <20170605215607.27766-1-puthik@chromium.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Puthikorn Voravootivat Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, Dhinakaran Pandiyan List-Id: dri-devel@lists.freedesktop.org --===============1465242865== Content-Type: multipart/alternative; boundary="001a114fb0442dded80551f48a28" --001a114fb0442dded80551f48a28 Content-Type: text/plain; charset="UTF-8" Friendly ping. Is this patch set good to go now? On Mon, Jun 5, 2017 at 2:56 PM, Puthikorn Voravootivat wrote: > This patch set contain 3 patches which are already reviewed by DK. > Another 6 patches in previous version was already merged in v7 and v9. > - First patch sets the PWM freqency to match data in panel vbt. > - Next patch adds heuristic to determine whether we should use AUX > or PWM pin to adjust panel backlight brightness. > - Last patch adds support for dynamic brightness. > > Change log: > v11: > - Reorder patches in v10 to make the last patch come first > - Fix nits > > v10: > - Add heuristic in patch #1 > - Add _unsafe mod option in patch #1, #2 > - handle frequency set error in patch #3 > > v9: > - Fix nits in v8 > > v8: > - Drop 4 patches that was already merged > - Move DP_EDP_BACKLIGHT_AUX_ENABLE_CAP check to patch #2 to avoid > behavior change if only apply patch #1 > - Add TODO to warn about enable backlight twice in patch #2 > - Use DIV_ROUND_CLOSEST instead of just "/" in patch #5 > - Fix bug calculate pn in patch #5 > - Clarify commit message / code comment in patch #5 > > v7: > - Add check in intel_dp_pwm_pin_display_control_capable in patch #4 > - Add option in patch #6 to enable DPCD or not > - Change definition in patch #8 and implementation in #9 to use Khz > - Fix compiler warning from build bot in patch #9 > > v6: > - Address review from Dhinakaran > - Make PWM frequency to have highest value of Pn that make the > frequency still within 25% of desired frequency. > > v5: > - Split first patch in v4 to 3 patches > - Bump priority for "Correctly enable backlight brightness adjustment via > DPCD" > - Make logic clearer for the case that both PWM pin and AUX are supported > - Add more log when write to register fail > - Add log when enable DBC > > v4: > - Rebase / minor typo fix. > > v3: > - Add new implementation of PWM frequency patch > > v2: > - Drop PWM frequency patch > - Address suggestion from Jani Nikula > > Puthikorn Voravootivat (3): > drm/i915: Set PWM divider to match desired frequency in vbt > drm/i915: Add heuristic to determine better way to adjust brightness > drm/i915: Add option to support dynamic backlight via DPCD > > drivers/gpu/drm/i915/i915_params.c | 12 +- > drivers/gpu/drm/i915/i915_params.h | 5 +- > drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 185 > ++++++++++++++++++++++++-- > 3 files changed, 186 insertions(+), 16 deletions(-) > > -- > 2.13.0.506.g27d5fe0cd-goog > > --001a114fb0442dded80551f48a28 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Friendly ping.

Is this patch set good t= o go now?

On Mon, Jun 5, 2017 at 2:56 PM, Puthikorn Voravootivat <puthik@chrom= ium.org> wrote:
This patch = set contain 3 patches which are already reviewed by DK.
Another 6 patches in previous version was already merged in v7 and v9.
- First patch sets the PWM freqency to match data in panel vbt.
- Next patch adds heuristic to determine whether we should use AUX
=C2=A0 or PWM pin to adjust panel backlight brightness.
- Last patch adds support for dynamic brightness.

Change log:
v11:
- Reorder patches in v10 to make the last patch come first
- Fix nits

v10:
- Add heuristic in patch #1
- Add _unsafe mod option in patch #1, #2
- handle frequency set error in patch #3

v9:
- Fix nits in v8

v8:
- Drop 4 patches that was already merged
- Move DP_EDP_BACKLIGHT_AUX_ENABLE_CAP check to patch #2 to avoid
=C2=A0 behavior change if only apply patch #1
- Add TODO to warn about enable backlight twice in patch #2
- Use DIV_ROUND_CLOSEST instead of just "/" in patch #5
- Fix bug calculate pn in patch #5
- Clarify commit=C2=A0 message / code comment in patch #5

v7:
- Add check in intel_dp_pwm_pin_display_control_capable in patch #4 - Add option in patch #6 to enable DPCD or not
- Change definition in patch #8 and implementation in #9 to use Khz
- Fix compiler warning from build bot in patch #9

v6:
- Address review from Dhinakaran
- Make PWM frequency to have highest value of Pn that make the
=C2=A0 frequency still within 25% of desired frequency.

v5:
- Split first patch in v4 to 3 patches
- Bump priority for "Correctly enable backlight brightness adjustment = via DPCD"
- Make logic clearer for the case that both PWM pin and AUX are supported - Add more log when write to register fail
- Add log when enable DBC

v4:
- Rebase / minor typo fix.

v3:
- Add new implementation of PWM frequency patch

v2:
- Drop PWM frequency patch
- Address suggestion from Jani Nikula

Puthikorn Voravootivat (3):
=C2=A0 drm/i915: Set PWM divider to match desired frequency in vbt
=C2=A0 drm/i915: Add heuristic to determine better way to adjust brightness=
=C2=A0 drm/i915: Add option to support dynamic backlight via DPCD

=C2=A0drivers/gpu/drm/i915/i915_params.c=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 |=C2=A0 12 +-
=C2=A0drivers/gpu/drm/i915/i915_params.h=C2=A0 =C2=A0 =C2=A0 =C2=A0 = =C2=A0 =C2=A0 |=C2=A0 =C2=A05 +-
=C2=A0drivers/gpu/drm/i915/intel_dp_aux_backlight.c | 185 ++++++++++++= ++++++++++++--
=C2=A03 files changed, 186 insertions(+), 16 deletions(-)

--
2.13.0.506.g27d5fe0cd-goog


--001a114fb0442dded80551f48a28-- --===============1465242865== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1465242865==--