From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vladimir Medvedkin <medvedkinv@gmail.com>
Subject: Re: [PATCH v2 2/3] build: fix check for libbsd in meson
Date: Fri, 27 Apr 2018 20:51:04 +0300
Message-ID: <CANDrEHmMzmvWHXFT+C5vazChz5aOw8OEy0U_Pw89BsHTWanFkA@mail.gmail.com>
References: <20180418210521.277384-1-bruce.richardson@intel.com>
 <20180427134928.4716-1-bruce.richardson@intel.com>
 <20180427134928.4716-3-bruce.richardson@intel.com>
 <20180427135129.GA89888@bricha3-MOBL.ger.corp.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Cc: dev@dpdk.org, hemant.agrawal@nxp.com, bluca@debian.org
To: Bruce Richardson <bruce.richardson@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-qt0-f196.google.com (mail-qt0-f196.google.com
 [209.85.216.196]) by dpdk.org (Postfix) with ESMTP id 53A63CFD8
 for <dev@dpdk.org>; Fri, 27 Apr 2018 19:51:05 +0200 (CEST)
Received: by mail-qt0-f196.google.com with SMTP id j42-v6so3338312qtj.12
 for <dev@dpdk.org>; Fri, 27 Apr 2018 10:51:05 -0700 (PDT)
In-Reply-To: <20180427135129.GA89888@bricha3-MOBL.ger.corp.intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Hi,

2018-04-27 16:51 GMT+03:00 Bruce Richardson <bruce.richardson@intel.com>:

> On Fri, Apr 27, 2018 at 02:49:27PM +0100, Bruce Richardson wrote:
> > When we check for libbsd we were just checking for the library itself.
> > However, on some distros, e.g. CentOS, libbsd will be found even though
> > it's not usable by DPDK as it's missing the string header. Therefore we
> > should check for both the library and the header file.
> >
> > Fixes: 5364de644a4b ("eal: support strlcpy function")
> >
>
> Sorry, forgot to add:
>
> Reported-by: Vladimir Medvedkin <medvedkinv@gmail.com>
>
> > Signed-off-by: Bruce Richarson <bruce.richardson@intel.com>
> > ---
> >  config/meson.build | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/config/meson.build b/config/meson.build
> > index 5815b5602..2179c689c 100644
> > --- a/config/meson.build
> > +++ b/config/meson.build
> > @@ -43,7 +43,8 @@ if numa_dep.found() and cc.has_header('numaif.h')
> >  endif
> >
> >  # check for strlcpy
> > -if host_machine.system() == 'linux' and cc.find_library('bsd',
> required: false).found()
> > +if host_machine.system() == 'linux' and cc.find_library('bsd',
> > +             required: false).found() and cc.has_header('bsd/string.h')
> >       dpdk_conf.set('RTE_USE_LIBBSD', 1)
> >       add_project_link_arguments('-lbsd', language: 'c')
> >       dpdk_extra_ldflags += '-lbsd'
> > --
> > 2.14.3
> >
>

Acked-by: Vladimir Medvedkin <medvedkinv@gmail.com>

-- 
Regards,
Vladimir