From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 12674C433DB for ; Wed, 20 Jan 2021 01:17:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CFCE422C9E for ; Wed, 20 Jan 2021 01:17:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728331AbhATBRY (ORCPT ); Tue, 19 Jan 2021 20:17:24 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51380 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730531AbhATBPv (ORCPT ); Tue, 19 Jan 2021 20:15:51 -0500 Received: from mail-vk1-xa2b.google.com (mail-vk1-xa2b.google.com [IPv6:2607:f8b0:4864:20::a2b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F342FC061757 for ; Tue, 19 Jan 2021 17:15:07 -0800 (PST) Received: by mail-vk1-xa2b.google.com with SMTP id p128so5286174vkf.12 for ; Tue, 19 Jan 2021 17:15:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Brf3WO950D1Q6AZvZIOD9DGe8ISGSWxrv8pGr/tlzMU=; b=EtQvUWk7uKUBuqxqWiTn1+cdCMqvcZrSNSg8dh7GOx17/dg+ptQEJHeRtha9a92jku Sn4hT0kwZn4e12PMw3rDhCetZBM8MM8v7kohIMohZhkW/CdymAyhbCA0f52O1Ks4nr/a Oc9MtFvU5z1xziTTFDR9wDfpEybEbAsofBCBU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Brf3WO950D1Q6AZvZIOD9DGe8ISGSWxrv8pGr/tlzMU=; b=LIE/zEIB5E0M36j5qfl7WfTPS8Hmvi1rcE/5Rn1sA9aWtqdo4Mm7f2WeQp8kIIoQEL vOx5p9o6A5/dcZVLj5m/lzE0/PI3Bro35ZlVmIscmchSY/OyncrFktYojEB7lHtHbl8K jrqew9slVq4dElKbICXZvK7Dy9zRN6DmEBXmmynUGCdqNIAB+YvkTaXcURPZGUYocRsT +wlAMCU6doEFfaD3cb/Wf1WBErtLZ5jFYAuHxwbVaKa71kHeXxi8jhkCVYLtF4rO/QIc 863oDu5QwUE83Fx1PpS/hTM0dQYS3tK7auG3nU6YSN2/wB4JogGrk4gqCrezOj+/ky5z oHGg== X-Gm-Message-State: AOAM530Z0L6I0ubtt7FqcZ7hGStjxyU9yZ9CPGIPjkLIk9lviZaP1ze9 XKKc4euAPwuUXzgiPfwn3NvxvggGyldqynaBlaajPw== X-Google-Smtp-Source: ABdhPJxzzWtdGxD8t0BxB6bMkRuGxNx8eneoxGE+jzu/u6mGGowOJfIQW7qV2QQ0cP//HwTe3jP7meGJRcmxG+Rw7eU= X-Received: by 2002:a1f:1c4c:: with SMTP id c73mr5018609vkc.22.1611105306635; Tue, 19 Jan 2021 17:15:06 -0800 (PST) MIME-Version: 1.0 References: <20210116052623.3196274-1-grundler@chromium.org> <20210116052623.3196274-3-grundler@chromium.org> <20210119134558.5072a1cc@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> <20210119170546.189e12d1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> In-Reply-To: <20210119170546.189e12d1@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> From: Grant Grundler Date: Wed, 20 Jan 2021 01:14:55 +0000 Message-ID: Subject: Re: [PATCH 3/3] net: usb: cdc_ncm: don't spew notifications To: Jakub Kicinski Cc: Grant Grundler , Oliver Neukum , "David S. Miller" , Greg Kroah-Hartman , linux-usb@vger.kernel.org, netdev , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jan 20, 2021 at 1:05 AM Jakub Kicinski wrote: > > On Wed, 20 Jan 2021 00:59:17 +0000 Grant Grundler wrote: > > > > Thanks for the patch, this looks like an improvement over: > > > > > > > > 59b4a8fa27f5 ("CDC-NCM: remove "connected" log message") > > > > > > > > right? Should we bring the "network connection: connected" message back? > > > > > > Yes, we can revert Roland's patch. I didn't see that one. > > > > > > > Do you want all of these patches to be applied to 5.11 and backported? > > > > > > Yes to 5.11. Only the 3rd one really needs to be applied to stable kernels. > > > > Sorry - I was thinking 5.11 was -next (and that's incorrect). > > > > As you suggested below, only the 3rd one really needs to be applied to > > 5.11 and other stable kernels. > > Cool, would you mind reposting just the 3rd patch separately, and > tagged as [PATCH net] so that CI can give it a shaking? Done :) > We'll go from there with the rest. Awesome - thank you! cheers, grant > > > > > > > > Feels to me like the last one is a fix and the rest can go into -next, > > > > WDYT? > > > > > > Exactly.