From: Grant Grundler <grundler@chromium.org>
To: Igor Russkikh <irusskikh@marvell.com>
Cc: Grant Grundler <grundler@chromium.org>,
Dmitrii Bezrukov <dbezrukov@marvell.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
netdev <netdev@vger.kernel.org>,
"David S . Miller" <davem@davemloft.net>,
LKML <linux-kernel@vger.kernel.org>,
Aashay Shringarpure <aashay@google.com>,
Yi Chou <yich@google.com>,
Shervin Oloumi <enlightened@google.com>
Subject: Re: [EXT] Re: [PATCH 0/5] net: atlantic: more fuzzing fixes
Date: Thu, 5 May 2022 13:57:24 -0700 [thread overview]
Message-ID: <CANEJEGuPUBQ3c12RkzBsDu0Ub+QAb3BJxA_v8GsDTeq9Uvzt8g@mail.gmail.com> (raw)
In-Reply-To: <735b9c21-6a8f-0f28-d11d-bd9bbd78986b@marvell.com>
On Thu, May 5, 2022 at 12:11 AM Igor Russkikh <irusskikh@marvell.com> wrote:
>
>
> Hi Grant and Dmitrii,
>
> >> So to close session I guess need to set is_rsc_completed to true when
> >> number of frags is going to exceed value MAX_SKB_FRAGS, then packet will
> >> be built and submitted to stack.
> >> But of course need to check that there will not be any other corner cases
> >> with this new change.
> >
> > Ok. Sounds like I should post a v2 then and just drop 1/5 and 5/5
> > patches. Will post that tomorrow.
>
> I think the part with check `hw_head_ >= ring->size` still can be used safely (patch 5).
Ok - I'll rewrite 5/5 to only include this hunk.
> For patch 1 - I agree it may make things worse, so either drop or think on how to interpret invalid `next` and stop LRO session.
I'll drop the proposed patch for now and discuss with Aashay (ChromeOS
security) more.
cheers,
grant
>
> Thanks,
> Igor
prev parent reply other threads:[~2022-05-05 20:57 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-18 23:17 [PATCH 0/5] net: atlantic: more fuzzing fixes Grant Grundler
2022-04-18 23:17 ` [PATCH 1/5] net: atlantic: limit buff_ring index value Grant Grundler
2022-04-18 23:17 ` [PATCH 2/5] net: atlantic: fix "frag[0] not initialized" Grant Grundler
2022-04-18 23:17 ` [PATCH 3/5] net: atlantic: reduce scope of is_rsc_complete Grant Grundler
2022-04-18 23:17 ` [PATCH 4/5] net: atlantic: add check for MAX_SKB_FRAGS Grant Grundler
2022-04-18 23:17 ` [PATCH 5/5] net: atlantic: verify hw_head_ is reasonable Grant Grundler
2022-04-21 19:53 ` [PATCH 0/5] net: atlantic: more fuzzing fixes Grant Grundler
2022-04-26 16:00 ` [EXT] " Igor Russkikh
2022-04-26 17:20 ` Grant Grundler
2022-05-03 11:14 ` Dmitrii Bezrukov
2022-05-03 18:07 ` Grant Grundler
2022-05-04 14:39 ` Dmitrii Bezrukov
2022-05-04 20:11 ` Grant Grundler
2022-05-05 7:11 ` Igor Russkikh
2022-05-05 20:57 ` Grant Grundler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CANEJEGuPUBQ3c12RkzBsDu0Ub+QAb3BJxA_v8GsDTeq9Uvzt8g@mail.gmail.com \
--to=grundler@chromium.org \
--cc=aashay@google.com \
--cc=davem@davemloft.net \
--cc=dbezrukov@marvell.com \
--cc=enlightened@google.com \
--cc=irusskikh@marvell.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.