From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CAA01CA9EB9 for ; Sat, 26 Oct 2019 17:39:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 94F172070B for ; Sat, 26 Oct 2019 17:39:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lmhZG5Wm" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726318AbfJZRja (ORCPT ); Sat, 26 Oct 2019 13:39:30 -0400 Received: from mail-qk1-f193.google.com ([209.85.222.193]:44908 "EHLO mail-qk1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726270AbfJZRja (ORCPT ); Sat, 26 Oct 2019 13:39:30 -0400 Received: by mail-qk1-f193.google.com with SMTP id g21so4749930qkm.11 for ; Sat, 26 Oct 2019 10:39:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WJj+XYLe3cMZIZoQ9vr6L71XNxTz/FYk/4q0duDThfY=; b=lmhZG5WmjZSGyG/n8DvvWPUtaIUQTSAcqfXm1lhQkFBllCnZ0iPY0qO+FfncxWVG1O iGaup108mV3brmcMFcKNNZG1pEu5uY5d31Q7MY//EU1hh+eyZ1YJmsNnwtuZu+TxM3uk uhzDUa/57Q+1Od0c9tEFXNNNfwOEFVHqPLRBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WJj+XYLe3cMZIZoQ9vr6L71XNxTz/FYk/4q0duDThfY=; b=K+PmKGhFJtXdPjCUbZ5bwc+idVmffIKbk1+Btxb/a9EdY6lImPkwyOvhfcjzaiIjMk 28qvmRwmbve5GuTvpSzxb6Bq1LfbZ/jWKm/sJ1Dv+orsN/Ej/2ari9+8CxBGVpaZ09Sg WedQRyOSdXbGV7x0DUuX6CQkWy+r/8ALzVOHVjK7d+/Y318EYZYCjEJLtT4qBPiVJOz8 oOK2Kl77lJWjlXOHN5CpM8JxixZrA5aU9nLxNp/59YXR5ciPDww1FMcvtxf95XZZEoKJ KSgHAaPFFD0dkVo2XAnATwbdi8Ff+WwOY10noBH02qNlzN/v8QxPpb/X1DrtXZMZ/ypo u2uw== X-Gm-Message-State: APjAAAVf9KG29C5tyfUqwp+Q/tdyt4drIzBnRRz6e/eRV+RykJbcqN96 7FIB3lmye0pV6XPVlKLNqyAw+JpsHUxClSEYWeqgGg== X-Google-Smtp-Source: APXvYqxNNWzFrSsnCjh1NbFwr4AgLKBoBn+uLrUEM4+ByNDY81vMaaOzmML5AYyWCxiqf2lVQlNLxbhZNQL2Jn753dk= X-Received: by 2002:a37:4dd1:: with SMTP id a200mr8422942qkb.419.1572111568786; Sat, 26 Oct 2019 10:39:28 -0700 (PDT) MIME-Version: 1.0 References: <20191025215428.31607-1-abhishekpandit@chromium.org> <20191025215428.31607-4-abhishekpandit@chromium.org> In-Reply-To: From: Abhishek Pandit-Subedi Date: Sat, 26 Oct 2019 10:39:18 -0700 Message-ID: Subject: Re: [PATCH 3/3] ARM: dts: rockchip: Add brcm bluetooth module on uart0 To: Doug Anderson Cc: Johan Hedberg , Marcel Holtmann , linux-bluetooth@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Heiko Stuebner , LKML , "open list:ARM/Rockchip SoC..." , Rob Herring , Mark Rutland , Linux ARM Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Yes, these shouldn't be for all of Veyron, only Minnie, Mickey and Speedy -- my mistake. I'll send an updated patch with your suggestions. Thanks Abhishek On Fri, Oct 25, 2019 at 3:50 PM Doug Anderson wrote: > > Hi, > > On Fri, Oct 25, 2019 at 2:55 PM Abhishek Pandit-Subedi > wrote: > > > > This enables the Broadcom uart bluetooth driver on uart0 and gives it > > ownership of its gpios. In order to use this, you must enable the > > following kconfig options: > > - CONFIG_BT_HCIUART_BCM > > - CONFIG_SERIAL_DEV > > > > Signed-off-by: Abhishek Pandit-Subedi > > --- > > > > arch/arm/boot/dts/rk3288-veyron.dtsi | 31 +++++++--------------------- > > 1 file changed, 7 insertions(+), 24 deletions(-) > > > > diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi > > index 7525e3dd1fc1..8c9f91ba6f57 100644 > > --- a/arch/arm/boot/dts/rk3288-veyron.dtsi > > +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi > > You are changing this for _all_ veryon, not just those veyron devices > using Broadcom. I don't think you want to change the marvell-based > boards. > > ...presumably you'll want to make you change only affect minnie, > speedy, and mickey. > > > > @@ -23,30 +23,6 @@ > > reg = <0x0 0x0 0x0 0x80000000>; > > }; > > > > - bt_activity: bt-activity { > > - compatible = "gpio-keys"; > > - pinctrl-names = "default"; > > - pinctrl-0 = <&bt_host_wake>; > > - > > - /* > > - * HACK: until we have an LPM driver, we'll use an > > - * ugly GPIO key to allow Bluetooth to wake from S3. > > - * This is expected to only be used by BT modules that > > - * use UART for comms. For BT modules that talk over > > - * SDIO we should use a wakeup mechanism related to SDIO. > > - * > > - * Use KEY_RESERVED here since that will work as a wakeup but > > - * doesn't get reported to higher levels (so doesn't confuse > > - * Chrome). > > - */ > > - bt-wake { > > - label = "BT Wakeup"; > > - gpios = <&gpio4 RK_PD7 GPIO_ACTIVE_HIGH>; > > - linux,code = ; > > - wakeup-source; > > - }; > > - > > - }; > > > > power_button: power-button { > > compatible = "gpio-keys"; > > @@ -434,6 +410,13 @@ > > /* Pins don't include flow control by default; add that in */ > > pinctrl-names = "default"; > > pinctrl-0 = <&uart0_xfer &uart0_cts &uart0_rts>; > > + > > + bluetooth { > > + compatible = "brcm,bcm43540-bt"; > > You probably need some pinctrl entries here to make sure that things > are properly configured, like: > > pinctrl-names = "default"; > pinctrl-0 = <&bt_host_wake>, <&bt_dev_wake>, <&bt_enable>; > > This would require defining bt_dev_wake and bt_enable and removing the > hacky output-only versions they have now. > > > > + host-wakeup-gpios = <&gpio4 RK_PD7 GPIO_ACTIVE_HIGH>; > > + shutdown-gpios = <&gpio4 RK_PD5 GPIO_ACTIVE_LOW>; > > Right now gpio4 RK_PD5 is controlled by the "sdio_pwrseq". Should you > remove it from there? Looks like it was a no-op for marvell which > makes it a little easier. > > > > + device-wakeup-gpios = <&gpio4 RK_PD2 GPIO_ACTIVE_HIGH>; > > You probably need to stop driving this in the pinctrl hogs for > Broadcom boards... > > > -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 From: Abhishek Pandit-Subedi Subject: Re: [PATCH 3/3] ARM: dts: rockchip: Add brcm bluetooth module on uart0 Date: Sat, 26 Oct 2019 10:39:18 -0700 Message-ID: References: <20191025215428.31607-1-abhishekpandit@chromium.org> <20191025215428.31607-4-abhishekpandit@chromium.org> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: linux-kernel-owner@vger.kernel.org To: Doug Anderson Cc: Johan Hedberg , Marcel Holtmann , linux-bluetooth@vger.kernel.org, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Heiko Stuebner , LKML , "open list:ARM/Rockchip SoC..." , Rob Herring , Mark Rutland , Linux ARM List-Id: linux-rockchip.vger.kernel.org Yes, these shouldn't be for all of Veyron, only Minnie, Mickey and Speedy -- my mistake. I'll send an updated patch with your suggestions. Thanks Abhishek On Fri, Oct 25, 2019 at 3:50 PM Doug Anderson wrote: > > Hi, > > On Fri, Oct 25, 2019 at 2:55 PM Abhishek Pandit-Subedi > wrote: > > > > This enables the Broadcom uart bluetooth driver on uart0 and gives it > > ownership of its gpios. In order to use this, you must enable the > > following kconfig options: > > - CONFIG_BT_HCIUART_BCM > > - CONFIG_SERIAL_DEV > > > > Signed-off-by: Abhishek Pandit-Subedi > > --- > > > > arch/arm/boot/dts/rk3288-veyron.dtsi | 31 +++++++--------------------- > > 1 file changed, 7 insertions(+), 24 deletions(-) > > > > diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi > > index 7525e3dd1fc1..8c9f91ba6f57 100644 > > --- a/arch/arm/boot/dts/rk3288-veyron.dtsi > > +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi > > You are changing this for _all_ veryon, not just those veyron devices > using Broadcom. I don't think you want to change the marvell-based > boards. > > ...presumably you'll want to make you change only affect minnie, > speedy, and mickey. > > > > @@ -23,30 +23,6 @@ > > reg = <0x0 0x0 0x0 0x80000000>; > > }; > > > > - bt_activity: bt-activity { > > - compatible = "gpio-keys"; > > - pinctrl-names = "default"; > > - pinctrl-0 = <&bt_host_wake>; > > - > > - /* > > - * HACK: until we have an LPM driver, we'll use an > > - * ugly GPIO key to allow Bluetooth to wake from S3. > > - * This is expected to only be used by BT modules that > > - * use UART for comms. For BT modules that talk over > > - * SDIO we should use a wakeup mechanism related to SDIO. > > - * > > - * Use KEY_RESERVED here since that will work as a wakeup but > > - * doesn't get reported to higher levels (so doesn't confuse > > - * Chrome). > > - */ > > - bt-wake { > > - label = "BT Wakeup"; > > - gpios = <&gpio4 RK_PD7 GPIO_ACTIVE_HIGH>; > > - linux,code = ; > > - wakeup-source; > > - }; > > - > > - }; > > > > power_button: power-button { > > compatible = "gpio-keys"; > > @@ -434,6 +410,13 @@ > > /* Pins don't include flow control by default; add that in */ > > pinctrl-names = "default"; > > pinctrl-0 = <&uart0_xfer &uart0_cts &uart0_rts>; > > + > > + bluetooth { > > + compatible = "brcm,bcm43540-bt"; > > You probably need some pinctrl entries here to make sure that things > are properly configured, like: > > pinctrl-names = "default"; > pinctrl-0 = <&bt_host_wake>, <&bt_dev_wake>, <&bt_enable>; > > This would require defining bt_dev_wake and bt_enable and removing the > hacky output-only versions they have now. > > > > + host-wakeup-gpios = <&gpio4 RK_PD7 GPIO_ACTIVE_HIGH>; > > + shutdown-gpios = <&gpio4 RK_PD5 GPIO_ACTIVE_LOW>; > > Right now gpio4 RK_PD5 is controlled by the "sdio_pwrseq". Should you > remove it from there? Looks like it was a no-op for marvell which > makes it a little easier. > > > > + device-wakeup-gpios = <&gpio4 RK_PD2 GPIO_ACTIVE_HIGH>; > > You probably need to stop driving this in the pinctrl hogs for > Broadcom boards... > > > -Doug From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AEE59CA9EB9 for ; Sat, 26 Oct 2019 17:39:51 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FE5A2070B for ; Sat, 26 Oct 2019 17:39:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="PQsuipYT"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="lmhZG5Wm" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7FE5A2070B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=V4jZ/L8kYBpInVyu5fBy8fWq9tnV6Y6F1H3Zhnj8FPw=; b=PQsuipYTrqRCkB spIA/F4HxpCOUYM30c+zmSWbCT4Tb2DZXaEVqwB489NsqYqZATIiecrwsK6w5dHglvI9BNeBZEAgy NWiTGZRX7ezGndtG1RhIKR2zPdEU4Vd2pfvuncywIoWfzHChEzVD3ahnYEsMve3eAX/ABN7fHakKb 7kkoGOZd22+UeDhHp5vbzng4vTsvmpYCY/60Awaep4pf+61epdc7M2rxhyit8rnT1CaZxQInD5k2R gkFCrG0IV/wp0YaVQO94MSqBvcu1oq++Nv0BqD+KtI9432U1wobyJgXH5yQmKZ75MV8y+n7h+PIJg m77xsInNZ+FH961Iak0A==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1iOQ2M-0002ih-KS; Sat, 26 Oct 2019 17:39:38 +0000 Received: from mail-qk1-x744.google.com ([2607:f8b0:4864:20::744]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1iOQ2G-0002hU-L8 for linux-arm-kernel@lists.infradead.org; Sat, 26 Oct 2019 17:39:34 +0000 Received: by mail-qk1-x744.google.com with SMTP id q70so4736159qke.12 for ; Sat, 26 Oct 2019 10:39:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=WJj+XYLe3cMZIZoQ9vr6L71XNxTz/FYk/4q0duDThfY=; b=lmhZG5WmjZSGyG/n8DvvWPUtaIUQTSAcqfXm1lhQkFBllCnZ0iPY0qO+FfncxWVG1O iGaup108mV3brmcMFcKNNZG1pEu5uY5d31Q7MY//EU1hh+eyZ1YJmsNnwtuZu+TxM3uk uhzDUa/57Q+1Od0c9tEFXNNNfwOEFVHqPLRBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=WJj+XYLe3cMZIZoQ9vr6L71XNxTz/FYk/4q0duDThfY=; b=TkfqN/BR3waKGDIJDNogyVDMBSs/AWNu71ICaS8LnvO/e29FY2ltq3cq8H7FRCfX3P ng3Raz3HH896bQXBm0WpUevWYm1MWbnycQWXhDHyaRfsl/WtxxZibG8aSNio7Ut6GTxe kGM3OqXy1ZXetcsHz6PBIw6idfq0ZREAZMf392wdYEMCNtaJEX8slI7P4mZUdA9KtPrT bS3ybUxrEjpMNpEjFbx77HjH65eOQrM6pMjMr5HvdmwlF6zaAJUNa6Kvv2RB8oiKRvTG SkAo3oUxUNleqLQsePHcfG9ZCMMCbP0lxVyIEe1w5Sf9KdDWBqvwvpsH1Ia7cRfDXIr/ wU1A== X-Gm-Message-State: APjAAAVXLk9nnySSJ+PDomwH4Ej4Xhdivc6E5qEYSMIg16NWEj7/419S +vN3s7P5RbqvXYeMesj2AlgwkDtYxdR6HtO2OOGI8Q== X-Google-Smtp-Source: APXvYqxNNWzFrSsnCjh1NbFwr4AgLKBoBn+uLrUEM4+ByNDY81vMaaOzmML5AYyWCxiqf2lVQlNLxbhZNQL2Jn753dk= X-Received: by 2002:a37:4dd1:: with SMTP id a200mr8422942qkb.419.1572111568786; Sat, 26 Oct 2019 10:39:28 -0700 (PDT) MIME-Version: 1.0 References: <20191025215428.31607-1-abhishekpandit@chromium.org> <20191025215428.31607-4-abhishekpandit@chromium.org> In-Reply-To: From: Abhishek Pandit-Subedi Date: Sat, 26 Oct 2019 10:39:18 -0700 Message-ID: Subject: Re: [PATCH 3/3] ARM: dts: rockchip: Add brcm bluetooth module on uart0 To: Doug Anderson X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191026_103932_719517_ACD71E67 X-CRM114-Status: GOOD ( 21.34 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , Heiko Stuebner , "open list:ARM/Rockchip SoC..." , Marcel Holtmann , LKML , linux-bluetooth@vger.kernel.org, Rob Herring , Linux ARM , Johan Hedberg Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Yes, these shouldn't be for all of Veyron, only Minnie, Mickey and Speedy -- my mistake. I'll send an updated patch with your suggestions. Thanks Abhishek On Fri, Oct 25, 2019 at 3:50 PM Doug Anderson wrote: > > Hi, > > On Fri, Oct 25, 2019 at 2:55 PM Abhishek Pandit-Subedi > wrote: > > > > This enables the Broadcom uart bluetooth driver on uart0 and gives it > > ownership of its gpios. In order to use this, you must enable the > > following kconfig options: > > - CONFIG_BT_HCIUART_BCM > > - CONFIG_SERIAL_DEV > > > > Signed-off-by: Abhishek Pandit-Subedi > > --- > > > > arch/arm/boot/dts/rk3288-veyron.dtsi | 31 +++++++--------------------- > > 1 file changed, 7 insertions(+), 24 deletions(-) > > > > diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi > > index 7525e3dd1fc1..8c9f91ba6f57 100644 > > --- a/arch/arm/boot/dts/rk3288-veyron.dtsi > > +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi > > You are changing this for _all_ veryon, not just those veyron devices > using Broadcom. I don't think you want to change the marvell-based > boards. > > ...presumably you'll want to make you change only affect minnie, > speedy, and mickey. > > > > @@ -23,30 +23,6 @@ > > reg = <0x0 0x0 0x0 0x80000000>; > > }; > > > > - bt_activity: bt-activity { > > - compatible = "gpio-keys"; > > - pinctrl-names = "default"; > > - pinctrl-0 = <&bt_host_wake>; > > - > > - /* > > - * HACK: until we have an LPM driver, we'll use an > > - * ugly GPIO key to allow Bluetooth to wake from S3. > > - * This is expected to only be used by BT modules that > > - * use UART for comms. For BT modules that talk over > > - * SDIO we should use a wakeup mechanism related to SDIO. > > - * > > - * Use KEY_RESERVED here since that will work as a wakeup but > > - * doesn't get reported to higher levels (so doesn't confuse > > - * Chrome). > > - */ > > - bt-wake { > > - label = "BT Wakeup"; > > - gpios = <&gpio4 RK_PD7 GPIO_ACTIVE_HIGH>; > > - linux,code = ; > > - wakeup-source; > > - }; > > - > > - }; > > > > power_button: power-button { > > compatible = "gpio-keys"; > > @@ -434,6 +410,13 @@ > > /* Pins don't include flow control by default; add that in */ > > pinctrl-names = "default"; > > pinctrl-0 = <&uart0_xfer &uart0_cts &uart0_rts>; > > + > > + bluetooth { > > + compatible = "brcm,bcm43540-bt"; > > You probably need some pinctrl entries here to make sure that things > are properly configured, like: > > pinctrl-names = "default"; > pinctrl-0 = <&bt_host_wake>, <&bt_dev_wake>, <&bt_enable>; > > This would require defining bt_dev_wake and bt_enable and removing the > hacky output-only versions they have now. > > > > + host-wakeup-gpios = <&gpio4 RK_PD7 GPIO_ACTIVE_HIGH>; > > + shutdown-gpios = <&gpio4 RK_PD5 GPIO_ACTIVE_LOW>; > > Right now gpio4 RK_PD5 is controlled by the "sdio_pwrseq". Should you > remove it from there? Looks like it was a no-op for marvell which > makes it a little easier. > > > > + device-wakeup-gpios = <&gpio4 RK_PD2 GPIO_ACTIVE_HIGH>; > > You probably need to stop driving this in the pinctrl hogs for > Broadcom boards... > > > -Doug _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel