All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bailey Forrest <bcf@google.com>
To: Arnd Bergmann <arnd@kernel.org>
Cc: "David S . Miller" <davem@davemloft.net>,
	Jakub Kicinski <kuba@kernel.org>,
	Networking <netdev@vger.kernel.org>
Subject: Re: [PATCH net] gve: DQO: Suppress unused var warnings
Date: Mon, 27 Sep 2021 13:21:30 -0700	[thread overview]
Message-ID: <CANH7hM7_brYnVu_x7=+vY34SGQNbc7GUGQmAqpYwXGgVP0RH6Q@mail.gmail.com> (raw)
In-Reply-To: <CAK8P3a1aGA+xqpUPOfGVtt3ch8bvDd75OP=xphN_FrUiuyuX+w@mail.gmail.com>

Apologies, resending as text

On Mon, Sep 27, 2021 at 2:59 AM Arnd Bergmann <arnd@kernel.org> wrote:
>
> On Sat, Jul 24, 2021 at 1:19 AM Bailey Forrest <bcf@google.com> wrote:
> >
> > Some variables become unused when `CONFIG_NEED_DMA_MAP_STATE=n`.
> >
> > We only suppress when `CONFIG_NEED_DMA_MAP_STATE=n` in order to avoid
> > false negatives.
> >
> > Fixes: a57e5de476be ("gve: DQO: Add TX path")
> > Signed-off-by: Bailey Forrest <bcf@google.com>
>
> Hi Bailey,
>
> I see that the warning still exists in linux-5.15-rc3 and net-next,
> I'm building with my original patch[1] to get around the -Werror
> warnings.
>
> Can you resend your patch, or should I resend mine after all?
>
>       Arnd
>
> [1] https://lore.kernel.org/all/20210721151100.2042139-1-arnd@kernel.org/

Hi David/Jakub,

Any thoughts on my patch? I'm open to alternative suggestions for how
to resolve this.

This patch still works and merges cleanly on HEAD.

Thanks,
Bailey

  reply	other threads:[~2021-09-27 20:21 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-23 23:19 [PATCH net] gve: DQO: Suppress unused var warnings Bailey Forrest
2021-09-27  9:58 ` Arnd Bergmann
2021-09-27 20:21   ` Bailey Forrest [this message]
2021-09-27 23:21     ` Jakub Kicinski
2021-09-27 23:59       ` Bailey Forrest
2021-09-28 14:15         ` Arnd Bergmann
2021-09-28 20:04           ` Bailey Forrest

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CANH7hM7_brYnVu_x7=+vY34SGQNbc7GUGQmAqpYwXGgVP0RH6Q@mail.gmail.com' \
    --to=bcf@google.com \
    --cc=arnd@kernel.org \
    --cc=davem@davemloft.net \
    --cc=kuba@kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.