From mboxrd@z Thu Jan  1 00:00:00 1970
From: Che-liang Chiou <clchiou@chromium.org>
Date: Mon, 19 Dec 2011 17:51:54 +0800
Subject: [U-Boot] [PATCH v1 2/2] tpm: Add i2c TPM driver
In-Reply-To: <201112161221.14711.vapier@gentoo.org>
References: <1323852504-19954-1-git-send-email-clchiou@chromium.org>
	<1323852504-19954-3-git-send-email-clchiou@chromium.org>
	<201112161221.14711.vapier@gentoo.org>
Message-ID: <CANJuy2JZ93xHVEyWQZ5VUrT6ae=M2YJwvnnd8YceH3hDtqrB2A@mail.gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

On Sat, Dec 17, 2011 at 1:21 AM, Mike Frysinger <vapier@gentoo.org> wrote:
> On Wednesday 14 December 2011 03:48:24 Che-Liang Chiou wrote:
>> --- /dev/null
>> +++ b/drivers/tpm/tpm.c
>>
>> +int tis_sendrecv(const uint8_t *sendbuf, size_t send_size, uint8_t
>> *recvbuf, + ? ? ? ? ? size_t *recv_len)
>> +{
>> + ? ? ? ? ? ? error("%s: invalid send_size %zx\n", __func__, send_size);
>
> using __func__ with error() makes no sense as error() already includes that

Done.

>> --- /dev/null
>> +++ b/drivers/tpm/tpm_private.h
>
> this should probably include linux/types.h and linux/compiler.h since it uses
> __be32 and __packed

Done.

>> --- /dev/null
>> +++ b/drivers/tpm/tpm_tis_i2c.c
>>
>> + ? ? ? ? ? ? if (burstcnt > (len-1-count))
>> + ? ? ? ? ? ? ? ? ? ? burstcnt = len-1-count;
>
> add some spaces around those "-"

Done.

> -mike