All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tomoya MORINAGA <tomoya.rohm@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc/pch_phub: Enable UART clock setting by module parameter
Date: Tue, 31 Jul 2012 19:36:49 +0900	[thread overview]
Message-ID: <CANKRQnimtFQapk-u_ipYYOqrVVavGBCqcAG6x82WNWCH_Jcdkw@mail.gmail.com> (raw)
In-Reply-To: <201207251331.52883.arnd@arndb.de>

On Wed, Jul 25, 2012 at 10:31 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> What I think should work better here would be to use the clk API,
> so that the phub driver registers a 'struct clk' using
> (I assume) clk_register_divider_table().
> The UART driver would then call clk_get() to find that clk for
> the uart device and call clk_set_rate when it needs to change
> that clock in order to set a different baud rate.
>
> Does this make sense?
>

Thank you for your comments. This sounds good idea.
However, it seems the latest kernel doesn't have clk_register_divider_table().
Will the clk_register_divider_table function be applied soon ?

Thanks.

-- 
ROHM Co., Ltd.
tomoya

  reply	other threads:[~2012-07-31 10:36 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-07-11  9:57 [PATCH] misc/pch_phub: Enable UART clock setting by module parameter Tomoya MORINAGA
2012-07-11 10:45 ` Arnd Bergmann
2012-07-12  0:54   ` Tomoya MORINAGA
2012-07-24 23:57     ` Tomoya MORINAGA
2012-07-25 13:31       ` Arnd Bergmann
2012-07-31 10:36         ` Tomoya MORINAGA [this message]
2012-07-31 21:01           ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CANKRQnimtFQapk-u_ipYYOqrVVavGBCqcAG6x82WNWCH_Jcdkw@mail.gmail.com \
    --to=tomoya.rohm@gmail.com \
    --cc=arnd@arndb.de \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.