From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5FDA4C433EF for ; Mon, 13 Sep 2021 17:08:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 49411610CE for ; Mon, 13 Sep 2021 17:08:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242067AbhIMRJu (ORCPT ); Mon, 13 Sep 2021 13:09:50 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:54804 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242046AbhIMRJt (ORCPT ); Mon, 13 Sep 2021 13:09:49 -0400 Received: from mail-ej1-x62f.google.com (mail-ej1-x62f.google.com [IPv6:2a00:1450:4864:20::62f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 179B9C061574 for ; Mon, 13 Sep 2021 10:08:33 -0700 (PDT) Received: by mail-ej1-x62f.google.com with SMTP id i21so22620077ejd.2 for ; Mon, 13 Sep 2021 10:08:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cjPU+X9z9q5//ZdtVdqefXjWrLECo/nmrS1BCrfqx7g=; b=ghiF91VkcaKIpKSUng2aUjJ9vVT9FvGOpbvsTPrpeC/Xlosl0bJN7JExpc+JWor1Hm 4yvTiO1X6f5vOWiI4lWguUEQc4MAsEM1hSZvY0sbrYesGX/5MGxjNIwMKt5qXlc5QPtR GeWyokind7pfnfdD9Deph1ghZsRaYkmsWYvGJecZwNvjIWMXsHhzHalM7M7CObpn0j3f LPs2a83a2qk2DqAGDKejG73kqz++sFzSLnXaNAcIakBKE7c3wv+uW8izyMpzJVV54hCI F3pHZcUDht13JnLmsWbTRoDfTgXqqMHvIIfRDzgYQTgfAQSs6WEhP5EG5nY4aM0kCUxE hQsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cjPU+X9z9q5//ZdtVdqefXjWrLECo/nmrS1BCrfqx7g=; b=N5r+ujZI8FCzQ1bugpROLpNGKVjWuHmjrlakzsE93lQuhVqKHZIuAp1LZYup1gvUNz 6rNBvPqiU+qYLF8+xYsQG4+tNvcAT0n4V9+OK+gy2jSkx/7xvROOmPzKikvp4FkVGmdk qcUX0MkU+rhu3lA2w8boxZuKPMSJFPEnIaVsu0dAhZBgsFlZCUtFSsJrDZrsiIkYomUB yuCLOl04swOM3tNS2Nt84os7uLyIq0vUCGdZwI5SZG3q7IHE44BkhR5YbJsdCXpT1qcJ brU5ODlA9iLr+iG3wIHyQhhi0lnSkQQJV67DguH4o+2/+K/nkTCaGl+49B8lJLMdQ26I 2MDA== X-Gm-Message-State: AOAM531oEfKsBtsdc3RxrkPh+2NF9v3cRWlI917DlV0Ju+V4ASz2pA0i D2kKzoT8rQ6O2jHI5/xE2q7BRvnmNtMKSEDPvmZoDg== X-Google-Smtp-Source: ABdhPJyZlYWjcU4fshnZAhArELY92YocVWhkvsqsWqoxB6o41HaD+s6nKUDT9uEmHcDzaizJBz3LhL1qETW2KBy5mP8= X-Received: by 2002:a17:907:2662:: with SMTP id ci2mr13615318ejc.107.1631552911570; Mon, 13 Sep 2021 10:08:31 -0700 (PDT) MIME-Version: 1.0 References: <1631092255-25150-1-git-send-email-shengjiu.wang@nxp.com> <1631092255-25150-5-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: From: Mathieu Poirier Date: Mon, 13 Sep 2021 11:08:19 -0600 Message-ID: Subject: Re: [PATCH v4 4/4] dt-bindings: dsp: fsl: update binding document for remote proc driver To: Shengjiu Wang Cc: Rob Herring , Shengjiu Wang , Ohad Ben-Cohen , Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , daniel.baluta@nxp.com, NXP Linux Team , linux-remoteproc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Sun, 12 Sept 2021 at 20:50, Shengjiu Wang wrote: > > Hi Rob > > On Sat, Sep 11, 2021 at 5:43 AM Rob Herring wrote: > > > > On Wed, Sep 08, 2021 at 05:10:55PM +0800, Shengjiu Wang wrote: > > > As there are two drivers for DSP on i.MX, one is for sound open > > > firmware, another is for remote processor framework. In order to > > > distinguish two kinds of driver, defining different compatible strings. > > > > What determines which firmware is used? Is it tied to the board? Or for > > a given board, users could want different firmware? In the latter case, > > this configuration should not be in DT. > > The compatible string determines which firmware is used. > For a given board, users could want different firmware, then need > to reboot the kernel and switch to another DTB. > > > > > > For remote proc driver, the properties firmware-name and fsl,dsp-ctrl > > > are needed and the mailbox channel is different with SOF. > > > > > > Signed-off-by: Shengjiu Wang > > > --- > > > .../devicetree/bindings/dsp/fsl,dsp.yaml | 81 +++++++++++++++++-- > > > 1 file changed, 75 insertions(+), 6 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > > index 7afc9f2be13a..51ea657f6d42 100644 > > > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > > @@ -8,6 +8,7 @@ title: NXP i.MX8 DSP core > > > > > > maintainers: > > > - Daniel Baluta > > > + - Shengjiu Wang > > > > > > description: | > > > Some boards from i.MX8 family contain a DSP core used for > > > @@ -19,6 +20,10 @@ properties: > > > - fsl,imx8qxp-dsp > > > - fsl,imx8qm-dsp > > > - fsl,imx8mp-dsp > > > + - fsl,imx8qxp-hifi4 > > > + - fsl,imx8qm-hifi4 > > > + - fsl,imx8mp-hifi4 > > > + - fsl,imx8ulp-hifi4 > > > > > > reg: > > > maxItems: 1 > > > @@ -28,37 +33,63 @@ properties: > > > - description: ipg clock > > > - description: ocram clock > > > - description: core clock > > > + - description: debug interface clock > > > + - description: message unit clock > > > + minItems: 3 > > > + maxItems: 5 > > > > > > clock-names: > > > items: > > > - const: ipg > > > - const: ocram > > > - const: core > > > + - const: debug > > > + - const: mu > > > + minItems: 3 > > > + maxItems: 5 > > > > > > power-domains: > > > description: > > > List of phandle and PM domain specifier as documented in > > > Documentation/devicetree/bindings/power/power_domain.txt > > > + minItems: 1 > > > maxItems: 4 > > > > How does the same h/w have different number of power domains? > > For different SoC, the integration is different, on i.MX8QM/8QXP, there are > 4 power-domains for DSP, but on i.MX8MP, there are 1 power-domain. > > > > > > > > > mboxes: > > > description: > > > List of <&phandle type channel> - 2 channels for TXDB, 2 channels for RXDB > > > + or - 1 channel for TX, 1 channel for RX, 1 channel for RXDB > > > (see mailbox/fsl,mu.txt) > > > + minItems: 3 > > > maxItems: 4 > > > > > > mbox-names: > > > - items: > > > - - const: txdb0 > > > - - const: txdb1 > > > - - const: rxdb0 > > > - - const: rxdb1 > > > + oneOf: > > > + - items: > > > + - const: txdb0 > > > + - const: txdb1 > > > + - const: rxdb0 > > > + - const: rxdb1 > > > + - items: > > > + - const: tx > > > + - const: rx > > > + - const: rxdb > > > > These are completely different mailboxes? > > It is the same mailbox, for this mailbox, there are 16 channels > (4 for tx, 4 for rx, 4 for txdb, 4 for rxdb). > For sound open firmware and remoteproc firmware, they > use different mailbox channels. > > > > > > > > > memory-region: > > > description: > > > phandle to a node describing reserved memory (System RAM memory) > > > used by DSP (see bindings/reserved-memory/reserved-memory.txt) > > > - maxItems: 1 > > > + minItems: 1 > > > + maxItems: 4 > > > + > > > + firmware-name: > > > + description: | > > > + Default name of the firmware to load to the remote processor. > > > + > > > + fsl,dsp-ctrl: > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > + description: > > > + Phandle to syscon block which provide access for processor enablement > > > > Curious, how is this done with the open sound f/w? > > Currently the code for this in sound open firmware is not upsteamed, > I think this phandle is also applied for sound open firmware. > > By the way, Should I separate the change of this file from this > patch series? Does it belong to your linux tree? Please keep the patches together. Once Rob acks the bindings, patches in this series will be picked up in the remoteproc tree. Thanks, Mathieu > > > Best Regards > Wang Shengjiu From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBD33C433F5 for ; Mon, 13 Sep 2021 17:26:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id BE0C56103B for ; Mon, 13 Sep 2021 17:26:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org BE0C56103B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6AoY0j45iNxQrslcG8aGf6/9lqFo9q3OHb9qg6mqyD0=; b=e4OrbjvfSTIuQi w016QFmdyfjm5yrYLMj42rpEuy8mQhTxRWao47TfwxFyupUUQoSG87hieO+KyR6Q9ewyXTuYlYg5Z fJNqyuJwZ4+q4KK8w81bJrZHGGVB9Rf3szQG27Z6w9Cg6yZmXysS71YZ62O3+MHw8PmjBBsQoEUyj Ta6P5Rj8qzY6UQA212X10dvhbyA3ceY7UsgOgQVizBPetPGVG1uLLaUbY1OizmnP9iLzJLdoHObgp PD3EEIwfFG/1jLK0Orrr9HbPhsfdxsHlX5wnWsR9B/RNkRt0UWmxwtP2ZakbA19QcUCTTE8+T0FYn RQQQr1LI2elqIUn5LWsw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPpgO-002fUB-Or; Mon, 13 Sep 2021 17:23:53 +0000 Received: from mail-ej1-x635.google.com ([2a00:1450:4864:20::635]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mPpRa-002bJf-TF for linux-arm-kernel@lists.infradead.org; Mon, 13 Sep 2021 17:08:36 +0000 Received: by mail-ej1-x635.google.com with SMTP id bt14so22615791ejb.3 for ; Mon, 13 Sep 2021 10:08:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=cjPU+X9z9q5//ZdtVdqefXjWrLECo/nmrS1BCrfqx7g=; b=ghiF91VkcaKIpKSUng2aUjJ9vVT9FvGOpbvsTPrpeC/Xlosl0bJN7JExpc+JWor1Hm 4yvTiO1X6f5vOWiI4lWguUEQc4MAsEM1hSZvY0sbrYesGX/5MGxjNIwMKt5qXlc5QPtR GeWyokind7pfnfdD9Deph1ghZsRaYkmsWYvGJecZwNvjIWMXsHhzHalM7M7CObpn0j3f LPs2a83a2qk2DqAGDKejG73kqz++sFzSLnXaNAcIakBKE7c3wv+uW8izyMpzJVV54hCI F3pHZcUDht13JnLmsWbTRoDfTgXqqMHvIIfRDzgYQTgfAQSs6WEhP5EG5nY4aM0kCUxE hQsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=cjPU+X9z9q5//ZdtVdqefXjWrLECo/nmrS1BCrfqx7g=; b=OBV9iWAmwDuVBYZGV7DPvAm3vkI6hYNNsJes/C+1u6IVU+Rmk1Rd7ShtyZr/Tubm2W 9X3B7c5Z+MSgZNK1BQ+ggBxYvMJ5DgczT5d42RLUmlSp3rehh29JxewZbrDMEL355xNe 25OOBkygzJa1LSnhHvKe3NqJQkqSgEX6ezdf4OEhO9dXiV34+o4iOeKEw241sWJQGrG8 5LOkYxmv/fZ8ZWkNMON32Ei85m38/a0pJgDuVTXoFB+O6+brEzxYy/vBbZugAYQVmhBR rgCsdZdG6V0kuXyh/zwleHanU9aMq9+d3/oXD3Ph99G1jVVunnLLN1cz2hO2NnBLecyD p2Ew== X-Gm-Message-State: AOAM5339Zo3npmbDfILAt6OVqvxTGUNKHMdn1Rj68AC6oqVIkPOfdB26 JzY6++wjjQNd2FmTcgg2l7qJh4lBeAMQ+NszmSyQbw== X-Google-Smtp-Source: ABdhPJyZlYWjcU4fshnZAhArELY92YocVWhkvsqsWqoxB6o41HaD+s6nKUDT9uEmHcDzaizJBz3LhL1qETW2KBy5mP8= X-Received: by 2002:a17:907:2662:: with SMTP id ci2mr13615318ejc.107.1631552911570; Mon, 13 Sep 2021 10:08:31 -0700 (PDT) MIME-Version: 1.0 References: <1631092255-25150-1-git-send-email-shengjiu.wang@nxp.com> <1631092255-25150-5-git-send-email-shengjiu.wang@nxp.com> In-Reply-To: From: Mathieu Poirier Date: Mon, 13 Sep 2021 11:08:19 -0600 Message-ID: Subject: Re: [PATCH v4 4/4] dt-bindings: dsp: fsl: update binding document for remote proc driver To: Shengjiu Wang Cc: Rob Herring , Shengjiu Wang , Ohad Ben-Cohen , Bjorn Andersson , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , daniel.baluta@nxp.com, NXP Linux Team , linux-remoteproc , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , linux-arm-kernel , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210913_100835_038423_C8DC0677 X-CRM114-Status: GOOD ( 38.49 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 12 Sept 2021 at 20:50, Shengjiu Wang wrote: > > Hi Rob > > On Sat, Sep 11, 2021 at 5:43 AM Rob Herring wrote: > > > > On Wed, Sep 08, 2021 at 05:10:55PM +0800, Shengjiu Wang wrote: > > > As there are two drivers for DSP on i.MX, one is for sound open > > > firmware, another is for remote processor framework. In order to > > > distinguish two kinds of driver, defining different compatible strings. > > > > What determines which firmware is used? Is it tied to the board? Or for > > a given board, users could want different firmware? In the latter case, > > this configuration should not be in DT. > > The compatible string determines which firmware is used. > For a given board, users could want different firmware, then need > to reboot the kernel and switch to another DTB. > > > > > > For remote proc driver, the properties firmware-name and fsl,dsp-ctrl > > > are needed and the mailbox channel is different with SOF. > > > > > > Signed-off-by: Shengjiu Wang > > > --- > > > .../devicetree/bindings/dsp/fsl,dsp.yaml | 81 +++++++++++++++++-- > > > 1 file changed, 75 insertions(+), 6 deletions(-) > > > > > > diff --git a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > > index 7afc9f2be13a..51ea657f6d42 100644 > > > --- a/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > > +++ b/Documentation/devicetree/bindings/dsp/fsl,dsp.yaml > > > @@ -8,6 +8,7 @@ title: NXP i.MX8 DSP core > > > > > > maintainers: > > > - Daniel Baluta > > > + - Shengjiu Wang > > > > > > description: | > > > Some boards from i.MX8 family contain a DSP core used for > > > @@ -19,6 +20,10 @@ properties: > > > - fsl,imx8qxp-dsp > > > - fsl,imx8qm-dsp > > > - fsl,imx8mp-dsp > > > + - fsl,imx8qxp-hifi4 > > > + - fsl,imx8qm-hifi4 > > > + - fsl,imx8mp-hifi4 > > > + - fsl,imx8ulp-hifi4 > > > > > > reg: > > > maxItems: 1 > > > @@ -28,37 +33,63 @@ properties: > > > - description: ipg clock > > > - description: ocram clock > > > - description: core clock > > > + - description: debug interface clock > > > + - description: message unit clock > > > + minItems: 3 > > > + maxItems: 5 > > > > > > clock-names: > > > items: > > > - const: ipg > > > - const: ocram > > > - const: core > > > + - const: debug > > > + - const: mu > > > + minItems: 3 > > > + maxItems: 5 > > > > > > power-domains: > > > description: > > > List of phandle and PM domain specifier as documented in > > > Documentation/devicetree/bindings/power/power_domain.txt > > > + minItems: 1 > > > maxItems: 4 > > > > How does the same h/w have different number of power domains? > > For different SoC, the integration is different, on i.MX8QM/8QXP, there are > 4 power-domains for DSP, but on i.MX8MP, there are 1 power-domain. > > > > > > > > > mboxes: > > > description: > > > List of <&phandle type channel> - 2 channels for TXDB, 2 channels for RXDB > > > + or - 1 channel for TX, 1 channel for RX, 1 channel for RXDB > > > (see mailbox/fsl,mu.txt) > > > + minItems: 3 > > > maxItems: 4 > > > > > > mbox-names: > > > - items: > > > - - const: txdb0 > > > - - const: txdb1 > > > - - const: rxdb0 > > > - - const: rxdb1 > > > + oneOf: > > > + - items: > > > + - const: txdb0 > > > + - const: txdb1 > > > + - const: rxdb0 > > > + - const: rxdb1 > > > + - items: > > > + - const: tx > > > + - const: rx > > > + - const: rxdb > > > > These are completely different mailboxes? > > It is the same mailbox, for this mailbox, there are 16 channels > (4 for tx, 4 for rx, 4 for txdb, 4 for rxdb). > For sound open firmware and remoteproc firmware, they > use different mailbox channels. > > > > > > > > > memory-region: > > > description: > > > phandle to a node describing reserved memory (System RAM memory) > > > used by DSP (see bindings/reserved-memory/reserved-memory.txt) > > > - maxItems: 1 > > > + minItems: 1 > > > + maxItems: 4 > > > + > > > + firmware-name: > > > + description: | > > > + Default name of the firmware to load to the remote processor. > > > + > > > + fsl,dsp-ctrl: > > > + $ref: /schemas/types.yaml#/definitions/phandle > > > + description: > > > + Phandle to syscon block which provide access for processor enablement > > > > Curious, how is this done with the open sound f/w? > > Currently the code for this in sound open firmware is not upsteamed, > I think this phandle is also applied for sound open firmware. > > By the way, Should I separate the change of this file from this > patch series? Does it belong to your linux tree? Please keep the patches together. Once Rob acks the bindings, patches in this series will be picked up in the remoteproc tree. Thanks, Mathieu > > > Best Regards > Wang Shengjiu _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel