From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5604CC433EF for ; Fri, 29 Oct 2021 15:12:50 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3AD5461211 for ; Fri, 29 Oct 2021 15:12:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229940AbhJ2PPR (ORCPT ); Fri, 29 Oct 2021 11:15:17 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229621AbhJ2PPP (ORCPT ); Fri, 29 Oct 2021 11:15:15 -0400 Received: from mail-ed1-x535.google.com (mail-ed1-x535.google.com [IPv6:2a00:1450:4864:20::535]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADBE5C061570 for ; Fri, 29 Oct 2021 08:12:46 -0700 (PDT) Received: by mail-ed1-x535.google.com with SMTP id h7so40376177ede.8 for ; Fri, 29 Oct 2021 08:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jbp1RVUWpXxmf6q8wM0Uf1eGImV3WO+nHaJoNI5GzDs=; b=mMC4BoJW3hMSmbxyFp6HdSByFD3WUlevp7UGvD8AkSAidA2poPLFA3Tpfw+fe4Nyd1 rsME8fJqcfF265gVd1pHPe+imgFu7OZEFVsZmNamkeN9h205hCdp5aQsNBEp6+f1UvI/ CUJgxSS6iWsfh8A85CvH/smVNy0ysNbWo/MZXi3pXVSfcGR6dLbo1AtkZPzQfurV6Wiq 79dIpAWNut/XA6NUr2ANC6skrSwxEDjmDS6aQSeTNj89amtuF3o5MvgFNRthCA8ABjAp 7qz4sNtqh46UrFETo1hyMhKBAynodWJSKy0pCb+kpcUGoWCo4JeJUY60tteckS0BTFKe jrkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jbp1RVUWpXxmf6q8wM0Uf1eGImV3WO+nHaJoNI5GzDs=; b=jfXa4RdJbNrs7dZeg8h4zDzIYFTR83ImS5vzPibrab1SvjZ1UP9ErQrRgERoSU3kcw EUYKuK2xferEme75Larq8CQizmgDTb2h24S7Wtk9IEZIQPQ+dBGVP1NFoe0drpNfFc47 5RoSSxjzC2el4cHkCCsyoo+RnBpSYxElDlFk8FrIJM0DPoovRRzIhfHlYYxIv5XmjHmz +uyuqQo3MzHMPvxxIM8AmatI+HiJemrkJdQ3FbU096viVb05YHMBEE4Qt8G2LF5y1b/A RudQttMcWx3b/ybMo7eiMFrSilxrwp849DevinZfl/eYN2uRJP/+lODQ03vIAR10n8Br ke+A== X-Gm-Message-State: AOAM532NFuXbllYNKfpDqNPWShpiSYD+yno/EFANMsXxHs97LpX41/9Q 1ymurF8dCr+LFZbq4oslHdidg7FUPrGlP0nBGKp0uw== X-Google-Smtp-Source: ABdhPJzpsDLjJQ/WwdBQ9O4Stwk6wd9Sj4N6byqzYkuACRBh35AKF+UU5XzoJbdDigL/gVr9oD8hf7SibborrPj1Or0= X-Received: by 2002:a17:907:9858:: with SMTP id jj24mr14491131ejc.505.1635520365217; Fri, 29 Oct 2021 08:12:45 -0700 (PDT) MIME-Version: 1.0 References: <20211029113023.760421-1-arnd@kernel.org> <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> In-Reply-To: <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> From: Mathieu Poirier Date: Fri, 29 Oct 2021 09:12:33 -0600 Message-ID: Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap To: Suzuki K Poulose Cc: Arnd Bergmann , Catalin Marinas , Will Deacon , Anshuman Khandual , Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 29 Oct 2021 at 07:31, Suzuki K Poulose wrote: > > Hi Arnd > > Thanks for the fix. > > On 29/10/2021 12:30, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > It's now used in a coresight driver that can be a loadable module: > > > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") > > Reviewed-by: Suzuki K Poulose > Tested-by: Suzuki K Poulose > > Will, Catalin, Mathieu, > > Do you have a preference on how this fix can be pulled in ? This may > be safe to go via coresight tree if it is not too late. Otherwise, > it could go via the arm64 tree. All the same to me. It's in arm64 so I'll let Will and Catalin have the final word. > > Suzuki > > > Signed-off-by: Arnd Bergmann > > --- > > Not sure if we actually want this to be exported, this is my local > > workaround for the randconfig build bot. > > --- > > arch/arm64/kernel/cpufeature.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > index ecbdff795f5e..beccbcfa7391 100644 > > --- a/arch/arm64/kernel/cpufeature.c > > +++ b/arch/arm64/kernel/cpufeature.c > > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > > > return false; > > } > > +EXPORT_SYMBOL(this_cpu_has_cap); > > > > /* > > * This helper function is used in a narrow window when, > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C9386C433EF for ; Fri, 29 Oct 2021 15:14:01 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 98670610FD for ; Fri, 29 Oct 2021 15:14:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 98670610FD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=l9OoMOb3EqsGe3banjJL0S2qgo9WI6apZH8tMYlG+so=; b=CDntSem4hLMZOe 4GLIhKD8wh+wQDGdWLjcvqIGJ7NhBDF0XVj8VW8ZFlG9S9rGNiQ7SNKwus78wF1730DiG8oZ1+TVO ebW/ibge+jebn4W6XrUPKXGMSp/ms0+LBUMiqKQbqgVTEE4e7Xp21Cxt9nunaCHQ490gjL8zBN945 xX8AnYRYwlfEmi70sEo7Dik41YYaoon5u4bqxhRC73Jf1ztDK96YALca1doESQ7OFewtztTkkcn+U WIUiuXFeBoQbba7Ia7Wbu+Pww8SIIx26jE8td1g9USV5vNfgkWsD/wCj59q9dAy9pJ07pDuZxMW4f BAIMKHK1AexbCEkPv9cA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgTYs-00BJdb-0S; Fri, 29 Oct 2021 15:12:54 +0000 Received: from mail-ed1-x529.google.com ([2a00:1450:4864:20::529]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mgTYo-00BJap-HG for linux-arm-kernel@lists.infradead.org; Fri, 29 Oct 2021 15:12:52 +0000 Received: by mail-ed1-x529.google.com with SMTP id r12so39986387edt.6 for ; Fri, 29 Oct 2021 08:12:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=jbp1RVUWpXxmf6q8wM0Uf1eGImV3WO+nHaJoNI5GzDs=; b=mMC4BoJW3hMSmbxyFp6HdSByFD3WUlevp7UGvD8AkSAidA2poPLFA3Tpfw+fe4Nyd1 rsME8fJqcfF265gVd1pHPe+imgFu7OZEFVsZmNamkeN9h205hCdp5aQsNBEp6+f1UvI/ CUJgxSS6iWsfh8A85CvH/smVNy0ysNbWo/MZXi3pXVSfcGR6dLbo1AtkZPzQfurV6Wiq 79dIpAWNut/XA6NUr2ANC6skrSwxEDjmDS6aQSeTNj89amtuF3o5MvgFNRthCA8ABjAp 7qz4sNtqh46UrFETo1hyMhKBAynodWJSKy0pCb+kpcUGoWCo4JeJUY60tteckS0BTFKe jrkA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=jbp1RVUWpXxmf6q8wM0Uf1eGImV3WO+nHaJoNI5GzDs=; b=7OJbVAidPWcVhtxcRgCg8zVHdAm+L6qyrUNcrEzKPFgkmIIJ5g1GOLo8M1se5oFL2S rzlXnG2/MugYhxnio0AeifilzU6HEQVtw7+c1viK3gnzQ0M5cQFQfrWMTzMqgZPYqeFa bEkr1qJtvnXVwrr262mQQ/etVTbQya+w9gj8Prs1UkomBDAnXneBShvSun6dG6iz93ir 19sZXsMszLKgisDBMC4aRi3AC50O4Cipv/QbiIS6Ucv8JBR8/GbdA5Y+dmXhrjllGcPM 4KCFScffUoRbVC1PGJ2v8mZhDXEfzFd1Lcwd03l+ShAEBZXALj/ek2NwJiwXf1UNqnSB wsTg== X-Gm-Message-State: AOAM531l/HQoqXc2VkBLSIv20gUcU0ULe8jvBjGh0GFqTsknthTR4QA9 GRITfJtJy11MPsdiIrjgQNGnzhOTiqTPbF6nAZvWgw== X-Google-Smtp-Source: ABdhPJzpsDLjJQ/WwdBQ9O4Stwk6wd9Sj4N6byqzYkuACRBh35AKF+UU5XzoJbdDigL/gVr9oD8hf7SibborrPj1Or0= X-Received: by 2002:a17:907:9858:: with SMTP id jj24mr14491131ejc.505.1635520365217; Fri, 29 Oct 2021 08:12:45 -0700 (PDT) MIME-Version: 1.0 References: <20211029113023.760421-1-arnd@kernel.org> <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> In-Reply-To: <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> From: Mathieu Poirier Date: Fri, 29 Oct 2021 09:12:33 -0600 Message-ID: Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap To: Suzuki K Poulose Cc: Arnd Bergmann , Catalin Marinas , Will Deacon , Anshuman Khandual , Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211029_081250_612250_9A7CCFBC X-CRM114-Status: GOOD ( 23.75 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 29 Oct 2021 at 07:31, Suzuki K Poulose wrote: > > Hi Arnd > > Thanks for the fix. > > On 29/10/2021 12:30, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > It's now used in a coresight driver that can be a loadable module: > > > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") > > Reviewed-by: Suzuki K Poulose > Tested-by: Suzuki K Poulose > > Will, Catalin, Mathieu, > > Do you have a preference on how this fix can be pulled in ? This may > be safe to go via coresight tree if it is not too late. Otherwise, > it could go via the arm64 tree. All the same to me. It's in arm64 so I'll let Will and Catalin have the final word. > > Suzuki > > > Signed-off-by: Arnd Bergmann > > --- > > Not sure if we actually want this to be exported, this is my local > > workaround for the randconfig build bot. > > --- > > arch/arm64/kernel/cpufeature.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > index ecbdff795f5e..beccbcfa7391 100644 > > --- a/arch/arm64/kernel/cpufeature.c > > +++ b/arch/arm64/kernel/cpufeature.c > > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > > > return false; > > } > > +EXPORT_SYMBOL(this_cpu_has_cap); > > > > /* > > * This helper function is used in a narrow window when, > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel