From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 226D3C43219 for ; Mon, 29 Apr 2019 21:59:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C3B55215EA for ; Mon, 29 Apr 2019 21:59:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Mgqmlk1q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729542AbfD2V7W (ORCPT ); Mon, 29 Apr 2019 17:59:22 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:43280 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729401AbfD2V7W (ORCPT ); Mon, 29 Apr 2019 17:59:22 -0400 Received: by mail-io1-f68.google.com with SMTP id v9so10375787iol.10 for ; Mon, 29 Apr 2019 14:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=indmq07XFWS4gXjaJZT+iAAcr9a+9V4LSWqr6LCFENs=; b=Mgqmlk1qtdpemtyR8SiKe74oQes1kP9UrcFgu+l5KDcESXqvN3uaPaBvlrMsQRub5s hvYjr0p9EdV6dg3qSo4djhR+x0EH3cYlgAjgnqtytlUbrxQ7XXnx2HCosUyBPJkJz+Qq vcuEnK1GPMiB0f9kkZs/PRwPvpPoIBDYHBiXjyYKYMX/B2X3CI2i4jJxamQtrZTywBQ+ i67e1hEGNtLmv4nE8NywOsPt0p1D6xNISzGBny5dV7/5/GtOPvMYN88UVwcG7rBwLucv WGFusyQc1ipj8gZa5CnYO5/nJmQ+JbcbDDQHtOw7p2A7jAPpgivazeaNmnO7BoHnZmKR tZKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=indmq07XFWS4gXjaJZT+iAAcr9a+9V4LSWqr6LCFENs=; b=T/BLJEkwD/5Dx1iyWD488lhU8JAGBNU7qehORg5YMp8fACIm3Q5jw14vEDprg870LL ppvKkG/d09HUDayJKLqUiyF209pumnFu0zgXt609CCII+ZZMrnWWuLjXpp7cV4eug7ZS 07Lp3FIwfYwg2Pp7me1GQ1s8cOQvM7DqzIfkRZY/S0SBpLmBAtCZr6e/SHTwwSLO9h+K J8cFrvxCfeyRN832jMe+08KQWl2/IgpAPCc9SdAzdLSJ0Rf+vf/JsX3CBQHouqIjEniZ LJEPcCfecIH4kpAQmeXpdK1sSGUYLNt8eqWO77yQ0H0x3gWn/Zhcroghyw56RGyo3HEi KELA== X-Gm-Message-State: APjAAAVJF1hEWoOvqBN7y/HLpDLnpqpO9Z3vgpNjeB/RHqUcukNct7Hw mQ1A6pmUwpz4m+R32SU5st1a9CFbS96R7loc3VHbtQ== X-Google-Smtp-Source: APXvYqxG1GzcRB+vFWGBoNZIqNnICyueduhcBwZKb6PRheekulHycP3vvBlFYcIgl9rbtXqUXGmWqoU2Wg7d9cNvmhs= X-Received: by 2002:a5d:97cd:: with SMTP id k13mr808132ios.11.1556575160884; Mon, 29 Apr 2019 14:59:20 -0700 (PDT) MIME-Version: 1.0 References: <1555768835-68555-1-git-send-email-shiwanglai@hisilicon.com> <20190421124606.GA12134@leoy-ThinkPad-X240s> In-Reply-To: <20190421124606.GA12134@leoy-ThinkPad-X240s> From: Mathieu Poirier Date: Mon, 29 Apr 2019 15:59:09 -0600 Message-ID: Subject: Re: [PATCH v4] arm64: dts: hi3660: Add CoreSight support To: Leo Yan Cc: Wanglai Shi , "Suzuki K. Poulose" , Rob Herring , Mark Rutland , xuwei , Mike Leach , linux-arm-kernel , devicetree@vger.kernel.org, Linux Kernel Mailing List , Suzhuangluan Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 21 Apr 2019 at 06:46, Leo Yan wrote: > > On Sat, Apr 20, 2019 at 10:00:35PM +0800, Wanglai Shi wrote: > > This patch adds DT bindings for the CoreSight trace components > > on hi3660, which is used by 96boards Hikey960. > > > > Signed-off-by: Wanglai Shi > > Reviewed this patch and tested on my Hikey960 board, FWIW: > > Reviewed-and-tested-by: Leo Yan Reviewed-by: Mathieu Poirier > > > --- > > .../arm64/boot/dts/hisilicon/hi3660-coresight.dtsi | 456 +++++++++++++++++++++ > > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 + > > 2 files changed, 458 insertions(+) > > create mode 100644 arch/arm64/boot/dts/hisilicon/hi3660-coresight.dtsi > > > > diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-coresight.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660-coresight.dtsi > > new file mode 100644 > > index 0000000..d607f2f > > --- /dev/null > > +++ b/arch/arm64/boot/dts/hisilicon/hi3660-coresight.dtsi > > @@ -0,0 +1,456 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +/* > > + * dtsi for Hisilicon Hi3660 Coresight > > + * > > + * Copyright (C) 2016-2018 Hisilicon Ltd. > > + * > > + * Author: Wanglai Shi > > + * > > + */ > > +/ { > > + soc { > > + /* A53 cluster internals */ > > + etm@ecc40000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xecc40000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu0>; > > + > > + out-ports { > > + port { > > + etm0_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in0>; > > + }; > > + }; > > + }; > > + }; > > + > > + etm@ecd40000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xecd40000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu1>; > > + > > + out-ports { > > + port { > > + etm1_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in1>; > > + }; > > + }; > > + }; > > + }; > > + > > + etm@ece40000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xece40000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu2>; > > + > > + out-ports { > > + port { > > + etm2_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in2>; > > + }; > > + }; > > + }; > > + }; > > + > > + etm@ecf40000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xecf40000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu3>; > > + > > + out-ports { > > + port { > > + etm3_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in3>; > > + }; > > + }; > > + }; > > + }; > > + > > + funnel@ec801000 { > > + compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > > + reg = <0 0xec801000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + out-ports { > > + port { > > + cluster0_funnel_out: endpoint { > > + remote-endpoint = > > + <&cluster0_etf_in>; > > + }; > > + }; > > + }; > > + > > + in-ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + cluster0_funnel_in0: endpoint { > > + remote-endpoint = <&etm0_out>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + cluster0_funnel_in1: endpoint { > > + remote-endpoint = <&etm1_out>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <2>; > > + cluster0_funnel_in2: endpoint { > > + remote-endpoint = <&etm2_out>; > > + }; > > + }; > > + > > + port@3 { > > + reg = <3>; > > + cluster0_funnel_in3: endpoint { > > + remote-endpoint = <&etm3_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + etf@ec802000 { > > + compatible = "arm,coresight-tmc", "arm,primecell"; > > + reg = <0 0xec802000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + in-ports { > > + port { > > + cluster0_etf_in: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_out>; > > + }; > > + }; > > + }; > > + > > + out-ports { > > + port { > > + cluster0_etf_out: endpoint { > > + remote-endpoint = > > + <&combo_funnel_in0>; > > + }; > > + }; > > + }; > > + }; > > + > > + /* A73 cluster internals */ > > + etm@ed440000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xed440000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu4>; > > + > > + out-ports { > > + port { > > + etm4_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in0>; > > + }; > > + }; > > + }; > > + }; > > + > > + etm@ed540000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xed540000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu5>; > > + > > + out-ports { > > + port { > > + etm5_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in1>; > > + }; > > + }; > > + }; > > + }; > > + > > + etm@ed640000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xed640000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu6>; > > + > > + out-ports { > > + port { > > + etm6_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in2>; > > + }; > > + }; > > + }; > > + }; > > + > > + etm@ed740000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xed740000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu7>; > > + > > + out-ports { > > + port { > > + etm7_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in3>; > > + }; > > + }; > > + }; > > + }; > > + > > + funnel@ed001000 { > > + compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > > + reg = <0 0xed001000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + out-ports { > > + port { > > + cluster1_funnel_out: endpoint { > > + remote-endpoint = > > + <&cluster1_etf_in>; > > + }; > > + }; > > + }; > > + > > + in-ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + cluster1_funnel_in0: endpoint { > > + remote-endpoint = <&etm4_out>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + cluster1_funnel_in1: endpoint { > > + remote-endpoint = <&etm5_out>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <2>; > > + cluster1_funnel_in2: endpoint { > > + remote-endpoint = <&etm6_out>; > > + }; > > + }; > > + > > + port@3 { > > + reg = <3>; > > + cluster1_funnel_in3: endpoint { > > + remote-endpoint = <&etm7_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + etf@ed002000 { > > + compatible = "arm,coresight-tmc", "arm,primecell"; > > + reg = <0 0xed002000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + in-ports { > > + port { > > + cluster1_etf_in: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_out>; > > + }; > > + }; > > + }; > > + > > + out-ports { > > + port { > > + cluster1_etf_out: endpoint { > > + remote-endpoint = > > + <&combo_funnel_in1>; > > + }; > > + }; > > + }; > > + }; > > + > > + /* An invisible combo funnel between clusters and top funnel */ > > + funnel { > > + compatible = "arm,coresight-static-funnel"; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + out-ports { > > + port { > > + combo_funnel_out: endpoint { > > + remote-endpoint = > > + <&top_funnel_in>; > > + }; > > + }; > > + }; > > + > > + in-ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + combo_funnel_in0: endpoint { > > + remote-endpoint = > > + <&cluster0_etf_out>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + combo_funnel_in1: endpoint { > > + remote-endpoint = > > + <&cluster1_etf_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + /* Top internals */ > > + funnel@ec031000 { > > + compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > > + reg = <0 0xec031000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + out-ports { > > + port { > > + top_funnel_out: endpoint { > > + remote-endpoint = > > + <&top_etf_in>; > > + }; > > + }; > > + }; > > + > > + in-ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + top_funnel_in: endpoint { > > + remote-endpoint = > > + <&combo_funnel_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + etf@ec036000 { > > + compatible = "arm,coresight-tmc", "arm,primecell"; > > + reg = <0 0xec036000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + in-ports { > > + port { > > + top_etf_in: endpoint { > > + remote-endpoint = > > + <&top_funnel_out>; > > + }; > > + }; > > + }; > > + > > + out-ports { > > + port { > > + top_etf_out: endpoint { > > + remote-endpoint = > > + <&replicator_in>; > > + }; > > + }; > > + }; > > + }; > > + > > + replicator { > > + compatible = "arm,coresight-static-replicator"; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + in-ports { > > + port { > > + replicator_in: endpoint { > > + remote-endpoint = > > + <&top_etf_out>; > > + }; > > + }; > > + }; > > + > > + out-ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + replicator0_out0: endpoint { > > + remote-endpoint = <&etr_in>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + replicator0_out1: endpoint { > > + remote-endpoint = <&tpiu_in>; > > + }; > > + }; > > + }; > > + }; > > + > > + etr@ec033000 { > > + compatible = "arm,coresight-tmc", "arm,primecell"; > > + reg = <0 0xec033000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + in-ports { > > + port { > > + etr_in: endpoint { > > + remote-endpoint = > > + <&replicator0_out0>; > > + }; > > + }; > > + }; > > + }; > > + > > + tpiu@ec032000 { > > + compatible = "arm,coresight-tpiu", "arm,primecell"; > > + reg = <0 0xec032000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + in-ports { > > + port { > > + tpiu_in: endpoint { > > + remote-endpoint = > > + <&replicator0_out1>; > > + }; > > + }; > > + }; > > + }; > > + }; > > +}; > > diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > > index a4a3d08..8f2fede 100644 > > --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > > +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > > @@ -1246,3 +1246,5 @@ > > }; > > }; > > }; > > + > > +#include "hi3660-coresight.dtsi" > > -- > > 2.7.4 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 781CBC43219 for ; Mon, 29 Apr 2019 21:59:30 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 44F0E21655 for ; Mon, 29 Apr 2019 21:59:30 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Yg1UKMXJ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Mgqmlk1q" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 44F0E21655 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sT1I7a/6zT7ElYMf5g9ooU1Q/HEDmUhHUSRnQuA3mAU=; b=Yg1UKMXJAaZTDh zLKuM9BXR3Ys3y7MW9Tg6hx423eSIBUlDt2PooDkC3yHAWmn0yMSPd3u8pmXVzf9E+cLOU1yjb8gr pbRlsrs9G26QF4/NHhjdHamOMgKUXk+Zar31vAPT0Pu0PFMlLhHG9fEWT/J1loGgukAusow1XyP9H HeZOwomoDgglWdRSz1AX/dYZXS36FyUwzqw4AA0xkf9pSIJM0poGlzzLeB6V1k9S/NNOAzIF3EwYf Ou5uchQRam6JHGRiDd4MYYTpvRjzbRGzTGCLJPcNU9xKAbVReDtwCHp3kd2Bg0kQlVcePDYSZ5r3f yo4e0cf7nOteOa7URjcg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLEJ3-0002sQ-2g; Mon, 29 Apr 2019 21:59:25 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hLEIz-0002ry-U4 for linux-arm-kernel@lists.infradead.org; Mon, 29 Apr 2019 21:59:24 +0000 Received: by mail-io1-xd42.google.com with SMTP id u12so10453516iop.0 for ; Mon, 29 Apr 2019 14:59:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=indmq07XFWS4gXjaJZT+iAAcr9a+9V4LSWqr6LCFENs=; b=Mgqmlk1qtdpemtyR8SiKe74oQes1kP9UrcFgu+l5KDcESXqvN3uaPaBvlrMsQRub5s hvYjr0p9EdV6dg3qSo4djhR+x0EH3cYlgAjgnqtytlUbrxQ7XXnx2HCosUyBPJkJz+Qq vcuEnK1GPMiB0f9kkZs/PRwPvpPoIBDYHBiXjyYKYMX/B2X3CI2i4jJxamQtrZTywBQ+ i67e1hEGNtLmv4nE8NywOsPt0p1D6xNISzGBny5dV7/5/GtOPvMYN88UVwcG7rBwLucv WGFusyQc1ipj8gZa5CnYO5/nJmQ+JbcbDDQHtOw7p2A7jAPpgivazeaNmnO7BoHnZmKR tZKg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=indmq07XFWS4gXjaJZT+iAAcr9a+9V4LSWqr6LCFENs=; b=ezzsrXIecIiasHMCYhBVgTPoFpT4GwMAt8AxtppU4ri5lKpyx1GzPEe0guggCzjkeX MeHxIkpjHPWeHWWevpfhZgFp2fglbZf6r75dDU5o3vwl/XyOe4CDqdfo3p+cc3jme+er H6SiMCBdzX6F2H+m5SxAADBI0mSVoz6Wjxh8p4EJnPL4+YFAhEEcXZm0JjGejQ4xzxYf /s316Euw8cO24sdjhZjjvYqw/vqwjf/1DgC0ywYG6ltU5WIpS3nWQ3LVeCR6kc9VPuIA 0bZQsrC5acF63TFW1NhW0HI0XWDAjGtIs38umLOL0qZfPGpbFoTROw9D8+IsufHlFCqV 7TcQ== X-Gm-Message-State: APjAAAV75lAIXdPxKuLFLzZY/gf8vxcgTCbwhhWzQ2s4MkTqEgphQ/iq GUgSU+xAldG2utpfIHRygm7VKrI3iQV3BI//RWPXaRjc X-Google-Smtp-Source: APXvYqxG1GzcRB+vFWGBoNZIqNnICyueduhcBwZKb6PRheekulHycP3vvBlFYcIgl9rbtXqUXGmWqoU2Wg7d9cNvmhs= X-Received: by 2002:a5d:97cd:: with SMTP id k13mr808132ios.11.1556575160884; Mon, 29 Apr 2019 14:59:20 -0700 (PDT) MIME-Version: 1.0 References: <1555768835-68555-1-git-send-email-shiwanglai@hisilicon.com> <20190421124606.GA12134@leoy-ThinkPad-X240s> In-Reply-To: <20190421124606.GA12134@leoy-ThinkPad-X240s> From: Mathieu Poirier Date: Mon, 29 Apr 2019 15:59:09 -0600 Message-ID: Subject: Re: [PATCH v4] arm64: dts: hi3660: Add CoreSight support To: Leo Yan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190429_145921_979658_BDA06540 X-CRM114-Status: GOOD ( 17.94 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Wanglai Shi , "Suzuki K. Poulose" , Suzhuangluan , Linux Kernel Mailing List , xuwei , Rob Herring , linux-arm-kernel , Mike Leach Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sun, 21 Apr 2019 at 06:46, Leo Yan wrote: > > On Sat, Apr 20, 2019 at 10:00:35PM +0800, Wanglai Shi wrote: > > This patch adds DT bindings for the CoreSight trace components > > on hi3660, which is used by 96boards Hikey960. > > > > Signed-off-by: Wanglai Shi > > Reviewed this patch and tested on my Hikey960 board, FWIW: > > Reviewed-and-tested-by: Leo Yan Reviewed-by: Mathieu Poirier > > > --- > > .../arm64/boot/dts/hisilicon/hi3660-coresight.dtsi | 456 +++++++++++++++++++++ > > arch/arm64/boot/dts/hisilicon/hi3660.dtsi | 2 + > > 2 files changed, 458 insertions(+) > > create mode 100644 arch/arm64/boot/dts/hisilicon/hi3660-coresight.dtsi > > > > diff --git a/arch/arm64/boot/dts/hisilicon/hi3660-coresight.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660-coresight.dtsi > > new file mode 100644 > > index 0000000..d607f2f > > --- /dev/null > > +++ b/arch/arm64/boot/dts/hisilicon/hi3660-coresight.dtsi > > @@ -0,0 +1,456 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > + > > +/* > > + * dtsi for Hisilicon Hi3660 Coresight > > + * > > + * Copyright (C) 2016-2018 Hisilicon Ltd. > > + * > > + * Author: Wanglai Shi > > + * > > + */ > > +/ { > > + soc { > > + /* A53 cluster internals */ > > + etm@ecc40000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xecc40000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu0>; > > + > > + out-ports { > > + port { > > + etm0_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in0>; > > + }; > > + }; > > + }; > > + }; > > + > > + etm@ecd40000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xecd40000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu1>; > > + > > + out-ports { > > + port { > > + etm1_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in1>; > > + }; > > + }; > > + }; > > + }; > > + > > + etm@ece40000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xece40000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu2>; > > + > > + out-ports { > > + port { > > + etm2_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in2>; > > + }; > > + }; > > + }; > > + }; > > + > > + etm@ecf40000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xecf40000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu3>; > > + > > + out-ports { > > + port { > > + etm3_out: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_in3>; > > + }; > > + }; > > + }; > > + }; > > + > > + funnel@ec801000 { > > + compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > > + reg = <0 0xec801000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + out-ports { > > + port { > > + cluster0_funnel_out: endpoint { > > + remote-endpoint = > > + <&cluster0_etf_in>; > > + }; > > + }; > > + }; > > + > > + in-ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + cluster0_funnel_in0: endpoint { > > + remote-endpoint = <&etm0_out>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + cluster0_funnel_in1: endpoint { > > + remote-endpoint = <&etm1_out>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <2>; > > + cluster0_funnel_in2: endpoint { > > + remote-endpoint = <&etm2_out>; > > + }; > > + }; > > + > > + port@3 { > > + reg = <3>; > > + cluster0_funnel_in3: endpoint { > > + remote-endpoint = <&etm3_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + etf@ec802000 { > > + compatible = "arm,coresight-tmc", "arm,primecell"; > > + reg = <0 0xec802000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + in-ports { > > + port { > > + cluster0_etf_in: endpoint { > > + remote-endpoint = > > + <&cluster0_funnel_out>; > > + }; > > + }; > > + }; > > + > > + out-ports { > > + port { > > + cluster0_etf_out: endpoint { > > + remote-endpoint = > > + <&combo_funnel_in0>; > > + }; > > + }; > > + }; > > + }; > > + > > + /* A73 cluster internals */ > > + etm@ed440000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xed440000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu4>; > > + > > + out-ports { > > + port { > > + etm4_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in0>; > > + }; > > + }; > > + }; > > + }; > > + > > + etm@ed540000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xed540000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu5>; > > + > > + out-ports { > > + port { > > + etm5_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in1>; > > + }; > > + }; > > + }; > > + }; > > + > > + etm@ed640000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xed640000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu6>; > > + > > + out-ports { > > + port { > > + etm6_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in2>; > > + }; > > + }; > > + }; > > + }; > > + > > + etm@ed740000 { > > + compatible = "arm,coresight-etm4x", "arm,primecell"; > > + reg = <0 0xed740000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + cpu = <&cpu7>; > > + > > + out-ports { > > + port { > > + etm7_out: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_in3>; > > + }; > > + }; > > + }; > > + }; > > + > > + funnel@ed001000 { > > + compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > > + reg = <0 0xed001000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + out-ports { > > + port { > > + cluster1_funnel_out: endpoint { > > + remote-endpoint = > > + <&cluster1_etf_in>; > > + }; > > + }; > > + }; > > + > > + in-ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + cluster1_funnel_in0: endpoint { > > + remote-endpoint = <&etm4_out>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + cluster1_funnel_in1: endpoint { > > + remote-endpoint = <&etm5_out>; > > + }; > > + }; > > + > > + port@2 { > > + reg = <2>; > > + cluster1_funnel_in2: endpoint { > > + remote-endpoint = <&etm6_out>; > > + }; > > + }; > > + > > + port@3 { > > + reg = <3>; > > + cluster1_funnel_in3: endpoint { > > + remote-endpoint = <&etm7_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + etf@ed002000 { > > + compatible = "arm,coresight-tmc", "arm,primecell"; > > + reg = <0 0xed002000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + in-ports { > > + port { > > + cluster1_etf_in: endpoint { > > + remote-endpoint = > > + <&cluster1_funnel_out>; > > + }; > > + }; > > + }; > > + > > + out-ports { > > + port { > > + cluster1_etf_out: endpoint { > > + remote-endpoint = > > + <&combo_funnel_in1>; > > + }; > > + }; > > + }; > > + }; > > + > > + /* An invisible combo funnel between clusters and top funnel */ > > + funnel { > > + compatible = "arm,coresight-static-funnel"; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + out-ports { > > + port { > > + combo_funnel_out: endpoint { > > + remote-endpoint = > > + <&top_funnel_in>; > > + }; > > + }; > > + }; > > + > > + in-ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + combo_funnel_in0: endpoint { > > + remote-endpoint = > > + <&cluster0_etf_out>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + combo_funnel_in1: endpoint { > > + remote-endpoint = > > + <&cluster1_etf_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + /* Top internals */ > > + funnel@ec031000 { > > + compatible = "arm,coresight-dynamic-funnel", "arm,primecell"; > > + reg = <0 0xec031000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + out-ports { > > + port { > > + top_funnel_out: endpoint { > > + remote-endpoint = > > + <&top_etf_in>; > > + }; > > + }; > > + }; > > + > > + in-ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + top_funnel_in: endpoint { > > + remote-endpoint = > > + <&combo_funnel_out>; > > + }; > > + }; > > + }; > > + }; > > + > > + etf@ec036000 { > > + compatible = "arm,coresight-tmc", "arm,primecell"; > > + reg = <0 0xec036000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + in-ports { > > + port { > > + top_etf_in: endpoint { > > + remote-endpoint = > > + <&top_funnel_out>; > > + }; > > + }; > > + }; > > + > > + out-ports { > > + port { > > + top_etf_out: endpoint { > > + remote-endpoint = > > + <&replicator_in>; > > + }; > > + }; > > + }; > > + }; > > + > > + replicator { > > + compatible = "arm,coresight-static-replicator"; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + in-ports { > > + port { > > + replicator_in: endpoint { > > + remote-endpoint = > > + <&top_etf_out>; > > + }; > > + }; > > + }; > > + > > + out-ports { > > + #address-cells = <1>; > > + #size-cells = <0>; > > + > > + port@0 { > > + reg = <0>; > > + replicator0_out0: endpoint { > > + remote-endpoint = <&etr_in>; > > + }; > > + }; > > + > > + port@1 { > > + reg = <1>; > > + replicator0_out1: endpoint { > > + remote-endpoint = <&tpiu_in>; > > + }; > > + }; > > + }; > > + }; > > + > > + etr@ec033000 { > > + compatible = "arm,coresight-tmc", "arm,primecell"; > > + reg = <0 0xec033000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + in-ports { > > + port { > > + etr_in: endpoint { > > + remote-endpoint = > > + <&replicator0_out0>; > > + }; > > + }; > > + }; > > + }; > > + > > + tpiu@ec032000 { > > + compatible = "arm,coresight-tpiu", "arm,primecell"; > > + reg = <0 0xec032000 0 0x1000>; > > + clocks = <&crg_ctrl HI3660_PCLK>; > > + clock-names = "apb_pclk"; > > + > > + in-ports { > > + port { > > + tpiu_in: endpoint { > > + remote-endpoint = > > + <&replicator0_out1>; > > + }; > > + }; > > + }; > > + }; > > + }; > > +}; > > diff --git a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > > index a4a3d08..8f2fede 100644 > > --- a/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > > +++ b/arch/arm64/boot/dts/hisilicon/hi3660.dtsi > > @@ -1246,3 +1246,5 @@ > > }; > > }; > > }; > > + > > +#include "hi3660-coresight.dtsi" > > -- > > 2.7.4 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel