From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A9F1AC5519F for ; Fri, 27 Nov 2020 18:25:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64C642224B for ; Fri, 27 Nov 2020 18:25:28 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qZK9SghC" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726178AbgK0SZN (ORCPT ); Fri, 27 Nov 2020 13:25:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41962 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725980AbgK0SZM (ORCPT ); Fri, 27 Nov 2020 13:25:12 -0500 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7E317C0613D1 for ; Fri, 27 Nov 2020 10:25:12 -0800 (PST) Received: by mail-il1-x143.google.com with SMTP id b8so5346182ila.13 for ; Fri, 27 Nov 2020 10:25:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6kYoVKqPC3vhqU3nrR8MKfApG6zVMbrBxSj843bnZ/E=; b=qZK9SghCUm4wMaFfBrzS7CyvIixET6Sh0iFuK0MFi/MgD408Jk0gmPHcV/FuomkdNx 45q7TGYLZr9S3LsGC5WxePnOwe+COlLD97VN2Qq81ylU19XYH7Ose4dqwgNGInAnMEfI wJriQc7TkjW1I+U2TfD41BPMZu7eCBmFAk7h/KbjaV2UK6boPRQaeOMwDfP2hCiAyHg3 Lo7hxa57U1d6Z76jg4kcvWCERdMX+8GR3HRobVdHVKq4NaG2T1pcdjmOz5UC7dAGL7rR MbzGct9f+beWbbX4K1JZi9cdBu0NcnVlO9XSMkZaL+93IT55HfZvUIwHnzvZVW9H1e57 yyRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6kYoVKqPC3vhqU3nrR8MKfApG6zVMbrBxSj843bnZ/E=; b=XUHxvurmlM0NDNKn9O51JEV8JQRjgaxorwGeCqi9tzWMuEW11mWtqg8hWxRBANoEDP mG9tKXDMa6dTlGooKXRrcBtO9xB7D2vC3EE+D93SpRsomXhJIETJ7HyStvzYNOPmvKhq BrAlVos47IlIkthTJvNZepCQ0aOLIAPh6WxQT/sczfDOpYrdSmnSmijZN0bZJWo0MzhS 2GSd7eAkpdAokLk/q3U38UZjhl6wvLhGI+dZeMOEkYjSTcc6ff3+iDFZI6WfzeieYqbV Hop+ITprRSIuRn66VwIZ4XYlQnvTPRiDwHdfMpj5daO2A9LNTR/kSb+wTVZLlKsOcDn6 i2zw== X-Gm-Message-State: AOAM5310maj30jQxMgPIDbSKCo+q47xL1mbzfRp+o0r0I3jZ/Xt1DfLl /fnXdP4l/2NR/FYJStxlvnXCPR1EnPhMNbfiPRTsuQ== X-Google-Smtp-Source: ABdhPJyHGxibPr/pcc2cJ+NWBNFIpeSdMBuz+P0601qjR/KBDxKpkUl6Ou7uphTF6dCMxe0/w7IIrk2GG0GmMAyZJpY= X-Received: by 2002:a92:3403:: with SMTP id b3mr8146206ila.140.1606501511895; Fri, 27 Nov 2020 10:25:11 -0800 (PST) MIME-Version: 1.0 References: <20201127092941.1646260-1-tzungbi@google.com> In-Reply-To: From: Mathieu Poirier Date: Fri, 27 Nov 2020 11:25:01 -0700 Message-ID: Subject: Re: [RESEND PATCH v2] remoteproc/mediatek: read IPI buffer offset from FW To: Tzung-Bi Shih Cc: Ohad Ben-Cohen , Bjorn Andersson , linux-remoteproc , Matthias Brugger , "moderated list:ARM/Mediatek SoC support" , linux-arm-kernel , Pi-Hsun Shih Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Fri, 27 Nov 2020 at 10:25, Tzung-Bi Shih wrote: > > On Sat, Nov 28, 2020 at 12:11 AM Mathieu Poirier > wrote: > > On Fri, 27 Nov 2020 at 02:30, Tzung-Bi Shih wrote: > > > The patch breaks MTK SCP when working with legacy SCP firmware. We're > > > aware of it and will upgrade the devices' kernel and SCP firmware > > > carefully. Other than that, AFAICT, no other devices in the wild are > > > using this driver. > > > > > > > This is the exact same patch that you sent here [1], that I commented > > on, and that you agreed with my assessment. > > > > What do you want me to do here? What am I missing? > > Yes, this is a resend patch because only the first 2 patches in the > previous series have merged. > The first two patches were merged because they made sense. > I agree the patch is aggressive which would break machines with old > SCP firmware. But AFAICT, no other devices are using this driver; and > we'll take care of our devices to upgrade SCP firmware first and then > kernel drivers. Thus, ideally, no real device breakage is expected. > How do you know about all the systems out there that use this SoC? Moreover why would the original author have implemented the driver the way they did if it didn't work for them? > Would the patch be acceptable? Definitely not. > Or would you suggest we consider > backward-compatible anyway (even if with the context mentioned above)? That is the only way this patch will get merged. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B0B9C3E8C5 for ; Fri, 27 Nov 2020 18:25:24 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E17B42224B for ; Fri, 27 Nov 2020 18:25:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="w/HYl40C"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qZK9SghC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E17B42224B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=agrulAEbw74CYh/+oI1hP8ouF95rfYCOxhTKXXj8lnw=; b=w/HYl40C3djPhR1wug1qjKFiN hfUUKkCEYQPipWFZVPXuJ5S1Ef4M8gMw7SsPLDZr8iiDqnPI4vyEVxCZ2txD17ds1g5qXaYvBYcMM EsehKLXkZkqTvLLxxnzJniA1h1UW2iBku66Qag4DJZaYr2fTzHKM9mMJs4yYOcC+bpgKoLVm0JMga PO9MgWO2Mm1c0rBuQuqM98jpeUUNFxmNETJUM6jEsGvvxQPb3iS7/82dS/vkeQK/zqFQTcUlfZ431 4Euc/G+SiIp8hiQA9OBs28bQPEG1jEf2H0r9RMEI1XlkP2pvP1xS3zKADCMIfr3oA2iQnOQf3cMIT n9dsJv6Sw==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiiQo-0007UF-8N; Fri, 27 Nov 2020 18:25:18 +0000 Received: from mail-il1-x141.google.com ([2607:f8b0:4864:20::141]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiiQj-0007TS-QO for linux-mediatek@lists.infradead.org; Fri, 27 Nov 2020 18:25:14 +0000 Received: by mail-il1-x141.google.com with SMTP id x15so5409762ilq.1 for ; Fri, 27 Nov 2020 10:25:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6kYoVKqPC3vhqU3nrR8MKfApG6zVMbrBxSj843bnZ/E=; b=qZK9SghCUm4wMaFfBrzS7CyvIixET6Sh0iFuK0MFi/MgD408Jk0gmPHcV/FuomkdNx 45q7TGYLZr9S3LsGC5WxePnOwe+COlLD97VN2Qq81ylU19XYH7Ose4dqwgNGInAnMEfI wJriQc7TkjW1I+U2TfD41BPMZu7eCBmFAk7h/KbjaV2UK6boPRQaeOMwDfP2hCiAyHg3 Lo7hxa57U1d6Z76jg4kcvWCERdMX+8GR3HRobVdHVKq4NaG2T1pcdjmOz5UC7dAGL7rR MbzGct9f+beWbbX4K1JZi9cdBu0NcnVlO9XSMkZaL+93IT55HfZvUIwHnzvZVW9H1e57 yyRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6kYoVKqPC3vhqU3nrR8MKfApG6zVMbrBxSj843bnZ/E=; b=onK5RaYxHr6kaxADQKXjCmOeix4+wLSSyApfs5K8nNDyXYOYmg86XuTVkrTxS9Z6wI 8kDOAUOB8C8TJXtVDKPvXo80x48YFd3ikHhDCxwbJi0VCf9RAuf+ZuV7VXk8NTkPKF7h 8hul84uoioST4kS9fpzUR7fYMY43vPqyIBPESxHXwKpd1w8d63hTxkR2gEC6ffPorOYz WSlxjfKcyXHvROqPY2/LuUuJhKNf6Od9gjOA7ZsAn28tkrUhArZ1k2L+mGahfNlbihRj zqiYDnVSSv8nlFS1ihZv7h6VJTxtJev82ktTarhyPjwvVwEogGmU5wboDPRgWHNYRANT mbHA== X-Gm-Message-State: AOAM530hT5JHgj0Iijcip3bFbBUYHFQHrvkFL7RgTJWRv13Gy/SQqFLg MFs27oEtI7BImYWJkKAUgpWKnDH32576CFg9+h6eQA== X-Google-Smtp-Source: ABdhPJyHGxibPr/pcc2cJ+NWBNFIpeSdMBuz+P0601qjR/KBDxKpkUl6Ou7uphTF6dCMxe0/w7IIrk2GG0GmMAyZJpY= X-Received: by 2002:a92:3403:: with SMTP id b3mr8146206ila.140.1606501511895; Fri, 27 Nov 2020 10:25:11 -0800 (PST) MIME-Version: 1.0 References: <20201127092941.1646260-1-tzungbi@google.com> In-Reply-To: From: Mathieu Poirier Date: Fri, 27 Nov 2020 11:25:01 -0700 Message-ID: Subject: Re: [RESEND PATCH v2] remoteproc/mediatek: read IPI buffer offset from FW To: Tzung-Bi Shih X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201127_132514_035198_238AC177 X-CRM114-Status: GOOD ( 19.65 ) X-BeenThere: linux-mediatek@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ohad Ben-Cohen , linux-remoteproc , Bjorn Andersson , "moderated list:ARM/Mediatek SoC support" , Pi-Hsun Shih , Matthias Brugger , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-mediatek" Errors-To: linux-mediatek-bounces+linux-mediatek=archiver.kernel.org@lists.infradead.org On Fri, 27 Nov 2020 at 10:25, Tzung-Bi Shih wrote: > > On Sat, Nov 28, 2020 at 12:11 AM Mathieu Poirier > wrote: > > On Fri, 27 Nov 2020 at 02:30, Tzung-Bi Shih wrote: > > > The patch breaks MTK SCP when working with legacy SCP firmware. We're > > > aware of it and will upgrade the devices' kernel and SCP firmware > > > carefully. Other than that, AFAICT, no other devices in the wild are > > > using this driver. > > > > > > > This is the exact same patch that you sent here [1], that I commented > > on, and that you agreed with my assessment. > > > > What do you want me to do here? What am I missing? > > Yes, this is a resend patch because only the first 2 patches in the > previous series have merged. > The first two patches were merged because they made sense. > I agree the patch is aggressive which would break machines with old > SCP firmware. But AFAICT, no other devices are using this driver; and > we'll take care of our devices to upgrade SCP firmware first and then > kernel drivers. Thus, ideally, no real device breakage is expected. > How do you know about all the systems out there that use this SoC? Moreover why would the original author have implemented the driver the way they did if it didn't work for them? > Would the patch be acceptable? Definitely not. > Or would you suggest we consider > backward-compatible anyway (even if with the context mentioned above)? That is the only way this patch will get merged. _______________________________________________ Linux-mediatek mailing list Linux-mediatek@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-mediatek From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 52F5AC3E8C5 for ; Fri, 27 Nov 2020 18:26:35 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id EC7932087C for ; Fri, 27 Nov 2020 18:26:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="T54VfV0+"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="qZK9SghC" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EC7932087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=FLHaZpovLng4gCyHf4dQNfIBy733d9fg+k+lvBHFjAw=; b=T54VfV0+YR5tFgFHQik0O3wsP kUf0fKwvCyXO7b28mkyEv6suSWkloS7FCKegdZtCSpPDFs71PefLtUmrJIkGG8DAZaY4jdB1h7IXx TbKrGUbYbY43edEp6SfhH6PhxnagafxBdlidflyAE3yf9KrBby8F0LV50TF7jEgjfUoBQRsaVMVQp ejXvXPqd/NJ1t1JERuKy+hr7b9vbKNOEBFL1gwL+MqsnbcoB6HSh2oc73Xe5LGKURxZGcFGobS38E cf0PuA3+tcvxkBzOoXSy/KiMQdJHuKyBlBwwOXU7EwJGcHLXsr46n5dHGjRatbFyOR1Omvy8ff4yW Grb6h/EFg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiiQn-0007U4-3l; Fri, 27 Nov 2020 18:25:17 +0000 Received: from mail-il1-x142.google.com ([2607:f8b0:4864:20::142]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kiiQj-0007TR-QL for linux-arm-kernel@lists.infradead.org; Fri, 27 Nov 2020 18:25:14 +0000 Received: by mail-il1-x142.google.com with SMTP id v3so5384929ilo.5 for ; Fri, 27 Nov 2020 10:25:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6kYoVKqPC3vhqU3nrR8MKfApG6zVMbrBxSj843bnZ/E=; b=qZK9SghCUm4wMaFfBrzS7CyvIixET6Sh0iFuK0MFi/MgD408Jk0gmPHcV/FuomkdNx 45q7TGYLZr9S3LsGC5WxePnOwe+COlLD97VN2Qq81ylU19XYH7Ose4dqwgNGInAnMEfI wJriQc7TkjW1I+U2TfD41BPMZu7eCBmFAk7h/KbjaV2UK6boPRQaeOMwDfP2hCiAyHg3 Lo7hxa57U1d6Z76jg4kcvWCERdMX+8GR3HRobVdHVKq4NaG2T1pcdjmOz5UC7dAGL7rR MbzGct9f+beWbbX4K1JZi9cdBu0NcnVlO9XSMkZaL+93IT55HfZvUIwHnzvZVW9H1e57 yyRw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6kYoVKqPC3vhqU3nrR8MKfApG6zVMbrBxSj843bnZ/E=; b=XkX+9bxJftFWEw5LX6vz+tHRvf7Fac9yHPYu1/5gWZgdJ6NuTiLVB+0ulLq8G8THms LkRGRj8bi5UE2TvZIfCfP8BLJfbttHTE1jI9VWaYF968/jKxG3EMShhvcLzahSR6sVvF PBORWPBM+SNnkDF8TnYdROTzbNHZkTE5j88HEXpc4Hwhb0w/63kTN3AgIekK6eVA3vXr jTj4ctZTz4UMzMKvtnnycmWHAOzaBkiMytrcTuXXn5kWU1tuNE2/IZv2Dy+C0aGAlhDe hnC31as4vZfcCHML6MshZQztTfgdhUcW1VKR0CWZlnfGwJML5vR12EOCVD40/TgZ03mS 3FGQ== X-Gm-Message-State: AOAM5319oPpB++5mWvZp+IA/rgfgiREjdp75upFwy+eq6NKudzk0Wy1g xUzeeHm1aeHwN3cfoiUpVYFF0Px9B3S4G4VzKWWLqA== X-Google-Smtp-Source: ABdhPJyHGxibPr/pcc2cJ+NWBNFIpeSdMBuz+P0601qjR/KBDxKpkUl6Ou7uphTF6dCMxe0/w7IIrk2GG0GmMAyZJpY= X-Received: by 2002:a92:3403:: with SMTP id b3mr8146206ila.140.1606501511895; Fri, 27 Nov 2020 10:25:11 -0800 (PST) MIME-Version: 1.0 References: <20201127092941.1646260-1-tzungbi@google.com> In-Reply-To: From: Mathieu Poirier Date: Fri, 27 Nov 2020 11:25:01 -0700 Message-ID: Subject: Re: [RESEND PATCH v2] remoteproc/mediatek: read IPI buffer offset from FW To: Tzung-Bi Shih X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201127_132514_030032_4E5A4ACC X-CRM114-Status: GOOD ( 21.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Ohad Ben-Cohen , linux-remoteproc , Bjorn Andersson , "moderated list:ARM/Mediatek SoC support" , Pi-Hsun Shih , Matthias Brugger , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 27 Nov 2020 at 10:25, Tzung-Bi Shih wrote: > > On Sat, Nov 28, 2020 at 12:11 AM Mathieu Poirier > wrote: > > On Fri, 27 Nov 2020 at 02:30, Tzung-Bi Shih wrote: > > > The patch breaks MTK SCP when working with legacy SCP firmware. We're > > > aware of it and will upgrade the devices' kernel and SCP firmware > > > carefully. Other than that, AFAICT, no other devices in the wild are > > > using this driver. > > > > > > > This is the exact same patch that you sent here [1], that I commented > > on, and that you agreed with my assessment. > > > > What do you want me to do here? What am I missing? > > Yes, this is a resend patch because only the first 2 patches in the > previous series have merged. > The first two patches were merged because they made sense. > I agree the patch is aggressive which would break machines with old > SCP firmware. But AFAICT, no other devices are using this driver; and > we'll take care of our devices to upgrade SCP firmware first and then > kernel drivers. Thus, ideally, no real device breakage is expected. > How do you know about all the systems out there that use this SoC? Moreover why would the original author have implemented the driver the way they did if it didn't work for them? > Would the patch be acceptable? Definitely not. > Or would you suggest we consider > backward-compatible anyway (even if with the context mentioned above)? That is the only way this patch will get merged. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel