From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7EC2AC433F5 for ; Tue, 29 Mar 2022 14:37:12 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234191AbiC2Oix (ORCPT ); Tue, 29 Mar 2022 10:38:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57334 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S237975AbiC2Oiw (ORCPT ); Tue, 29 Mar 2022 10:38:52 -0400 Received: from mail-ej1-x62a.google.com (mail-ej1-x62a.google.com [IPv6:2a00:1450:4864:20::62a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 96A1614A6DE for ; Tue, 29 Mar 2022 07:37:08 -0700 (PDT) Received: by mail-ej1-x62a.google.com with SMTP id yy13so35611321ejb.2 for ; Tue, 29 Mar 2022 07:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=EcuRjEXPtepaNw67w45p1dvod6pvQZQGq0SXmPy4MNM=; b=LN3ysnetZQLcHg9zh5VkpeCR5hv0qVm90OFT6sMlmHkcc0GNBDYZgWZ33mcs81Jucv ANcDd2CpVBdtKihImZNmBIKegZEm6pTFHkLHCQNPjduL7vcbkvvRGM6oFlHhh42/EIH+ zflvjmlE5dxoQAZOtZPdlBvGmEPeFlsxFH87vMgbFgZduhk/xFFLUYkD9VoeVfibAeO9 2c489J/YOw2H5iBgPQv+kHXbOxlBPlhzPUggTKmbm331Rp1BRLBOojM2loQGea3ae0Wt PbXWVa76Q5vjNOrZ08rM4qASeDpnqmzA/dOYDGO2cTLF5CRxjDJ4LCImqhPkoxxP2qrQ Ixsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=EcuRjEXPtepaNw67w45p1dvod6pvQZQGq0SXmPy4MNM=; b=gQiAl+q2NSxsIS1Ci79Fo+7OhCJbc6rAFBEZjVFEkd6IANkgdQalh1vVEYK7SJJbUH SL0lLuN1rZSXrk64RE9bvA+RZlMRwl0IpkeHn/DwN+IaE8p6U/c8icw/jYFa/W3GMKWo M040DUt9Iw7Adj529C+EHu8MzBiRVupRiFvTyo1+kGoIu6fYzTuoftYaGN8GtYc1FZOq t+WXsBUiYUt4uCapJJoB6HKtELW6pKEGkjCK1IzTec4vGHI5Owoddb3+Z4YfPiOwz9rP 0BwN04fSTvNM3B85/fjakgVaJtntJx2Hco75+2Xx5mDrApB8p72aiEAy8rGKD9BBjtMB +vtg== X-Gm-Message-State: AOAM530T14+d3yiA9EZCP7/h3uTvisAcj8yg8rOip8LI5z2qnA0CM3QD S7JL+xhjTXXprEn6zyKqewgdqYa9ilhQKcirw0c6jw== X-Google-Smtp-Source: ABdhPJzndU+hlAGsMBBHh3Q+ShVaQhl5rWLyscG/0jqOREe5OuXAZESfMX1K8aSunzXjtjrjXAK8MjbwH73ALpccOCM= X-Received: by 2002:a17:906:7307:b0:6da:92db:c78f with SMTP id di7-20020a170906730700b006da92dbc78fmr34999509ejc.35.1648564626968; Tue, 29 Mar 2022 07:37:06 -0700 (PDT) MIME-Version: 1.0 References: <20220324121734.21531-1-quic_jinlmao@quicinc.com> <20220324121734.21531-2-quic_jinlmao@quicinc.com> <7d571b9d-2066-8217-5485-da0e6ace65eb@arm.com> <8698dc76-613e-a00d-340b-220c752d9449@quicinc.com> In-Reply-To: <8698dc76-613e-a00d-340b-220c752d9449@quicinc.com> From: Mathieu Poirier Date: Tue, 29 Mar 2022 08:36:55 -0600 Message-ID: Subject: Re: [PATCH v4 01/10] Use IDR to maintain all the enabled sources' paths. To: Jinlong Mao Cc: Suzuki K Poulose , Greg Kroah-Hartman , Alexander Shishkin , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On Tue, 29 Mar 2022 at 07:56, Jinlong Mao wrote: > > Hi Suzuki, > > On 3/28/2022 4:33 PM, Suzuki K Poulose wrote: > > On 24/03/2022 14:23, Jinlong Mao wrote: > >> Hi Greg, > >> > >> Thanks for your review. > >> > >> On 3/24/2022 8:26 PM, Greg Kroah-Hartman wrote: > >>> On Thu, Mar 24, 2022 at 08:17:25PM +0800, Mao Jinlong wrote: > >>>> Use hash length of the source's device name to map to the pointer > >>>> of the enabled path. Using IDR will be more efficient than using > >>>> the list. And there could be other sources except STM and CPU etms > >>>> in the new HWs. It is better to maintain all the paths together. > >>>> > >>>> Signed-off-by: Mao Jinlong > >>>> --- > >>>> drivers/hwtracing/coresight/coresight-core.c | 75 > >>>> +++++++------------- > >>>> 1 file changed, 26 insertions(+), 49 deletions(-) > >>> Your subject line is odd. Please put back the driver subsystem in th= e > >>> subject line so that it makes more sense. > >> I will update the subject in next version. > >>> > >>> And how have you measured "more efficient"? > >> > >> Using IDR would be better than doing a sequential search as there > >> will be much more device in future. > > > > Where do we use sequential search now ? For non-CPU bound sources, yes > > we may need something. But CPU case is straight forward, and could be > > retained as it is. i.e., per-cpu list of paths. > > > We use list to store the paths for both ETM and non-CPU bound sources in > patch below. > > =E2=80=9C[PATCH 01/10] coresight: add support to enable more coresight pa= ths=E2=80=9D > > According to Mathieu's comments, IDR is used now. So i added "Using IDR > will be more efficient than using > the list" this message in my commit message. I think we need to use one > mechanism to store ETM and > non-CPU bound sources. > > > Mathieu's comments: > > So many TPDM and many ETMs... That is definitely a reason to do better t= han a > sequential search. > > If an IDR (or some other kind of mechanism) is used then we can use that = to > store paths associated with ETMs as well. That way everything works the = same > way and access time is constant for any kind of source. As per my last sentence above, the goal of my comment was to simplify things so that we don't have two different ways of managing sources. But if that ends up causing more trouble than benefit then it should be avoided. > > Thanks > > Jinlong Mao > > > Cheers > > Suzuki > > > > > >> > >>> > >>> thanks, > >>> > >>> greg k-h > >> > >> Thanks > >> > >> Jinlong Mao > >> > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BB83EC433EF for ; Tue, 29 Mar 2022 14:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=ToMcWbv/NlkmQkuBXhecuyYCGPQ9n2sl/fDN/Fm1Lk0=; b=k7n0sQreH1UYbm ARepfK2Ch08fE9anD6dkWLNyITwWV269AgN9KuducCXuCq49xaf8IhGguyGTuz70GvanYSVNJKPSg JQFVABocvTuU0GvQuIwPFZMgq5vuLKCDTgWIgXhdTpz4seKNPZ04ztgw79iA8InutwqRh52co2nbS v2GeX/oQAYFqsA7VoklrHIUFtCzumdmvKak13Wp1uqq/2s+4cTc9bZcaTE7WvkbOnvtWA48gvel1D HHb0Sf1ey5f4BoV45USo8nO0sSJo00KHOkfjkAwrutpmRRnvSqp82+7N3bqnnl411BvPzMhLq+F1O BLjiCp/PoQFkNliwESwQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZCy9-00CViX-S1; Tue, 29 Mar 2022 14:37:14 +0000 Received: from mail-ej1-x62b.google.com ([2a00:1450:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZCy5-00CVhv-JC for linux-arm-kernel@lists.infradead.org; Tue, 29 Mar 2022 14:37:11 +0000 Received: by mail-ej1-x62b.google.com with SMTP id a8so35450448ejc.8 for ; Tue, 29 Mar 2022 07:37:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=EcuRjEXPtepaNw67w45p1dvod6pvQZQGq0SXmPy4MNM=; b=LN3ysnetZQLcHg9zh5VkpeCR5hv0qVm90OFT6sMlmHkcc0GNBDYZgWZ33mcs81Jucv ANcDd2CpVBdtKihImZNmBIKegZEm6pTFHkLHCQNPjduL7vcbkvvRGM6oFlHhh42/EIH+ zflvjmlE5dxoQAZOtZPdlBvGmEPeFlsxFH87vMgbFgZduhk/xFFLUYkD9VoeVfibAeO9 2c489J/YOw2H5iBgPQv+kHXbOxlBPlhzPUggTKmbm331Rp1BRLBOojM2loQGea3ae0Wt PbXWVa76Q5vjNOrZ08rM4qASeDpnqmzA/dOYDGO2cTLF5CRxjDJ4LCImqhPkoxxP2qrQ Ixsw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=EcuRjEXPtepaNw67w45p1dvod6pvQZQGq0SXmPy4MNM=; b=OOTTduOP1quSFSUOx+fu2+dKxDSYi/ROgJQ0m46E+Dv8Rj3OB2xkIBsFNj/3eu/6o3 x7zC9IlFfra0LRlSae7EEb4+44NEW+2OSFML164XQfMZ1rraj+CMc77RroMoMWOzPFwG t6CVtUULHU/FR5b4b+fiyovrwUm5uvaYTpm3poXhBh0sjRvovweKz7MgJd+C41LREHDI ODF24ibVGUJdj80AcLODXUcL+GOB0qncb70rPh4xqdxS1RdfY/cwOA6wMbmkUnMHl4bx qIvTaHclVXsojKWYkdv7IQOySZctyNKWQ0vOEu/6BMui2gs48zMx+GIxp0PdgVkUjqYc XLng== X-Gm-Message-State: AOAM531puEL0NBihl+tucH5R1153G/S4c8W+/YLEhsfBbtF5zBnZi/Gz Lo9OfEBAdx3okF9qkqpWHjzFzFrEGyCfcE34anV46Q== X-Google-Smtp-Source: ABdhPJzndU+hlAGsMBBHh3Q+ShVaQhl5rWLyscG/0jqOREe5OuXAZESfMX1K8aSunzXjtjrjXAK8MjbwH73ALpccOCM= X-Received: by 2002:a17:906:7307:b0:6da:92db:c78f with SMTP id di7-20020a170906730700b006da92dbc78fmr34999509ejc.35.1648564626968; Tue, 29 Mar 2022 07:37:06 -0700 (PDT) MIME-Version: 1.0 References: <20220324121734.21531-1-quic_jinlmao@quicinc.com> <20220324121734.21531-2-quic_jinlmao@quicinc.com> <7d571b9d-2066-8217-5485-da0e6ace65eb@arm.com> <8698dc76-613e-a00d-340b-220c752d9449@quicinc.com> In-Reply-To: <8698dc76-613e-a00d-340b-220c752d9449@quicinc.com> From: Mathieu Poirier Date: Tue, 29 Mar 2022 08:36:55 -0600 Message-ID: Subject: Re: [PATCH v4 01/10] Use IDR to maintain all the enabled sources' paths. To: Jinlong Mao Cc: Suzuki K Poulose , Greg Kroah-Hartman , Alexander Shishkin , Mike Leach , Leo Yan , coresight@lists.linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Tingwei Zhang , Yuanfang Zhang , Tao Zhang , Trilok Soni , Hao Zhang , linux-arm-msm@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220329_073709_660447_79B1E7D7 X-CRM114-Status: GOOD ( 29.42 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org T24gVHVlLCAyOSBNYXIgMjAyMiBhdCAwNzo1NiwgSmlubG9uZyBNYW8gPHF1aWNfamlubG1hb0Bx dWljaW5jLmNvbT4gd3JvdGU6Cj4KPiBIaSBTdXp1a2ksCj4KPiBPbiAzLzI4LzIwMjIgNDozMyBQ TSwgU3V6dWtpIEsgUG91bG9zZSB3cm90ZToKPiA+IE9uIDI0LzAzLzIwMjIgMTQ6MjMsIEppbmxv bmcgTWFvIHdyb3RlOgo+ID4+IEhpIEdyZWcsCj4gPj4KPiA+PiBUaGFua3MgZm9yIHlvdXIgcmV2 aWV3Lgo+ID4+Cj4gPj4gT24gMy8yNC8yMDIyIDg6MjYgUE0sIEdyZWcgS3JvYWgtSGFydG1hbiB3 cm90ZToKPiA+Pj4gT24gVGh1LCBNYXIgMjQsIDIwMjIgYXQgMDg6MTc6MjVQTSArMDgwMCwgTWFv IEppbmxvbmcgd3JvdGU6Cj4gPj4+PiBVc2UgaGFzaCBsZW5ndGggb2YgdGhlIHNvdXJjZSdzIGRl dmljZSBuYW1lIHRvIG1hcCB0byB0aGUgcG9pbnRlcgo+ID4+Pj4gb2YgdGhlIGVuYWJsZWQgcGF0 aC4gVXNpbmcgSURSIHdpbGwgYmUgbW9yZSBlZmZpY2llbnQgdGhhbiB1c2luZwo+ID4+Pj4gdGhl IGxpc3QuIEFuZCB0aGVyZSBjb3VsZCBiZSBvdGhlciBzb3VyY2VzIGV4Y2VwdCBTVE0gYW5kIENQ VSBldG1zCj4gPj4+PiBpbiB0aGUgbmV3IEhXcy4gSXQgaXMgYmV0dGVyIHRvIG1haW50YWluIGFs bCB0aGUgcGF0aHMgdG9nZXRoZXIuCj4gPj4+Pgo+ID4+Pj4gU2lnbmVkLW9mZi1ieTogTWFvIEpp bmxvbmcgPHF1aWNfamlubG1hb0BxdWljaW5jLmNvbT4KPiA+Pj4+IC0tLQo+ID4+Pj4gICBkcml2 ZXJzL2h3dHJhY2luZy9jb3Jlc2lnaHQvY29yZXNpZ2h0LWNvcmUuYyB8IDc1Cj4gPj4+PiArKysr KysrLS0tLS0tLS0tLS0tLQo+ID4+Pj4gICAxIGZpbGUgY2hhbmdlZCwgMjYgaW5zZXJ0aW9ucygr KSwgNDkgZGVsZXRpb25zKC0pCj4gPj4+IFlvdXIgc3ViamVjdCBsaW5lIGlzIG9kZC4gIFBsZWFz ZSBwdXQgYmFjayB0aGUgZHJpdmVyIHN1YnN5c3RlbSBpbiB0aGUKPiA+Pj4gc3ViamVjdCBsaW5l IHNvIHRoYXQgaXQgbWFrZXMgbW9yZSBzZW5zZS4KPiA+PiBJIHdpbGwgdXBkYXRlIHRoZSBzdWJq ZWN0IGluIG5leHQgdmVyc2lvbi4KPiA+Pj4KPiA+Pj4gQW5kIGhvdyBoYXZlIHlvdSBtZWFzdXJl ZCAibW9yZSBlZmZpY2llbnQiPwo+ID4+Cj4gPj4gVXNpbmcgSURSIHdvdWxkIGJlIGJldHRlciB0 aGFuIGRvaW5nIGEgc2VxdWVudGlhbCBzZWFyY2ggYXMgdGhlcmUKPiA+PiB3aWxsIGJlIG11Y2gg bW9yZSBkZXZpY2UgIGluIGZ1dHVyZS4KPiA+Cj4gPiBXaGVyZSBkbyB3ZSB1c2Ugc2VxdWVudGlh bCBzZWFyY2ggbm93ID8gRm9yIG5vbi1DUFUgYm91bmQgc291cmNlcywgeWVzCj4gPiB3ZSBtYXkg bmVlZCBzb21ldGhpbmcuIEJ1dCBDUFUgY2FzZSBpcyBzdHJhaWdodCBmb3J3YXJkLCBhbmQgY291 bGQgYmUKPiA+IHJldGFpbmVkIGFzIGl0IGlzLiBpLmUuLCBwZXItY3B1IGxpc3Qgb2YgcGF0aHMu Cj4gPgo+IFdlIHVzZSBsaXN0IHRvIHN0b3JlIHRoZSBwYXRocyBmb3IgYm90aCBFVE0gYW5kIG5v bi1DUFUgYm91bmQgc291cmNlcyBpbgo+IHBhdGNoIGJlbG93Lgo+Cj4g4oCcW1BBVENIIDAxLzEw XSBjb3Jlc2lnaHQ6IGFkZCBzdXBwb3J0IHRvIGVuYWJsZSBtb3JlIGNvcmVzaWdodCBwYXRoc+KA nQo+Cj4gQWNjb3JkaW5nIHRvIE1hdGhpZXUncyBjb21tZW50cywgSURSIGlzIHVzZWQgbm93LiAg U28gaSBhZGRlZCAiVXNpbmcgSURSCj4gd2lsbCBiZSBtb3JlIGVmZmljaWVudCB0aGFuIHVzaW5n Cj4gdGhlIGxpc3QiIHRoaXMgbWVzc2FnZSBpbiBteSBjb21taXQgbWVzc2FnZS4gSSB0aGluayB3 ZSBuZWVkIHRvIHVzZSBvbmUKPiBtZWNoYW5pc20gdG8gc3RvcmUgRVRNIGFuZAo+IG5vbi1DUFUg Ym91bmQgc291cmNlcy4KPgo+Cj4gTWF0aGlldSdzIGNvbW1lbnRzOgo+Cj4gU28gbWFueSBUUERN IGFuZCBtYW55IEVUTXMuLi4gIFRoYXQgaXMgZGVmaW5pdGVseSBhIHJlYXNvbiB0byBkbyBiZXR0 ZXIgdGhhbiBhCj4gc2VxdWVudGlhbCBzZWFyY2guCj4KPiBJZiBhbiBJRFIgKG9yIHNvbWUgb3Ro ZXIga2luZCBvZiBtZWNoYW5pc20pIGlzIHVzZWQgdGhlbiB3ZSBjYW4gdXNlIHRoYXQgdG8KPiBz dG9yZSBwYXRocyBhc3NvY2lhdGVkIHdpdGggRVRNcyBhcyB3ZWxsLiAgVGhhdCB3YXkgZXZlcnl0 aGluZyB3b3JrcyB0aGUgc2FtZQo+IHdheSBhbmQgYWNjZXNzIHRpbWUgaXMgY29uc3RhbnQgZm9y IGFueSBraW5kIG9mIHNvdXJjZS4KCkFzIHBlciBteSBsYXN0IHNlbnRlbmNlIGFib3ZlLCB0aGUg Z29hbCBvZiAgbXkgY29tbWVudCB3YXMgdG8gc2ltcGxpZnkKdGhpbmdzIHNvIHRoYXQgd2UgZG9u J3QgaGF2ZSB0d28gZGlmZmVyZW50IHdheXMgb2YgbWFuYWdpbmcgc291cmNlcy4KQnV0IGlmIHRo YXQgZW5kcyB1cCBjYXVzaW5nIG1vcmUgdHJvdWJsZSB0aGFuIGJlbmVmaXQgdGhlbiBpdCBzaG91 bGQKYmUgYXZvaWRlZC4KCj4KPiBUaGFua3MKPgo+IEppbmxvbmcgTWFvCj4KPiA+IENoZWVycwo+ ID4gU3V6dWtpCj4gPgo+ID4KPiA+Pgo+ID4+Pgo+ID4+PiB0aGFua3MsCj4gPj4+Cj4gPj4+IGdy ZWcgay1oCj4gPj4KPiA+PiBUaGFua3MKPiA+Pgo+ID4+IEppbmxvbmcgTWFvCj4gPj4KPiA+Cgpf X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0t a2VybmVsIG1haWxpbmcgbGlzdApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcK aHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2Vy bmVsCg==