From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 015ADC63697 for ; Tue, 24 Nov 2020 00:56:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B2323206D8 for ; Tue, 24 Nov 2020 00:56:02 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N8kuw9Ev" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727085AbgKXAzn (ORCPT ); Mon, 23 Nov 2020 19:55:43 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58510 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726948AbgKXAzm (ORCPT ); Mon, 23 Nov 2020 19:55:42 -0500 Received: from mail-io1-xd43.google.com (mail-io1-xd43.google.com [IPv6:2607:f8b0:4864:20::d43]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4C760C061A4D for ; Mon, 23 Nov 2020 16:55:41 -0800 (PST) Received: by mail-io1-xd43.google.com with SMTP id j23so20182841iog.6 for ; Mon, 23 Nov 2020 16:55:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kVHPzIRwek8E3f7Sx26BG40H0alZuW716ApQdhgz6Iw=; b=N8kuw9EvqwIgGVWTR29b/Rl/2bss44iB/0TgMwyT1N0NZh4sBu+46M9TtGYGuWxyBY H3q+QwEgpCbJpJl9jNrnQrod75wA8elCoD5+7AR0IonZro764uw3wKzMsDPZ2jeasPh8 DX5Z3TOUARxslaevqzGUx8lihh6f/WMSxMq1gGAPwUzDFrAL1vNt+hk05+BNXrsBNgyx lkwb906PQ7cczc05Qz1fZLReqwwrr8DS6+OfVIq1DJ097xOfPzzJQ+dM6exEMSr03jls WqRY3+lUSTA548y/cL9Kw4IZsIveV6OhEwvGo5BuYoOED+Rpkw0RBxrt8Qfp6odX5g0c FRjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kVHPzIRwek8E3f7Sx26BG40H0alZuW716ApQdhgz6Iw=; b=AxPTELgya7bEfqifLWE23R2zSqCV8Aux6Mz6lkuxjDfWpBZcBN0j4tKdDwsq/eHyiN S6QIAHGikcWiwJnacBQnSfQTv5jD8q+3PKOyB8iT164EPVGVymLD6Ckv7qaf0EMn1iV3 +Yng9IRpMve/g1MKhxAKWbl7qii7Dfa4JnXhJmpnFW5Djxpx6+uWDt+mKoyTVcldWdyF ty5U5aFo9aIWf/AEVia7ANzGotZy4/9W8SodDUS4gD1tBHifyB7K2piEY4OcoHRnBqbn h1fUs+gtckFV976AjnzvO3ekstYe2f/2IHQT8hlcgWEncgsQZSorxXKqbSU6arMaYl2/ T9bA== X-Gm-Message-State: AOAM530Cc4wDHAHY8hU2KCBY4k14apR3/Pt8RkOYTBuwFARM6faZJzuN Lo3d8JBetiGONeQ81FsH8i8/LWgAX27g4uXnsIDVVbg6krLalw== X-Google-Smtp-Source: ABdhPJx8XuSzuFA3gwJRwNQZUxGR11tr21aduP0wprZd3IG5fPOzXI3BUYt+xJGGKYTwkwdINdrI5WAz36g6v816Aqc= X-Received: by 2002:a5d:9284:: with SMTP id s4mr2024314iom.165.1606179340562; Mon, 23 Nov 2020 16:55:40 -0800 (PST) MIME-Version: 1.0 References: <20201119010531.21083-1-s-anna@ti.com> <20201119010531.21083-4-s-anna@ti.com> <20201123235129.GA529235@xps15> In-Reply-To: <20201123235129.GA529235@xps15> From: Mathieu Poirier Date: Mon, 23 Nov 2020 17:55:27 -0700 Message-ID: Subject: Re: [PATCH 3/3] remoteproc: k3-r5: Adjust TCM sizes in Split-mode on J7200 SoCs To: Suman Anna Cc: Bjorn Andersson , Rob Herring , Lokesh Vutla , linux-remoteproc , devicetree@vger.kernel.org, linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Mon, 23 Nov 2020 at 16:51, Mathieu Poirier wrote: > > Good afternoon Suman, > > On Wed, Nov 18, 2020 at 07:05:31PM -0600, Suman Anna wrote: > > The J7200 SoCs have a revised R5FSS IP that adds a unique feature w.r.t > > TCM sizing. Each R5F core in a cluster typically has 32 KB each of ATCM > > and BTCM, with only the Core0 TCMs usable in LockStep mode. This revised > > IP however doubles the total available TCM in LockStep mode by making the > > Core1 TCM visible immediately after the corresponding Core0 TCM. > > > > The R5F DT nodes on the J7200 SoCs define double (64 KB) the normal TCM > > size (32 KB) for R5F Core0 for each of ATCM and BTCM to represent the > > above. This increased TCM memory is only usable in LockStep-mode, and > > has to be adjusted to the normal 32 KB size in Split mode. Enhance the > > TI K3 R5F remoteproc for this logic through a new function. The adjustment > > is a no-op on prior SoCs and relies on the correct DTS node sizes in > > LockStep-mode on applicable SoCs. > > > > Signed-off-by: Suman Anna > > --- > > drivers/remoteproc/ti_k3_r5_remoteproc.c | 43 ++++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > > > diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c > > index 66a32dcdd7d0..62b5a4c29456 100644 > > --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c > > +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c > > @@ -71,9 +71,11 @@ enum cluster_mode { > > > > /** > > * struct k3_r5_soc_data - match data to handle SoC variations > > + * @tcm_is_double: flag to denote the larger unified TCMs in certain modes > > * @tcm_ecc_autoinit: flag to denote the auto-initialization of TCMs for ECC > > */ > > struct k3_r5_soc_data { > > + bool tcm_is_double; > > bool tcm_ecc_autoinit; > > }; > > > > @@ -886,6 +888,43 @@ static void k3_r5_reserved_mem_exit(struct k3_r5_rproc *kproc) > > of_reserved_mem_device_release(kproc->dev); > > } > > > > +/* > > + * Each R5F core within a typical R5FSS instance has a total of 64 KB of TCMs, > > + * split equally into two 32 KB banks between ATCM and BTCM. The TCMs from both > > + * cores are usable in Split-mode, but only the Core0 TCMs can be used in > > + * LockStep-mode. The newer revisions of the R5FSS IP maximizes these TCMs by > > + * leveraging the Core1 TCMs as well in certain modes where they would have > > + * otherwise been unusable (Eg: LockStep-mode on J7200 SoCs). This is done by > > + * making a Core1 TCM visible immediately after the corresponding Core0 TCM. > > + * The SoC memory map uses the larger 64 KB sizes for the Core0 TCMs, and the > > + * dts representation reflects this increased size on supported SoCs. The Core0 > > + * TCM sizes therefore have to be adjusted to only half the original size in > > + * Split mode. > > + */ > > +static void k3_r5_adjust_tcm_sizes(struct k3_r5_rproc *kproc) > > +{ > > + struct k3_r5_cluster *cluster = kproc->cluster; > > + struct k3_r5_core *core = kproc->core; > > + struct device *cdev = core->dev; > > + struct k3_r5_core *core0; > > + > > + if (cluster->mode == CLUSTER_MODE_LOCKSTEP || > > + !cluster->soc_data->tcm_is_double) > > + return; > > Shouldn't this be: > > if (cluster->mode == CLUSTER_MODE_SPLIT || > !cluster->soc_data->tcm_is_double) > return; > > If am wrong then I'm pretty sure other people will be confused and a comment is > warranted. > Forget the above, I misread the context. The memories are already set to 64KB so there is nothing to do if in lockstep mode. > > + > > + core0 = list_first_entry(&cluster->cores, struct k3_r5_core, elem); > > + if (core == core0) { > > + WARN_ON(core->mem[0].size != SZ_64K); > > + WARN_ON(core->mem[1].size != SZ_64K); > > + > > + core->mem[0].size /= 2; > > + core->mem[1].size /= 2; > > + > > + dev_dbg(cdev, "adjusted TCM sizes, ATCM = 0x%zx BTCM = 0x%zx\n", > > + core->mem[0].size, core->mem[1].size); > > + } > > +} > > + > > static int k3_r5_cluster_rproc_init(struct platform_device *pdev) > > { > > struct k3_r5_cluster *cluster = platform_get_drvdata(pdev); > > @@ -933,6 +972,8 @@ static int k3_r5_cluster_rproc_init(struct platform_device *pdev) > > goto err_config; > > } > > > > + k3_r5_adjust_tcm_sizes(kproc); > > + > > ret = k3_r5_reserved_mem_init(kproc); > > if (ret) { > > dev_err(dev, "reserved memory init failed, ret = %d\n", > > @@ -1407,10 +1448,12 @@ static int k3_r5_probe(struct platform_device *pdev) > > } > > > > static const struct k3_r5_soc_data am65_j721e_soc_data = { > > + .tcm_is_double = false, > > .tcm_ecc_autoinit = false, > > }; > > > > static const struct k3_r5_soc_data j7200_soc_data = { > > + .tcm_is_double = true, > > .tcm_ecc_autoinit = true, > > With the above and for the set: > > Reviewed-by: Mathieu Poirier > > > }; > > > > -- > > 2.28.0 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.8 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA937C2D0E4 for ; Tue, 24 Nov 2020 00:57:00 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5A106206D8 for ; Tue, 24 Nov 2020 00:57:00 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="1Tqw0/jm"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="N8kuw9Ev" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5A106206D8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From:In-Reply-To: References:MIME-Version:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=YO0t5cXA2Nyv+YfV2bV9rZBe/Y/4ZsjfZoBbak9dbYI=; b=1Tqw0/jmy1vK0ikP7hRbLvkin aXVPtj225z8z1BEBeyR+cjtMAWFzO5voI401/iiN6YJNOUKxZ8UuCVhQdNY/hn+qiWpn05PPi4lhX GL9JeK+ZVGDE16zW7CdJrOX4ih/MvfLdkoGGkzPMMTVxtd2uPZMil0hqFfUqIdLUk7WWuW910wd8M EpZ1gdDTuGTzhQgj+As8XHwZCMRutQDNn3WrZ/fZrNuO4+q0pFJT7f9//MRmmrV8QI9U+WMRv9kCh xIGINQxXGqYoAEvrCsE3h/zb+Pbh6IV6g9GAwz/hk+jB2C0umAHP9Hcl/u1+s/eh45OSDKXrFlCGG 8B01T3YMQ==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1khMcV-0004ZX-PI; Tue, 24 Nov 2020 00:55:47 +0000 Received: from mail-io1-xd42.google.com ([2607:f8b0:4864:20::d42]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1khMcS-0004Yt-1U for linux-arm-kernel@lists.infradead.org; Tue, 24 Nov 2020 00:55:45 +0000 Received: by mail-io1-xd42.google.com with SMTP id i18so20193189ioa.3 for ; Mon, 23 Nov 2020 16:55:42 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=kVHPzIRwek8E3f7Sx26BG40H0alZuW716ApQdhgz6Iw=; b=N8kuw9EvqwIgGVWTR29b/Rl/2bss44iB/0TgMwyT1N0NZh4sBu+46M9TtGYGuWxyBY H3q+QwEgpCbJpJl9jNrnQrod75wA8elCoD5+7AR0IonZro764uw3wKzMsDPZ2jeasPh8 DX5Z3TOUARxslaevqzGUx8lihh6f/WMSxMq1gGAPwUzDFrAL1vNt+hk05+BNXrsBNgyx lkwb906PQ7cczc05Qz1fZLReqwwrr8DS6+OfVIq1DJ097xOfPzzJQ+dM6exEMSr03jls WqRY3+lUSTA548y/cL9Kw4IZsIveV6OhEwvGo5BuYoOED+Rpkw0RBxrt8Qfp6odX5g0c FRjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=kVHPzIRwek8E3f7Sx26BG40H0alZuW716ApQdhgz6Iw=; b=FrYKGbaG1ww3oszSEdkscjrVVEMl3r+c5QsrXn/75n/AAv9Kwc+iN7Qy7EZfQIjdlp CxzzSR/mHcrv/g2yDl3Ax7PfIF6550zcBtpDun6+ZM/JmdbRmWo/Ev0cuwE4DUJ/QVWp AEHf77Sc+NI1hBwhHYEprOGO8/+tYZE1HTQW9NzrIxc4FwVGeJZ6oatUdMllM+4H/S7t hKBUBu+PrG+/a+c++VhyWn01qxMjIT7Oay2nPjfBMjvlhTkgHyDt0ZlRhjyrJS3ECkLy 19qwCylIn6zdcO6QRIgLgkljco7ZMuzNLnXeEwlkkHB0NDsu1BJMZhva1LK4efM+Suuk pw2Q== X-Gm-Message-State: AOAM532/odn32uXXqeDevScd4+ZUfyIwrhK7DTSN0ise7INffRgYOl/1 vJ4/rqzr/YgKoKGMa1dG6/S/n54b/KR+OrGXD2p6GA== X-Google-Smtp-Source: ABdhPJx8XuSzuFA3gwJRwNQZUxGR11tr21aduP0wprZd3IG5fPOzXI3BUYt+xJGGKYTwkwdINdrI5WAz36g6v816Aqc= X-Received: by 2002:a5d:9284:: with SMTP id s4mr2024314iom.165.1606179340562; Mon, 23 Nov 2020 16:55:40 -0800 (PST) MIME-Version: 1.0 References: <20201119010531.21083-1-s-anna@ti.com> <20201119010531.21083-4-s-anna@ti.com> <20201123235129.GA529235@xps15> In-Reply-To: <20201123235129.GA529235@xps15> From: Mathieu Poirier Date: Mon, 23 Nov 2020 17:55:27 -0700 Message-ID: Subject: Re: [PATCH 3/3] remoteproc: k3-r5: Adjust TCM sizes in Split-mode on J7200 SoCs To: Suman Anna X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20201123_195544_363302_D5A06C89 X-CRM114-Status: GOOD ( 33.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Lokesh Vutla , linux-remoteproc , Linux Kernel Mailing List , Bjorn Andersson , Rob Herring , linux-arm-kernel Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 23 Nov 2020 at 16:51, Mathieu Poirier wrote: > > Good afternoon Suman, > > On Wed, Nov 18, 2020 at 07:05:31PM -0600, Suman Anna wrote: > > The J7200 SoCs have a revised R5FSS IP that adds a unique feature w.r.t > > TCM sizing. Each R5F core in a cluster typically has 32 KB each of ATCM > > and BTCM, with only the Core0 TCMs usable in LockStep mode. This revised > > IP however doubles the total available TCM in LockStep mode by making the > > Core1 TCM visible immediately after the corresponding Core0 TCM. > > > > The R5F DT nodes on the J7200 SoCs define double (64 KB) the normal TCM > > size (32 KB) for R5F Core0 for each of ATCM and BTCM to represent the > > above. This increased TCM memory is only usable in LockStep-mode, and > > has to be adjusted to the normal 32 KB size in Split mode. Enhance the > > TI K3 R5F remoteproc for this logic through a new function. The adjustment > > is a no-op on prior SoCs and relies on the correct DTS node sizes in > > LockStep-mode on applicable SoCs. > > > > Signed-off-by: Suman Anna > > --- > > drivers/remoteproc/ti_k3_r5_remoteproc.c | 43 ++++++++++++++++++++++++ > > 1 file changed, 43 insertions(+) > > > > diff --git a/drivers/remoteproc/ti_k3_r5_remoteproc.c b/drivers/remoteproc/ti_k3_r5_remoteproc.c > > index 66a32dcdd7d0..62b5a4c29456 100644 > > --- a/drivers/remoteproc/ti_k3_r5_remoteproc.c > > +++ b/drivers/remoteproc/ti_k3_r5_remoteproc.c > > @@ -71,9 +71,11 @@ enum cluster_mode { > > > > /** > > * struct k3_r5_soc_data - match data to handle SoC variations > > + * @tcm_is_double: flag to denote the larger unified TCMs in certain modes > > * @tcm_ecc_autoinit: flag to denote the auto-initialization of TCMs for ECC > > */ > > struct k3_r5_soc_data { > > + bool tcm_is_double; > > bool tcm_ecc_autoinit; > > }; > > > > @@ -886,6 +888,43 @@ static void k3_r5_reserved_mem_exit(struct k3_r5_rproc *kproc) > > of_reserved_mem_device_release(kproc->dev); > > } > > > > +/* > > + * Each R5F core within a typical R5FSS instance has a total of 64 KB of TCMs, > > + * split equally into two 32 KB banks between ATCM and BTCM. The TCMs from both > > + * cores are usable in Split-mode, but only the Core0 TCMs can be used in > > + * LockStep-mode. The newer revisions of the R5FSS IP maximizes these TCMs by > > + * leveraging the Core1 TCMs as well in certain modes where they would have > > + * otherwise been unusable (Eg: LockStep-mode on J7200 SoCs). This is done by > > + * making a Core1 TCM visible immediately after the corresponding Core0 TCM. > > + * The SoC memory map uses the larger 64 KB sizes for the Core0 TCMs, and the > > + * dts representation reflects this increased size on supported SoCs. The Core0 > > + * TCM sizes therefore have to be adjusted to only half the original size in > > + * Split mode. > > + */ > > +static void k3_r5_adjust_tcm_sizes(struct k3_r5_rproc *kproc) > > +{ > > + struct k3_r5_cluster *cluster = kproc->cluster; > > + struct k3_r5_core *core = kproc->core; > > + struct device *cdev = core->dev; > > + struct k3_r5_core *core0; > > + > > + if (cluster->mode == CLUSTER_MODE_LOCKSTEP || > > + !cluster->soc_data->tcm_is_double) > > + return; > > Shouldn't this be: > > if (cluster->mode == CLUSTER_MODE_SPLIT || > !cluster->soc_data->tcm_is_double) > return; > > If am wrong then I'm pretty sure other people will be confused and a comment is > warranted. > Forget the above, I misread the context. The memories are already set to 64KB so there is nothing to do if in lockstep mode. > > + > > + core0 = list_first_entry(&cluster->cores, struct k3_r5_core, elem); > > + if (core == core0) { > > + WARN_ON(core->mem[0].size != SZ_64K); > > + WARN_ON(core->mem[1].size != SZ_64K); > > + > > + core->mem[0].size /= 2; > > + core->mem[1].size /= 2; > > + > > + dev_dbg(cdev, "adjusted TCM sizes, ATCM = 0x%zx BTCM = 0x%zx\n", > > + core->mem[0].size, core->mem[1].size); > > + } > > +} > > + > > static int k3_r5_cluster_rproc_init(struct platform_device *pdev) > > { > > struct k3_r5_cluster *cluster = platform_get_drvdata(pdev); > > @@ -933,6 +972,8 @@ static int k3_r5_cluster_rproc_init(struct platform_device *pdev) > > goto err_config; > > } > > > > + k3_r5_adjust_tcm_sizes(kproc); > > + > > ret = k3_r5_reserved_mem_init(kproc); > > if (ret) { > > dev_err(dev, "reserved memory init failed, ret = %d\n", > > @@ -1407,10 +1448,12 @@ static int k3_r5_probe(struct platform_device *pdev) > > } > > > > static const struct k3_r5_soc_data am65_j721e_soc_data = { > > + .tcm_is_double = false, > > .tcm_ecc_autoinit = false, > > }; > > > > static const struct k3_r5_soc_data j7200_soc_data = { > > + .tcm_is_double = true, > > .tcm_ecc_autoinit = true, > > With the above and for the set: > > Reviewed-by: Mathieu Poirier > > > }; > > > > -- > > 2.28.0 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel