From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1AB8BC433F5 for ; Thu, 27 Jan 2022 20:26:42 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240092AbiA0U0l (ORCPT ); Thu, 27 Jan 2022 15:26:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49196 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231384AbiA0U0k (ORCPT ); Thu, 27 Jan 2022 15:26:40 -0500 Received: from mail-ed1-x52c.google.com (mail-ed1-x52c.google.com [IPv6:2a00:1450:4864:20::52c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F215BC061748 for ; Thu, 27 Jan 2022 12:26:39 -0800 (PST) Received: by mail-ed1-x52c.google.com with SMTP id p12so5249843edq.9 for ; Thu, 27 Jan 2022 12:26:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Fi1CjDDx2TurE9KIT9xNPFydS/AJyEq38oGV2uaA61U=; b=zrJPnyAi4QGp6MxlP38emBrpS5F5jPUi1PK1fZWvpwb0xusZzOev1cXwqXD93Ah303 Ys26qGM+xFSapbAYx+F93tj/Kg5JrfOi1eaHxcUZPXT2gfuzK3Trv25cghbnsmpduaIp rJEr880xWNlS5IhFzKydfG6n3habeIUecE+dPbH9yYuzu6pIVi66TjU8gPS0Fk/b1YOV z/FwOdNYLUobxS5GHQc1FFk9W41zhXeECZD3ZxDA/9Qi+v+sppG50iWj+WkIXkNCiyK3 kq8QpsI70OhvFhB0uMMS2pDWpgN+VgzO7VyqMjXjE2SeWZ3kCOXqSuUUv/zkJHcqesvt 6KhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fi1CjDDx2TurE9KIT9xNPFydS/AJyEq38oGV2uaA61U=; b=zU3/SywL3p1p1JDcFnGxGR+VETWiATApkn8HxV+MqHBQVKTf22IdU/aQFpZD7qVB6g nsImfHdRdsug/6mYGlzQmwKlrJaKE8XOdQ4Xn5YwNh0wYvRL2JLeUSDCVw9KRxZg1SXQ 98XHSWdRPc4XVAI/TyRKLU24/k7VolBCJFnH1X7AUCzMddeHY8+aBHKNfCZ+IBJR3ra6 xdSidt/G4rx8R79WEj2hA+xWJ1Tcge70JIY1Z9lVXPfaYhBcxSpW8Agbpc7jjjC5ZaMc K+7ioDk/SSyZ6OmuZZQFMS2vmurkigz1NC79VWw0tPDtpZyP1GU+FbSuc1HlFzVYwJ7n zzGA== X-Gm-Message-State: AOAM533kjrjoO63DZm3bud9nVnroB/4Fpi6BlUuHRVsR0NXDOQug/fFB Vp8qdEugbcGgZ/EnNKvqUo0oTuFBo6zgP8UKGrhUQg== X-Google-Smtp-Source: ABdhPJznXPKKye7FSdr+lVY9GNZVYl4Rl6/0Ojgh5L4rDb57d3KmHVB5vjBqJr6BFTPH1QZ7Ji/9E0+4jr95RWzgttk= X-Received: by 2002:a05:6402:1703:: with SMTP id y3mr5072637edu.239.1643315198479; Thu, 27 Jan 2022 12:26:38 -0800 (PST) MIME-Version: 1.0 References: <20220113091056.1297982-1-james.clark@arm.com> In-Reply-To: <20220113091056.1297982-1-james.clark@arm.com> From: Mathieu Poirier Date: Thu, 27 Jan 2022 13:26:26 -0700 Message-ID: Subject: Re: [PATCH v2 0/6] coresight: Add config flag to enable branch broadcast To: James Clark Cc: Suzuki.Poulose@arm.com, coresight@lists.linaro.org, leo.yan@linaro.com, mike.leach@linaro.org, Leo Yan , John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi James, I am seriously back-logged in my patch reviews and as such will not be able to get to your work in the usual 14 days. At this time and if everything goes well, I should be able to start reviewing this patchset during the week of February 7th. Thanks, Mathieu On Thu, 13 Jan 2022 at 02:11, James Clark wrote: > > This allows enabling branch broadcast for Perf hosted sessions (the option > is currently only available for the sysfs interface). Hopefully this could > be useful for testing the decode in perf, for example does a determinisitic > run with branch broadcast enabled look the same as with it disabled? It > could also be used for scenarios like OpenJ9's support for JIT code: > > java -Xjit:perfTool hello.java > > Currently this is not working and you get the usual errors of a missing > DSO, but branch broadcast would have to be enabled anyway before working > through this next issue: > > CS ETM Trace: Debug data not found for address 0xffff7b94b058 in /tmp/perf-29360.map > > Address range support in Perf for branch broadcast has also not been added > here, but could be added later. > > The documentation has been refactored slightly to allow updates to be made > that link the Perf format arguments with the existing documentation. > > For Suzuki's comment, I will do it as a separate change that converts all > the other hard coded values to a more consistent sysreg.h style: > > nit: While at this, please could you change the hard coded value > to ETM4_CFG_BIT_RETSTK ? > > Changes since v1: > > * Added Leo's reviewed by on patch 3 > * Fix bracket styling > * Add documentation > > Applies on top of coresight/next efa56eddf5d5c. But this docs fix is also > required to get the links to work: > https://marc.info/?l=linux-doc&m=164139331923986&w=2 > > Also available at: https://gitlab.arm.com/linux-arm/linux-jc/-/tree/james-branch-broadcast-v2 > > James Clark (6): > coresight: Add config flag to enable branch broadcast > coresight: Fail to open with return stacks if they are unavailable > perf cs-etm: Update deduction of TRCCONFIGR register for branch > broadcast > Documentation: coresight: Turn numbered subsections into real > subsections > Documentation: coresight: Link config options to existing > documentation > Documentation: coresight: Expand branch broadcast documentation > > .../coresight/coresight-etm4x-reference.rst | 14 ++++- > Documentation/trace/coresight/coresight.rst | 56 +++++++++++++++++-- > .../hwtracing/coresight/coresight-etm-perf.c | 2 + > .../coresight/coresight-etm4x-core.c | 23 ++++++-- > include/linux/coresight-pmu.h | 2 + > tools/include/linux/coresight-pmu.h | 2 + > tools/perf/arch/arm/util/cs-etm.c | 3 + > 7 files changed, 92 insertions(+), 10 deletions(-) > > -- > 2.28.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 35554C433F5 for ; Thu, 27 Jan 2022 20:28:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=J8+hUEJxKq42+X7jiK8Z4TJ9fV+PVBIaVrk8gax27Vw=; b=0u2ykbJtAULKbs M26LQb9Rr+st9YYRsHdsVTL81xN1P6luOl0xf2CBvZSA4Gxpqi+Kpsu5sdwGyUIf7fIaiRwKYquJT lqOaBfR4XVZi7kKjixP4uDbBS99sucv5oJfV3XcjLeAWKvpT7QloOEjHIfTTnLLzdn9Y3lTOoso5p iXc6gU4YcUaWHGeG70v/tbtxhX0hfqRNl5k4y7IdHOtBM1j/av1YmHxXWJ0K8dZKjk1iaf3d5iQ6g GrXgsOrvfHbEhPZzDrircTIskoXguTj2BTMu7SrjKC3oSQ8WOSYebzPr+vZk3/A/X5hrcJ6fhZYtk ugwnrEPodJgI6ZXxCFiA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDBLw-00H62d-A4; Thu, 27 Jan 2022 20:26:44 +0000 Received: from mail-ed1-x52e.google.com ([2a00:1450:4864:20::52e]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nDBLs-00H60k-4g for linux-arm-kernel@lists.infradead.org; Thu, 27 Jan 2022 20:26:41 +0000 Received: by mail-ed1-x52e.google.com with SMTP id r10so5306089edt.1 for ; Thu, 27 Jan 2022 12:26:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Fi1CjDDx2TurE9KIT9xNPFydS/AJyEq38oGV2uaA61U=; b=zrJPnyAi4QGp6MxlP38emBrpS5F5jPUi1PK1fZWvpwb0xusZzOev1cXwqXD93Ah303 Ys26qGM+xFSapbAYx+F93tj/Kg5JrfOi1eaHxcUZPXT2gfuzK3Trv25cghbnsmpduaIp rJEr880xWNlS5IhFzKydfG6n3habeIUecE+dPbH9yYuzu6pIVi66TjU8gPS0Fk/b1YOV z/FwOdNYLUobxS5GHQc1FFk9W41zhXeECZD3ZxDA/9Qi+v+sppG50iWj+WkIXkNCiyK3 kq8QpsI70OhvFhB0uMMS2pDWpgN+VgzO7VyqMjXjE2SeWZ3kCOXqSuUUv/zkJHcqesvt 6KhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Fi1CjDDx2TurE9KIT9xNPFydS/AJyEq38oGV2uaA61U=; b=sgnUyAkrViPk/mwpUUx4TDIuGu4BRr5rznXQVrb8buGmXZx5qbhTofLzNniC1i8mZo y+Drx3m/Q924IUOd+RyeBUUb0KxF7HpmzGBcqJcXmR0slnxKa/FeW3uDTGv87UdaCsql lJK1r5MyAA4ovaZ299dI7LEAci8Vw7USfTqvLY+Wn+W9kE4I+6cR7FcCZsyTZyOzvYzi iWGOGfTQvigUi4ipMOWx9iiGfZvMeGg3f3MX1XzZHlY9Rt1ezPU8D9a1P0QwJpzUaq+s 4PatFXQ/RKHdapFRV43Pnbf6jjHdZ1S5lqmcYf5IvAuTtPMPNBQNeBm/S19ngZC5/nDb abeQ== X-Gm-Message-State: AOAM530EJzmlp+rWu3hBdPHXVV9dBATH5m5JUDsoVomtfA/KtnakqVp8 m93WreWImtLhPqkrWjvjPM6fWkagEvItkCZsjf0Hqw+ux+M= X-Google-Smtp-Source: ABdhPJznXPKKye7FSdr+lVY9GNZVYl4Rl6/0Ojgh5L4rDb57d3KmHVB5vjBqJr6BFTPH1QZ7Ji/9E0+4jr95RWzgttk= X-Received: by 2002:a05:6402:1703:: with SMTP id y3mr5072637edu.239.1643315198479; Thu, 27 Jan 2022 12:26:38 -0800 (PST) MIME-Version: 1.0 References: <20220113091056.1297982-1-james.clark@arm.com> In-Reply-To: <20220113091056.1297982-1-james.clark@arm.com> From: Mathieu Poirier Date: Thu, 27 Jan 2022 13:26:26 -0700 Message-ID: Subject: Re: [PATCH v2 0/6] coresight: Add config flag to enable branch broadcast To: James Clark Cc: Suzuki.Poulose@arm.com, coresight@lists.linaro.org, leo.yan@linaro.com, mike.leach@linaro.org, Leo Yan , John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220127_122640_209584_36A54332 X-CRM114-Status: GOOD ( 25.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi James, I am seriously back-logged in my patch reviews and as such will not be able to get to your work in the usual 14 days. At this time and if everything goes well, I should be able to start reviewing this patchset during the week of February 7th. Thanks, Mathieu On Thu, 13 Jan 2022 at 02:11, James Clark wrote: > > This allows enabling branch broadcast for Perf hosted sessions (the option > is currently only available for the sysfs interface). Hopefully this could > be useful for testing the decode in perf, for example does a determinisitic > run with branch broadcast enabled look the same as with it disabled? It > could also be used for scenarios like OpenJ9's support for JIT code: > > java -Xjit:perfTool hello.java > > Currently this is not working and you get the usual errors of a missing > DSO, but branch broadcast would have to be enabled anyway before working > through this next issue: > > CS ETM Trace: Debug data not found for address 0xffff7b94b058 in /tmp/perf-29360.map > > Address range support in Perf for branch broadcast has also not been added > here, but could be added later. > > The documentation has been refactored slightly to allow updates to be made > that link the Perf format arguments with the existing documentation. > > For Suzuki's comment, I will do it as a separate change that converts all > the other hard coded values to a more consistent sysreg.h style: > > nit: While at this, please could you change the hard coded value > to ETM4_CFG_BIT_RETSTK ? > > Changes since v1: > > * Added Leo's reviewed by on patch 3 > * Fix bracket styling > * Add documentation > > Applies on top of coresight/next efa56eddf5d5c. But this docs fix is also > required to get the links to work: > https://marc.info/?l=linux-doc&m=164139331923986&w=2 > > Also available at: https://gitlab.arm.com/linux-arm/linux-jc/-/tree/james-branch-broadcast-v2 > > James Clark (6): > coresight: Add config flag to enable branch broadcast > coresight: Fail to open with return stacks if they are unavailable > perf cs-etm: Update deduction of TRCCONFIGR register for branch > broadcast > Documentation: coresight: Turn numbered subsections into real > subsections > Documentation: coresight: Link config options to existing > documentation > Documentation: coresight: Expand branch broadcast documentation > > .../coresight/coresight-etm4x-reference.rst | 14 ++++- > Documentation/trace/coresight/coresight.rst | 56 +++++++++++++++++-- > .../hwtracing/coresight/coresight-etm-perf.c | 2 + > .../coresight/coresight-etm4x-core.c | 23 ++++++-- > include/linux/coresight-pmu.h | 2 + > tools/include/linux/coresight-pmu.h | 2 + > tools/perf/arch/arm/util/cs-etm.c | 3 + > 7 files changed, 92 insertions(+), 10 deletions(-) > > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel