From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751956AbdGGP3B (ORCPT ); Fri, 7 Jul 2017 11:29:01 -0400 Received: from mail-yb0-f171.google.com ([209.85.213.171]:33969 "EHLO mail-yb0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750778AbdGGP3A (ORCPT ); Fri, 7 Jul 2017 11:29:00 -0400 MIME-Version: 1.0 In-Reply-To: <97ff1c3f7145b0e4326fbbb246579cd5382880b3.1499233557.git.arvind.yadav.cs@gmail.com> References: <97ff1c3f7145b0e4326fbbb246579cd5382880b3.1499233557.git.arvind.yadav.cs@gmail.com> From: Mathieu Poirier Date: Fri, 7 Jul 2017 09:28:58 -0600 Message-ID: Subject: Re: [PATCH] hwtracing: coresight: constify attribute_group structures. To: Arvind Yadav Cc: Greg KH , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 4 July 2017 at 23:49, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 2573 288 296 3157 c55 coresight-etm-perf.o > > File size After adding 'const': > text data bss dec hex filename > 2613 224 296 3133 c3d coresight-etm-perf.o Hi Arvind, Did you find this using an automated tool or simply stumbled on it while reviewing the code? In case of the former it is usually a good idea to specify which tool was used in the change log. Thanks, Mathieu > > Signed-off-by: Arvind Yadav > --- > drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c > index 288a423..e97775d 100644 > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > @@ -60,7 +60,7 @@ struct etm_event_data { > NULL, > }; > > -static struct attribute_group etm_pmu_format_group = { > +static const struct attribute_group etm_pmu_format_group = { > .name = "format", > .attrs = etm_config_formats_attr, > }; > -- > 1.9.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 From: mathieu.poirier@linaro.org (Mathieu Poirier) Date: Fri, 7 Jul 2017 09:28:58 -0600 Subject: [PATCH] hwtracing: coresight: constify attribute_group structures. In-Reply-To: <97ff1c3f7145b0e4326fbbb246579cd5382880b3.1499233557.git.arvind.yadav.cs@gmail.com> References: <97ff1c3f7145b0e4326fbbb246579cd5382880b3.1499233557.git.arvind.yadav.cs@gmail.com> Message-ID: To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 4 July 2017 at 23:49, Arvind Yadav wrote: > attribute_groups are not supposed to change at runtime. All functions > working with attribute_groups provided by work with const > attribute_group. So mark the non-const structs as const. > > File size before: > text data bss dec hex filename > 2573 288 296 3157 c55 coresight-etm-perf.o > > File size After adding 'const': > text data bss dec hex filename > 2613 224 296 3133 c3d coresight-etm-perf.o Hi Arvind, Did you find this using an automated tool or simply stumbled on it while reviewing the code? In case of the former it is usually a good idea to specify which tool was used in the change log. Thanks, Mathieu > > Signed-off-by: Arvind Yadav > --- > drivers/hwtracing/coresight/coresight-etm-perf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/hwtracing/coresight/coresight-etm-perf.c b/drivers/hwtracing/coresight/coresight-etm-perf.c > index 288a423..e97775d 100644 > --- a/drivers/hwtracing/coresight/coresight-etm-perf.c > +++ b/drivers/hwtracing/coresight/coresight-etm-perf.c > @@ -60,7 +60,7 @@ struct etm_event_data { > NULL, > }; > > -static struct attribute_group etm_pmu_format_group = { > +static const struct attribute_group etm_pmu_format_group = { > .name = "format", > .attrs = etm_config_formats_attr, > }; > -- > 1.9.1 >