From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E0A7C4338F for ; Wed, 4 Aug 2021 14:33:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 26FE660F58 for ; Wed, 4 Aug 2021 14:33:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238782AbhHDOdY (ORCPT ); Wed, 4 Aug 2021 10:33:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55342 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238960AbhHDOcK (ORCPT ); Wed, 4 Aug 2021 10:32:10 -0400 Received: from mail-il1-x12c.google.com (mail-il1-x12c.google.com [IPv6:2607:f8b0:4864:20::12c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 00969C0613D5 for ; Wed, 4 Aug 2021 07:31:24 -0700 (PDT) Received: by mail-il1-x12c.google.com with SMTP id r1so1846518iln.6 for ; Wed, 04 Aug 2021 07:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ArPyR0cCoAxuI9e4sD/Wh51Ldx6h8E3MWwQUW8SaObk=; b=LNOjU4eYHVG/OAkMvEMLp1SWmVxQYnnAUDh1hZTMn+UdjxREoD3BDl/JNp2JQqMcTz IliK4YhV6iQAUPqCY5oWPPhOBQEHq/+O9V3Z9QCcZ7GmQcoWzbv7ObL2QFz7LtLNEpWI nw/XSyTdsZdoj0uVNoPitK3HBqERPm7Owq6r3l4GfzEmJvtYPmReTrtN5NYxOnAogDKc kidXZE4bBAjhlEdLnZWTzjHKfkh0reVCxo1G/XnDkLxQW1Rj4vsnSnznhRYwRbpI96u5 E+2i5ztoJLIau8P66CQ9Trhlto8120t0dxeZfzJVS3b7U9+3ho5CLh07lrqhhvlHCTGA TXQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ArPyR0cCoAxuI9e4sD/Wh51Ldx6h8E3MWwQUW8SaObk=; b=nRSSdslhz5gF7mCGo22GYLGejBtEdNTV+aeS+ceXt2vpdCxFgnIlvT6+3eUYgYN6VF 7O7pTw0CupPCHMG4CcQyHzIE7ijbgBsVd2JhU8PWFLtFGRBIl2xJEn3DUKTH80PT/2Pc kywyCfv8hzprJCQ72D/mUUzBQjFh44XuRp/MiDU62gmDky5A4WXC2sL4exh8qVAsYtZb 77Yz9cofkJkfmKKf00kBhRwHH6fqpKZqjWD3L9PeqOIK7JzkUiyTQ53yahHgcei1oBbv 3jC2i43fpe4oCVe2lP410DthOPGOJ3+/Y3mfWPQHeHfcdEuJ5cte+VE1s1+RzjRrS/FU 18xQ== X-Gm-Message-State: AOAM5330qJSXD8mrf/S42B+5m0PCMlzZ6SUt2T296JRH6wSsiMvs++38 jp+b8ojv3nAkvZvaAJsidkd0p6ySjRTcjRYs+xQBUA== X-Google-Smtp-Source: ABdhPJycmN+PxuH8ZW/WWqujOz75VX1L1PHN4GOjYU+NOKvpSTC25Z4rlJF1LbQfWzDUHgfobfssDz9DlrReCTWCRYg= X-Received: by 2002:a92:cb4d:: with SMTP id f13mr343ilq.57.1628087484395; Wed, 04 Aug 2021 07:31:24 -0700 (PDT) MIME-Version: 1.0 References: <20210719111737.47891-1-liuqi115@huawei.com> <41661d60-d8ef-9d50-57eb-8964c6f6eef8@huawei.com> In-Reply-To: <41661d60-d8ef-9d50-57eb-8964c6f6eef8@huawei.com> From: Mathieu Poirier Date: Wed, 4 Aug 2021 08:31:13 -0600 Message-ID: Subject: Re: [PATCH 0/2] coresight: ultrasoc: Add support for System Memory Buffer device To: "liuqi (BA)" Cc: Linuxarm , "Suzuki K. Poulose" , Mike Leach , Coresight ML , Linux Kernel Mailing List , linux-arm-kernel Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 4 Aug 2021 at 02:05, liuqi (BA) wrote: > > Gentle ping... > Hi Mathieu and Suzuki, can you have a look at this patchset? thanks. > On August 2nd I got back to you privately saying I won't be able to review this patchset before the last week of August or the first week of September. Pinging me again on it won't change that reality. > On 2021/7/19 19:17, Qi Liu wrote: > > This patchset add support for SMB(System Memory Buffer) device, SMB > > obtains CPU instructions from Coresight ETM device and stores these > > messages in system memory. > > SMB is developed by Ultrasoc technology, which is acquired by Siemens, > > and we still use "Ultrasoc" to name document and driver. > > > > Change since RFC: > > - Move ultrasoc driver to drivers/hwtracing/coresight. > > - Remove ultrasoc-axi-com.c, as AXI-COM doesn't need to be configured in > > basic tracing function. > > - Remove ultrasoc.c as SMB does not need to register with the ultrasoc core. > > - Address the comments from Mathieu and Suzuki. > > - Link: https://lists.linaro.org/pipermail/coresight/2021-June/006535.html > > > > Qi Liu (2): > > Documentation: tracing: Documentation for ultrasoc SMB drivers > > coresight: ultrasoc: Add System Memory Buffer driver > > > > .../trace/coresight/ultrasoc-trace.rst | 193 +++++ > > MAINTAINERS | 7 + > > drivers/hwtracing/coresight/Kconfig | 3 + > > drivers/hwtracing/coresight/Makefile | 2 + > > drivers/hwtracing/coresight/ultrasoc/Kconfig | 12 + > > drivers/hwtracing/coresight/ultrasoc/Makefile | 6 + > > .../coresight/ultrasoc/ultrasoc-smb.c | 722 ++++++++++++++++++ > > .../coresight/ultrasoc/ultrasoc-smb.h | 142 ++++ > > 8 files changed, 1087 insertions(+) > > create mode 100644 Documentation/trace/coresight/ultrasoc-trace.rst > > create mode 100644 drivers/hwtracing/coresight/ultrasoc/Kconfig > > create mode 100644 drivers/hwtracing/coresight/ultrasoc/Makefile > > create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.c > > create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.h > > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 127E2C4338F for ; Wed, 4 Aug 2021 14:33:16 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D97E660FC3 for ; Wed, 4 Aug 2021 14:33:15 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org D97E660FC3 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f1xH8F7VirrQXrvqjisJQkvJXjNPU9jpMWEhfIARcWc=; b=rr0obBhz8oOLz3 8KNEe6quZaXoI68IWuskS3k0LH5K9VH4hM/k5WEjL4GxzSZVyEvBGFFrPFihnHL2N0oOG1b83Zk7F EaMbOK03DKr/4SCd/t3DE+WNs4iWQ8OYe8sxHPaC14vYsdwT5NODajsoLJyBDyBoIALZaM8PRFlcG DgBk4cmIUWOx32SVDgepwVDp0XSAARh0jn8nj7go5vOD9OyLXSw9jrPwaDK59bgYzbDDchm1J6tff oOMuABldnVuiXtexMtMsOyWqmfh6Wh6FUM354hcKp5dRDY+FuxqKrbBnUFbtStSWSsZP8KrYovlfY fUvD6/ij2s+x+Qw6Epdw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBHvd-006RGp-MV; Wed, 04 Aug 2021 14:31:29 +0000 Received: from mail-il1-x130.google.com ([2607:f8b0:4864:20::130]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mBHvZ-006RFe-VB for linux-arm-kernel@lists.infradead.org; Wed, 04 Aug 2021 14:31:27 +0000 Received: by mail-il1-x130.google.com with SMTP id j18so1846257ile.8 for ; Wed, 04 Aug 2021 07:31:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ArPyR0cCoAxuI9e4sD/Wh51Ldx6h8E3MWwQUW8SaObk=; b=LNOjU4eYHVG/OAkMvEMLp1SWmVxQYnnAUDh1hZTMn+UdjxREoD3BDl/JNp2JQqMcTz IliK4YhV6iQAUPqCY5oWPPhOBQEHq/+O9V3Z9QCcZ7GmQcoWzbv7ObL2QFz7LtLNEpWI nw/XSyTdsZdoj0uVNoPitK3HBqERPm7Owq6r3l4GfzEmJvtYPmReTrtN5NYxOnAogDKc kidXZE4bBAjhlEdLnZWTzjHKfkh0reVCxo1G/XnDkLxQW1Rj4vsnSnznhRYwRbpI96u5 E+2i5ztoJLIau8P66CQ9Trhlto8120t0dxeZfzJVS3b7U9+3ho5CLh07lrqhhvlHCTGA TXQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ArPyR0cCoAxuI9e4sD/Wh51Ldx6h8E3MWwQUW8SaObk=; b=sOx85024eR/45/qqalVjpZvnrOwyQQfDAtQ+rkIH4xJlk1ANDNdE8i7h/Xy8H5lQPz 3cZgL6GYH+BFPiSK/0a2B6+932fBaVB6eYfK4j2apKp/lWU7DlKozxIbanIYdGU+1irY A41im3DwqKpwY3Wl3B1LfnVD+lWErBORR03k6K9xY9jQAFzuf9blmcn+LaeeaIpJql3T tiQ56Ylec9J5lf6KEyWwleqt7rlGLGPkLRj3IIXa8//0tmE1DMWWTAVvlxWaxVXhFvGS CUCG6/q16xEW4hMJ34XLrwu1xLuxgVE5zcvptaTniUSrqWHP0gk3KoLPwdZoWC2i64kk TZxQ== X-Gm-Message-State: AOAM5315vjzu2x6Zxg/cQe0KGGZaHXV8fvvb/IsNjzmnNj+hAerVbMIb mzvc1hmUQjqsf4UdWVymCd2Yd3Xpb5kOJmt7Lyp5TA== X-Google-Smtp-Source: ABdhPJycmN+PxuH8ZW/WWqujOz75VX1L1PHN4GOjYU+NOKvpSTC25Z4rlJF1LbQfWzDUHgfobfssDz9DlrReCTWCRYg= X-Received: by 2002:a92:cb4d:: with SMTP id f13mr343ilq.57.1628087484395; Wed, 04 Aug 2021 07:31:24 -0700 (PDT) MIME-Version: 1.0 References: <20210719111737.47891-1-liuqi115@huawei.com> <41661d60-d8ef-9d50-57eb-8964c6f6eef8@huawei.com> In-Reply-To: <41661d60-d8ef-9d50-57eb-8964c6f6eef8@huawei.com> From: Mathieu Poirier Date: Wed, 4 Aug 2021 08:31:13 -0600 Message-ID: Subject: Re: [PATCH 0/2] coresight: ultrasoc: Add support for System Memory Buffer device To: "liuqi (BA)" Cc: Linuxarm , "Suzuki K. Poulose" , Mike Leach , Coresight ML , Linux Kernel Mailing List , linux-arm-kernel X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210804_073126_053223_7DA79372 X-CRM114-Status: GOOD ( 22.91 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 4 Aug 2021 at 02:05, liuqi (BA) wrote: > > Gentle ping... > Hi Mathieu and Suzuki, can you have a look at this patchset? thanks. > On August 2nd I got back to you privately saying I won't be able to review this patchset before the last week of August or the first week of September. Pinging me again on it won't change that reality. > On 2021/7/19 19:17, Qi Liu wrote: > > This patchset add support for SMB(System Memory Buffer) device, SMB > > obtains CPU instructions from Coresight ETM device and stores these > > messages in system memory. > > SMB is developed by Ultrasoc technology, which is acquired by Siemens, > > and we still use "Ultrasoc" to name document and driver. > > > > Change since RFC: > > - Move ultrasoc driver to drivers/hwtracing/coresight. > > - Remove ultrasoc-axi-com.c, as AXI-COM doesn't need to be configured in > > basic tracing function. > > - Remove ultrasoc.c as SMB does not need to register with the ultrasoc core. > > - Address the comments from Mathieu and Suzuki. > > - Link: https://lists.linaro.org/pipermail/coresight/2021-June/006535.html > > > > Qi Liu (2): > > Documentation: tracing: Documentation for ultrasoc SMB drivers > > coresight: ultrasoc: Add System Memory Buffer driver > > > > .../trace/coresight/ultrasoc-trace.rst | 193 +++++ > > MAINTAINERS | 7 + > > drivers/hwtracing/coresight/Kconfig | 3 + > > drivers/hwtracing/coresight/Makefile | 2 + > > drivers/hwtracing/coresight/ultrasoc/Kconfig | 12 + > > drivers/hwtracing/coresight/ultrasoc/Makefile | 6 + > > .../coresight/ultrasoc/ultrasoc-smb.c | 722 ++++++++++++++++++ > > .../coresight/ultrasoc/ultrasoc-smb.h | 142 ++++ > > 8 files changed, 1087 insertions(+) > > create mode 100644 Documentation/trace/coresight/ultrasoc-trace.rst > > create mode 100644 drivers/hwtracing/coresight/ultrasoc/Kconfig > > create mode 100644 drivers/hwtracing/coresight/ultrasoc/Makefile > > create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.c > > create mode 100644 drivers/hwtracing/coresight/ultrasoc/ultrasoc-smb.h > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel