From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 60C9BC67871 for ; Mon, 24 Oct 2022 22:16:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Bdr9XzmXGP/KF2FoZM+Y/HJsV/At/sNPH7vemn/MtfQ=; b=dUcH1Wxsy8bXDF tWPlb2888W73xzgy+jhm3VLySkGmqds6QKkF49FYE8O5CbWuM/STQ0USlaorsJ+SSXcR96pGC1JrB zh3dbkpweaRJaHkBEI2JWZdfLJWRMPqQmweEUVjI/uQRyIJLHk4lw0YhICOSHA8JdSt5WANrnbU42 KMubayl9P58/eHdftJXOgFa+I7Tl3R9T3Caz8vMfhi4xZa24TW7PoAIKVcL7K19jUs5Ykdq2PwI5e a/+QjrkycoRPk6HkWorUJ348/2r2wbM/GNQggtrf/oDIw7DM9PLjs/H0bnNqTJEj52IdoYNdFVjpb LrNTuAIFKfWXH+m2XwpQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1on5iz-003Fo0-Hv; Mon, 24 Oct 2022 22:15:13 +0000 Received: from mail-io1-xd36.google.com ([2607:f8b0:4864:20::d36]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1on5iv-003FmC-Ku for linux-arm-kernel@lists.infradead.org; Mon, 24 Oct 2022 22:15:11 +0000 Received: by mail-io1-xd36.google.com with SMTP id e15so8941071iof.2 for ; Mon, 24 Oct 2022 15:15:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=h6vua4Dyda0yEvNLZR0r5GnBK0oOLnVu43JFNVctrL0=; b=JMAVY4yEPNKXqRpMvAj2Z5XXaddcr3sui1yLCm77hsyJyRHKJOTfx1vxVzi8RGZJM4 Z1MwJKPfFkHQrnGMeg0ZJ8zl290QuCfNSBDJpSg0M0N8T8PeMtv69qvfOq0OquUmsnZ5 qVqxBdK5bVvoj3HDwCU7eD5g+OjFVGa0L46FGvviBpU/hcVQVehrTenHvKPD7T5LuHfT q3UgCblQKy0vuuQcHGi/waniCyqxlj+MViSgVmni8DbhNiY3THogwibqCz2FsnoxA/ol CU/GdzRfqQNCMVGhPaiJk6q4YzIfA73i8AtW7mqwqi10ofVP/vHKIivCoCdJw2EBXSE7 FBRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=h6vua4Dyda0yEvNLZR0r5GnBK0oOLnVu43JFNVctrL0=; b=mSTiXzGQyqOOocDpUZCFSg7C79Fsi1R9/uljTj5qomXcofEzokj6WqEtAOTaOO27+z fxTDpG9E44vfzyXV2iVYv9PXtHskSfOz4FIDyGHenuqjBmbELTO7WcgEi8iToadZ0f08 ZMVhnNQvh1ixr6apchlQS1ES2OeuSoX+4HD6Gd2WQ+BcQw4diGIv1cVxgRJMVBw4+moD rbNK5etomPjyx/7lOg1qks2a9AQmuL769T6kIOvwf3NuS5kiX8KnUeIOpGxpf1uLVwzo w6Y5j+hO4RLnD9zXhLrFjRhcnkHIhM2mRO0U2Mz/x87kCoXOqXWBUXMiku5yKHplQFY/ K9LQ== X-Gm-Message-State: ACrzQf32GT4Yr0y1uHH9e7VO3FQnI8f0xomDtQq4p1pNU9HV6FIiF/Yg KhOzM7jr/GqlHCNrkyeMXfygTWdPAO8HN3I55QiXOA== X-Google-Smtp-Source: AMsMyM6KLbOdRtdnqqasj6uf/KvNNi26YuJ8uJwYogOKbtCN2OaIs1Boa0viHFPJjZPGe3zFvUwEyrB66Fq89CUxc8o= X-Received: by 2002:a05:6638:379f:b0:363:cd63:1954 with SMTP id w31-20020a056638379f00b00363cd631954mr22919914jal.103.1666649706202; Mon, 24 Oct 2022 15:15:06 -0700 (PDT) MIME-Version: 1.0 References: <20221021041526.3696483-1-peng.fan@oss.nxp.com> In-Reply-To: <20221021041526.3696483-1-peng.fan@oss.nxp.com> From: Mathieu Poirier Date: Mon, 24 Oct 2022 16:14:55 -0600 Message-ID: Subject: Re: [PATCH V8 0/7] remoteproc: imx_rproc: support i.MX8QM/QXP To: "Peng Fan (OSS)" Cc: bjorn.andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221024_151509_732198_DC7DF83A X-CRM114-Status: GOOD ( 22.53 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org I have applied this set. Thanks, Mathieu On Thu, 20 Oct 2022 at 22:14, Peng Fan (OSS) wrote: > > From: Peng Fan > > V8: > patch 2/7: Per Krzysztof, keep alphabetical order for compatible string > Patch 6/7: Add comments to explain the tx_ch/rx_ch check in imx_rproc_xtr_mbox_init, > to address comment: https://lore.kernel.org/all/20221017173335.GA121862@p14s/ > > V7: > patch 3/7: use dev_err, and R-b from Mathieu > patch 4/7: Add comment when "num_pd <= 1", add R-b from Mathieu > patch 5/7: Typo has->have, add R-b from Mathieu > patch 6/7: add detach hook to free the mbox. As wrote in the patch commit log, > imx_rproc_xtr_mbox_init is called both in probe and attach hook to resolve > mbox defer probe, so there is check in imx_rproc_xtr_mbox_init. > Moved imx_rproc_free_mbox out from parition notify to detach hook > patch 7/7: since detach hook moved to patch 6/7, so only enable recovery feature. > > https://lore.kernel.org/all/20221014031037.1070424-1-peng.fan@oss.nxp.com/ > > V6: > Two changes are made: > 1. > In V5, patch 3 has a wrong logic in imx_rproc_put_scu, see [1], however > patch 4 fixed the wrong logic, as below: > > - if (!imx_sc_rm_is_resource_owned(priv->ipc_handle, priv->rsrc_id)) > - return; > + if (imx_sc_rm_is_resource_owned(priv->ipc_handle, priv->rsrc_id)) > + return imx_rproc_detach_pd(rproc); > > In V6, patch 3 fixed the wrong logic, drop the fix in patch 4. And patch 4 > changed as below, because put scu not has return value. > imx_rproc_detach_pd(rproc); > return; > > 2. Include patch 7/7 to enable attach recovery, because the attach recovery > feature has been supported in remoteproc core. > > [1] https://lore.kernel.org/linux-remoteproc/DU0PR04MB941763C3EBF8AE9A9CD69445884C9@DU0PR04MB9417.eurprd04.prod.outlook.com/T/#m87e2864260d0a1c431b577068ba79e1d64c595f1 > > V5: > The patchset could not apply on latest remoteproc for-next branch, > so rebased. Only patch 6 has a minor conflict, other patches are not > changed. > > V4: > https://lore.kernel.org/all/20220701104725.557314-1-peng.fan@oss.nxp.com/ > Add R-b from DT maintainer > Fix probe failure and driver remove path in patch 3, 4 > Add comments about i.MX8QM entries filter in patch 5 > > V3: > Drop the dependency in V2. > Tested on i.MX8QM/8MM > Use 'fsl,resource-id' and 'fsl,entry-address' Per dt maintainer > Drop 'reg' property Per remoteproc maintainer > Drop mcore self recovery, until we land in common framework support. > https://patchwork.kernel.org/project/linux-remoteproc/cover/20220517064937.4033441-1-peng.fan@oss.nxp.com/ > > V2: > https://patchwork.kernel.org/project/linux-remoteproc/cover/20220309102118.8131-1-peng.fan@oss.nxp.com/ > Depends on https://patchwork.kernel.org/project/linux-remoteproc/list/?series=621311 > Tested on i.MX8QXP/QM/8MP > Addressed Mathieu's comments > Drop V1 patch 5/9, patch 3/9 is replaced with upper dependency patchset > Move V1 patch 4/9 out to https://patchwork.kernel.org/project/linux-remoteproc/patch/20220308065754.3355-1-peng.fan@oss.nxp.com/ > Update commit log > Drop magic number to get entry address from device tree in patch 4/6 > > The V1 patchset: > https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-4-peng.fan@oss.nxp.com/ > > Peng Fan (7): > dt-bindings: remoteproc: imx_rproc: support i.MX8QXP > dt-bindings: remoteproc: imx_rproc: support i.MX8QM > remoteproc: imx_rproc: support attaching to i.MX8QXP M4 > remoteproc: imx_rproc: support kicking Mcore from Linux for i.MX8QXP > remoteproc: imx_rproc: support i.MX8QM > remoteproc: imx_rproc: request mbox channel later > remoteproc: imx_rproc: Enable attach recovery for i.MX8QM/QXP > > .../bindings/remoteproc/fsl,imx-rproc.yaml | 16 + > drivers/remoteproc/imx_rproc.c | 294 +++++++++++++++++- > 2 files changed, 304 insertions(+), 6 deletions(-) > > -- > 2.37.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 910A7C38A2D for ; Mon, 24 Oct 2022 23:58:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231128AbiJXX6Y (ORCPT ); Mon, 24 Oct 2022 19:58:24 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39820 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231180AbiJXX6C (ORCPT ); Mon, 24 Oct 2022 19:58:02 -0400 Received: from mail-io1-xd2a.google.com (mail-io1-xd2a.google.com [IPv6:2607:f8b0:4864:20::d2a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 884D5347B7E for ; Mon, 24 Oct 2022 15:15:09 -0700 (PDT) Received: by mail-io1-xd2a.google.com with SMTP id b79so8920809iof.5 for ; Mon, 24 Oct 2022 15:15:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=h6vua4Dyda0yEvNLZR0r5GnBK0oOLnVu43JFNVctrL0=; b=JMAVY4yEPNKXqRpMvAj2Z5XXaddcr3sui1yLCm77hsyJyRHKJOTfx1vxVzi8RGZJM4 Z1MwJKPfFkHQrnGMeg0ZJ8zl290QuCfNSBDJpSg0M0N8T8PeMtv69qvfOq0OquUmsnZ5 qVqxBdK5bVvoj3HDwCU7eD5g+OjFVGa0L46FGvviBpU/hcVQVehrTenHvKPD7T5LuHfT q3UgCblQKy0vuuQcHGi/waniCyqxlj+MViSgVmni8DbhNiY3THogwibqCz2FsnoxA/ol CU/GdzRfqQNCMVGhPaiJk6q4YzIfA73i8AtW7mqwqi10ofVP/vHKIivCoCdJw2EBXSE7 FBRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=h6vua4Dyda0yEvNLZR0r5GnBK0oOLnVu43JFNVctrL0=; b=EJ4UIJcMvnbjEvwB6HbskREnj0j3v2/hpPYYl58Ii6W7hxPXrIdcBh3iK9zviPP7jC BMpeca8d7OG92ZZljs3p/gEfV1kVps1KZ9ERkBx37D1YFIR5c+ggw+SHwEFxqI3fIuMe lWU1gSZ8EEUHChfCe+8hxoA1U9j9J99+IBL3zVkTU0zQUnyuzO9cLGZaLECsWKEM0wz4 tfoem63G3uCzEMoVeBNL6LvUAzIl3qq6VgdZGyyLVUxFn5LryktTwOuaDtdv1RXzofJw jRS2EjJaNDZi5SBFhZmMZydfCXMmm36Yr+GCzpOSuk2dZCGhaZKLLCik8NoMtwWNifgo UA/w== X-Gm-Message-State: ACrzQf1uQqTMgkBNL78aXzLy/hHmqkIdPXPcp94WbbAuIWaVPR66lOc3 FY5pKqgLNPSFQ35N7lPQnaNyUN3p84Q0o07z/9IrKw== X-Google-Smtp-Source: AMsMyM6KLbOdRtdnqqasj6uf/KvNNi26YuJ8uJwYogOKbtCN2OaIs1Boa0viHFPJjZPGe3zFvUwEyrB66Fq89CUxc8o= X-Received: by 2002:a05:6638:379f:b0:363:cd63:1954 with SMTP id w31-20020a056638379f00b00363cd631954mr22919914jal.103.1666649706202; Mon, 24 Oct 2022 15:15:06 -0700 (PDT) MIME-Version: 1.0 References: <20221021041526.3696483-1-peng.fan@oss.nxp.com> In-Reply-To: <20221021041526.3696483-1-peng.fan@oss.nxp.com> From: Mathieu Poirier Date: Mon, 24 Oct 2022 16:14:55 -0600 Message-ID: Subject: Re: [PATCH V8 0/7] remoteproc: imx_rproc: support i.MX8QM/QXP To: "Peng Fan (OSS)" Cc: bjorn.andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org I have applied this set. Thanks, Mathieu On Thu, 20 Oct 2022 at 22:14, Peng Fan (OSS) wrote: > > From: Peng Fan > > V8: > patch 2/7: Per Krzysztof, keep alphabetical order for compatible string > Patch 6/7: Add comments to explain the tx_ch/rx_ch check in imx_rproc_xtr_mbox_init, > to address comment: https://lore.kernel.org/all/20221017173335.GA121862@p14s/ > > V7: > patch 3/7: use dev_err, and R-b from Mathieu > patch 4/7: Add comment when "num_pd <= 1", add R-b from Mathieu > patch 5/7: Typo has->have, add R-b from Mathieu > patch 6/7: add detach hook to free the mbox. As wrote in the patch commit log, > imx_rproc_xtr_mbox_init is called both in probe and attach hook to resolve > mbox defer probe, so there is check in imx_rproc_xtr_mbox_init. > Moved imx_rproc_free_mbox out from parition notify to detach hook > patch 7/7: since detach hook moved to patch 6/7, so only enable recovery feature. > > https://lore.kernel.org/all/20221014031037.1070424-1-peng.fan@oss.nxp.com/ > > V6: > Two changes are made: > 1. > In V5, patch 3 has a wrong logic in imx_rproc_put_scu, see [1], however > patch 4 fixed the wrong logic, as below: > > - if (!imx_sc_rm_is_resource_owned(priv->ipc_handle, priv->rsrc_id)) > - return; > + if (imx_sc_rm_is_resource_owned(priv->ipc_handle, priv->rsrc_id)) > + return imx_rproc_detach_pd(rproc); > > In V6, patch 3 fixed the wrong logic, drop the fix in patch 4. And patch 4 > changed as below, because put scu not has return value. > imx_rproc_detach_pd(rproc); > return; > > 2. Include patch 7/7 to enable attach recovery, because the attach recovery > feature has been supported in remoteproc core. > > [1] https://lore.kernel.org/linux-remoteproc/DU0PR04MB941763C3EBF8AE9A9CD69445884C9@DU0PR04MB9417.eurprd04.prod.outlook.com/T/#m87e2864260d0a1c431b577068ba79e1d64c595f1 > > V5: > The patchset could not apply on latest remoteproc for-next branch, > so rebased. Only patch 6 has a minor conflict, other patches are not > changed. > > V4: > https://lore.kernel.org/all/20220701104725.557314-1-peng.fan@oss.nxp.com/ > Add R-b from DT maintainer > Fix probe failure and driver remove path in patch 3, 4 > Add comments about i.MX8QM entries filter in patch 5 > > V3: > Drop the dependency in V2. > Tested on i.MX8QM/8MM > Use 'fsl,resource-id' and 'fsl,entry-address' Per dt maintainer > Drop 'reg' property Per remoteproc maintainer > Drop mcore self recovery, until we land in common framework support. > https://patchwork.kernel.org/project/linux-remoteproc/cover/20220517064937.4033441-1-peng.fan@oss.nxp.com/ > > V2: > https://patchwork.kernel.org/project/linux-remoteproc/cover/20220309102118.8131-1-peng.fan@oss.nxp.com/ > Depends on https://patchwork.kernel.org/project/linux-remoteproc/list/?series=621311 > Tested on i.MX8QXP/QM/8MP > Addressed Mathieu's comments > Drop V1 patch 5/9, patch 3/9 is replaced with upper dependency patchset > Move V1 patch 4/9 out to https://patchwork.kernel.org/project/linux-remoteproc/patch/20220308065754.3355-1-peng.fan@oss.nxp.com/ > Update commit log > Drop magic number to get entry address from device tree in patch 4/6 > > The V1 patchset: > https://patchwork.kernel.org/project/linux-remoteproc/patch/20220111033333.403448-4-peng.fan@oss.nxp.com/ > > Peng Fan (7): > dt-bindings: remoteproc: imx_rproc: support i.MX8QXP > dt-bindings: remoteproc: imx_rproc: support i.MX8QM > remoteproc: imx_rproc: support attaching to i.MX8QXP M4 > remoteproc: imx_rproc: support kicking Mcore from Linux for i.MX8QXP > remoteproc: imx_rproc: support i.MX8QM > remoteproc: imx_rproc: request mbox channel later > remoteproc: imx_rproc: Enable attach recovery for i.MX8QM/QXP > > .../bindings/remoteproc/fsl,imx-rproc.yaml | 16 + > drivers/remoteproc/imx_rproc.c | 294 +++++++++++++++++- > 2 files changed, 304 insertions(+), 6 deletions(-) > > -- > 2.37.1 >