From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1E04C433F5 for ; Mon, 1 Nov 2021 15:32:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7DC4B60F3A for ; Mon, 1 Nov 2021 15:32:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232587AbhKAPfU (ORCPT ); Mon, 1 Nov 2021 11:35:20 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42894 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230261AbhKAPfR (ORCPT ); Mon, 1 Nov 2021 11:35:17 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3456C061714 for ; Mon, 1 Nov 2021 08:32:43 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id z20so65998673edc.13 for ; Mon, 01 Nov 2021 08:32:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CN8rQ1tRxeXIpx3jQunjqqrNjS826z1bdP3f36w4Lmc=; b=E3z1G6+rXmLBTcUCEqna/tuPLpo7fQbax/jJAq51voPIued0ebctyXesnEDJyedqe0 B3vApk1aqq1mW3FMTHaXpNrpeX63SmVWjLnv/ghtdm46WN0W0Fz/VVeVFtB6+N/WCIJ0 VMWpTqU10VHUp0Dtzgh/QRKVZzNJ6FrdKViIZe75HFsTGTo8dRvxkuLKaoVBJGFtttId IcFSbAWXtptga7Gia+JapGySXbmulnW1xxh0uzgpkwCTSdyB/Gb7vMkfdeJ4dKsQKR62 F6tXJs06vlMlvRqdnkvJtkLJwq8OqzEjSCwSeLJGD5xIaCIZMTAr9dGZL6ASKUivzo2z Zqiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CN8rQ1tRxeXIpx3jQunjqqrNjS826z1bdP3f36w4Lmc=; b=23aEafPUTagif4QdI6fGtR8wgCo5mBlOPwU3a1XsBHgfTv/4PoCW/tJuZFEBNx90ep Lk7mUj+cNsPpZ+VW0fd5kyYuuwsW7DrV543UzuXuOUf9y9KYgwmrMxUy4gtu11jsP+Zn c3cWbUJVoXzTMCDrqA84A4987FSKd5aQ1FESNME2lE/HmBN+B/belbxMNYAn8aT5rS6L X/6I/ca5uyWvSCRlin5bDE1CpYkq9oW4aNBxAYUCwX5RMC5KOvouFvnPivNABUGR9V6/ 5q7GRnix9DXVJ1dE4dIVVPT+NW4DooWdXsXlQDjbqrnD5FuYuT8U5sjifjLCaksWPqcz GBOg== X-Gm-Message-State: AOAM531U1rQV+d5tk8/8D1CMKxa4dWP556vkjXb1QvQl54MlBT76XXU/ 6BsfNO+rQ5iJzp8aKFa30pMdofOmzwBfPTRVL3TI0w== X-Google-Smtp-Source: ABdhPJxlap7LRxTrSRvjY8lTA/SiUFKR9WcJC/LnAtRi/RCXGvMgRMJKHeuKplgfc3q8qm6aH0J1juUwGiL/w/nuq6o= X-Received: by 2002:a17:906:9601:: with SMTP id s1mr38619975ejx.68.1635780762250; Mon, 01 Nov 2021 08:32:42 -0700 (PDT) MIME-Version: 1.0 References: <20211029113023.760421-1-arnd@kernel.org> <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> <20211101090143.GA27181@willie-the-truck> <20211101094045.GB27400@willie-the-truck> <55cc7816-cc7a-3161-71cc-0c969ec131a2@arm.com> In-Reply-To: From: Mathieu Poirier Date: Mon, 1 Nov 2021 09:32:29 -0600 Message-ID: Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap To: Greg Kroah-Hartman Cc: Suzuki K Poulose , Will Deacon , Catalin Marinas , Arnd Bergmann , Anshuman Khandual , Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel , Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 1 Nov 2021 at 05:13, Greg Kroah-Hartman wrote: > > On Mon, Nov 01, 2021 at 09:52:22AM +0000, Suzuki K Poulose wrote: > > On 01/11/2021 09:40, Will Deacon wrote: > > > On Mon, Nov 01, 2021 at 09:34:08AM +0000, Suzuki K Poulose wrote: > > > > On 01/11/2021 09:01, Will Deacon wrote: > > > > > On Fri, Oct 29, 2021 at 07:06:23PM +0100, Catalin Marinas wrote: > > > > > > On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote: > > > > > > > On 29/10/2021 12:30, Arnd Bergmann wrote: > > > > > > > > From: Arnd Bergmann > > > > > > > > > > > > > > > > It's now used in a coresight driver that can be a loadable module: > > > > > > > > > > > > > > > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > > > > > > > > > > > > > > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") > > > > > > > > > > > > > > Reviewed-by: Suzuki K Poulose > > > > > > > Tested-by: Suzuki K Poulose > > > > > > > > > > > > > > Will, Catalin, Mathieu, > > > > > > > > > > > > > > Do you have a preference on how this fix can be pulled in ? This may > > > > > > > be safe to go via coresight tree if it is not too late. Otherwise, > > > > > > > it could go via the arm64 tree. > > > > > > > > > > > > I think Will already closed/tagged the arm64 tree for the upcoming > > > > > > merging window, though he could take it as a fix afterwards. > > > > > > > > > > > > If it doesn't conflict with the arm64 for-next/core, it's fine by me to > > > > > > go through the coresight tree. > > > > > > > > > > > > > > Signed-off-by: Arnd Bergmann > > > > > > > > --- > > > > > > > > Not sure if we actually want this to be exported, this is my local > > > > > > > > workaround for the randconfig build bot. > > > > > > > > --- > > > > > > > > arch/arm64/kernel/cpufeature.c | 1 + > > > > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > > > > > > > index ecbdff795f5e..beccbcfa7391 100644 > > > > > > > > --- a/arch/arm64/kernel/cpufeature.c > > > > > > > > +++ b/arch/arm64/kernel/cpufeature.c > > > > > > > > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > > > > > > > return false; > > > > > > > > } > > > > > > > > +EXPORT_SYMBOL(this_cpu_has_cap); > > > > > > > > > > > > EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more > > > > > > specialised than cpus_have_const_cap(). > > > > > > > > > > > > With that: > > > > > > > > > > > > Acked-by: Catalin Marinas > > > > > > > > > > Yes, at this stage I think it's best for this to go via the Coresight tree. > > > > > So with the _GPL export: > > > > > > > > > > Acked-by: Will Deacon > > > > > > > > > > If that doesn't work for some reason, I can take it next week after the > > > > > initial arm64 queue has been merged. Please just let me know. > > > > > > > > As I understand correctly, this will now need to go via arm64 tree. The > > > > CoreSight tree changes are pulled into Greg's tree and the next it will > > > > happen is for the next release. Usually the fixes don't end up there > > > > during the -rc cycles. So, I believe it is better if this goes via > > > > arm64. > > > > > > Hmm, are you saying that Coresight drivers don't receive fixes outside of > > > the merge window? That sounds sub-optimal... > > > > Unfortunately thats how it works today. We should fix this. > > > > Mathieu, Greg, > > > > Do you have any thoughts on how to address this ? > > What? That's crazy, if there are bugfixes needed of course I would take > them during the -rc cycle, that is explicitly what it is there for! I have sent patches to the char-misc tree several times during -rc cycles. As Greg points out, proceeding otherwise would not make sense. > > It's up to the maintainer of the subsystem to send me the fixes to get > into the -final kernel release, I don't pick them up on my own unless > asked to by them. > I will send a pull request for this when I receive another patch with Catalin's annotation and collected RB tags. > thanks, > > greg k-h From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8ADE9C433EF for ; Mon, 1 Nov 2021 15:34:07 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 51A6960F58 for ; Mon, 1 Nov 2021 15:34:07 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 51A6960F58 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Kpn0JCBYMsBSQ0ttu5yJHNW36/vzRDPSRjQhlOP8UYY=; b=e3iS5roGJ8FS/R MnFlc8kyoIcKpvuBCcKw+TLD3pfcNF3DAvZTiyks2nYs7Fzu1/cLY0lVSyL5OlCd1+hpCGwDYTwk+ p2rdlgEo+za2gyD5bELjREbyioudu//crYVYSXClwmQJoGHAYCgfiGkDc4+XoOEhXK9JcllaMEEnV Y/8CukJR7dYo8VxmxFuJZF4Cv5ZNv31ZzRbwVpeZxI2p93MyDVCbvGb3ojDIs4jL6nhV352FRxv/j BehFTwyPPkHW8+r0htZAavtbPm1tCASr8ETKzSDn0KlxHFXQqnXw4V20EgCylr2MOofPginKdHIC8 OaCftAfolEx7j/YixJBw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhZIm-00GhIx-AE; Mon, 01 Nov 2021 15:32:48 +0000 Received: from mail-ed1-x52c.google.com ([2a00:1450:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mhZIi-00GhIW-T3 for linux-arm-kernel@lists.infradead.org; Mon, 01 Nov 2021 15:32:46 +0000 Received: by mail-ed1-x52c.google.com with SMTP id j21so42797849edt.11 for ; Mon, 01 Nov 2021 08:32:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CN8rQ1tRxeXIpx3jQunjqqrNjS826z1bdP3f36w4Lmc=; b=E3z1G6+rXmLBTcUCEqna/tuPLpo7fQbax/jJAq51voPIued0ebctyXesnEDJyedqe0 B3vApk1aqq1mW3FMTHaXpNrpeX63SmVWjLnv/ghtdm46WN0W0Fz/VVeVFtB6+N/WCIJ0 VMWpTqU10VHUp0Dtzgh/QRKVZzNJ6FrdKViIZe75HFsTGTo8dRvxkuLKaoVBJGFtttId IcFSbAWXtptga7Gia+JapGySXbmulnW1xxh0uzgpkwCTSdyB/Gb7vMkfdeJ4dKsQKR62 F6tXJs06vlMlvRqdnkvJtkLJwq8OqzEjSCwSeLJGD5xIaCIZMTAr9dGZL6ASKUivzo2z Zqiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CN8rQ1tRxeXIpx3jQunjqqrNjS826z1bdP3f36w4Lmc=; b=Cfn3d3JAFoSbrGZKH90ugjdw6eJD4cHgYnLZGzHLqueEP78UPkOaUU+4IHQuzJ1Rob aSQl83w7RuNZFp2kHkUwN3g5/FAZ+rLYcNybGq7a21WIChVSyIsv2h132zPALbO+DYQo AB3QvSGgqUSQrVUR8VmfKSSj0Ns9QlEEHhlhkSbwuSoiTQP357dleN1jtjjHi/dGyUn9 GFHclJqe51W8hrjgdLa09zEWQr2DRQd97m6Yp8Yd71JrM2xUajtT02tITMbCS8YTIXE6 UsGcyUDKPJHX2fO3ezWvyX2VQDGg95UDBivohKKnkKiC87USfF09+AGTF0N2E6dBmZTq n/VA== X-Gm-Message-State: AOAM533+M9cRCd86Z9qu7o3ZjCCRWMXlVKIxLfLz6gR+DWPNGy8Yab/P 4rtHpv4fB4t5lVC0HOJLD0BCrEGLTUzQZ3FXAxZyXg== X-Google-Smtp-Source: ABdhPJxlap7LRxTrSRvjY8lTA/SiUFKR9WcJC/LnAtRi/RCXGvMgRMJKHeuKplgfc3q8qm6aH0J1juUwGiL/w/nuq6o= X-Received: by 2002:a17:906:9601:: with SMTP id s1mr38619975ejx.68.1635780762250; Mon, 01 Nov 2021 08:32:42 -0700 (PDT) MIME-Version: 1.0 References: <20211029113023.760421-1-arnd@kernel.org> <9d4e09b4-47dc-ed3c-2b6d-e0d1a081e592@arm.com> <20211101090143.GA27181@willie-the-truck> <20211101094045.GB27400@willie-the-truck> <55cc7816-cc7a-3161-71cc-0c969ec131a2@arm.com> In-Reply-To: From: Mathieu Poirier Date: Mon, 1 Nov 2021 09:32:29 -0600 Message-ID: Subject: Re: [PATCH] [RFC] arm64: export this_cpu_has_cap To: Greg Kroah-Hartman Cc: Suzuki K Poulose , Will Deacon , Catalin Marinas , Arnd Bergmann , Anshuman Khandual , Arnd Bergmann , Marc Zyngier , Mark Rutland , David Brazdil , linux-arm-kernel , Linux Kernel Mailing List X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211101_083244_991701_3B56B11E X-CRM114-Status: GOOD ( 47.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 1 Nov 2021 at 05:13, Greg Kroah-Hartman wrote: > > On Mon, Nov 01, 2021 at 09:52:22AM +0000, Suzuki K Poulose wrote: > > On 01/11/2021 09:40, Will Deacon wrote: > > > On Mon, Nov 01, 2021 at 09:34:08AM +0000, Suzuki K Poulose wrote: > > > > On 01/11/2021 09:01, Will Deacon wrote: > > > > > On Fri, Oct 29, 2021 at 07:06:23PM +0100, Catalin Marinas wrote: > > > > > > On Fri, Oct 29, 2021 at 02:31:23PM +0100, Suzuki K Poulose wrote: > > > > > > > On 29/10/2021 12:30, Arnd Bergmann wrote: > > > > > > > > From: Arnd Bergmann > > > > > > > > > > > > > > > > It's now used in a coresight driver that can be a loadable module: > > > > > > > > > > > > > > > > ERROR: modpost: "this_cpu_has_cap" [drivers/hwtracing/coresight/coresight-trbe.ko] undefined! > > > > > > > > > > > > > > > > Fixes: 8a1065127d95 ("coresight: trbe: Add infrastructure for Errata handling") > > > > > > > > > > > > > > Reviewed-by: Suzuki K Poulose > > > > > > > Tested-by: Suzuki K Poulose > > > > > > > > > > > > > > Will, Catalin, Mathieu, > > > > > > > > > > > > > > Do you have a preference on how this fix can be pulled in ? This may > > > > > > > be safe to go via coresight tree if it is not too late. Otherwise, > > > > > > > it could go via the arm64 tree. > > > > > > > > > > > > I think Will already closed/tagged the arm64 tree for the upcoming > > > > > > merging window, though he could take it as a fix afterwards. > > > > > > > > > > > > If it doesn't conflict with the arm64 for-next/core, it's fine by me to > > > > > > go through the coresight tree. > > > > > > > > > > > > > > Signed-off-by: Arnd Bergmann > > > > > > > > --- > > > > > > > > Not sure if we actually want this to be exported, this is my local > > > > > > > > workaround for the randconfig build bot. > > > > > > > > --- > > > > > > > > arch/arm64/kernel/cpufeature.c | 1 + > > > > > > > > 1 file changed, 1 insertion(+) > > > > > > > > > > > > > > > > diff --git a/arch/arm64/kernel/cpufeature.c b/arch/arm64/kernel/cpufeature.c > > > > > > > > index ecbdff795f5e..beccbcfa7391 100644 > > > > > > > > --- a/arch/arm64/kernel/cpufeature.c > > > > > > > > +++ b/arch/arm64/kernel/cpufeature.c > > > > > > > > @@ -2864,6 +2864,7 @@ bool this_cpu_has_cap(unsigned int n) > > > > > > > > return false; > > > > > > > > } > > > > > > > > +EXPORT_SYMBOL(this_cpu_has_cap); > > > > > > > > > > > > EXPORT_SYMBOL_GPL? I think this_cpu_has_cap() is a bit more more > > > > > > specialised than cpus_have_const_cap(). > > > > > > > > > > > > With that: > > > > > > > > > > > > Acked-by: Catalin Marinas > > > > > > > > > > Yes, at this stage I think it's best for this to go via the Coresight tree. > > > > > So with the _GPL export: > > > > > > > > > > Acked-by: Will Deacon > > > > > > > > > > If that doesn't work for some reason, I can take it next week after the > > > > > initial arm64 queue has been merged. Please just let me know. > > > > > > > > As I understand correctly, this will now need to go via arm64 tree. The > > > > CoreSight tree changes are pulled into Greg's tree and the next it will > > > > happen is for the next release. Usually the fixes don't end up there > > > > during the -rc cycles. So, I believe it is better if this goes via > > > > arm64. > > > > > > Hmm, are you saying that Coresight drivers don't receive fixes outside of > > > the merge window? That sounds sub-optimal... > > > > Unfortunately thats how it works today. We should fix this. > > > > Mathieu, Greg, > > > > Do you have any thoughts on how to address this ? > > What? That's crazy, if there are bugfixes needed of course I would take > them during the -rc cycle, that is explicitly what it is there for! I have sent patches to the char-misc tree several times during -rc cycles. As Greg points out, proceeding otherwise would not make sense. > > It's up to the maintainer of the subsystem to send me the fixes to get > into the -final kernel release, I don't pick them up on my own unless > asked to by them. > I will send a pull request for this when I receive another patch with Catalin's annotation and collected RB tags. > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel