From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932838AbbLWQqe (ORCPT <rfc822;w@1wt.eu>);
	Wed, 23 Dec 2015 11:46:34 -0500
Received: from mail-ob0-f181.google.com ([209.85.214.181]:34667 "EHLO
	mail-ob0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756136AbbLWQq3 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Wed, 23 Dec 2015 11:46:29 -0500
MIME-Version: 1.0
In-Reply-To: <20151219172705.GC2437@debian>
References: <1450472361-426-1-git-send-email-mathieu.poirier@linaro.org>
	<1450472361-426-25-git-send-email-mathieu.poirier@linaro.org>
	<20151219172705.GC2437@debian>
Date: Wed, 23 Dec 2015 09:46:29 -0700
Message-ID: <CANLsYkyZkb4=DwFGpPCsnny1KKiHd0reQSJxFniqerdB3P0shg@mail.gmail.com>
Subject: Re: [PATCH V7 24/24] perf tools: adding coresight etm PMU record capabilities
From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Rabin Vincent <rabin@rab.in>
Cc: Greg KH <gregkh@linuxfoundation.org>,
        Alexander Shishkin <alexander.shishkin@linux.intel.com>,
        Chunyan Zhang <zhang.chunyan@linaro.org>,
        Mike Leach <mike.leach@arm.com>, "Jeremiassen, Tor" <tor@ti.com>,
        Al Grant <al.grant@arm.com>, fainelli@broadcom.com,
        "linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
        linux-doc@vger.kernel.org,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 19 December 2015 at 10:27, Rabin Vincent <rabin@rab.in> wrote:
> On Fri, Dec 18, 2015 at 01:59:20PM -0700, Mathieu Poirier wrote:
>> +struct auxtrace_record
>> +*auxtrace_record__init(struct perf_evlist *evlist, int *err)
>> +{
>> +     struct perf_pmu *cs_etm_pmu;
>> +     struct perf_evsel *evsel;
>> +     bool found_etm = false;
>> +
>> +     cs_etm_pmu = perf_pmu__find(CORESIGHT_ETM_PMU_NAME);
>> +
>> +      if (evlist) {
>> +             evlist__for_each(evlist, evsel) {
>> +                     if (cs_etm_pmu &&
>> +                         evsel->attr.type == cs_etm_pmu->type)
>> +                             found_etm = true;
>> +             }
>> +     }
>> +
>> +     if (found_etm)
>> +             return cs_etm_record_init(err);
>> +
>> +     *err = -EINVAL;
>
> This should not set an error code when found_etm is false.  Otherwise
> any attempt to uses perf record without a cs_etm event enabled errors
> out.

Yes, you're right.

Many thanks for the thorough review,
Mathieu

>
>> +     return NULL;
>> +}

From mboxrd@z Thu Jan  1 00:00:00 1970
From: mathieu.poirier@linaro.org (Mathieu Poirier)
Date: Wed, 23 Dec 2015 09:46:29 -0700
Subject: [PATCH V7 24/24] perf tools: adding coresight etm PMU record
 capabilities
In-Reply-To: <20151219172705.GC2437@debian>
References: <1450472361-426-1-git-send-email-mathieu.poirier@linaro.org>
 <1450472361-426-25-git-send-email-mathieu.poirier@linaro.org>
 <20151219172705.GC2437@debian>
Message-ID: <CANLsYkyZkb4=DwFGpPCsnny1KKiHd0reQSJxFniqerdB3P0shg@mail.gmail.com>
To: linux-arm-kernel@lists.infradead.org
List-Id: linux-arm-kernel.lists.infradead.org

On 19 December 2015 at 10:27, Rabin Vincent <rabin@rab.in> wrote:
> On Fri, Dec 18, 2015 at 01:59:20PM -0700, Mathieu Poirier wrote:
>> +struct auxtrace_record
>> +*auxtrace_record__init(struct perf_evlist *evlist, int *err)
>> +{
>> +     struct perf_pmu *cs_etm_pmu;
>> +     struct perf_evsel *evsel;
>> +     bool found_etm = false;
>> +
>> +     cs_etm_pmu = perf_pmu__find(CORESIGHT_ETM_PMU_NAME);
>> +
>> +      if (evlist) {
>> +             evlist__for_each(evlist, evsel) {
>> +                     if (cs_etm_pmu &&
>> +                         evsel->attr.type == cs_etm_pmu->type)
>> +                             found_etm = true;
>> +             }
>> +     }
>> +
>> +     if (found_etm)
>> +             return cs_etm_record_init(err);
>> +
>> +     *err = -EINVAL;
>
> This should not set an error code when found_etm is false.  Otherwise
> any attempt to uses perf record without a cs_etm event enabled errors
> out.

Yes, you're right.

Many thanks for the thorough review,
Mathieu

>
>> +     return NULL;
>> +}