From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 308B4C433FE for ; Fri, 4 Dec 2020 17:52:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E22CF22AAD for ; Fri, 4 Dec 2020 17:52:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387627AbgLDRwl (ORCPT ); Fri, 4 Dec 2020 12:52:41 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40740 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387580AbgLDRwl (ORCPT ); Fri, 4 Dec 2020 12:52:41 -0500 Received: from mail-io1-xd44.google.com (mail-io1-xd44.google.com [IPv6:2607:f8b0:4864:20::d44]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0A159C061A4F for ; Fri, 4 Dec 2020 09:52:01 -0800 (PST) Received: by mail-io1-xd44.google.com with SMTP id y5so6618726iow.5 for ; Fri, 04 Dec 2020 09:52:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=7UAVaDXI+I5u9V+JJpY6eb9l7dnPddi/+P+0R/fGgMY=; b=AjlKtvRF/fi9F8lPROkXKg51IjrxmrrtIDYi5sz1HKdVda2FMTzJCtoidPFpsLedvF togG9/KWphvdHTDOGeIlz1Mx/vJGAxIMxBYRbs+xMZUl0vNscohNS6Smpy6YBV2JJmW6 eS1H66CEcz07rLjMmevcT0oN+JVCmOdsgyWeSKXJaQwy/rcTKn+ELv8LmofPqSbt7wdu 2sJ1zpBA6MsuOEKBZDoU+YFUos6p4Et0XrSg9r/GqGE4JKei4NtQP0CiJ3DvUdjdMsDK 0u8Hwkho8bFJVZHqeqghFZv6x60COdfFVYG7TIlNFO5+fQr4if81wHxlKP7655rP3CGO K60g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=7UAVaDXI+I5u9V+JJpY6eb9l7dnPddi/+P+0R/fGgMY=; b=fofDsYQ1C1ef2ecQWCH9ma2ZNqnjYEZQsywLub+0axb3Vrd0LTnzFBv+mjS9npLKH2 qdplS4T0fe8PZ/9d2/34lwKE2P4gRSH6Zi+H6k0I+zzsg/ykSW+EQMFbHrGwgAL+UsVO 3ay9QjSno0IYXxR+o0tOeDWjjG8DVuYWZAz+6DU9mV76xQXEJvh/ajgS/N2cFK31DBXb HvJIQryFKzZIDEm/Kpat70a/cEZ7WHmC6x+aYBiGrQyjROyzrnVxxAjDPdAcMWTiz1WU xTURYksPliSTFwEpiNjwdPumGKh+E1ThoVRln1WMDmK0Lvuo4w7xH3iFIEbUrYDKHalP DxEg== X-Gm-Message-State: AOAM531akjKC1Cfhwnyxo7Ljprp2HGFxroa8QHwyOtGArrM65b3gzKon exOl5WepbBj8EHczLm2ajSR/4OGmJzGkZxy+o7zqrA== X-Google-Smtp-Source: ABdhPJyI3pTXHexcHgBPq8OSBX6ioRMzSNf+GCrlVplPEh/3zrvNYahNpsh1ZldQNo3MU+KoMgSUBVxGggJrmOmyB1s= X-Received: by 2002:a5e:db4b:: with SMTP id r11mr7636498iop.148.1607104320277; Fri, 04 Dec 2020 09:52:00 -0800 (PST) MIME-Version: 1.0 References: <20201120214245.172963-1-mathieu.poirier@linaro.org> <20201123160610.GA19108@ubuntu> <20201202110555.GA65230@ubuntu> <20201202203954.GC1282360@xps15> <20201203204218.GA13001@ubuntu> In-Reply-To: <20201203204218.GA13001@ubuntu> From: Mathieu Poirier Date: Fri, 4 Dec 2020 10:51:49 -0700 Message-ID: Subject: Re: [PATCH v7 0/8] rpmsg: Make RPMSG name service modular To: Guennadi Liakhovetski Cc: Kishon Vijay Abraham I , Ohad Ben-Cohen , Bjorn Andersson , Arnaud POULIQUEN , linux-remoteproc , Linux Kernel Mailing List , Jason Wang , "Michael S. Tsirkin" , Vincent Whitchurch , virtualization@lists.linux-foundation.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org I am adding Vincent Whitchurch and the virtualization mailing list... On Thu, 3 Dec 2020 at 13:42, Guennadi Liakhovetski wrote: > > (adding vhost maintainers and the author of [1]) > > Hi, > > I'm working on an Audio DSP virtualisation solution [2] and the next > step in its upstreaming should be an RPMsg vhost implementation, based > on [3], which contains a simple addition to the current library-style > vhost API. Later in [1] a different approach has been presented, > converting the vhost framework to a proper bus-type and device driver. > Therefore my questions: > > 1. if the latter approach is prefered, should we expect follow up > versions of [1] and their upstreaming? > 2. judging by the size and complexity of [1] would it maybe be > preferable to first extract a minimum patch set just to add vhost > rpmsg? Looking at the patch set it should be doable and not too > difficult? Kishon, would it be something you could submit? To me that is the best approach. It might be best for you to do the work and credit Kishon where needed. > 3. or would it be preferable to keep vhost in its present form, use > [3] for rpmsg support and re-implement [1] based on a different > vhost / vringh approach? > > Thanks > Guennadi > > [1] https://www.spinics.net/lists/kvm/msg219632.html > [2] https://mailman.alsa-project.org/pipermail/sound-open-firmware/2020-April/003766.html > [3] https://www.spinics.net/lists/linux-virtualization/msg43359.html > > On Wed, Dec 02, 2020 at 01:39:54PM -0700, Mathieu Poirier wrote: > > Good day, > > > > On Wed, Dec 02, 2020 at 12:05:55PM +0100, Guennadi Liakhovetski wrote: > > > Hi Mathieu, > > > > > > I'd like to resume reviewing and begin upstreaming of the next steps of > > > my Audio DSP Virtualisation work, based on this your patch set. How > > > > I'm all for it too. > > > > > confident are we that it's going to be upstreamed in its present form? > > > What's the plan to push it to "next?" > > > > > > > I thought we were pretty unanimous that something like what Kishon did was the > > way to go. > > > > > Thanks > > > Guennadi > > > > > > On Mon, Nov 23, 2020 at 05:06:10PM +0100, Guennadi Liakhovetski wrote: > > > > Hi Mathieu, > > > > > > > > Thanks for bringing all the stuff together and for polishing it! > > > > > > > > For the entire series: > > > > > > > > Tested-by: Guennadi Liakhovetski > > > > Reviewed-by: Guennadi Liakhovetski > > > > > > > > Thanks > > > > Guennadi > > > > > > > > On Fri, Nov 20, 2020 at 02:42:37PM -0700, Mathieu Poirier wrote: > > > > > This revision addresses comments received from the previous revision, > > > > > i.e V6. Please see details below. > > > > > > > > > > It starts by making the RPMSG protocol transport agnostic by > > > > > moving the headers it uses to generic types and using those in the > > > > > current implementation. From there it re-uses the work that Arnaud > > > > > published[1] to make the name service modular. > > > > > > > > > > Tested on stm32mp157 with the RPMSG client sample application. Applies > > > > > cleanly on rpmsg-next. > > > > > > > > > > Thanks, > > > > > Mathieu > > > > > > > > > > [1]. https://patchwork.kernel.org/project/linux-remoteproc/list/?series=338335 > > > > > > > > > > ------- > > > > > New for V7: > > > > > - Fixed error path in rpmsg_probe() as reported by Guennadi > > > > > > > > > > Arnaud Pouliquen (4): > > > > > rpmsg: virtio: Rename rpmsg_create_channel > > > > > rpmsg: core: Add channel creation internal API > > > > > rpmsg: virtio: Add rpmsg channel device ops > > > > > rpmsg: Turn name service into a stand alone driver > > > > > > > > > > Mathieu Poirier (4): > > > > > rpmsg: Introduce __rpmsg{16|32|64} types > > > > > rpmsg: virtio: Move from virtio to rpmsg byte conversion > > > > > rpmsg: Move structure rpmsg_ns_msg to header file > > > > > rpmsg: Make rpmsg_{register|unregister}_device() public > > > > > > > > > > drivers/rpmsg/Kconfig | 9 ++ > > > > > drivers/rpmsg/Makefile | 1 + > > > > > drivers/rpmsg/rpmsg_core.c | 44 ++++++++ > > > > > drivers/rpmsg/rpmsg_internal.h | 14 ++- > > > > > drivers/rpmsg/rpmsg_ns.c | 126 +++++++++++++++++++++ > > > > > drivers/rpmsg/virtio_rpmsg_bus.c | 186 +++++++++++-------------------- > > > > > include/linux/rpmsg.h | 63 ++++++++++- > > > > > include/linux/rpmsg/byteorder.h | 67 +++++++++++ > > > > > include/linux/rpmsg/ns.h | 45 ++++++++ > > > > > include/uapi/linux/rpmsg_types.h | 11 ++ > > > > > 10 files changed, 439 insertions(+), 127 deletions(-) > > > > > create mode 100644 drivers/rpmsg/rpmsg_ns.c > > > > > create mode 100644 include/linux/rpmsg/byteorder.h > > > > > create mode 100644 include/linux/rpmsg/ns.h > > > > > create mode 100644 include/uapi/linux/rpmsg_types.h > > > > > > > > > > -- > > > > > 2.25.1 > > > > >