From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58C65C433FE for ; Thu, 29 Sep 2022 23:21:18 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229691AbiI2XVP (ORCPT ); Thu, 29 Sep 2022 19:21:15 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229636AbiI2XVM (ORCPT ); Thu, 29 Sep 2022 19:21:12 -0400 Received: from mail-ej1-x62c.google.com (mail-ej1-x62c.google.com [IPv6:2a00:1450:4864:20::62c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19B4F132D4D for ; Thu, 29 Sep 2022 16:21:10 -0700 (PDT) Received: by mail-ej1-x62c.google.com with SMTP id r18so5737523eja.11 for ; Thu, 29 Sep 2022 16:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=1Lm6VXmur+/4daoRRpAM76RIHFiAfUBxz6IdDWHuOY4=; b=opHQOs3rn9EzBtb48ioD7yF3uif3JGhopAZuZ0xk3StZfZoWRuXDIFEccK1DuKuycm CIj+XSdBVrmYkE/vF5GZIQjvVJS9zjADbj0bSCaBow/jJl4AG1RcnZ0YaO5nq6y2zTPu WjJAJPc6YiyAp9SAtma5yabZkfBxCoVt3BLnR5HSULHrpYa8qoK3fB9M4rF8gPFECRe8 7jWmcgu7VZipwYA5GHytA3kKji4AklimVGYrbMvD3kqurfh0lwEq8xI2NaWv+I6go+Xq cxMpv8H6bD5u4mRCQMgmxG8wZx4U/mYlfrsLojDKokJL4/Djrx0ckT6iB184vZdoxcSB kIVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=1Lm6VXmur+/4daoRRpAM76RIHFiAfUBxz6IdDWHuOY4=; b=08zJ/QKc8aWwfuMDFIiXfginx/O++CgAlx9bQ/qtfKGgTQ9ZqeyeNIF2eiLc4ARbkN 1+P08B/fv3yxT3clPTCKER0V/U/CkFMxl+YHkW155E6g6p04Xo5enWSLfxdXxiT24TJ9 QAdvWurwQQXIJLt64ZbJPT2zRtDdrSHpXrSqQvUW7522DK3+/LzPJKK8azbGt9Y8AO3h EbYx4MVllPXB6lU7i3im/rbrklKxDb7dh63zz7IHUPKgy+YFBwFCEQCfX/rRDmj0ODWF pDpmhRn5Yu5ZLiYVcqYddAqLC8bG5HOZpPbYdJg155tTVSfTWXF5MGDp6AYDGa+KVJhZ zZIg== X-Gm-Message-State: ACrzQf18f8Y1htnHaN6f4Oze4vrJwbx+Yz9P2FuaCw2/mknarrPXRhpv SHF0OtOMX4GsP64WydK7FoZzWQgd1ujb5856gq5lXQ== X-Google-Smtp-Source: AMsMyM7ou8R3GEJ4wdix9XuO7815aqFuta7V8VxGDSDUNoMGXaeSv+fUTi446omoon3NurqNc7oupYDZ18/IS4jZtmY= X-Received: by 2002:a17:907:e93:b0:782:da6:8c47 with SMTP id ho19-20020a1709070e9300b007820da68c47mr4501522ejc.741.1664493668489; Thu, 29 Sep 2022 16:21:08 -0700 (PDT) MIME-Version: 1.0 References: <20220708013955.2340449-1-tanmay.shah@amd.com> <20220708013955.2340449-7-tanmay.shah@amd.com> <20220901202517.GB626605@p14s> <20220929172200.GB3107608@p14s> In-Reply-To: From: Mathieu Poirier Date: Thu, 29 Sep 2022 17:20:56 -0600 Message-ID: Subject: Re: [PATCH v9 6/6] drivers: remoteproc: Add Xilinx r5 remoteproc driver To: Tanmay Shah Cc: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com, ben.levinsky@xilinx.com, tanmay.shah@xilinx.com, michal.simek@amd.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Thu, 29 Sept 2022 at 13:28, Tanmay Shah wrote: > > Thanks Mathieu. > > Also, I see that last few revisions I have changed driver a lot based on > comments, but documentation in driver is not in sync. > > I know we agreed initially, that I will address changes _only_ commented > in previous revision. However, in next revision I would like > > to fix documentation all over the driver along with your comments. I > hope it's fine and I wanted to give you heads up so we stay on same page. I'm fine with that. Thanks for the heads up. > > Thanks, > > Tanmay > > On 9/29/22 10:22 AM, Mathieu Poirier wrote: > > On Mon, Sep 26, 2022 at 03:02:22PM -0700, Tanmay Shah wrote: > >> On 9/1/22 1:25 PM, Mathieu Poirier wrote: > >>> On Thu, Jul 07, 2022 at 06:39:55PM -0700, Tanmay Shah wrote: > >> [ ... ] > >>>> --- /dev/null > >>>> +++ b/drivers/remoteproc/xlnx_r5_remoteproc.c > >>>> @@ -0,0 +1,1055 @@ > >>>> +// SPDX-License-Identifier: GPL-2.0 > >> Hi Mathieu, > >> > >> I tried to fix SPDX-License-Identifier to GPL (same as MODULE_LICENSE > >> below), However checkpatch.pl reports this as following warning: > >> > >> "WARNING: 'SPDX-License-Identifier: GPL' is not supported in LICENSES/..." > >> > >> I see that GPL-1.0 is under LICENSE/deprecated directory. > >> > >>>> +/* > >>>> + * ZynqMP R5 Remote Processor driver > >>>> + * > >>>> + */ > >>>> + > >>>> +#include > >> [ ... ] > >> > >>>> +MODULE_DEVICE_TABLE(of, zynqmp_r5_remoteproc_match); > >>>> + > >>>> +static struct platform_driver zynqmp_r5_remoteproc_driver = { > >>>> + .probe = zynqmp_r5_remoteproc_probe, > >>>> + .driver = { > >>>> + .name = "zynqmp_r5_remoteproc", > >>>> + .of_match_table = zynqmp_r5_remoteproc_match, > >>>> + }, > >>>> +}; > >>>> +module_platform_driver(zynqmp_r5_remoteproc_driver); > >>>> + > >>>> +MODULE_DESCRIPTION("Xilinx R5F remote processor driver"); > >>>> +MODULE_AUTHOR("Xilinx Inc."); > >>>> +MODULE_LICENSE("GPL"); > >>> There is a discrepency between the GPL-2.0 in the SPDS identifier and the above. > >> Also, changing to MODULE_LICENSE("GPL v2") gives following warning: > >> > >> WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure > >> the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") > >> #1115: FILE: drivers/remoteproc/xlnx_r5_remoteproc.c:1034: > >> +MODULE_LICENSE("GPL v2"); > >> > >> So, It looks like SPDX-License-Identifier should be GPL-2.0-only and > >> MODULE_LICENSE should be change to "GPL". > > Commit bf7fbeeae6db is an interesting read - thanks for pointing it out. > > > >> It this ok? Any other suggestions ? > > What you have looks good, in that regard there is no need to change anything > > from your patch. > > > >> Thanks, > >> > >> Tanmay > >> > >>> More comments tomorrow or Tuesday. > >>> > >>> Thanks, > >>> Mathieu > >>> > >>>> -- > >>>> 2.25.1 > >>>> From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 631B3C433F5 for ; Thu, 29 Sep 2022 23:22:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=5GicM4vy0+Q2XvkQr6OCujQdyFM38oQoPs5eETF9Bp0=; b=jSuvwK9KJNok5O Yz3WbcEfFZQEDos0xqZS3Q5KlWxuq8ps6hm9x4cEnVY67w2pk+yMFTYgpCq82Dywls9+qxwxk86B9 kc0pVeOtnuDT4MQVjsgGoHauOl6uIYa/zWQIpHvxWd7VKOyJeqxbhMs4Fdf53wy4Z7GsHhxXqJrI9 uWIVeZImftrYCoE2SpH7NFwtSCBswkIhR4+r0MUfPUs9UfD6yv3MKXU0bQb7QvLWx7ERo1cXtlZNW aG7SrdgXXUNvxAHHXdlqTm/KOJ9gF8TQiqk+/5Vbec+hTYj3shphKT4Ds62F+gE5WddZEAWH3v83m Vk+R9Vty6HxEv5GaKUCw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oe2qE-005udF-Qu; Thu, 29 Sep 2022 23:21:18 +0000 Received: from mail-ej1-x633.google.com ([2a00:1450:4864:20::633]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oe2q6-005ua4-DU for linux-arm-kernel@lists.infradead.org; Thu, 29 Sep 2022 23:21:12 +0000 Received: by mail-ej1-x633.google.com with SMTP id hy2so5749391ejc.8 for ; Thu, 29 Sep 2022 16:21:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date; bh=1Lm6VXmur+/4daoRRpAM76RIHFiAfUBxz6IdDWHuOY4=; b=opHQOs3rn9EzBtb48ioD7yF3uif3JGhopAZuZ0xk3StZfZoWRuXDIFEccK1DuKuycm CIj+XSdBVrmYkE/vF5GZIQjvVJS9zjADbj0bSCaBow/jJl4AG1RcnZ0YaO5nq6y2zTPu WjJAJPc6YiyAp9SAtma5yabZkfBxCoVt3BLnR5HSULHrpYa8qoK3fB9M4rF8gPFECRe8 7jWmcgu7VZipwYA5GHytA3kKji4AklimVGYrbMvD3kqurfh0lwEq8xI2NaWv+I6go+Xq cxMpv8H6bD5u4mRCQMgmxG8wZx4U/mYlfrsLojDKokJL4/Djrx0ckT6iB184vZdoxcSB kIVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date; bh=1Lm6VXmur+/4daoRRpAM76RIHFiAfUBxz6IdDWHuOY4=; b=u1ItTC4fAeBMGlO/VaYCBzbLeC88k8Nr606l4IxNfUT6m2BmSSdNPPQRTwIK1uNUcq DoWZtDrrQ4j+7lYotXjhXZxmWuo7yHkSmy/2Uq3fTDORUZ4vGNn1hsNiaGaGUKtplLEI sj8lUpr6auZIOlVvBvKtpUfhtuzkbTa0QFWRO8oNwbdcinSdzyL44Oo6mbBrxM4Q46u5 fsijuStvruaLQ5gUZZmJ4d34tj7KTjQo9rjvKUHXLD2vpjZxUKq9D+onkEG8agQCMUk/ kVy3VENYGf10iadz6a1HOIlE2sqaT1vNjht5cYtgPnCM2x75wr4HgdNbI1d3QvdvWN/F aEaQ== X-Gm-Message-State: ACrzQf0AGb4KF7fBTXo9E2/1R3QfWVQTLyqckjz8BcUHJzcOyf57p5St Rdtr5lJLLtLcKnEjAhRcU21NjtU+sENujgXqCqRRKA== X-Google-Smtp-Source: AMsMyM7ou8R3GEJ4wdix9XuO7815aqFuta7V8VxGDSDUNoMGXaeSv+fUTi446omoon3NurqNc7oupYDZ18/IS4jZtmY= X-Received: by 2002:a17:907:e93:b0:782:da6:8c47 with SMTP id ho19-20020a1709070e9300b007820da68c47mr4501522ejc.741.1664493668489; Thu, 29 Sep 2022 16:21:08 -0700 (PDT) MIME-Version: 1.0 References: <20220708013955.2340449-1-tanmay.shah@amd.com> <20220708013955.2340449-7-tanmay.shah@amd.com> <20220901202517.GB626605@p14s> <20220929172200.GB3107608@p14s> In-Reply-To: From: Mathieu Poirier Date: Thu, 29 Sep 2022 17:20:56 -0600 Message-ID: Subject: Re: [PATCH v9 6/6] drivers: remoteproc: Add Xilinx r5 remoteproc driver To: Tanmay Shah Cc: andersson@kernel.org, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, michal.simek@xilinx.com, ben.levinsky@xilinx.com, tanmay.shah@xilinx.com, michal.simek@amd.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220929_162110_496756_932C6B72 X-CRM114-Status: GOOD ( 31.97 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 29 Sept 2022 at 13:28, Tanmay Shah wrote: > > Thanks Mathieu. > > Also, I see that last few revisions I have changed driver a lot based on > comments, but documentation in driver is not in sync. > > I know we agreed initially, that I will address changes _only_ commented > in previous revision. However, in next revision I would like > > to fix documentation all over the driver along with your comments. I > hope it's fine and I wanted to give you heads up so we stay on same page. I'm fine with that. Thanks for the heads up. > > Thanks, > > Tanmay > > On 9/29/22 10:22 AM, Mathieu Poirier wrote: > > On Mon, Sep 26, 2022 at 03:02:22PM -0700, Tanmay Shah wrote: > >> On 9/1/22 1:25 PM, Mathieu Poirier wrote: > >>> On Thu, Jul 07, 2022 at 06:39:55PM -0700, Tanmay Shah wrote: > >> [ ... ] > >>>> --- /dev/null > >>>> +++ b/drivers/remoteproc/xlnx_r5_remoteproc.c > >>>> @@ -0,0 +1,1055 @@ > >>>> +// SPDX-License-Identifier: GPL-2.0 > >> Hi Mathieu, > >> > >> I tried to fix SPDX-License-Identifier to GPL (same as MODULE_LICENSE > >> below), However checkpatch.pl reports this as following warning: > >> > >> "WARNING: 'SPDX-License-Identifier: GPL' is not supported in LICENSES/..." > >> > >> I see that GPL-1.0 is under LICENSE/deprecated directory. > >> > >>>> +/* > >>>> + * ZynqMP R5 Remote Processor driver > >>>> + * > >>>> + */ > >>>> + > >>>> +#include > >> [ ... ] > >> > >>>> +MODULE_DEVICE_TABLE(of, zynqmp_r5_remoteproc_match); > >>>> + > >>>> +static struct platform_driver zynqmp_r5_remoteproc_driver = { > >>>> + .probe = zynqmp_r5_remoteproc_probe, > >>>> + .driver = { > >>>> + .name = "zynqmp_r5_remoteproc", > >>>> + .of_match_table = zynqmp_r5_remoteproc_match, > >>>> + }, > >>>> +}; > >>>> +module_platform_driver(zynqmp_r5_remoteproc_driver); > >>>> + > >>>> +MODULE_DESCRIPTION("Xilinx R5F remote processor driver"); > >>>> +MODULE_AUTHOR("Xilinx Inc."); > >>>> +MODULE_LICENSE("GPL"); > >>> There is a discrepency between the GPL-2.0 in the SPDS identifier and the above. > >> Also, changing to MODULE_LICENSE("GPL v2") gives following warning: > >> > >> WARNING: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure > >> the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity") > >> #1115: FILE: drivers/remoteproc/xlnx_r5_remoteproc.c:1034: > >> +MODULE_LICENSE("GPL v2"); > >> > >> So, It looks like SPDX-License-Identifier should be GPL-2.0-only and > >> MODULE_LICENSE should be change to "GPL". > > Commit bf7fbeeae6db is an interesting read - thanks for pointing it out. > > > >> It this ok? Any other suggestions ? > > What you have looks good, in that regard there is no need to change anything > > from your patch. > > > >> Thanks, > >> > >> Tanmay > >> > >>> More comments tomorrow or Tuesday. > >>> > >>> Thanks, > >>> Mathieu > >>> > >>>> -- > >>>> 2.25.1 > >>>> _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel