From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 37FADCCA47B for ; Tue, 5 Jul 2022 15:10:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229501AbiGEPKF (ORCPT ); Tue, 5 Jul 2022 11:10:05 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35980 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231634AbiGEPJs (ORCPT ); Tue, 5 Jul 2022 11:09:48 -0400 Received: from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com [IPv6:2a00:1450:4864:20::32d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AD5DC165A7 for ; Tue, 5 Jul 2022 08:06:56 -0700 (PDT) Received: by mail-wm1-x32d.google.com with SMTP id o16-20020a05600c379000b003a02eaea815so8039246wmr.0 for ; Tue, 05 Jul 2022 08:06:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=+cVXdg+Brnle8yemDKHWIkEdNxNp1s8TSLsVgVGe5J0=; b=MGwCh4yeqqLnhT0WMeoMr6CScRSYX/1HhkHLkHd4QnnDjSiVs6v9atM7MaOH9RGZDK dGO7qUntVI039HvOKrW3QKVdjI2CczNLcXdb7Dt1Ub7vmntUW/GmQihHPISmn7NdyW6x Oz3bmlZUkboe9bpM7bjhv3VgCAhihHMi8oG80QjJ8o+3hxS3yPiy3Q0+fWBsjDHSC4NT 8Fmugcq3HKmqosRHKeCgvK/GzuEf+g62jHkWPXUR0XfqbUFTtkyOv51QXZZEcXaYblgq mTfli3sCq2GSvf3Tlj6JJp/NqJoNlsmSYIDI1XPGIDLvzIbbY6BYNAK6jXh5Tuj2jQsn 0f8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=+cVXdg+Brnle8yemDKHWIkEdNxNp1s8TSLsVgVGe5J0=; b=pVT5jLpmmBF4oQd+dQBrNgYuFWIYxQCVtEkOYP4i5Pr+65/j3U1236rOhw0KLxRF4z nBn07MXGLVIWTbeKWow5x0YpqDJcBrVrpKAYJOy2iFJh0APGwqH7Q9Kw8L36dKwTv2nJ cDZGOZ6Mjq0uLMuEZ5sQZLoLGyHSXmLwQNeqJ+483UbITKcNUNwhAxIWbnV+tZyib8EE BVd2LR/ZVbO1NBWisMixREfX/R7V4xGjAQinV76Egl8E/KPE6rbgoUUiDET0Lakbm+sz KJlmNmcENKszXVBRgCeYmMA3ZZoK+AmyV80mi2TtdkoLSV5MOAqPE+w29TH0YbfmHfO8 vY5A== X-Gm-Message-State: AJIora9OLEDpqnqshyOqa7lF9PkU/yE6XZjSgeAAXaYX+bo27spbN9xh XzNAGP9uwHt/uEqjM0erS4IrByXvjWVAHy8/+4/+mA== X-Google-Smtp-Source: AGRyM1sPaHkA/oz0kbKM+58TCz8Bc3vtUDjTnCx3JRdROJ2gHJtU1pj3EzwdjI0I3EXWoLbaZGRMWaQPNjnOe1p6KLo= X-Received: by 2002:a05:600c:4e46:b0:3a0:4d54:f206 with SMTP id e6-20020a05600c4e4600b003a04d54f206mr40771971wmq.151.1657033615052; Tue, 05 Jul 2022 08:06:55 -0700 (PDT) MIME-Version: 1.0 References: <20220519073330.7187-1-krzysztof.kozlowski@linaro.org> <640d2a3d-4c38-b921-45c1-048c255b5a9d@linaro.org> <57aca768-18f4-6b79-9490-c57123d71232@linaro.org> In-Reply-To: <57aca768-18f4-6b79-9490-c57123d71232@linaro.org> From: Mathieu Poirier Date: Tue, 5 Jul 2022 09:06:43 -0600 Message-ID: Subject: Re: [PATCH v2 1/3] rpmsg: qcom: glink: replace strncpy() with strscpy_pad() To: Krzysztof Kozlowski Cc: Andy Gross , Bjorn Andersson , linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org, Stephen Boyd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Tue, 5 Jul 2022 at 06:14, Krzysztof Kozlowski wrote: > > On 20/06/2022 20:37, Krzysztof Kozlowski wrote: > > On 09/06/2022 10:56, Krzysztof Kozlowski wrote: > >> On 19/05/2022 09:33, Krzysztof Kozlowski wrote: > >>> The use of strncpy() is considered deprecated for NUL-terminated > >>> strings[1]. Replace strncpy() with strscpy_pad(), to keep existing > >>> pad-behavior of strncpy, similarly to commit 08de420a8014 ("rpmsg: > >>> glink: Replace strncpy() with strscpy_pad()"). This fixes W=3D1 warn= ing: > >>> > >>> In function =E2=80=98qcom_glink_rx_close=E2=80=99, > >>> inlined from =E2=80=98qcom_glink_work=E2=80=99 at ../drivers/rpms= g/qcom_glink_native.c:1638:4: > >>> drivers/rpmsg/qcom_glink_native.c:1549:17: warning: =E2=80=98strncp= y=E2=80=99 specified bound 32 equals destination size [-Wstringop-truncatio= n] > >>> 1549 | strncpy(chinfo.name, channel->name, sizeof(= chinfo.name)); > >>> > >>> [1] https://www.kernel.org/doc/html/latest/process/deprecated.html#st= rncpy-on-nul-terminated-strings > >>> > >>> Signed-off-by: Krzysztof Kozlowski > >>> > >>> --- > >>> > >>> Changes since v1: > >>> 1. Split series per subsystem. > >> > >> Any comments on these? > > > > I sent first iteration in May, then on 19th of May. There is review fro= m > > Stephen. > > > > On 9th of June I pinged but the patchset is still waiting. Anyone minds > > me taking these? > > Hmmm... These are all fixes but wait for quite a long time. Shall we > make the rpmsg subsystem orphaned? Bjorn handles all Qcom patches for the remoteproc/rpmsg subsystems. > > Best regards, > Krzysztof