From mboxrd@z Thu Jan 1 00:00:00 1970 From: Benson Leung Subject: Re: [PATCH v5 09/21] clk: tegra: pll: Add logic for handling SDM data Date: Mon, 18 May 2015 15:35:14 -0700 Message-ID: References: <1431451444-23155-1-git-send-email-rklein@nvidia.com> <1431451444-23155-11-git-send-email-rklein@nvidia.com> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Return-path: In-Reply-To: <1431451444-23155-11-git-send-email-rklein-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Rhyland Klein Cc: Peter De Schrijver , Mike Turquette , Stephen Warren , Stephen Boyd , Thierry Reding , Alexandre Courbot , Bill Huang , Paul Walmsley , Jim Lin , linux-clk-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: linux-tegra@vger.kernel.org On Tue, May 12, 2015 at 10:23 AM, Rhyland Klein wrote: > This adds logic for taking SDM_DIN (Sigma Delta Modulator) setting into > the equation to calculate the effective N value for PLL which supports > fractional divider. > > The effective N = NDIV + 1/2 + SDM_DIN/2^13, where NDIV is the integer > feedback divider. > > Signed-off-by: Rhyland Klein Reviewed-by: Benson Leung Thanks for making the suggested changes. > --- > v5: > - made use of sdm_en_mask when possible to clean up logic > - added kerneldoc info for new struct params > - Added info about SDM near sdm_set_data > - rewrote check in sdm_set_data to make it clearer -- Benson Leung Software Engineer, Chrom* OS bleung-F7+t8E8rja9g9hUCZPvPmw@public.gmane.org From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754483AbbERWfS (ORCPT ); Mon, 18 May 2015 18:35:18 -0400 Received: from mail-ie0-f175.google.com ([209.85.223.175]:34528 "EHLO mail-ie0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753226AbbERWfP (ORCPT ); Mon, 18 May 2015 18:35:15 -0400 MIME-Version: 1.0 In-Reply-To: <1431451444-23155-11-git-send-email-rklein@nvidia.com> References: <1431451444-23155-1-git-send-email-rklein@nvidia.com> <1431451444-23155-11-git-send-email-rklein@nvidia.com> Date: Mon, 18 May 2015 15:35:14 -0700 X-Google-Sender-Auth: 3bsHZvznK4jYXN34kX_UZP6fLPs Message-ID: Subject: Re: [PATCH v5 09/21] clk: tegra: pll: Add logic for handling SDM data From: Benson Leung To: Rhyland Klein Cc: Peter De Schrijver , Mike Turquette , Stephen Warren , Stephen Boyd , Thierry Reding , Alexandre Courbot , Bill Huang , Paul Walmsley , Jim Lin , linux-clk@vger.kernel.org, linux-tegra@vger.kernel.org, "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, May 12, 2015 at 10:23 AM, Rhyland Klein wrote: > This adds logic for taking SDM_DIN (Sigma Delta Modulator) setting into > the equation to calculate the effective N value for PLL which supports > fractional divider. > > The effective N = NDIV + 1/2 + SDM_DIN/2^13, where NDIV is the integer > feedback divider. > > Signed-off-by: Rhyland Klein Reviewed-by: Benson Leung Thanks for making the suggested changes. > --- > v5: > - made use of sdm_en_mask when possible to clean up logic > - added kerneldoc info for new struct params > - Added info about SDM near sdm_set_data > - rewrote check in sdm_set_data to make it clearer -- Benson Leung Software Engineer, Chrom* OS bleung@chromium.org