From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBFEBC433DB for ; Thu, 4 Feb 2021 22:26:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7809064FAF for ; Thu, 4 Feb 2021 22:26:13 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230198AbhBDWZ5 (ORCPT ); Thu, 4 Feb 2021 17:25:57 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229611AbhBDWZz (ORCPT ); Thu, 4 Feb 2021 17:25:55 -0500 Received: from mail-vs1-xe31.google.com (mail-vs1-xe31.google.com [IPv6:2607:f8b0:4864:20::e31]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 59E23C0613D6 for ; Thu, 4 Feb 2021 14:25:15 -0800 (PST) Received: by mail-vs1-xe31.google.com with SMTP id u127so2581989vsc.10 for ; Thu, 04 Feb 2021 14:25:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=31jUhQb4QgBdzmAxm7WR6grUlNAOknQ+++TxEZo30Ts=; b=AEZu9A+PtNGkoSHnMDnQwaWORrLt+lZB4uI7bD12xs19pXOqzYGftocfVpVi11/2nP vGMjloHYJP6gHbtTCqiJdG43ZiNRd4E9FAPpeKv8FzMPLwiDADgf6jzi9rOvvrBvPfa3 iNF6k3j71vTvOITaT7d/322ce5rE0H+3Oh0Go= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=31jUhQb4QgBdzmAxm7WR6grUlNAOknQ+++TxEZo30Ts=; b=JaYJ48Ynkq7erxGqpJXkzCPaVLUJmK6pzDVg8aqNpv0dP2FarD/Kxojb3NfMawjdzW +r7Hqp3PhV6ooaLkuZV/eB5jHzQzYynQdjSnKTsGmCIDfMRWt7pRNTnfe4Aadk68zVZw QB2H2rh8T5CKxVwCap7HTkZrILnU/2Z5ptkNMYULr049gryKl4Yh8xYWv5fkGHoXMmXw FQd1/Kp/jkKg/yst85zrgmp67Q+0QEYaRyaIitRCGA0c9j4xvpBPUpXFZjxkZsUeJKkm t+GEznXaQjmsY0tIm2cnsP5JfxuJk12JOcJRwe4JZuVmKv4GqAtBN3w86JE9ykuvMyKo utPg== X-Gm-Message-State: AOAM532KG2qCkrT/snf2WX0BFkVnidNW405wRkHxsjpT7V/7p9BN1JbR zksSaF4COlBqv+rfBg+Vk/CnusSl5FvaKgr4C2QZLQ== X-Google-Smtp-Source: ABdhPJyMpXvwQyrCOQjc4jvN2lm7zHDjPIYpmEmeanwteLDdiY63Jm6FlPAvp99+wgnb/9zVDISwMQgWlH5CvnpGXkc= X-Received: by 2002:a67:6b46:: with SMTP id g67mr1153931vsc.60.1612477514078; Thu, 04 Feb 2021 14:25:14 -0800 (PST) MIME-Version: 1.0 References: <20210128111549.GA8174@zhaomy-pc> In-Reply-To: From: Nicolas Boichat Date: Fri, 5 Feb 2021 06:25:02 +0800 Message-ID: Subject: Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP To: Andrzej Hajda Cc: Robert Foss , devel@driverdev.osuosl.org, Nicolas Boichat , Jernej Skrabec , Sheng Pan , Jonas Karlman , David Airlie , Neil Armstrong , linux-kernel , dri-devel , Vasily Khoruzhick , Boris Brezillon , Torsten Duwe , Laurent Pinchart , Hsin-Yi Wang , Sam Ravnborg , Xin Ji , Dan Carpenter , Marek Szyprowski Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote: > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > >> Hi Xin, > >> > >> Thanks for the patch. > >> > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji wrote: > >>> Enable DSI EOTP feature for fixing some panel screen constance > >>> shift issue. > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. > >> I don't think I quite understand how removing the > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could > >> you extrapolate on this in the commit message? > > That confused me as well, but it turns out that's how the flag is defined: > > ``` > > /* disable EoT packets in HS mode */ > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9) > > ``` > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129) > > > > I'm almost tempted to put together a mass patch to rename all of these flags... > > > Yes that would be good, many of these flags were just copy pasted from > some hw datasheet, without good analysis how to adapt them to the framework. I'll look into it (but that shouldn't block this patch). > > > Regards > > Andrzej > > > > > >>> Signed-off-by: Xin Ji > >>> --- > >>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 - > >>> 1 file changed, 1 deletion(-) > >>> > >>> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > >>> index 65cc059..e31eeb1b 100644 > >>> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > >>> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > >>> @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx) > >>> dsi->format = MIPI_DSI_FMT_RGB888; > >>> dsi->mode_flags = MIPI_DSI_MODE_VIDEO | > >>> MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > >>> - MIPI_DSI_MODE_EOT_PACKET | > >>> MIPI_DSI_MODE_VIDEO_HSE; > >>> > >>> if (mipi_dsi_attach(dsi) < 0) { > >>> -- > >>> 2.7.4 > >>> > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://protect2.fireeye.com/v1/url?k=457f3f39-1ae4067f-457eb476-0cc47a3003e8-b702072da729d8c9&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60939C433E6 for ; Thu, 4 Feb 2021 22:25:19 +0000 (UTC) Received: from hemlock.osuosl.org (smtp2.osuosl.org [140.211.166.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E5EE964FAD for ; Thu, 4 Feb 2021 22:25:18 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E5EE964FAD Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=driverdev-devel-bounces@linuxdriverproject.org Received: from localhost (localhost [127.0.0.1]) by hemlock.osuosl.org (Postfix) with ESMTP id 7E78287278; Thu, 4 Feb 2021 22:25:18 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from hemlock.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yh+dtJL8k6qn; Thu, 4 Feb 2021 22:25:16 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by hemlock.osuosl.org (Postfix) with ESMTP id DDB858726A; Thu, 4 Feb 2021 22:25:16 +0000 (UTC) Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 0CCF01BF32C for ; Thu, 4 Feb 2021 22:25:16 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 067A586D33 for ; Thu, 4 Feb 2021 22:25:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id B4YJoCQMNCaY for ; Thu, 4 Feb 2021 22:25:15 +0000 (UTC) X-Greylist: from auto-whitelisted by SQLgrey-1.7.6 Received: from mail-vs1-f43.google.com (mail-vs1-f43.google.com [209.85.217.43]) by whitealder.osuosl.org (Postfix) with ESMTPS id 1619086D32 for ; Thu, 4 Feb 2021 22:25:15 +0000 (UTC) Received: by mail-vs1-f43.google.com with SMTP id v19so2588541vsf.9 for ; Thu, 04 Feb 2021 14:25:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=31jUhQb4QgBdzmAxm7WR6grUlNAOknQ+++TxEZo30Ts=; b=AEZu9A+PtNGkoSHnMDnQwaWORrLt+lZB4uI7bD12xs19pXOqzYGftocfVpVi11/2nP vGMjloHYJP6gHbtTCqiJdG43ZiNRd4E9FAPpeKv8FzMPLwiDADgf6jzi9rOvvrBvPfa3 iNF6k3j71vTvOITaT7d/322ce5rE0H+3Oh0Go= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=31jUhQb4QgBdzmAxm7WR6grUlNAOknQ+++TxEZo30Ts=; b=QYK+zIFo9PehV3w29ZuYtqQ63QthQl/h0Wx9t8yLuVmcc/MRgFFRtVrcjTkIe6lr8n ckpykE32JnTILT9Cz48ar2vmRDtX8XKz8Gi8Flt3bmsZKXHGCaPiNxc/iQLK39SKc7MO BK7weKDNjGkdaIxmx+y52YG/yUcIyilZ9VxEn6kj81+8jALgW7z3R8t+s5deNHWZ6IDZ 7GhmVyj/Jp6X8/2ZK1BhQhjtcQCPS942/Sn0oBU3LkDsqBIcCRv+QLEwts6HmMhaFhvy +DKUFamG4NoR2AacQFR2JgGIhMpCrNy/1iPefJFqqO1J547a1ipOjlc6gFlGeki/1qni A+Cw== X-Gm-Message-State: AOAM5321PR37m9T8dfk52dzd04ado1+0nXnl/UnVSrfGA7fElZY4ujiz UqJCcECdUjvFkY9BWN0NDH5Fy/ruhTvfBd1wVCExDg== X-Google-Smtp-Source: ABdhPJyMpXvwQyrCOQjc4jvN2lm7zHDjPIYpmEmeanwteLDdiY63Jm6FlPAvp99+wgnb/9zVDISwMQgWlH5CvnpGXkc= X-Received: by 2002:a67:6b46:: with SMTP id g67mr1153931vsc.60.1612477514078; Thu, 04 Feb 2021 14:25:14 -0800 (PST) MIME-Version: 1.0 References: <20210128111549.GA8174@zhaomy-pc> In-Reply-To: From: Nicolas Boichat Date: Fri, 5 Feb 2021 06:25:02 +0800 Message-ID: Subject: Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP To: Andrzej Hajda X-BeenThere: driverdev-devel@linuxdriverproject.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux Driver Project Developer List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Nicolas Boichat , Jernej Skrabec , Jonas Karlman , David Airlie , dri-devel , Neil Armstrong , linux-kernel , Robert Foss , Vasily Khoruzhick , Boris Brezillon , Torsten Duwe , Sheng Pan , Hsin-Yi Wang , Marek Szyprowski , Sam Ravnborg , Xin Ji , Dan Carpenter , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: driverdev-devel-bounces@linuxdriverproject.org Sender: "devel" On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote: > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > >> Hi Xin, > >> > >> Thanks for the patch. > >> > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji wrote: > >>> Enable DSI EOTP feature for fixing some panel screen constance > >>> shift issue. > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. > >> I don't think I quite understand how removing the > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could > >> you extrapolate on this in the commit message? > > That confused me as well, but it turns out that's how the flag is defined: > > ``` > > /* disable EoT packets in HS mode */ > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9) > > ``` > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129) > > > > I'm almost tempted to put together a mass patch to rename all of these flags... > > > Yes that would be good, many of these flags were just copy pasted from > some hw datasheet, without good analysis how to adapt them to the framework. I'll look into it (but that shouldn't block this patch). > > > Regards > > Andrzej > > > > > >>> Signed-off-by: Xin Ji > >>> --- > >>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 - > >>> 1 file changed, 1 deletion(-) > >>> > >>> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > >>> index 65cc059..e31eeb1b 100644 > >>> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > >>> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > >>> @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx) > >>> dsi->format = MIPI_DSI_FMT_RGB888; > >>> dsi->mode_flags = MIPI_DSI_MODE_VIDEO | > >>> MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > >>> - MIPI_DSI_MODE_EOT_PACKET | > >>> MIPI_DSI_MODE_VIDEO_HSE; > >>> > >>> if (mipi_dsi_attach(dsi) < 0) { > >>> -- > >>> 2.7.4 > >>> > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://protect2.fireeye.com/v1/url?k=457f3f39-1ae4067f-457eb476-0cc47a3003e8-b702072da729d8c9&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel > > _______________________________________________ devel mailing list devel@linuxdriverproject.org http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.5 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4635CC433E0 for ; Thu, 4 Feb 2021 22:25:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D50FC64F95 for ; Thu, 4 Feb 2021 22:25:16 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D50FC64F95 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=dri-devel-bounces@lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BE52A6E0CA; Thu, 4 Feb 2021 22:25:15 +0000 (UTC) Received: from mail-vs1-xe2f.google.com (mail-vs1-xe2f.google.com [IPv6:2607:f8b0:4864:20::e2f]) by gabe.freedesktop.org (Postfix) with ESMTPS id F2C2F6E0CA for ; Thu, 4 Feb 2021 22:25:14 +0000 (UTC) Received: by mail-vs1-xe2f.google.com with SMTP id n18so2581706vsa.12 for ; Thu, 04 Feb 2021 14:25:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=31jUhQb4QgBdzmAxm7WR6grUlNAOknQ+++TxEZo30Ts=; b=AEZu9A+PtNGkoSHnMDnQwaWORrLt+lZB4uI7bD12xs19pXOqzYGftocfVpVi11/2nP vGMjloHYJP6gHbtTCqiJdG43ZiNRd4E9FAPpeKv8FzMPLwiDADgf6jzi9rOvvrBvPfa3 iNF6k3j71vTvOITaT7d/322ce5rE0H+3Oh0Go= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=31jUhQb4QgBdzmAxm7WR6grUlNAOknQ+++TxEZo30Ts=; b=Yf/acVzLKh8k60eLzSf76yb9XESaS2eu7woEYO2yGoi5AcRFRxQxT0xbJpOtp18xe4 XfvMwKUhm4N3czdfRPU4VZDkzstfbcrQ0EcPfEwRgOwkqp8iZGuTyGLtDpAWnUm4nJGc GViwYUIvNgIaVZRq9acAdS8TnemOh8W0kLynnfbjOstQfrA0YUkZcb+EW528IvfJUShZ A8guzrEQCK4cq57TCYatlTghdppNsML9rE3CrAYihB8BTKK84wh99g8AZ2LHRua/qM48 kmjEbvvyF387clKTMTYu2cuUoKwIDXj+2tUEXXFKAyHpLy7aIhm6t7/PD1oX85Wmf3MY Lnpg== X-Gm-Message-State: AOAM53220LlfWoJR8Dzyu2Ggx0MlqOIfmFJgKBbz6aBHfuaY0XeU89l/ 2enx1Iz5UWBGbm/ZklGbYp1zvaqn1oC8uhPxHsmhvA== X-Google-Smtp-Source: ABdhPJyMpXvwQyrCOQjc4jvN2lm7zHDjPIYpmEmeanwteLDdiY63Jm6FlPAvp99+wgnb/9zVDISwMQgWlH5CvnpGXkc= X-Received: by 2002:a67:6b46:: with SMTP id g67mr1153931vsc.60.1612477514078; Thu, 04 Feb 2021 14:25:14 -0800 (PST) MIME-Version: 1.0 References: <20210128111549.GA8174@zhaomy-pc> In-Reply-To: From: Nicolas Boichat Date: Fri, 5 Feb 2021 06:25:02 +0800 Message-ID: Subject: Re: [PATCH] drm/bridge: anx7625: enable DSI EOTP To: Andrzej Hajda X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devel@driverdev.osuosl.org, Nicolas Boichat , Jernej Skrabec , Jonas Karlman , David Airlie , dri-devel , Neil Armstrong , linux-kernel , Robert Foss , Vasily Khoruzhick , Boris Brezillon , Torsten Duwe , Sheng Pan , Hsin-Yi Wang , Marek Szyprowski , Sam Ravnborg , Xin Ji , Dan Carpenter , Laurent Pinchart Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Thu, Feb 4, 2021 at 8:59 PM Andrzej Hajda wrote: > > > W dniu 04.02.2021 o 13:34, Nicolas Boichat pisze: > > On Thu, Feb 4, 2021 at 8:07 PM Robert Foss wrote: > >> Hi Xin, > >> > >> Thanks for the patch. > >> > >> On Thu, 28 Jan 2021 at 12:17, Xin Ji wrote: > >>> Enable DSI EOTP feature for fixing some panel screen constance > >>> shift issue. > >>> Removing MIPI flag MIPI_DSI_MODE_EOT_PACKET to enable DSI EOTP. > >> I don't think I quite understand how removing the > >> MIPI_DSI_MODE_EOT_PACKET flag will cause DSI EOTP to be enabled. Could > >> you extrapolate on this in the commit message? > > That confused me as well, but it turns out that's how the flag is defined: > > ``` > > /* disable EoT packets in HS mode */ > > #define MIPI_DSI_MODE_EOT_PACKET BIT(9) > > ``` > > (https://protect2.fireeye.com/v1/url?k=5bd95ebd-044267fb-5bd8d5f2-0cc47a3003e8-ce9db8ea264d6901&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Felixir.bootlin.com%2Flinux%2Flatest%2Fsource%2Finclude%2Fdrm%2Fdrm_mipi_dsi.h%23L129) > > > > I'm almost tempted to put together a mass patch to rename all of these flags... > > > Yes that would be good, many of these flags were just copy pasted from > some hw datasheet, without good analysis how to adapt them to the framework. I'll look into it (but that shouldn't block this patch). > > > Regards > > Andrzej > > > > > >>> Signed-off-by: Xin Ji > >>> --- > >>> drivers/gpu/drm/bridge/analogix/anx7625.c | 1 - > >>> 1 file changed, 1 deletion(-) > >>> > >>> diff --git a/drivers/gpu/drm/bridge/analogix/anx7625.c b/drivers/gpu/drm/bridge/analogix/anx7625.c > >>> index 65cc059..e31eeb1b 100644 > >>> --- a/drivers/gpu/drm/bridge/analogix/anx7625.c > >>> +++ b/drivers/gpu/drm/bridge/analogix/anx7625.c > >>> @@ -1334,7 +1334,6 @@ static int anx7625_attach_dsi(struct anx7625_data *ctx) > >>> dsi->format = MIPI_DSI_FMT_RGB888; > >>> dsi->mode_flags = MIPI_DSI_MODE_VIDEO | > >>> MIPI_DSI_MODE_VIDEO_SYNC_PULSE | > >>> - MIPI_DSI_MODE_EOT_PACKET | > >>> MIPI_DSI_MODE_VIDEO_HSE; > >>> > >>> if (mipi_dsi_attach(dsi) < 0) { > >>> -- > >>> 2.7.4 > >>> > > _______________________________________________ > > dri-devel mailing list > > dri-devel@lists.freedesktop.org > > https://protect2.fireeye.com/v1/url?k=457f3f39-1ae4067f-457eb476-0cc47a3003e8-b702072da729d8c9&q=1&e=900556dc-d199-4c18-9432-5c3465a98eae&u=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Fdri-devel > > _______________________________________________ dri-devel mailing list dri-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/dri-devel