From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 06963C4360F for ; Fri, 8 Mar 2019 14:46:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C130F2087C for ; Fri, 8 Mar 2019 14:46:15 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MDSbdybV" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726887AbfCHOqO (ORCPT ); Fri, 8 Mar 2019 09:46:14 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:40155 "EHLO mail-qk1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726171AbfCHOqO (ORCPT ); Fri, 8 Mar 2019 09:46:14 -0500 Received: by mail-qk1-f195.google.com with SMTP id h28so11273533qkk.7 for ; Fri, 08 Mar 2019 06:46:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zudgGPjYTkagNqp9SUwl9xpMh9Y0w208BiIA8AHKW2I=; b=MDSbdybVQWQ1FZ3jmai9YJE8WZmLJKotIeiKt6YB6sT6Cs39WmAurN1WuO9X1Wiz98 u1ItGZGCNSKVGu9wxjaqaH6R1PvdAPNPHaZq8acLeD0Nq3+j5l4Pim4sRwiUBdrHUCml ri4b2mZdZI5kpR3yufslBWDDc3zpDJMR6N0SU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zudgGPjYTkagNqp9SUwl9xpMh9Y0w208BiIA8AHKW2I=; b=QFjyxTPXzac0xGOXFLd6xIq6LXEt78SiOcMBhEmyhjK8UT5puH/9yg/XOBGPsgUnWi FZsDwePw8NywJaS3gRkurpf5NGkj/DnAIUn5Qh1OiSzDlYYVWK9Yu7YfZQ5YJrEJbBXJ KkTqc164ARo1lWPMoqVTU83EjNVhubVieI5WynxgLkSR56xIhT7+z1/rwtmHtZCBxiYJ mMHnlf7Hoj8YsG/loZmdxdElhcDdi5sbSjCF0P/W0FjqLD4wxsGrAe5ACyTKsmdD4AtD rUysBy5Vz03xkVIhHl0aGW1yCai2z+xCaMejkF4pZRO1ogNU7dhtxuqLAA3UrlyMBYgP p5DQ== X-Gm-Message-State: APjAAAVPZsd74+0kQ/E3zSKfzy4+v4s3ZjyLcDH8ZFas+ZqzsZHOzDqs zIx1AFHhfF4L1z94y3SZiik+2dsX9pcuz1s2YxLwbw== X-Google-Smtp-Source: APXvYqzEMwkkGy5B9w5z4GHbJMJ2GNH0i0b1nmC2IhW9Fd71ECOGee7zBumuwtm4yR5TcVHXnHVUbOGFZdMRnjZwfYA= X-Received: by 2002:ae9:ef05:: with SMTP id d5mr14533524qkg.323.1552056372290; Fri, 08 Mar 2019 06:46:12 -0800 (PST) MIME-Version: 1.0 References: <20190305050546.23431-1-weiyi.lu@mediatek.com> <20190305050546.23431-10-weiyi.lu@mediatek.com> In-Reply-To: From: Nicolas Boichat Date: Fri, 8 Mar 2019 22:46:01 +0800 Message-ID: Subject: Re: [PATCH v5 8/9] clk: mediatek: Add MT8183 clock support To: Weiyi Lu Cc: Matthias Brugger , Stephen Boyd , Rob Herring , James Liao , Fan Chen , linux-arm Mailing List , lkml , "moderated list:ARM/Mediatek SoC support" , linux-clk@vger.kernel.org, srv_heupstream , stable@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Mar 8, 2019 at 2:42 PM Nicolas Boichat wrote: > > ) > On Tue, Mar 5, 2019 at 1:05 PM Weiyi Lu wrote: > > > > Add MT8183 clock support, include topckgen, apmixedsys, > > infracfg, mcucfg and subsystem clocks. > > > > Signed-off-by: Weiyi Lu > > In v1 a while back (https://patchwork.kernel.org/patch/10669765/) I > was complaining about code duplication between these many files, and > wondering if we can make simplify a lot of this code. Okay, we had a discussion on this gerrit: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1510921, and I didn't know the history that having separate clock domains that we can enable/disable with config options. And the same pattern already exists on clk-mt2712-*.c, for example. So, for now: Reviewed-by: Nicolas Boichat Some comment below about how this could be improved, potentially: > Apart from that: > Tested-by: Nicolas Boichat > [snip] > > --- /dev/null > > +++ b/drivers/clk/mediatek/clk-mt8183-audio.c > > @@ -0,0 +1,105 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +// > > +// Copyright (c) 2018 MediaTek Inc. > > +// Author: Weiyi Lu > > + > > +#include > > +#include > > +#include > > + > > +#include "clk-mtk.h" > > +#include "clk-gate.h" > > + > > +#include > > + > > +static const struct mtk_gate_regs audio0_cg_regs = { > > + .set_ofs = 0x0, > > + .clr_ofs = 0x0, > > + .sta_ofs = 0x0, > > +}; > > + > > +static const struct mtk_gate_regs audio1_cg_regs = { > > + .set_ofs = 0x4, > > + .clr_ofs = 0x4, > > + .sta_ofs = 0x4, > > +}; > > + > > +#define GATE_AUDIO0(_id, _name, _parent, _shift) \ > > + GATE_MTK(_id, _name, _parent, &audio0_cg_regs, _shift, \ > > + &mtk_clk_gate_ops_no_setclr) This macro (or variants that end up being equivalent) is repeated 103 times in drivers/clk/mediatek/*. We can probably do better. My suggestion is to do something like this: #define GATE_MTK_CLK(reg, _id, _name, _parent, _shift) \ GATE_MTK(_id, _name, _parent, ®##_cg_regs, _shift, \ &mtk_clk_gate_ops_setclr_inv) and use GATE_MTK_CLK(audio0, ...) in the gate clock arrays. > > +static int clk_mt8183_audio_probe(struct platform_device *pdev) > > +{ > > + struct clk_onecell_data *clk_data; > > + int r; > > + struct device_node *node = pdev->dev.of_node; > > + > > + clk_data = mtk_alloc_clk_data(CLK_AUDIO_NR_CLK); > > + > > + mtk_clk_register_gates(node, audio_clks, ARRAY_SIZE(audio_clks), > > + clk_data); > > + > > + r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); > > + if (r) > > + return r; > > + > > + r = devm_of_platform_populate(&pdev->dev); > > + if (r) > > + of_clk_del_provider(node); > > + > > + return r; > > +} This (almost exact) function is now repeated 33 times in drivers/clk/mediatek, I think it's really time for a cleanup... Maybe there should be a common helper in clk-gate.c (or another file, not sure), that fetches the clocks (and number of clocks from .data field in the structure below). > > +static const struct of_device_id of_match_clk_mt8183_audio[] = { > > + { .compatible = "mediatek,mt8183-audiosys", }, > > + {} > > +}; [snip] From mboxrd@z Thu Jan 1 00:00:00 1970 From: Nicolas Boichat Subject: Re: [PATCH v5 8/9] clk: mediatek: Add MT8183 clock support Date: Fri, 8 Mar 2019 22:46:01 +0800 Message-ID: References: <20190305050546.23431-1-weiyi.lu@mediatek.com> <20190305050546.23431-10-weiyi.lu@mediatek.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Return-path: In-Reply-To: Sender: stable-owner@vger.kernel.org To: Weiyi Lu Cc: Matthias Brugger , Stephen Boyd , Rob Herring , James Liao , Fan Chen , linux-arm Mailing List , lkml , "moderated list:ARM/Mediatek SoC support" , linux-clk@vger.kernel.org, srv_heupstream , stable@vger.kernel.org List-Id: linux-mediatek@lists.infradead.org On Fri, Mar 8, 2019 at 2:42 PM Nicolas Boichat wrote: > > ) > On Tue, Mar 5, 2019 at 1:05 PM Weiyi Lu wrote: > > > > Add MT8183 clock support, include topckgen, apmixedsys, > > infracfg, mcucfg and subsystem clocks. > > > > Signed-off-by: Weiyi Lu > > In v1 a while back (https://patchwork.kernel.org/patch/10669765/) I > was complaining about code duplication between these many files, and > wondering if we can make simplify a lot of this code. Okay, we had a discussion on this gerrit: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1510921, and I didn't know the history that having separate clock domains that we can enable/disable with config options. And the same pattern already exists on clk-mt2712-*.c, for example. So, for now: Reviewed-by: Nicolas Boichat Some comment below about how this could be improved, potentially: > Apart from that: > Tested-by: Nicolas Boichat > [snip] > > --- /dev/null > > +++ b/drivers/clk/mediatek/clk-mt8183-audio.c > > @@ -0,0 +1,105 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +// > > +// Copyright (c) 2018 MediaTek Inc. > > +// Author: Weiyi Lu > > + > > +#include > > +#include > > +#include > > + > > +#include "clk-mtk.h" > > +#include "clk-gate.h" > > + > > +#include > > + > > +static const struct mtk_gate_regs audio0_cg_regs = { > > + .set_ofs = 0x0, > > + .clr_ofs = 0x0, > > + .sta_ofs = 0x0, > > +}; > > + > > +static const struct mtk_gate_regs audio1_cg_regs = { > > + .set_ofs = 0x4, > > + .clr_ofs = 0x4, > > + .sta_ofs = 0x4, > > +}; > > + > > +#define GATE_AUDIO0(_id, _name, _parent, _shift) \ > > + GATE_MTK(_id, _name, _parent, &audio0_cg_regs, _shift, \ > > + &mtk_clk_gate_ops_no_setclr) This macro (or variants that end up being equivalent) is repeated 103 times in drivers/clk/mediatek/*. We can probably do better. My suggestion is to do something like this: #define GATE_MTK_CLK(reg, _id, _name, _parent, _shift) \ GATE_MTK(_id, _name, _parent, ®##_cg_regs, _shift, \ &mtk_clk_gate_ops_setclr_inv) and use GATE_MTK_CLK(audio0, ...) in the gate clock arrays. > > +static int clk_mt8183_audio_probe(struct platform_device *pdev) > > +{ > > + struct clk_onecell_data *clk_data; > > + int r; > > + struct device_node *node = pdev->dev.of_node; > > + > > + clk_data = mtk_alloc_clk_data(CLK_AUDIO_NR_CLK); > > + > > + mtk_clk_register_gates(node, audio_clks, ARRAY_SIZE(audio_clks), > > + clk_data); > > + > > + r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); > > + if (r) > > + return r; > > + > > + r = devm_of_platform_populate(&pdev->dev); > > + if (r) > > + of_clk_del_provider(node); > > + > > + return r; > > +} This (almost exact) function is now repeated 33 times in drivers/clk/mediatek, I think it's really time for a cleanup... Maybe there should be a common helper in clk-gate.c (or another file, not sure), that fetches the clocks (and number of clocks from .data field in the structure below). > > +static const struct of_device_id of_match_clk_mt8183_audio[] = { > > + { .compatible = "mediatek,mt8183-audiosys", }, > > + {} > > +}; [snip] From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE6FBC43381 for ; Fri, 8 Mar 2019 14:46:27 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B07A42087C for ; Fri, 8 Mar 2019 14:46:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="mgEu4Dpf"; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="MDSbdybV" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org B07A42087C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:To:Subject:Message-ID:Date:From: In-Reply-To:References:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KiKLwRhALGNUHMcVdx5hPWGqGKY99EGupSSh5OeW86g=; b=mgEu4Dpfj/e25g CtfP1BdSrA3sAx4bOzWP22amDOaETJVpf47JxlVM3LDPpOJBo29/ylAgmH9tTtgQZN1OCIeo/8xEE npGnLl/6G1emMimAXqs9C7oQ2+iiFI/lJ9Zl5hNKwsj/eAtoWacn3hkvtidBPrrJ+ZGTdmABc2FhC 0wBY9EB5JewEnoFPCaUu1vMPtCAQrT/rVGm1PjMJboPpzQ+lQptypRKxd4S2gXy8s8+RJv4NOUwk6 yWQKeUrWdXqoQrscIR33RIcag0T9LcJQqi2kQ/B6CUc2PTQ+vNoinJKnlQ4x+Tdr4nBx902jH4nsF bbfnWoRXVqtxvG2roGcA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h2GlO-000186-Uz; Fri, 08 Mar 2019 14:46:18 +0000 Received: from mail-qk1-x742.google.com ([2607:f8b0:4864:20::742]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h2GlK-00016Q-B5 for linux-arm-kernel@lists.infradead.org; Fri, 08 Mar 2019 14:46:17 +0000 Received: by mail-qk1-x742.google.com with SMTP id m9so11280187qkl.4 for ; Fri, 08 Mar 2019 06:46:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=zudgGPjYTkagNqp9SUwl9xpMh9Y0w208BiIA8AHKW2I=; b=MDSbdybVQWQ1FZ3jmai9YJE8WZmLJKotIeiKt6YB6sT6Cs39WmAurN1WuO9X1Wiz98 u1ItGZGCNSKVGu9wxjaqaH6R1PvdAPNPHaZq8acLeD0Nq3+j5l4Pim4sRwiUBdrHUCml ri4b2mZdZI5kpR3yufslBWDDc3zpDJMR6N0SU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=zudgGPjYTkagNqp9SUwl9xpMh9Y0w208BiIA8AHKW2I=; b=FgEgl8pI2B85rCBAIm0X8K7w+fEAJVG+mY2L0e/H17qUVvCEB/yJGCzOVLb+2UzPKh im/3lGqHQzxwykuwfrDjgEeld7USMpzWJ6q/crVOxVrsdsZYduAAI598cP/RdPeFX5uR uNYV7cwHdXkbDkb/zseXtBbxWJfwN+Zex/BwgSMQkRjY03601GjhuyAxsqAgID7Q08O5 pBaIJ0ofcPIiaYB1F5r8r92EG3eVfaRH0WVkNUwKCdwIRefyANd1yCzd0k8HBil3+SGr LRx78ja1Sztbhhq7PyqWbLYMr07INDQmjNrAw1m3Jl6kILnlARieo+Z42sx9MuYOyHPs 3pIQ== X-Gm-Message-State: APjAAAWTfXvUqzFLEh+hB47uoGC/XlvnHWagbk2/GdliOyskLoKr7mRL 7RpRMW9tc9LkS7itrV9nAbfmkLzRMUcrvdu1lViX5VFxhJJa4g== X-Google-Smtp-Source: APXvYqzEMwkkGy5B9w5z4GHbJMJ2GNH0i0b1nmC2IhW9Fd71ECOGee7zBumuwtm4yR5TcVHXnHVUbOGFZdMRnjZwfYA= X-Received: by 2002:ae9:ef05:: with SMTP id d5mr14533524qkg.323.1552056372290; Fri, 08 Mar 2019 06:46:12 -0800 (PST) MIME-Version: 1.0 References: <20190305050546.23431-1-weiyi.lu@mediatek.com> <20190305050546.23431-10-weiyi.lu@mediatek.com> In-Reply-To: From: Nicolas Boichat Date: Fri, 8 Mar 2019 22:46:01 +0800 Message-ID: Subject: Re: [PATCH v5 8/9] clk: mediatek: Add MT8183 clock support To: Weiyi Lu X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190308_064614_409432_2D58B703 X-CRM114-Status: GOOD ( 17.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Rob Herring , srv_heupstream , James Liao , Stephen Boyd , lkml , stable@vger.kernel.org, Fan Chen , "moderated list:ARM/Mediatek SoC support" , Matthias Brugger , linux-clk@vger.kernel.org, linux-arm Mailing List Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 8, 2019 at 2:42 PM Nicolas Boichat wrote: > > ) > On Tue, Mar 5, 2019 at 1:05 PM Weiyi Lu wrote: > > > > Add MT8183 clock support, include topckgen, apmixedsys, > > infracfg, mcucfg and subsystem clocks. > > > > Signed-off-by: Weiyi Lu > > In v1 a while back (https://patchwork.kernel.org/patch/10669765/) I > was complaining about code duplication between these many files, and > wondering if we can make simplify a lot of this code. Okay, we had a discussion on this gerrit: https://chromium-review.googlesource.com/c/chromiumos/third_party/kernel/+/1510921, and I didn't know the history that having separate clock domains that we can enable/disable with config options. And the same pattern already exists on clk-mt2712-*.c, for example. So, for now: Reviewed-by: Nicolas Boichat Some comment below about how this could be improved, potentially: > Apart from that: > Tested-by: Nicolas Boichat > [snip] > > --- /dev/null > > +++ b/drivers/clk/mediatek/clk-mt8183-audio.c > > @@ -0,0 +1,105 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +// > > +// Copyright (c) 2018 MediaTek Inc. > > +// Author: Weiyi Lu > > + > > +#include > > +#include > > +#include > > + > > +#include "clk-mtk.h" > > +#include "clk-gate.h" > > + > > +#include > > + > > +static const struct mtk_gate_regs audio0_cg_regs = { > > + .set_ofs = 0x0, > > + .clr_ofs = 0x0, > > + .sta_ofs = 0x0, > > +}; > > + > > +static const struct mtk_gate_regs audio1_cg_regs = { > > + .set_ofs = 0x4, > > + .clr_ofs = 0x4, > > + .sta_ofs = 0x4, > > +}; > > + > > +#define GATE_AUDIO0(_id, _name, _parent, _shift) \ > > + GATE_MTK(_id, _name, _parent, &audio0_cg_regs, _shift, \ > > + &mtk_clk_gate_ops_no_setclr) This macro (or variants that end up being equivalent) is repeated 103 times in drivers/clk/mediatek/*. We can probably do better. My suggestion is to do something like this: #define GATE_MTK_CLK(reg, _id, _name, _parent, _shift) \ GATE_MTK(_id, _name, _parent, ®##_cg_regs, _shift, \ &mtk_clk_gate_ops_setclr_inv) and use GATE_MTK_CLK(audio0, ...) in the gate clock arrays. > > +static int clk_mt8183_audio_probe(struct platform_device *pdev) > > +{ > > + struct clk_onecell_data *clk_data; > > + int r; > > + struct device_node *node = pdev->dev.of_node; > > + > > + clk_data = mtk_alloc_clk_data(CLK_AUDIO_NR_CLK); > > + > > + mtk_clk_register_gates(node, audio_clks, ARRAY_SIZE(audio_clks), > > + clk_data); > > + > > + r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data); > > + if (r) > > + return r; > > + > > + r = devm_of_platform_populate(&pdev->dev); > > + if (r) > > + of_clk_del_provider(node); > > + > > + return r; > > +} This (almost exact) function is now repeated 33 times in drivers/clk/mediatek, I think it's really time for a cleanup... Maybe there should be a common helper in clk-gate.c (or another file, not sure), that fetches the clocks (and number of clocks from .data field in the structure below). > > +static const struct of_device_id of_match_clk_mt8183_audio[] = { > > + { .compatible = "mediatek,mt8183-audiosys", }, > > + {} > > +}; [snip] _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel